- 22 Jun, 2016 1 commit
-
-
yangguo authored
We would otherwise also count if its just trimming whitespaces. R=adamk@chromium.org BUG=chromium:618595 Review-Url: https://codereview.chromium.org/2080183003 Cr-Commit-Position: refs/heads/master@{#37197}
-
- 09 Jun, 2016 1 commit
-
-
yangguo authored
R=adamk@chromium.org, jochen@chromium.org BUG=chromium:618595 Review-Url: https://codereview.chromium.org/2050733004 Cr-Commit-Position: refs/heads/master@{#36846}
-
- 04 Jan, 2016 1 commit
-
-
littledan authored
In the Date constructor or Date.parse, other browsers will accept time zones like GMT-8, but before this patch, Chrome would interpret 8 as 8 minutes. This patch interprets GMT-+ a one or two digit number as hours, not minutes. R=adamk,jshin@chromium.org LOG=Y BUG=chromium:422858 Review URL: https://codereview.chromium.org/1557053002 Cr-Commit-Position: refs/heads/master@{#33100}
-
- 15 Oct, 2015 1 commit
-
-
ulan authored
Revert of Make dates default to the local timezone if none specified (https://codereview.chromium.org/1229903004/) Even though the change is ES6 spec compliant, we decided to revert to be consistent with other browsers and work on fixing the spec. Original issue's description: > Make dates default to the local timezone if none specified > > In ES5, dates were supposed to default to UTC if no timezone was specified. However, this changed in ES6, which specified that dates should be in the local timezone if no timezone was specified. This CL updates our behavior to match that part of the ES6 spec. > BUG=chromium:391730, v8:4242 > LOG=Y > Committed: https://crrev.com/f06754a8e1d305a43560705f6c167d85d40e602d > Cr-Commit-Position: refs/heads/master@{#29854} BUG=chromium:543320,chromium:539813 LOG=NO Review URL: https://codereview.chromium.org/1403153003 Cr-Commit-Position: refs/heads/master@{#31295}
-
- 30 Sep, 2015 1 commit
-
-
mstarzinger authored
This enables linter checking for "readability/namespace" violations during presubmit and instead marks the few known exceptions that we allow explicitly. R=bmeurer@chromium.org Review URL: https://codereview.chromium.org/1371083003 Cr-Commit-Position: refs/heads/master@{#31019}
-
- 20 Aug, 2015 1 commit
-
-
mstarzinger authored
This make inclusion of unicode-inl.h in object.h absolete. Now most compilation units don't require that header. It also breaks a cycle within declarations of the scanner.h header. This tries to remove includes of "-inl.h" headers from normal ".h" headers, thereby reducing the chance of any cyclic dependencies and decreasing the average size of our compilation units. Note that this change still leaves 3 violations of that rule in the code, checked with the "tools/check-inline-includes.sh" tool. R=yangguo@chromium.org Review URL: https://codereview.chromium.org/1287893006 Cr-Commit-Position: refs/heads/master@{#30268}
-
- 12 Aug, 2015 1 commit
-
-
mstarzinger authored
This tries to remove includes of "-inl.h" headers from normal ".h" headers, thereby reducing the chance of any cyclic dependencies and decreasing the average size of our compilation units. Note that this change still leaves 7 violations of that rule in the code. However there now is the "tools/check-inline-includes.sh" tool detecting such violations. R=bmeurer@chromium.org Review URL: https://codereview.chromium.org/1283033003 Cr-Commit-Position: refs/heads/master@{#30125}
-
- 24 Jul, 2015 1 commit
-
-
hichris123 authored
In ES5, dates were supposed to default to UTC if no timezone was specified. However, this changed in ES6, which specified that dates should be in the local timezone if no timezone was specified. This CL updates our behavior to match that part of the ES6 spec. BUG=chromium:391730, v8:4242 LOG=Y Review URL: https://codereview.chromium.org/1229903004 Cr-Commit-Position: refs/heads/master@{#29854}
-
- 04 Aug, 2014 1 commit
-
-
bmeurer@chromium.org authored
This way we don't clash with the ASSERT* macros defined by GoogleTest, and we are one step closer to being able to replace our homegrown base/ with base/ from Chrome. R=jochen@chromium.org, svenpanne@chromium.org Review URL: https://codereview.chromium.org/430503007 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22812 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 03 Jun, 2014 1 commit
-
-
jochen@chromium.org authored
- this avoids using relative include paths which are forbidden by the style guide - makes the code more readable since it's clear which header is meant - allows for starting to use checkdeps BUG=none R=jkummerow@chromium.org, danno@chromium.org LOG=n Review URL: https://codereview.chromium.org/304153016 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21625 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 29 Apr, 2014 1 commit
-
-
bmeurer@chromium.org authored
R=svenpanne@chromium.org Review URL: https://codereview.chromium.org/259183002 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@21035 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 09 Oct, 2012 1 commit
-
-
rossberg@chromium.org authored
R=ulan@chromium.org BUG=145198 Review URL: https://codereview.chromium.org/11085006 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@12680 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 13 Jun, 2012 1 commit
-
-
ulan@chromium.org authored
BUG=53209,126448 TEST=mjsunit/date-parse.js R=rossberg@chromium.org Review URL: https://chromiumcodereview.appspot.com/10541138 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@11791 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 01 Jul, 2011 1 commit
-
-
lrn@chromium.org authored
This means that ES5 Date Time Strings will default to UTC if timezone is absent. Handle as many legacy strings as possible the same way as before BUG=v8:1498 TEST=mjsunit/date Review URL: http://codereview.chromium.org/7291022 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@8513 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 12 Apr, 2011 1 commit
-
-
lrn@chromium.org authored
The ScannerConstants class was originally static fields on the scanner class. During creation of the stand-alone preparser and later isolates, it has been moved into a separate class with a per-isolate instance. It is used to hold caching unicode Predicate values. This change renames the class to UnicodeCache, and passes a reference to the instance down to methods that doesn't have an easy access to an isolate (to avoid, e.g., having to do an Isolate::Current() for every number parsed). Review URL: http://codereview.chromium.org/6824071 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@7584 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 26 Nov, 2010 1 commit
-
-
lrn@chromium.org authored
see http://code.google.com/p/v8/issues/detail?id=944 This patch makes DateParser::TimeComposer process times that have millisecond values with only 1 or 2 digits. Without this patch, Date.parse("2010-11-25T22:02:30.5") returns 1290690150005 and Date.parse("2010-11-25T22:02:30.5") == Date.parse("2010-11-25T22:02:30.005") evaluates to true. With this patch, Date.parse("2010-11-25T22:02:30.5") returns 1290690150500 instead, and Date.parse("2010-11-25T22:02:30.5") == Date.parse("2010-11-25T22:02:30.005") evaluates to false. Review URL: http://codereview.chromium.org/5336005 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5893 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 10 Sep, 2010 1 commit
-
-
lrn@chromium.org authored
This makes, e.g., Date.parse("2010-08-31T22:35:36-09:00") work as expected. Without this change, the "-9:00" timezone-offset portion causes V8 to fail to properly parse that string into a date. BUG=http://code.google.com/p/v8/issues/detail?id=857 TEST=Try Date.parse("2010-08-31T22:35:36-09:00") and make sure that it gets parsed without errors and does not return NaN. Review URL: http://codereview.chromium.org/3318017 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5436 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 03 May, 2010 1 commit
-
-
ricow@chromium.org authored
Review URL: http://codereview.chromium.org/1704016 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@4557 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 15 Oct, 2009 1 commit
-
-
kmillikin@chromium.org authored
"jsregexp.h" and "jump-target.h" required "macro-assembler.h" to always be included first. Instead the include of "macro-assembler.h" has moved into those header files. "dateparser-inl.h" required "dateparser.h" to always be included first. Instead the include of "dateparser.h" has moved into "dateparser-inl.h". Review URL: http://codereview.chromium.org/267117 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3074 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 25 May, 2009 1 commit
-
-
mikhail.naganov@gmail.com authored
This issue was raised by Brett Wilson while reviewing my changelist for readability. Craig Silverstein (one of C++ SG maintainers) confirmed that we should declare one namespace per line. Our way of namespaces closing seems not violating style guides (there is no clear agreement on it), so I left it intact. Review URL: http://codereview.chromium.org/115756 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@2038 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 04 May, 2009 1 commit
-
-
deanm@chromium.org authored
- Fix some typos / guards that didn't match the filename. - Fix some style inconsistencies. - Add guards to files that were missing them. - Add the directory name to the guard. Review URL: http://codereview.chromium.org/99343 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@1845 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 19 Mar, 2009 1 commit
-
-
lrn@chromium.org authored
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@1544 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 17 Mar, 2009 1 commit
-
-
lrn@chromium.org authored
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@1525 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-