• hablich's avatar
    Revert of [heap] Initialize the owner on each page after lospace allocation... · 1e70454f
    hablich authored
    Revert of [heap] Initialize the owner on each page after lospace allocation (patchset #2 id:20001 of https://codereview.chromium.org/2565713002/ )
    
    Reason for revert:
    Tree closer: https://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20arm64%20-%20sim%20-%20MSAN/builds/12409
    
    Original issue's description:
    > [heap] Initialize the owner on each page after lospace allocation
    >
    > The least two bits of the owner field of a Page are used to determine
    > whether the Page is part of a large object. If these bits are not equal
    > to 0x11, the page is part of a large object and needs special handling
    > e.g. in MemoryChunk::FromAnyPointerAddress to determine which chunk it
    > belongs to.
    >
    > This CL fixes an issue in which the store buffer overflows after
    > a large object space allocation but before the object has been fully
    > initialized. Store buffer overflow handling attempts to look up the
    > chunk of a page, but fails to do so correctly since the page's owner
    > field has not yet been initialized.
    >
    > This CL ensures that the owner field of all pages belonging to a large
    > object allocation are initialized to a value that is interpreted
    > correctly.
    >
    > BUG=chromium:672041
    >
    > Committed: https://crrev.com/9b6808bfb5366beebe3af30a06f9851edb2039d4
    > Cr-Commit-Position: refs/heads/master@{#41641}
    
    TBR=mlippautz@chromium.org,jgruber@chromium.org
    # Skipping CQ checks because original CL landed less than 1 days ago.
    NOPRESUBMIT=true
    NOTREECHECKS=true
    NOTRY=true
    BUG=chromium:672041
    
    Review-Url: https://codereview.chromium.org/2562273004
    Cr-Commit-Position: refs/heads/master@{#41644}
    1e70454f
Name
Last commit
Last update
benchmarks Loading commit data...
build_overrides Loading commit data...
docs Loading commit data...
gni Loading commit data...
gypfiles Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
Makefile Loading commit data...
Makefile.android Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...
snapshot_toolchain.gni Loading commit data...