- 02 Mar, 2021 23 commits
-
-
Camillo Bruni authored
After deprecation and removal of the old misleading API we re-add v8::String::IsExternal which returns true for both, external one-byte and external two-byte strings. Bug: v8:10641 Change-Id: I4c66d4df891f7180c7a727a45c1fbd254a7f5c02 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2726512Reviewed-by: Maya Lekova <mslekova@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#73137}
-
Santiago Aboy Solanes authored
Tnodifying the last cases of StoreElement, brings the total Node* occurrences in code-stub-assembler to 0! Bug: v8:6949 Change-Id: I27f61447a2a57969b5d24fe24ee5b2265aa20f8e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2727504 Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org> Reviewed-by: Mythri Alle <mythria@chromium.org> Cr-Commit-Position: refs/heads/master@{#73136}
-
Manos Koukoutos authored
Tail calls are connected to the end of the graph, so technically they also constitute loop exits. Additional Changes: - In DoReturnCall, change the argument {Node* index_node} into {Value index_or_caller_value}. - Rename StackValueVector -> ValueVector. - Add a test that reveals the bug. Bug: chromium:1183622, v8:11298 Change-Id: I58f7877f2d03e94f6a281e566829897c3000b890 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2727503Reviewed-by: Clemens Backes <clemensb@chromium.org> Commit-Queue: Manos Koukoutos <manoskouk@chromium.org> Cr-Commit-Position: refs/heads/master@{#73135}
-
Leszek Swirski authored
Add a Utf16CharacterStream for windows-1252, which uses a table to covert from windows-1252 to the appropriate uc16 character. This fixes issues where windows-1252 encoded source was treated like latin-1. This introduces a new encoding type in the API, so embedders will have to opt-in to using this new stream. Fixed: v8:9315 Change-Id: I2e847c2d4f1727281f6be24b4743d77bb232a62d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2729338 Commit-Queue: Leszek Swirski <leszeks@chromium.org> Auto-Submit: Leszek Swirski <leszeks@chromium.org> Reviewed-by: Toon Verwaest <verwaest@chromium.org> Cr-Commit-Position: refs/heads/master@{#73134}
-
Dan Elphick authored
Moves the handling of base/trace_event/common/trace_event_common.h from v8_base_without_compiler to v8_internal_headers to fix a build break caused by: https://chromium-review.googlesource.com/c/v8/v8/+/2712569 Change-Id: Ie3c161874e18cdfaf30286ff0fa299a4c4e2c1a6 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2729340Reviewed-by: Mythri Alle <mythria@chromium.org> Commit-Queue: Dan Elphick <delphick@chromium.org> Cr-Commit-Position: refs/heads/master@{#73133}
-
Milad Fa authored
Also renamed VECTOR_BIN_OP to VECTOR_ARITHMETIC_OP for clarity. Change-Id: Icbe1cf9ac95f2c0b1cec364f50123a9fcb846f48 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2727644Reviewed-by: Junliang Yan <junyan@redhat.com> Commit-Queue: Milad Fa <mfarazma@redhat.com> Cr-Commit-Position: refs/heads/master@{#73132}
-
Nico Hartmann authored
This reverts commit 6e234e9d. Reason for revert: https://ci.chromium.org/ui/p/v8/builders/ci/V8%20Linux%20-%20arm64%20-%20sim%20-%20CFI/4795/overview Original change's description: > [wasm][liftoff][eh] Implement catch_all > > Inline a catch handler after each potentially throwing call. The handler > just merges values into the actual catch environment and then jumps to > the catch body. > > This automatically adds support for unwind, which also uses the > "CatchAll" interface method. > > Many tests can be written either with "catch" or with "catch_all". > Duplicate them to get coverage for both. > > R=clemensb@chromium.org > > Bug: v8:11453 > Change-Id: I789ad44b8d1e496f026157d5c37a12004a8b37e3 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2726497 > Reviewed-by: Clemens Backes <clemensb@chromium.org> > Commit-Queue: Thibaud Michaud <thibaudm@chromium.org> > Cr-Commit-Position: refs/heads/master@{#73129} Bug: v8:11453 Change-Id: Ica7fa708962d9ae4b9fbf7473963d187062227ca No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2727266 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Nico Hartmann <nicohartmann@chromium.org> Cr-Commit-Position: refs/heads/master@{#73131}
-
Toon Verwaest authored
The interpreter always adjusts the current interrupt budget down by the current bytecode size as well. This aligns the optimization heuristics. Bug: v8:11420 Change-Id: I0cc78d004779b393a3d8fb46e44bdd7465fcf4ed Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2726496 Auto-Submit: Toon Verwaest <verwaest@chromium.org> Reviewed-by: Leszek Swirski <leszeks@chromium.org> Commit-Queue: Toon Verwaest <verwaest@chromium.org> Cr-Commit-Position: refs/heads/master@{#73130}
-
Thibaud Michaud authored
Inline a catch handler after each potentially throwing call. The handler just merges values into the actual catch environment and then jumps to the catch body. This automatically adds support for unwind, which also uses the "CatchAll" interface method. Many tests can be written either with "catch" or with "catch_all". Duplicate them to get coverage for both. R=clemensb@chromium.org Bug: v8:11453 Change-Id: I789ad44b8d1e496f026157d5c37a12004a8b37e3 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2726497Reviewed-by: Clemens Backes <clemensb@chromium.org> Commit-Queue: Thibaud Michaud <thibaudm@chromium.org> Cr-Commit-Position: refs/heads/master@{#73129}
-
Camillo Bruni authored
- Fix diff coloring when a baseline is selected - Cleanup UI and use dark-mode by default - Reuse CSS from the system-analyzer - Support loading mutliple files by default everywhere - Use hideable panels from system-analyzer Change-Id: Iafe271d2f86fbbd10a940b3ac99874dd51f45442 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2721763 Commit-Queue: Camillo Bruni <cbruni@chromium.org> Reviewed-by: Patrick Thier <pthier@chromium.org> Cr-Commit-Position: refs/heads/master@{#73128}
-
Camillo Bruni authored
Clang cannot optimise across handle derefs and produces quite inefficient code when setting multiple properties in a row. We are already dealing with a lot of raw pointers in factory, thus adding further DisallowGarbageCollection and will not significantly increase the risk of stale pointers. Bug: v8:11263 Change-Id: I2b62f79ecde95faa84a182c09d89c03423900d98 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2581963 Commit-Queue: Camillo Bruni <cbruni@chromium.org> Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#73127}
-
Santiago Aboy Solanes authored
Using templates seems like the best way to go. We are duplicating code but seems like a fair trade-off. Bug: v8:6949 Change-Id: I22b3d5e2e74bfc2bf46f95656782aae4944d72de Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2727816Reviewed-by: Dan Elphick <delphick@chromium.org> Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org> Cr-Commit-Position: refs/heads/master@{#73126}
-
Dan Elphick authored
Dependency is needed as wasm-interpreter.cc uses base/overflowing-math.h and base/safe_conversions.h. Bug: v8:7330 Change-Id: I4515babf18723a34c89e63621f8aaa49252d3461 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2727408 Auto-Submit: Dan Elphick <delphick@chromium.org> Reviewed-by: Clemens Backes <clemensb@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#73125}
-
Dan Elphick authored
Adds test/common/flag-utils.h and test/common/wasm/flag-utils.h to wasm_test_common to reduce the number of gn check errors by 4. Bug: v8:7330 Change-Id: I94e11130c4b96972604cabbaa019617cb1f8f67a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2727404 Commit-Queue: Dan Elphick <delphick@chromium.org> Auto-Submit: Dan Elphick <delphick@chromium.org> Reviewed-by: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#73124}
-
Liu Yu authored
Add register t3 to ALLOCATABLE_GENERAL_REGISTERS, and change kSpeculationPoisonRegister from a7 to t3. Change-Id: I199c1b837d5fdd0b47f0865ac3146e47e4ddb68f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2726050 Auto-Submit: Liu yu <liuyu@loongson.cn> Reviewed-by: Zhao Jiazhong <zhaojiazhong-hf@loongson.cn> Commit-Queue: Zhao Jiazhong <zhaojiazhong-hf@loongson.cn> Cr-Commit-Position: refs/heads/master@{#73123}
-
Dan Elphick authored
Adds cppgc_headers to v8_internal_headers and fuzzer_support to lib_wasm_fuzzer_common in BUILD.gn as well as v8_libbase and v8_libplatform to cctest_headers in test/cctest/BUILD.gn. Bug: v8:7730 Change-Id: I9759bb0993be779ddfc26668b9e08503ea53bd69 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2727501 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Auto-Submit: Dan Elphick <delphick@chromium.org> Reviewed-by: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#73122}
-
Santiago Aboy Solanes authored
Bug: v8:6949 Change-Id: Ie8620ec5f3025cdf4f419c80db221d57698fd508 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2726514Reviewed-by: Mythri Alle <mythria@chromium.org> Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org> Cr-Commit-Position: refs/heads/master@{#73121}
-
Dan Elphick authored
To fix 6 gn check errors, this adds a cppgc_headers dep to v8_headers. To resolve the resulting cycle, it also changes v8_libplatform to depend on v8_config_headers since it only needs v8config.h. Bug: v8:7330 Change-Id: I1e21271c84f2a80c248c584e8e107da99eaad5a9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2727500 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Auto-Submit: Dan Elphick <delphick@chromium.org> Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#73120}
-
Benedikt Meurer authored
Be explicit about source positions for `Return`s in the BytecodeGenerator, and only do self-healing explicitly in the `ReturnStatement` translation, where an end position of `kNoSourcePosition` is turned into the return position of the function literal. This allows us to reason more easily about which `Return`s actually receive a meaningful source position, and in particular it allows us to construct the internal `Return`s for `yield` and `yield*` with no source position attached to them. Previously they'd get the source position for the implicit (final) return attached to it, which confused the debugger and led to breakpoints being set in the completely wrong spot. Considering the simplified example ``` function* foo(){ var a = 1; } ``` this would previously generate the following bytecode ``` 0 : SwitchOnGeneratorState r0, [0], [1] { 0: @20 } 4 : Mov <closure>, r2 7 : Mov <this>, r3 13 E> 10 : InvokeIntrinsic [_CreateJSGeneratorObject], r2-r3 14 : Star0 13 E> 15 : SuspendGenerator r0, r0-r1, [0] 20 : ResumeGenerator r0, r0-r1 24 : Star2 25 : InvokeIntrinsic [_GeneratorGetResumeMode], r0-r0 29 : SwitchOnSmiNoFeedback [1], [2], [0] { 0: @39, 1: @36 } 33 : Ldar r2 13 E> 35 : Throw 36 : Ldar r2 30 S> 38 : Return <=========================== internal Return 27 S> 39 : LdaSmi [1] 41 : Star1 42 : LdaUndefined 30 S> 43 : Return ``` where everything between offset 4 and 42 corresponds to the implicit yield at the beginning of every generator function, in particular the code between 20 and 42 corresponds to that initial yields resumption logic. Notice how the internal Return at offset 38 gets assigned the source position of the function literal (the same as the implicit return at the end). This confuses the debugger quite a bit when trying to set a breakpoint on the closing brace, since it's going in bytecode order and will thus discover the `Return` at offset 38 first (matching the source position 30 it's currently looking for) and setting the breakpoint there. This `Return` bytecode however is only executed when the generator is resumed via `GeneratorPrototype.return()`, and it'll not hit when the developer uses the generator normally, which is not the desired behavior and extremely confusing (especially since stepping on the other hand works as expected). With this patch, we no longer slap a source position (and in particular not the function literal's return position) onto these internal `Return`s as you can see from the generated bytecode below: ``` 0 : SwitchOnGeneratorState r0, [0], [1] { 0: @20 } 4 : Mov <closure>, r2 7 : Mov <this>, r3 13 E> 10 : InvokeIntrinsic [_CreateJSGeneratorObject], r2-r3 14 : Star0 13 E> 15 : SuspendGenerator r0, r0-r1, [0] 20 : ResumeGenerator r0, r0-r1 24 : Star2 25 : InvokeIntrinsic [_GeneratorGetResumeMode], r0-r0 29 : SwitchOnSmiNoFeedback [1], [2], [0] { 0: @39, 1: @36 } 33 : Ldar r2 13 E> 35 : Throw 36 : Ldar r2 38 : Return 27 S> 39 : LdaSmi [1] 41 : Star1 42 : LdaUndefined 30 S> 43 : Return ``` This also allows us to remove the break position finding hack that was kept in BreakIterator::BreakIndexFromPosition() for generators and modules. Fixed: chromium:901819 Change-Id: If19a6b26e2622d49b6b5e54bf7a162747543f970 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2727820Reviewed-by: Yang Guo <yangguo@chromium.org> Reviewed-by: Leszek Swirski <leszeks@chromium.org> Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Cr-Commit-Position: refs/heads/master@{#73119}
-
Dan Elphick authored
To reduce gn check errors, this moves EmbeddedFileWriterInterface into its own header file that can be included directly by isolate.cc since embedded-file-writer.h is in the mksnapshot target. Bug: v8:7330 Change-Id: I3bfb1f48c646680b71189e8229b8df54ead9eea0 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2727817 Auto-Submit: Dan Elphick <delphick@chromium.org> Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by: Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#73118}
-
Dan Elphick authored
Moves src/wasm/wasm-constants.h and src/wasm/wasm-limits.h into v8_shared_internal_headers so v8_flags can access them. Bug: v8:7330 Change-Id: I322ac483d26a03fd79e9961678462227a89e594b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2727498 Auto-Submit: Dan Elphick <delphick@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#73117}
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/06d89c7..a1f3c3d Rolling v8/buildtools/third_party/libunwind/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libunwind/+log/8d5fb6f..201ff85 Rolling v8/third_party/aemu-linux-x64: 12utHdzpAJMv14HvzgxQA19OLkI0UrGervsCs46ESbIC..gUyZgCT7R0DTHyu0Lq1Q7yrbbA9cage7ltjq_oN3mXkC Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/df7850d..cae643a Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/e952fae..6ac4a15 TBR=v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ic0e83640067bc37ed7b5ec5d35c6118e5e649e72 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2728641Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#73116}
-
Frank Tang authored
This reverts commit 57ae048b. Reason for revert: bug fixed in https://chromium-review.googlesource.com/c/v8/v8/+/2706353 Original change's description: > [test] Disable tests failing with new msan roll > > Temporarily disable these tests failing on msan builds after latest > roll: > - test262/intl402/DateTimeFormat/timezone-invalid > - intl/regress-364374 > - mjsunit/regress/regress-crbug-627935 > > No-Try: true > No-Tree-Checks: true > Bug: v8:11438 > Change-Id: I4a7755f9f65b2e9a12463c9e12fbbe39d3f5efb2 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2692188 > Reviewed-by: Clemens Backes <clemensb@chromium.org> > Commit-Queue: Clemens Backes <clemensb@chromium.org> > Auto-Submit: Nico Hartmann <nicohartmann@chromium.org> > Cr-Commit-Position: refs/heads/master@{#72691} Bug: v8:11438 Change-Id: Iaca0a401a2c6d89e1bc8292ad41ae0086943c635 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2724862Reviewed-by: Clemens Backes <clemensb@chromium.org> Reviewed-by: Nico Hartmann <nicohartmann@chromium.org> Commit-Queue: Frank Tang <ftang@chromium.org> Cr-Commit-Position: refs/heads/master@{#73115}
-
- 01 Mar, 2021 17 commits
-
-
Shu-yu Guo authored
Change-Id: I33999e33793662aad741d336018f3a099af17fec Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2728239 Commit-Queue: Shu-yu Guo <syg@chromium.org> Commit-Queue: Igor Sheludko <ishell@chromium.org> Auto-Submit: Shu-yu Guo <syg@chromium.org> Reviewed-by: Igor Sheludko <ishell@chromium.org> Cr-Commit-Position: refs/heads/master@{#73114}
-
Ng Zhi An authored
Bug: v8:11384 Change-Id: I51ac29ed041bc0491c9c45ca1416d69639d9338e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2720018 Commit-Queue: Zhi An Ng <zhin@chromium.org> Reviewed-by: Deepti Gandluri <gdeepti@chromium.org> Cr-Commit-Position: refs/heads/master@{#73113}
-
Dan Elphick authored
Add conditional include of caged-heap-local-data.h and v8_libplatform dep. Bug: v8:7730 Change-Id: Ic9dcb919a94e96fbdeb586e20de9fe17ff4d0ce1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2727499Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Auto-Submit: Dan Elphick <delphick@chromium.org> Commit-Queue: Dan Elphick <delphick@chromium.org> Cr-Commit-Position: refs/heads/master@{#73112}
-
Ng Zhi An authored
The main problem here is that the macro-assembler for Pmaddubsw and Pmaddwd expects dst == src1 when AVX is not supported. For Pmaddwd, we use an existing macro to define the function. For Pmaddubsw, we do the AVX check inline and use movaps if not supported because it requires a SSSE3 scope, and we don't have an existing macro to do this (we can find other uses and clean up as necessary in the future). Bug: v8:11086 Change-Id: I97bd29cd93456744414d28e5f1ffcbc875c3ab22 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2716740Reviewed-by: Deepti Gandluri <gdeepti@chromium.org> Commit-Queue: Zhi An Ng <zhin@chromium.org> Cr-Commit-Position: refs/heads/master@{#73111}
-
Dan Elphick authored
Moves flags/flags.h and flags/flag-definitions.h out of v8_internal_headers into a new v8_flags target that can be included by torque_base to resolve a gn check error. Bug: v8:7330 Change-Id: I08e3a4475cc4f455077995ddff8683266ed51cd9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2727819 Commit-Queue: Dan Elphick <delphick@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Auto-Submit: Dan Elphick <delphick@chromium.org> Reviewed-by: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#73110}
-
Milad Fa authored
Change-Id: I8f9f2e291e943a0a63cb78a033b44e6c4a7889f8 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2727822Reviewed-by: Junliang Yan <junyan@redhat.com> Commit-Queue: Milad Fa <mfarazma@redhat.com> Cr-Commit-Position: refs/heads/master@{#73109}
-
Dan Elphick authored
v8_libsampler was previously split off to serve goals that were never achieved and seem unlikely to be. Since the division creates a dependency cycle between v8_base_without_compiler and v8_libsampler (where one edge is a #include that breaks gn check), this moves sampler.* back into v8_base_without_compiler and removes the v8_libsampler target. Bug: v8:7330 Change-Id: Ied87b68927a372ec084cd650b278af98d7db5f8e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2727818 Auto-Submit: Dan Elphick <delphick@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Reviewed-by: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#73108}
-
Junliang Yan authored
Change-Id: Ia9935d84edc020196f0b728c2852499d62fffeca Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2727657Reviewed-by: Milad Fa <mfarazma@redhat.com> Commit-Queue: Junliang Yan <junyan@redhat.com> Cr-Commit-Position: refs/heads/master@{#73107}
-
Milad Fa authored
Port 7c78ad80 Original Commit Message: These were prototyped and not merged into the SIMD proposal. R=zhin@chromium.org, joransiu@ca.ibm.com, junyan@redhat.com, midawson@redhat.com BUG= LOG=N Change-Id: Ic6f604891908d0b4f1554951a57ef45e6e7d285e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2727655Reviewed-by: Junliang Yan <junyan@redhat.com> Commit-Queue: Milad Fa <mfarazma@redhat.com> Cr-Commit-Position: refs/heads/master@{#73106}
-
Michael Lippautz authored
Bug: chromium:1056170 Change-Id: I2744bbb615e417d9658cd2160220cf097b38b698 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2726509Reviewed-by: Omer Katz <omerkatz@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#73105}
-
Dan Elphick authored
Split out all the headers from v8_compiler/v8_compiler_opt and v8_base_without_compiler into v8_internal_headers since the headers have inter-dependencies that otherwise make it impossible to satisfy gn check. Also adds new v8_header_set torque_runtime_support that exports src/torque/runtime-support.h separately from the generated headers. This reduces the number of gn check failures from 169 to 59. Bug: v8:7330 Change-Id: Ie7ebc894910b7efa02011a74da964e11995c7f4f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2712569 Commit-Queue: Dan Elphick <delphick@chromium.org> Reviewed-by: Michael Achenbach <machenbach@chromium.org> Reviewed-by: Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#73104}
-
Santiago Aboy Solanes authored
Add tests for internal external uncached strings with cacheable resources, for the cached_data functionality added in https://chromium-review.googlesource.com/c/v8/v8/+/2710440. Bug: v8:7790, v8:11463 Change-Id: I679c50995d315cc4289452a00838b3cafa4c93e4 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2715187Reviewed-by: Leszek Swirski <leszeks@chromium.org> Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org> Cr-Commit-Position: refs/heads/master@{#73103}
-
Manos Koukoutos authored
Bug: v8:11298 Change-Id: I064cfda6744f01099f70aab37cfd620afaff1262 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2726505Reviewed-by: Georg Neis <neis@chromium.org> Commit-Queue: Manos Koukoutos <manoskouk@chromium.org> Cr-Commit-Position: refs/heads/master@{#73102}
-
Santiago Aboy Solanes authored
Using Parameter has some crashes on arm64. The other Parameters are also using UncheckedParameter so let's use that. Bug: v8:6949 Change-Id: Ia802b4edd6d57fb87de5c58415e9569b4824fc6a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2470566Reviewed-by: Dan Elphick <delphick@chromium.org> Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org> Cr-Commit-Position: refs/heads/master@{#73101}
-
Clemens Backes authored
This CL removes the includes of src/wasm files from the API if Wasm is disabled (v8_enable_webassembly=false). This will allow to later remove the whole src/wasm directory from compilation. Since we do not want to modify the exposed API in a no-wasm build, we instead make all Wasm-related functions fail. R=ulan@chromium.org Bug: v8:11238 Change-Id: I61038e75ac62871758351eb01f299fe68d478c82 Cq-Include-Trybots: luci.v8.try:v8_linux64_no_wasm_compile_rel Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2726504Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#73100}
-
Frank Emrich authored
This CL is part of a series that adds the C++ implementation of SwissNameDictionary, a deterministic property backing store based on Swiss Tables. This CL adds an in-place version of Rehash and a small change to HeapObject::HeapObjectShortPrint. Bug: v8:11388 Change-Id: I578ef8f5638a6201111602ffef7f2d4a5a257bcd Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2720305Reviewed-by: Igor Sheludko <ishell@chromium.org> Reviewed-by: Marja Hölttä <marja@chromium.org> Commit-Queue: Frank Emrich <emrich@google.com> Cr-Commit-Position: refs/heads/master@{#73099}
-
Mike Stanton authored
We got a TSAN warning because of the non-atomic store of the code pointer in a JSFunction in the interpreter builtin (when the pointer is discovered in the FeedbackVector). However, we know this store is safe because we guarantee a release store into the FeedbackVector. However, TSAN can't recognize this interesting triple relation. Therefore, we mark the fields we need to read from TurboFan as relaxed. Bug: v8:11501, v8:7790 Change-Id: I20652216294db540bf9c20e5067a6362fea07dc3 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2721762Reviewed-by: Michael Stanton <mvstanton@chromium.org> Reviewed-by: Georg Neis <neis@chromium.org> Commit-Queue: Michael Stanton <mvstanton@chromium.org> Cr-Commit-Position: refs/heads/master@{#73098}
-