- 29 Mar, 2017 16 commits
-
-
Michael Starzinger authored
R=clemensh@chromium.org BUG=v8:6127 Change-Id: I3b51474a6058312b4158c8cdd3eef004ee2e7d0c Reviewed-on: https://chromium-review.googlesource.com/461143Reviewed-by: Clemens Hammacher <clemensh@chromium.org> Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#44227}
-
bmeurer authored
Even in optimized code we can utilize the various load and store IC trampolines to save code space when it's an IC in the outermost function, as in that case the trampoline can just take the vector from the parent's frame. BUG=v8:5267 Review-Url: https://codereview.chromium.org/2776073005 Cr-Commit-Position: refs/heads/master@{#44226}
-
Peter Marshall authored
This should be the fastest case, as we can just copy the backing store directly. Adding this test so that we can monitor if upcoming changes regress this path. BUG=v8:5977 Change-Id: I021a199061ac845f265a906bda68b7ad3e8d5708 Reviewed-on: https://chromium-review.googlesource.com/461183Reviewed-by: Franziska Hinkelmann <franzih@chromium.org> Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> Commit-Queue: Peter Marshall <petermarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#44225}
-
jarin authored
Review-Url: https://codereview.chromium.org/2775423005 Cr-Commit-Position: refs/heads/master@{#44224}
-
Michael Starzinger authored
R=clemensh@chromium.org BUG=v8:6127 Change-Id: Id77e8eef3ad909608a5d32fa7373077540e201c7 Reviewed-on: https://chromium-review.googlesource.com/461824Reviewed-by: Clemens Hammacher <clemensh@chromium.org> Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#44223}
-
Yang Guo authored
Change-Id: I8de170892f061a8b30d1e39d1a7d3b4e2fe9230d Reviewed-on: https://chromium-review.googlesource.com/461823 Commit-Queue: Yang Guo <yangguo@chromium.org> Reviewed-by: Jochen Eisinger <jochen@chromium.org> Cr-Commit-Position: refs/heads/master@{#44222}
-
jgruber authored
Move builtin definitions (i.e. BUILTIN_LIST and family) to a separate header in preparation for auto-generation of TFS interface descriptors. BUG=v8:6116 Review-Url: https://codereview.chromium.org/2784793002 Cr-Commit-Position: refs/heads/master@{#44221}
-
bmeurer authored
Now that Ignition has the dedicated TestTypeOf operator, there's not really a point in doing the typeof with abstract/strict equal combining in TurboFan anymore. In fact it's counter-productive to do so, as it might try to cover typeof comparisons in cases where it's better to just compute the typeof once, i.e.: let x = typeof a, y = typeof b; if (x === y) { if (x === 'string') { ... } } Here we would combine the second comparison into an ObjectIsString, and still compute the typeof a. R=jarin@chromium.org BUG=v8:5267 Review-Url: https://codereview.chromium.org/2780953003 Cr-Commit-Position: refs/heads/master@{#44220}
-
Michael Starzinger authored
R=machenbach@chromium.org BUG=v8:6127 Change-Id: Ie828f6e0dc6fe9f9f9351aa1afaf7b9dbf536e26 Reviewed-on: https://chromium-review.googlesource.com/461181Reviewed-by: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#44219}
-
bmeurer authored
When we call from TurboFan to a CSA or C++ builtin, we can avoid the ArgumentsAdaptorFrame in case of a parameter arity mismatch by just filling up missing arguments with undefined or removing additional arguments on the call site already. This is safe for CSA/C++ builtins, since those that care about variable arguments are marked with the kDontAdaptArgumentsSentinel. R=danno@chromium.org BUG=v8:5267 Review-Url: https://codereview.chromium.org/2684963002 Cr-Commit-Position: refs/heads/master@{#44218}
-
machenbach authored
Revert of [inspector] console get all information from inspector when needed (patchset #4 id:60001 of https://codereview.chromium.org/2784713002/ ) Reason for revert: Breaks layout tests: https://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Linux%2064/builds/14569 Original issue's description: > [inspector] console get all information from inspector when needed > > With this CL we don't need to store reference to InspectedContext inside of JavaScript console object and able to get all required information from callback data. > It allows us to implement console methods without taking in account how and where we create and store these methods: > - later we can move console object implementation to builtins.. > - ..and install command line API methods smarter. > > BUG=chromium:588893 > R=dgozman@chromium.org > > Review-Url: https://codereview.chromium.org/2784713002 > Cr-Commit-Position: refs/heads/master@{#44212} > Committed: https://chromium.googlesource.com/v8/v8/+/908cd38123df33ce293e4c8d25e407f7ca915f4c TBR=dgozman@chromium.org,kozyatinskiy@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:588893 Review-Url: https://codereview.chromium.org/2784603003 Cr-Commit-Position: refs/heads/master@{#44217}
-
Mythri authored
Compare bytecode handlers does several checks to collect feedback and repeats these checks when actually performing the operation. This cl changes it perform the actual comparison for smi / number along with collecting feedback. BUG=v8:4280 Change-Id: If0954b68dd232461e08e94a90ccc17604c235b27 Reviewed-on: https://chromium-review.googlesource.com/458420 Commit-Queue: Mythri Alle <mythria@chromium.org> Reviewed-by: Ross McIlroy <rmcilroy@chromium.org> Cr-Commit-Position: refs/heads/master@{#44216}
-
jgruber authored
Compilation can fail e.g. on stack overflow. This ensures that we exit early from StringReplaceGlobalRegExpWithString in that case. BUG=v8:5437,chromium:705934 Review-Url: https://codereview.chromium.org/2778953004 Cr-Commit-Position: refs/heads/master@{#44215}
-
gsathya authored
Review-Url: https://codereview.chromium.org/2784653003 Cr-Commit-Position: refs/heads/master@{#44214}
-
v8-autoroll authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/947f28d..133db8f Rolling v8/third_party/catapult: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+log/e044353..0c870c7 Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/9fbab72..e9e483c TBR=machenbach@chromium.org,vogelheim@chromium.org,hablich@chromium.org Change-Id: Id56c81495145890f5436c904907cb1a75b968d8c Reviewed-on: https://chromium-review.googlesource.com/461459Reviewed-by: v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#44213}
-
kozyatinskiy authored
With this CL we don't need to store reference to InspectedContext inside of JavaScript console object and able to get all required information from callback data. It allows us to implement console methods without taking in account how and where we create and store these methods: - later we can move console object implementation to builtins.. - ..and install command line API methods smarter. BUG=chromium:588893 R=dgozman@chromium.org Review-Url: https://codereview.chromium.org/2784713002 Cr-Commit-Position: refs/heads/master@{#44212}
-
- 28 Mar, 2017 24 commits
-
-
kschimpf authored
Currently, V8 uses the same size counter to measure module sizes for both asm.js and WASM. This CL separates the counter into two separate counters, and then uses the appropriate counter when decoding. BUG=chromium:704922 R=mtrofin@chromium.org,bradnelson@chromium.org Review-Url: https://codereview.chromium.org/2777203005 Cr-Commit-Position: refs/heads/master@{#44211}
-
kschimpf authored
Currently, V* uses the same size counter to measure the maximum number of memory pages allocated by a module for both asm.js and WASM. This CL separates the counter into two separate counters, and then uses the appropriate counter when measuring. BUG=chromium:704922 R=mtrofin@chromium.org,bradnelson@chromium.org Review-Url: https://codereview.chromium.org/2783713002 Cr-Commit-Position: refs/heads/master@{#44210}
-
kozyatinskiy authored
Should be fixed. BUG=v8:6161 R=dgozman@chromium.org Review-Url: https://codereview.chromium.org/2779143002 Cr-Commit-Position: refs/heads/master@{#44209}
-
littledan authored
A couple bugs had led code in one Context to be able to lead to estimated memory usage in another Context, even in cases that should be easy to detect. - Ensure that the pointer to the next context is nulled out while recursing over the portion of the heap. It seems like there was previously some code to do this partway, but the nulling part was left out. - Skip including maps in the understanding of the Context estimated size, as the maps are shared between Contexts and may be reachable from other Contexts Review-Url: https://codereview.chromium.org/2780773002 Cr-Commit-Position: refs/heads/master@{#44208}
-
kschimpf authored
Currently, V8 uses the same counter to measue module decoding peak memory bytes for both asm.js and WASM. This CL separates the counter into two separate counters, and then uses the appropriate counter when decoding a module. BUG=chromium:704922 R=bbudge@chromium.org,bradnelson@chromium.org,mtrofin@chromium.org Review-Url: https://codereview.chromium.org/2778973003 Cr-Commit-Position: refs/heads/master@{#44207}
-
kozyatinskiy authored
Current implementation is unsafe if __proto__ getter is defined on Object.prototype. BUG=chromium:595206 R=dgozman@chromium.org Review-Url: https://codereview.chromium.org/2770263003 Cr-Commit-Position: refs/heads/master@{#44206}
-
kschimpf authored
Currently, V8 uses the same size counter to measure function byte sizes for both asm.js and WASM. This CL separates the counter into two separate counters, and then uses the appropriate counter when decoding. BUG=chromium:704922 R=bbudge@google.com,bradnelson@chromium.org Review-Url: https://codereview.chromium.org/2780783003 Cr-Commit-Position: refs/heads/master@{#44205}
-
kschimpf authored
Currently, V8 uses the same size counter to measure the minimum number of memory pages allocated by a module for both asm.js and WASM. This CL separates the counter into two separate counters, and then uses the appropriate counter when measuring. BUG=chromium:704922 R=mtrofin@chromium.org,bradnelson@chromium.org Review-Url: https://codereview.chromium.org/2781453004 Cr-Commit-Position: refs/heads/master@{#44204}
-
bradnelson authored
Fix a few items broken during review of scanner + parser: * Make the scanner retain stale newline state on a rewind (as otherwise it must be able to correctly rewind that too, though it doesn't need it). (Probably should revisit). * Change StashCode in the builder skip to the zero case, as it crashes for some reason (added TODO). Also fix: * Drop test based on constant expression evaluation in main parser * Support constant defined based on existing constant. * Type constants as signed. * Added a check that all used functions are defined eventually. * Zone allocate strings for simplicity (TODOs to refactor better). BUG=v8:6090 BUG=v8:4203 R=mstarzinger@chromium.org,marja@chromium.org,vogelheim@chromium.org Review-Url: https://codereview.chromium.org/2771183002 Cr-Original-Commit-Position: refs/heads/master@{#44200} Committed: https://chromium.googlesource.com/v8/v8/+/be0dbdd679b60c31d480d7635e579787a6a218df Review-Url: https://codereview.chromium.org/2771183002 Cr-Commit-Position: refs/heads/master@{#44203}
-
Jakob Kummerow authored
Change-Id: I0efbb837026908173739946353334ae7ebf62379 Reviewed-on: https://chromium-review.googlesource.com/461880Reviewed-by: Toon Verwaest <verwaest@chromium.org> Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#44202}
-
bradnelson authored
Revert of [wasm][asm.js] Fix and enable several asm.js tests with the new parser. (patchset #10 id:180001 of https://codereview.chromium.org/2771183002/ ) Reason for revert: Fails on gc-stress. Original issue's description: > [wasm][asm.js] Fix and enable several asm.js tests with the new parser. > > Fix a few items broken during review of scanner + parser: > * Make the scanner retain stale newline state on a rewind (as otherwise it must be able to correctly rewind that too, though it doesn't need it). (Probably should revisit). > * Change StashCode in the builder skip to the zero case, as it crashes for some reason (added TODO). > > Also fix: > * Drop test based on constant expression evaluation in main parser > * Support constant defined based on existing constant. > * Type constants as signed. > * Added a check that all used functions are defined eventually. > * Zone allocate strings for simplicity (TODOs to refactor better). > > BUG=v8:6090 > BUG=v8:4203 > R=mstarzinger@chromium.org,marja@chromium.org,vogelheim@chromium.org > > Review-Url: https://codereview.chromium.org/2771183002 > Cr-Commit-Position: refs/heads/master@{#44200} > Committed: https://chromium.googlesource.com/v8/v8/+/be0dbdd679b60c31d480d7635e579787a6a218df TBR=clemensh@chromium.org,bradnelson@google.com,marja@chromium.org,mstarzinger@chromium.org,vogelheim@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:6090 Review-Url: https://codereview.chromium.org/2782613002 Cr-Commit-Position: refs/heads/master@{#44201}
-
bradnelson authored
Fix a few items broken during review of scanner + parser: * Make the scanner retain stale newline state on a rewind (as otherwise it must be able to correctly rewind that too, though it doesn't need it). (Probably should revisit). * Change StashCode in the builder skip to the zero case, as it crashes for some reason (added TODO). Also fix: * Drop test based on constant expression evaluation in main parser * Support constant defined based on existing constant. * Type constants as signed. * Added a check that all used functions are defined eventually. * Zone allocate strings for simplicity (TODOs to refactor better). BUG=v8:6090 BUG=v8:4203 R=mstarzinger@chromium.org,marja@chromium.org,vogelheim@chromium.org Review-Url: https://codereview.chromium.org/2771183002 Cr-Commit-Position: refs/heads/master@{#44200}
-
Peter Marshall authored
Change-Id: I048b7d5229686cf64bed6ec31d118ae1928028a5 Reviewed-on: https://chromium-review.googlesource.com/461939Reviewed-by: Jochen Eisinger <jochen@chromium.org> Commit-Queue: Peter Marshall <petermarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#44199}
-
Michael Starzinger authored
This extends the existing insertion of soft deopts during early lowering from loads to stores (both named and keyed). It now covers all property access operations. Next we will handle monomorphic type feedback when applicable. R=bmeurer@chromium.org Change-Id: I6138744682cdbdbdb7274851aa81fb075229c309 Reviewed-on: https://chromium-review.googlesource.com/459482 Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> Cr-Commit-Position: refs/heads/master@{#44198}
-
kschimpf authored
Currently, V8 uses the same counter to collect decoding time for both asm.js and WASM. This separates the function decoding counter into two separate counters, and then uses the appropriate counter when decoding a module. BUG=chromium:704922 R=bbudge@chromium.org,bradnelson@chromium.org Review-Url: https://codereview.chromium.org/2772363002 Cr-Commit-Position: refs/heads/master@{#44197}
-
Ross McIlroy authored
Don't put internalized parser handles in a DeferredHandleScope if we aren't going to compile concurrently since this has a performance cost. BUG=chromium:686658 Change-Id: Id89d197b863569346895583e6df79134e79a5d4b Reviewed-on: https://chromium-review.googlesource.com/461879Reviewed-by: Marja Hölttä <marja@chromium.org> Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> Cr-Commit-Position: refs/heads/master@{#44196}
-
Igor Sheludko authored
BUG=v8:6116 Change-Id: I1487165550e938200ce49a022222892752feccae Reviewed-on: https://chromium-review.googlesource.com/461819Reviewed-by: Jakob Gruber <jgruber@chromium.org> Commit-Queue: Igor Sheludko <ishell@chromium.org> Cr-Commit-Position: refs/heads/master@{#44195}
-
jgruber authored
BUG=v8:5437 Review-Url: https://codereview.chromium.org/2776263003 Cr-Commit-Position: refs/heads/master@{#44194}
-
v8-autoroll authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/5dd7ff3..947f28d Rolling v8/third_party/catapult: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+log/d979a85..e044353 TBR=machenbach@chromium.org,vogelheim@chromium.org,hablich@chromium.org Change-Id: I902b94f5b225847b4bf1ac5a3bea807f4a62e37a Reviewed-on: https://chromium-review.googlesource.com/461959Reviewed-by: v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#44193}
-
Camillo Bruni authored
- support register expression for addresses, e.g.: $r15-1 - show whether addresses are in the minidump with "*" - show decoded Smis with dd - dd without arguments continues printing the next words Change-Id: I1a6a4f9f470c25eee7da1381014252e723ef5f7c Reviewed-on: https://chromium-review.googlesource.com/461900Reviewed-by: Toon Verwaest <verwaest@chromium.org> Cr-Commit-Position: refs/heads/master@{#44192}
-
Toon Verwaest authored
BUG= Change-Id: Ibadaef9ee4cb16afa01b782afc07a32bd39ad8aa Reviewed-on: https://chromium-review.googlesource.com/461140 Commit-Queue: Toon Verwaest <verwaest@chromium.org> Reviewed-by: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#44191}
-
jbroman authored
NOTRY=true Review-Url: https://codereview.chromium.org/2782463002 Cr-Commit-Position: refs/heads/master@{#44190}
-
Daniel Vogelheim authored
Introduce 'contextual keyword' tokens, which are parsed as identifiers but in some contexts are treated by the parser like proper keywords. These are usually keywords introduced by recent ECMAScript versions, which for reasons of backwards compatibility are still permissible as regular identifiers in most contexts. Current usage is to check for Token::IDENTIFIER and then do a string compare. With this change the initial scan will scan them as usual, but will then record the token as IDENTIFIER plus a secondary token with the 'contextual' value. BUG=v8:6902 Change-Id: I6ae390382998cf756a23720bd481cb9c0eb78a72 Reviewed-on: https://chromium-review.googlesource.com/459479 Commit-Queue: Daniel Vogelheim <vogelheim@chromium.org> Reviewed-by: Marja Hölttä <marja@chromium.org> Cr-Commit-Position: refs/heads/master@{#44189}
-
Toon Verwaest authored
BUG= Change-Id: I5e60705764b8ea20b171981cdd44d57a928fa34d Reviewed-on: https://chromium-review.googlesource.com/461178Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Toon Verwaest <verwaest@chromium.org> Cr-Commit-Position: refs/heads/master@{#44188}
-