• bradnelson's avatar
    Revert of [wasm][asm.js] Fix and enable several asm.js tests with the new... · f8973f1c
    bradnelson authored
    Revert of [wasm][asm.js] Fix and enable several asm.js tests with the new parser. (patchset #10 id:180001 of https://codereview.chromium.org/2771183002/ )
    
    Reason for revert:
    Fails on gc-stress.
    
    Original issue's description:
    > [wasm][asm.js] Fix and enable several asm.js tests with the new parser.
    >
    > Fix a few items broken during review of scanner + parser:
    > * Make the scanner retain stale newline state on a rewind (as otherwise it must be able to correctly rewind that too, though it doesn't need it). (Probably should revisit).
    > * Change StashCode in the builder skip to the zero case, as it crashes for some reason (added TODO).
    >
    > Also fix:
    > * Drop test based on constant expression evaluation in main parser
    > * Support constant defined based on existing constant.
    > * Type constants as signed.
    > * Added a check that all used functions are defined eventually.
    > * Zone allocate strings for simplicity (TODOs to refactor better).
    >
    > BUG=v8:6090
    > BUG=v8:4203
    > R=mstarzinger@chromium.org,marja@chromium.org,vogelheim@chromium.org
    >
    > Review-Url: https://codereview.chromium.org/2771183002
    > Cr-Commit-Position: refs/heads/master@{#44200}
    > Committed: https://chromium.googlesource.com/v8/v8/+/be0dbdd679b60c31d480d7635e579787a6a218df
    
    TBR=clemensh@chromium.org,bradnelson@google.com,marja@chromium.org,mstarzinger@chromium.org,vogelheim@chromium.org
    # Skipping CQ checks because original CL landed less than 1 days ago.
    NOPRESUBMIT=true
    NOTREECHECKS=true
    NOTRY=true
    BUG=v8:6090
    
    Review-Url: https://codereview.chromium.org/2782613002
    Cr-Commit-Position: refs/heads/master@{#44201}
    f8973f1c
Name
Last commit
Last update
benchmarks Loading commit data...
build_overrides Loading commit data...
docs Loading commit data...
gni Loading commit data...
gypfiles Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
Makefile Loading commit data...
Makefile.android Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...
snapshot_toolchain.gni Loading commit data...