- 27 Jul, 2020 20 commits
-
-
Andreas Haas authored
R=thibaudm@chromium.org Change-Id: I77711801a94ff8d57d66f2057b78a0d10521bbf1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2320648Reviewed-by:
Thibaud Michaud <thibaudm@chromium.org> Commit-Queue: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#69079}
-
Sigurd Schneider authored
Currently, only a scriptURL is reported, which can be over-written by sourceURL comments of the script. This means a script can basically claim to come from anywhere. This means that DevTools doesn't know the resource name the embedder provided if there is a sourceURL comment. This CL adds a `embedderName` field to the scriptParsed and scriptFailedToParse events that reports the name the embedder associated with the script. Bug: chromium:974543 Change-Id: I9863f878f57638174847890d9a3818952b1efc27 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2317310 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
Yang Guo <yangguo@chromium.org> Reviewed-by:
Toon Verwaest <verwaest@chromium.org> Cr-Commit-Position: refs/heads/master@{#69078}
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/bdbc779..5383c9f Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/342ad52..0606ae6 Rolling v8/third_party/zlib: https://chromium.googlesource.com/chromium/src/third_party/zlib/+log/89bddfe..103247f TBR=machenbach@chromium.org,tmrts@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I8a016265af2d1426e35ba6aa3a8fcf8f702c31d7 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2320429Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#69077}
-
Santiago Aboy Solanes authored
When we add safepointing, the source position address might change. Then, we need to use the handlified version for both concurrent-inlining and not. The logic for retrieving the Handle can be encapsulated in the BytecodeArrayRef, which can be reused in the other source_position_* methods. Bug: v8:7790 Change-Id: I3e5f937eb06153449cf6f720a2a4321cb338d903 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2316301Reviewed-by:
Georg Neis <neis@chromium.org> Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org> Cr-Commit-Position: refs/heads/master@{#69076}
-
Sathya Gunasekaran authored
This flag's name is slightly incorrect as it is possible to have more maps than this in the feecback vector. This flag doesn't account for deprecated maps in the feedback vector. To make this explicit, we change the flag to indicate that this only counts valid maps. Bug: v8:10582 Change-Id: Ib0cc425a03d590bb21184fc6b104d0ebee1d5b03 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2319992Reviewed-by:
Mythri Alle <mythria@chromium.org> Commit-Queue: Sathya Gunasekaran <gsathya@chromium.org> Cr-Commit-Position: refs/heads/master@{#69075}
-
Dominik Inführ authored
AllocateRaw(Aligned|Unaligned) will now refill LAB first and then invoke AllocateFast(Aligned|Unaligned) again. Bug: v8:10315 Change-Id: Ifa6e645b33a0c57a118de9cc15b0a38ad407a0c9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2319991Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Commit-Queue: Dominik Inführ <dinfuehr@chromium.org> Cr-Commit-Position: refs/heads/master@{#69074}
-
Andreas Haas authored
R= ulan@chromium.org Bug: chromium:1104580 Change-Id: I5824de7aa4c71b1464fc8b2c35375bcb5d84f2e9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2320329Reviewed-by:
-
Marja Hölttä authored
This test should've been rewritten in the last batch rewrite but wasn't. Bug: v8:10239 Change-Id: Ic2949e6282f72975898ab7e9aefe3210bba71fbf Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2319988 Commit-Queue: Marja Hölttä <marja@chromium.org> Reviewed-by:
Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#69072}
-
Milad Farazmand authored
Port 06bdd8d6 R=thibaudm@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com BUG= LOG=N Change-Id: I35cf8d96c542da6db840f90d30b3a77a8925fafb Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2313316Reviewed-by:
Junliang Yan <jyan@ca.ibm.com> Commit-Queue: Milad Farazmand <miladfar@ca.ibm.com> Cr-Commit-Position: refs/heads/master@{#69071}
-
Dominik Inführ authored
Change-Id: Ia071e8cfcb021ff7e80888370cafcc58c6cb0fca Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2317947 Auto-Submit: Dominik Inführ <dinfuehr@chromium.org> Commit-Queue: Peter Marshall <petermarshall@chromium.org> Reviewed-by:
Peter Marshall <petermarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#69070}
-
Tobias Tebbi authored
When mksnapshot fails on a static assert in Torque, print the statement and position from the Torque source. To enable special treatment, change the syntax of static asserts in Torque from StaticAssert() to static_assert() to align with assert() and check() statements. Bug: v8:7793 Change-Id: Idda8e3c342bdcefc893ff297f8d7727d2734c221 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2317314 Commit-Queue: Tobias Tebbi <tebbi@chromium.org> Reviewed-by:
Seth Brenith <seth.brenith@microsoft.com> Cr-Commit-Position: refs/heads/master@{#69069}
-
Santiago Aboy Solanes authored
This CL allows LocalHandles to be dereferenced by the same thread that created them, even if we have a DisallowHandleDereference scope. Bug: v8:7790 Change-Id: Ie227aaa4152c887d0d9c913dfa35217166726614 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2316111Reviewed-by:
Dominik Inführ <dinfuehr@chromium.org> Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org> Cr-Commit-Position: refs/heads/master@{#69068}
-
Manos Koukoutos authored
Change-Id: I29ab5285b3284ebecb97902703f5f1c0cc8f8961 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2317354Reviewed-by:
Clemens Backes <clemensb@chromium.org> Commit-Queue: Manos Koukoutos <manoskouk@chromium.org> Cr-Commit-Position: refs/heads/master@{#69067}
-
Zeynep Cankara authored
This CL adds a generic Event Class to unify common methods of IC and Map events. The Entry Class for IC Events and V8Map Class for Map Events inherits from this generic Event Class. Bug: v8:10644, v8:10735 Change-Id: I77d68fb40ee0ffbe297fcd1a13c3e2b746938168 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2317309 Commit-Queue: Zeynep Cankara <zcankara@google.com> Reviewed-by:
Camillo Bruni <cbruni@chromium.org> Reviewed-by:
Sathya Gunasekaran <gsathya@chromium.org> Cr-Commit-Position: refs/heads/master@{#69066}
-
Santiago Aboy Solanes authored
Bug: v8:7790 Change-Id: I9e62a60911d69aec20a59e92f989208f8eac6cb5 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2243219Reviewed-by:
Nico Hartmann <nicohartmann@chromium.org> Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org> Cr-Commit-Position: refs/heads/master@{#69065}
-
Thibaud Michaud authored
This is a reland of 06bdd8d6 Original change's description: > [liftoff][tail-call] Add indirect tail calls > > R=clemensb@chromium.org > > Bug: v8:10693 > Change-Id: Ic71d873bf7099ba671b9db1e87392d54aeebd7cf > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2312096 > Reviewed-by: Clemens Backes <clemensb@chromium.org> > Commit-Queue: Thibaud Michaud <thibaudm@chromium.org> > Cr-Commit-Position: refs/heads/master@{#68996} Bug: v8:10693 Change-Id: Ia360be2fff1e98fab969dd4ffa14b5991ec743af Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2316304 Commit-Queue: Thibaud Michaud <thibaudm@chromium.org> Reviewed-by:
-
Thibaud Michaud authored
If the types allow it, sometimes generate a return call instead of a regular call in the wasm-compile fuzzer. R=clemensb@chromium.org Bug: v8:10693 Change-Id: Ie5e92f2b012f655b9d7d5847dba4a669152635c3 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2316297 Commit-Queue: Thibaud Michaud <thibaudm@chromium.org> Reviewed-by:
-
Clemens Backes authored
Only the first four elements of the array will be used. Also, the fifth element sais 'stepInfo' instead of 'stepInto'. R=thibaudm@chromium.org Change-Id: I258a8b95795f0cfbcaf500b7d174786680914d36 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2316110Reviewed-by:
-
Dominik Inführ authored
Introduce explicit fast path for allocation from LAB. The slow path refills the LAB and allocates again. Other changes: 1) Move slow path methods out of the header file 2) AllocateRaw(Aligned|Unaligned) are now private methods. All allocations need to go through AllocateRaw for NewSpace now. Bug: v8:10315 Change-Id: Iee2bd7b74aa49be8b20d89fefeb2e087575d532c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2319987Reviewed-by:
-
Dominik Inführ authored
Add methods NotifyBytes(), NotifyObject() and NextBytes() to AllocationCounter. Methods are unused for now. Move AllocationObserver::Step after AllocationCounter methods as well. Use SetTopAndLimit as bottleneck instead of allocation_info_.Reset. Bug: v8:10315 Change-Id: I30049cb02e873bb08ebce606a491d99130421227 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2316103 Commit-Queue: Dominik Inführ <dinfuehr@chromium.org> Reviewed-by:
-
- 26 Jul, 2020 2 commits
-
-
Clemens Backes authored
This *partially* reverts commit b983076b (only the v8/build roll). Reason for revert: https://ci.chromium.org/p/v8/builders/ci/V8%20Mac64/35550 Original change's description: > Update V8 DEPS. > > Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/bdbc779..f99e62d > > Rolling v8/third_party/aemu-linux-x64: -zGqW99um_GNQKURMgzhK855VvGi_CfraQRvXhNduEQC..BSmiob0gPivtoM5FO4ByhQHofOIKJ7KxRVPyfzhrjTkC > > Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/b2282fe..342ad52 > > Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/cebfb4e..a58287b > > TBR=machenbach@chromium.org,tmrts@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com > > Change-Id: I696aa9bbd31a36830f2b13ea51b8a75a03cf717d > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2319386 > Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> > Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> > Cr-Commit-Position: refs/heads/master@{#69058} TBR=machenbach@chromium.org,v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com,tmrts@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I711b8a94ed2ef9c3df6bdcbcda4752881e50aff2 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:1049569 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2317868Reviewed-by:
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/bdbc779..f99e62d Rolling v8/third_party/aemu-linux-x64: -zGqW99um_GNQKURMgzhK855VvGi_CfraQRvXhNduEQC..BSmiob0gPivtoM5FO4ByhQHofOIKJ7KxRVPyfzhrjTkC Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/b2282fe..342ad52 Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/cebfb4e..a58287b TBR=machenbach@chromium.org,tmrts@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I696aa9bbd31a36830f2b13ea51b8a75a03cf717d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2319386Reviewed-by:
-
- 24 Jul, 2020 18 commits
-
-
Bill Budge authored
- Adds a SharedArrayBuffersEnabled callback and uses it to enable/disable SABs per context. The feature flag is used if no callback is registered. Bug: chromium:923807 Change-Id: I4d3472fcd79b158cb50dc98793aece6dbbb81d93 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2316901Reviewed-by:
Adam Klein <adamk@chromium.org> Commit-Queue: Bill Budge <bbudge@chromium.org> Cr-Commit-Position: refs/heads/master@{#69057}
-
Zeynep Cankara authored
This CL adds a Timeline Class to handle data interaction between panels. The timeline class enables to filter the data based on selected time range. Bug: v8:10644, v8:10735 Change-Id: I7fbbe1741abc69d2889b0547113e5da10b7f5510 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2315983 Commit-Queue: Zeynep Cankara <zcankara@google.com> Reviewed-by:
-
Bill Budge authored
- Changes runtime return value / parameter checks to check for subtype of StrongTagged. Bug: v8:10047,v8:9891 Change-Id: Ie86bacf138c67092983fc72f37b1a13bffa904a4 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2314828Reviewed-by:
Tobias Tebbi <tebbi@chromium.org> Reviewed-by:
Bill Budge <bbudge@chromium.org> Commit-Queue: Bill Budge <bbudge@chromium.org> Cr-Commit-Position: refs/heads/master@{#69055}
-
Jakob Kummerow authored
Now the following command builds mkgrokdump for x64.release and runs it to update v8heapconst.py: gm.py mkgrokdump Building the binary for other architectures still works as before. No-Try: true Change-Id: Iacfa1a50702b0452d00ba18e1306423b161ffe65 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2317352 Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by:
Mathias Bynens <mathias@chromium.org> Cr-Commit-Position: refs/heads/master@{#69054}
-
Frank Tang authored
Bug: v8:10753 Change-Id: Icbdc6d7ee0634d32b262860dd64c4bfccebdcc00 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2317064Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Frank Tang <ftang@chromium.org> Cr-Commit-Position: refs/heads/master@{#69053}
-
Ng Zhi An authored
Using uint8_t[] causes decay to pointer issue, which manifests in copying garbage values in the call to WriteLittleEndianValue. Change it to use a std::array, which doesn't have the decaying behavior. Also add a regression test from comment#6 of the linked bug. Bug: v8:10731 Change-Id: I4a1ca69fe99806642e9931625ca7aeab6663f955 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2316465Reviewed-by:
-
Ng Zhi An authored
These functions match on specific patterns of shuffle that have more optimized implementations. Moving them out of instruction-selector allows us to reuse them in Liftoff. Most of these pattern matching functions do not depend on InstructionSelector, since they work on byte arrays. (The only one is CanonicalizeShuffle, which swaps node inputs.) This is only the first pass of moving those functions out. In particular we can clean things up more by moving the tests out of instruction-selector as well. Those will come in follow-up changes. Bug: v8:10696 Change-Id: I4a4333cd8c0259875a672179e72d34dad5f7a008 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2308057 Commit-Queue: Zhi An Ng <zhin@chromium.org> Reviewed-by:
-
Z Nguyen-Huu authored
csuite.py compare command currently throws exception "_csv.Error: iterator should return strings, not bytes (did you open the file in text mode?)" This should fix it. Change-Id: I69c0ec43575a8c3627dac81dc99e47ba6adf6f61 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2316833Reviewed-by:
Michael Stanton <mvstanton@chromium.org> Commit-Queue: Z Nguyen-Huu <duongn@microsoft.com> Cr-Commit-Position: refs/heads/master@{#69050}
-
Maya Lekova authored
Bug: v8:9506 Change-Id: Ie343a4d49e769293d8a10d26bcfc3847b9d433ad Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2316109Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Auto-Submit: Maya Lekova <mslekova@chromium.org> Cr-Commit-Position: refs/heads/master@{#69049}
-
Dominik Inführ authored
We don't use the updated size anywhere. Bug: v8:10315 Change-Id: Iba1fd484fef062d109aa4e5a2c1b40d0a838f80b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2317320Reviewed-by:
-
Andreas Haas authored
As there are not enough registers on ia32 to execute the platform- independent code, the CL also adds ia32-specific code to liftoff-compiler.cc. For this we first retrieve the memory index from the stack, do a bounds check, and calculate the final address. Only afterwards we pop all other values from the stack and pass them to the platform-dependent code. R=clemensb@chromium.org Bug: v8:10108 Change-Id: I741266a9523c8b5c46acc0b29817fd143a75752e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2316305Reviewed-by:
-
Tobias Tebbi authored
This flag is already baked into the snapshot by enabling more write-barrier elimination, so changing it at runtime would be a bug. Change-Id: I3bc73f3c880285ec46b69b0c44934f64b49912ee Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2290856 Commit-Queue: Tobias Tebbi <tebbi@chromium.org> Reviewed-by:
-
Ross McIlroy authored
Adds support for register allocation within a block to the fast register allocator. Also adds some unittests covering basic register allocation. No support yet for spill slot allocation, so functions that spill don't work yet. BUG=v8:9684 Change-Id: I91d0fc0660d7b65f59235242fd5e3b1a7618d813 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2297467 Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> Reviewed-by:
-
Seth Brenith authored
Otherwise, a failure message from a common macro like UnsafeCast<A> is not particularly meaningful. With this change, the failure message would show the line number in the top-level builtin and each in-between macro that resulted in calling UnsafeCast<A>. This does not include plain CSA macros, only those generated by Torque. Bug: v8:7793 Change-Id: If0b9b7d2755f579ceacf47eef2440d97ec84a2ff Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2303598 Commit-Queue: Seth Brenith <seth.brenith@microsoft.com> Reviewed-by:
-
Maya Lekova authored
This CL includes the following minor cleanups: * Renames MakeRaisesException -> MakeWithErrorSupport * Removes remaining WrapperTraits related code * Makes the public header follow the IWYU principle Bug: chromium:1052746 Change-Id: I60e730fa15f9bde421a7b6273093c84870666a64 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2316296 Commit-Queue: Maya Lekova <mslekova@chromium.org> Reviewed-by:
-
Ross McIlroy authored
This is a reland of ab7e89f1 Original change's description: > [TurboProp] Add PendingOperand for use by fast register allocator. > > Adds a pending operand type for use with the fast register allocator. > These operands chain together multiple operands together, enabling > the allocator to keep track of multiple pending operands, then > replace them all with the allocated operand in one go. > > BUG=v8:9684 > > Change-Id: I5d8150f3f26549a747a2e89e32e31135e89dff9c > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2292302 > Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> > Reviewed-by: Tobias Tebbi <tebbi@chromium.org> > Cr-Commit-Position: refs/heads/master@{#69019} Bug: v8:9684 Change-Id: I60b902be82b766d98c0f08c9394fcac72d3b914a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2315994Reviewed-by:
-
Clemens Backes authored
Out of the four listed reasons, two are obsolete now, since stepping does not modify the code table any more. The first reason also cannot happen any more, since removing a breakpoint will also patch the stack of the isolate, and even if not, removing a breakpoint which is not set will have no effect (not even a stack rewriting). The same applies for the last listed reason. So overall, this code is not needed any more, since it has no effect. R=thibaudm@chromium.org Bug: v8:10611 Change-Id: I773ac2515b66e8bf66cb035c315db552024485c3 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2316299Reviewed-by:
-
Manos Koukoutos authored
Change-Id: I920a7b8aeda0d92eb0301962589a78e0258f33e5 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2315986Reviewed-by:
-
