- 12 Sep, 2019 32 commits
-
-
Ng Zhi An authored
Drive by fix of type of expected value in a test Bug: v8:9626 Change-Id: I1bb44082b873383ea75e7089828bc68c9d4e0df0 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1757503Reviewed-by:
Deepti Gandluri <gdeepti@chromium.org> Commit-Queue: Zhi An Ng <zhin@chromium.org> Cr-Commit-Position: refs/heads/master@{#63727}
-
Ng Zhi An authored
The point of this test is to check for OOB access traps, the read/write of the entire backing buffer is not useful to this test, and causes the test to be really slow, especially on arm simulator. This change cuts the runtime of the test from ~7.5min to ~1.5min. Bug: v8:7783 Bug: v8:9396 Change-Id: Id57648e920b7631d8c481d2a43ded1c16cd2d1d3 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1793905 Commit-Queue: Zhi An Ng <zhin@chromium.org> Reviewed-by:
Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#63726}
-
Santiago Aboy Solanes authored
TNodified: * EmitCreateShallowArrayLiteral * EmitCreateShallowObjectLiteral Also propagated the TNodification of AllocationSite. Previously it was used a lot with nullptr, and that changed to {}. Bug: v8:6949, v8:9396 Change-Id: I8ed04d2d346f5960bba23a233c3dd244ad7f122a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1795346 Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org> Reviewed-by:Ross McIlroy <rmcilroy@chromium.org> Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Reviewed-by:
Mythri Alle <mythria@chromium.org> Cr-Commit-Position: refs/heads/master@{#63725}
-
Francis McCabe authored
Bug: v8:9429 Change-Id: I2b1bc81f72e7cc7657330bd778586f608d62809b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1797659Reviewed-by:
Leszek Swirski <leszeks@chromium.org> Commit-Queue: Francis McCabe <fgm@chromium.org> Cr-Commit-Position: refs/heads/master@{#63724}
-
Milad Farazmand authored
Port 2304c194 R=neis@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com BUG= LOG=N Change-Id: Iadb240b15a081c3f0df4a5b513e54d0c7a4a2634 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1801494Reviewed-by:
Junliang Yan <jyan@ca.ibm.com> Commit-Queue: Milad Farazmand <miladfar@ca.ibm.com> Cr-Commit-Position: refs/heads/master@{#63723}
-
Thibaud Michaud authored
Sort inactive live ranges by their assigned register and by their next start. This allows {FindFreeRegistersForRange} to stop the search earlier and significantly reduces compile time for some test cases. R=sigurds@chromium.org CC=neis@chromium.org Bug: chromium:974804, v8:9529 Change-Id: I85e2ff8acf2c02ea0539c89daae5a427da775c2c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1795350 Commit-Queue: Thibaud Michaud <thibaudm@chromium.org> Reviewed-by:Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#63722}
-
Tobias Tebbi authored
This enables using TNode types without including code-assembler.h, which is useful when generating CallInterfaceDescriptors. As a drive-by, this moves TNode from v8::internal::compiler to v8::internal. It's only used outside of the compiler anyway. Change-Id: I3d938c22366a3570315041683094f77b0d1096a2 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1798425 Commit-Queue: Tobias Tebbi <tebbi@chromium.org> Reviewed-by:
Michael Stanton <mvstanton@chromium.org> Reviewed-by:
-
Maya Lekova authored
Bug: v8:7790 Change-Id: Ifb0de3ca0a300734f2dcc8c104c8186367ca520b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1800573 Commit-Queue: Maya Lekova <mslekova@chromium.org> Reviewed-by:
Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#63720}
-
Sigurd Schneider authored
Case statements have a list of statements associated with them, but are not blocks, and were hence not fixed-up correctly for code coverage. This CL also applies the fix-up to the "body" of case statements, in this way removing ranges reported as uncovered between the final break/return in a case and the next case (or end of function). Drive-by: Add optional pretty printing to code coverage test results. Change-Id: I5f4002d4e17b7253ed516d99f7c389ab2264be10 Bug: v8:9705 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1798426Reviewed-by:
Toon Verwaest <verwaest@chromium.org> Reviewed-by:
-
Igor Sheludko authored
Bug: v8:9708 Change-Id: I73cbe14437f596b805084ba61bc669556ac34289 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1798642Reviewed-by:
-
Victor Gomes authored
Bug: v8:9714 Change-Id: I70c28c3bc2aae6234e55e8a3b176da2035520a67 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1800567 Commit-Queue: Victor Gomes <victorgomes@google.com> Auto-Submit: Victor Gomes <victorgomes@google.com> Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#63717}
-
Mu Tao authored
Port 2304c194 Change-Id: I0e46424ddb647355d21b1e54cf96b1e5503627ce Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1800572 Auto-Submit: Mu Tao <pamilty@gmail.com> Reviewed-by:
-
Peter Marshall authored
Bug: chromium:913887 Change-Id: If533bb85675456b674f79486b06a44e447f40aee Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1739371Reviewed-by:
Simon Zünd <szuend@chromium.org> Commit-Queue: Peter Marshall <petermarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#63715}
-
Maya Lekova authored
Bug: v8:7790 Change-Id: Ief620bc24b59c2a4e0c823a7f7cebf5df114b9a6 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1787430 Commit-Queue: Maya Lekova <mslekova@chromium.org> Reviewed-by:
-
Santiago Aboy Solanes authored
TNodify: * EmitFastNewFunctionContext * EmitCreateRegExpLiteral * EmitCreateEmptyArrayLiteral * EmitCreateEmptyObjectLiteral Bug: v8:6949, v8:9396 Change-Id: I2a06e0a43feca42cf89d154b8fa9e84573676b4a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1793142Reviewed-by:
-
Santiago Aboy Solanes authored
Since https://chromium-review.googlesource.com/c/v8/v8/+/1791632 sped it up, there is no need to mark it as SLOW. Bug: v8:7783 Change-Id: I24d1b2f1e56dff4c820d397288ab3ad7662ae06b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1800564Reviewed-by:
-
Peter Marshall authored
This was missed during a file move and can cause build bugs. Bug: chromium:991547 Change-Id: I157e7bb656956c08293c205c0d00884aecc7adee Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1798430 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
-
Maya Lekova authored
Bug: v8:7790 Change-Id: I1abffc574b1d9964940625b1f15fc4d98f170b7b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1798682 Commit-Queue: Georg Neis <neis@chromium.org> Reviewed-by:
-
Michael Starzinger authored
This fixes the case where a table entry contains a function constructed via {WebAssembly.Function} and is then read out via a runtime function from the table. R=ahaas@chromium.org TEST=mjsunit/regress/wasm/regress-crbug-1002388 BUG=chromium:1002388 Change-Id: Ic0a9a544baaf37e68cd22eb91f2ef0bdf5fa5842 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1795352Reviewed-by:Andreas Haas <ahaas@chromium.org> Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#63709}
-
Patrick Thier authored
Currently the dispatch table could be accessed out of bounds if something is wrong with the generated bytecode. OOB access of the dispatch table can lead to jumps to arbitrary addresses in the code space. This CL prevents this issue by changing the following: BYTECODE_MASK now filters out all bits not currently used for bytecodes. All unused slots between the last actually defined bytecode and BYTECODE_MASK are now filled with BREAK Bytecodes (invalid operation). This way we can not access out of bounds of the dispatch table if something is broken/tampered with, preventing jumps to arbitrary code. Bug: v8:9699 Change-Id: Ibce591ae94b52472ba74a9fd0666e55185af7b2c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1795349 Commit-Queue: Patrick Thier <pthier@google.com> Reviewed-by:
Peter Marshall <petermarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#63708}
-
Thibaud Michaud authored
This reverts commit d0c980e1. Reason for revert: Regressions: https://chromeperf.appspot.com/group_report?rev=63641 Original change's description: > [regalloc] Enable control-flow aware allocation > > This is meant to check the performance impact of: > https://chromium-review.googlesource.com/c/v8/v8/+/1776085/3 > > R=neis@chromium.org > > Bug: v8:9088 > Change-Id: I8aad5272c1427b8bcaca02bdd0e51bf2779f7451 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1781054 > Reviewed-by: Georg Neis <neis@chromium.org> > Commit-Queue: Thibaud Michaud <thibaudm@chromium.org> > Cr-Commit-Position: refs/heads/master@{#63641} TBR=neis@chromium.org,thibaudm@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: v8:9088 Change-Id: I8228de030b8ea1066e4a26516d66517dc1dc6ca4 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1798684Reviewed-by:
Thibaud Michaud <thibaudm@chromium.org> Commit-Queue: Thibaud Michaud <thibaudm@chromium.org> Cr-Commit-Position: refs/heads/master@{#63707}
-
Jakob Gruber authored
This reverts commit 4a16305b. Reason for revert: Need to revalidate assumptions behind the CHECK. Original change's description: > [compiler] Optionally apply an offset to stack checks > > The motivation behind this change is that the frame size of an optimized > function and its unoptimized version may differ, and deoptimization > may thus trigger a stack overflow. The solution implemented in this CL > is to optionally apply an offset to the stack check s.t. the check > becomes 'sp - offset > limit'. The offset is applied to stack checks at > function-entry, and is set to the difference between the optimized and > unoptimized frame size. > > A caveat: OSR may not be fully handled by this fix since we've already > passed the function-entry stack check. A possible solution would be to > *not* skip creation of function-entry stack checks for inlinees. > > This CL: 1. annotates stack check nodes with the stack check kind, where > kind is one of {function-entry,iteration-body,unknown}. 2. potentially > allocates a temporary register to store the result of the 'sp - offset' > in instruction selection (and switches input registers to 'unique' > mode). 3. Applies the offset in code generation. > > Drive-by: Add src/compiler/globals.h for compiler-specific globals. > > Bug: v8:9534,chromium:1000887 > Change-Id: I257191c4a4978ccb60cfa5805ef421f30f0e9826 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1762521 > Commit-Queue: Jakob Gruber <jgruber@chromium.org> > Reviewed-by: Georg Neis <neis@chromium.org> > Cr-Commit-Position: refs/heads/master@{#63701} TBR=neis@chromium.org,sigurds@chromium.org,jgruber@chromium.org Change-Id: Iebf46d5256b6dee13451741781ef85a5fe9b1628 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:9534, chromium:1000887 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1800565Reviewed-by:
-
Georg Neis authored
Bug: v8:9429 Change-Id: Id775a765d9700e1d2c46b4598f5e4c8350e28f14 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1796340Reviewed-by:
-
Swapnil Gaikwad authored
Current GetIterator bytecode loads and calls @@iterator property on a given object. This change extends the bytecode functionality to check whether the value returned after calling @@iterator property is a valid JSReceiver. The bytecode throws SymbolIteratorInvalid exception if the returned value is not a valid JSReceiver. This change absorbs the functionality of additional two bytecodes - JumpIfJSReceiver and CallRuntime, that are part of the iterator protocol in the GetIterator bytecode. Bug: v8:9489 Change-Id: I9e84cfe85eeb9a1b8a97ca0595375ac26ba1bbfd Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1792905Reviewed-by:
Tobias Tebbi <tebbi@chromium.org> Commit-Queue: Swapnil Gaikwad <swapnilgaikwad@google.com> Cr-Commit-Position: refs/heads/master@{#63704}
-
Clemens Hammacher authored
This removes the {base::ReversedAdapter} class and uses {base::iterator_range} instead. The types are inferred from what {std::rbegin} and {std::rend} return. Since src/base/adapters.h would only contain this one method after this refactoring, it was merged into src/base/iterator.h. Some includes of src/base/adapters.h were unused and hence dropped. R=mlippautz@chromium.org Bug: v8:9396 Change-Id: I597172ec790193b73af196d1afcd64bbed0a597d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1798432Reviewed-by:Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Michael Starzinger <mstarzinger@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#63703}
-
Shu-yu Guo authored
https://chromium.googlesource.com/external/github.com/tc39/test262/+log/59a1a01..ef7fd2bc Bug: v8:7834, v8:9712 Change-Id: Iebc11aa3be2fa692bfae7069f45e89d795132cfa Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1799398 Auto-Submit: Shu-yu Guo <syg@chromium.org> Commit-Queue: Mathias Bynens <mathias@chromium.org> Reviewed-by:
Mathias Bynens <mathias@chromium.org> Cr-Commit-Position: refs/heads/master@{#63702}
-
Jakob Gruber authored
The motivation behind this change is that the frame size of an optimized function and its unoptimized version may differ, and deoptimization may thus trigger a stack overflow. The solution implemented in this CL is to optionally apply an offset to the stack check s.t. the check becomes 'sp - offset > limit'. The offset is applied to stack checks at function-entry, and is set to the difference between the optimized and unoptimized frame size. A caveat: OSR may not be fully handled by this fix since we've already passed the function-entry stack check. A possible solution would be to *not* skip creation of function-entry stack checks for inlinees. This CL: 1. annotates stack check nodes with the stack check kind, where kind is one of {function-entry,iteration-body,unknown}. 2. potentially allocates a temporary register to store the result of the 'sp - offset' in instruction selection (and switches input registers to 'unique' mode). 3. Applies the offset in code generation. Drive-by: Add src/compiler/globals.h for compiler-specific globals. Bug: v8:9534,chromium:1000887 Change-Id: I257191c4a4978ccb60cfa5805ef421f30f0e9826 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1762521 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by: -
Clemens Hammacher authored
This moves the code to allocate the far jump table from {SetRuntimeStubs} to {AddCodeSpace} to allocate one such table per code space. Also, the {runtime_stub_table_} and {runtime_stub_entries_} fields do not make sense any more now and are replaced by calls to {GetNearRuntimeStubEntry} and {GetRuntimeStubId}. R=mstarzinger@chromium.org Bug: v8:9477 Change-Id: Ie1f5c9d4eb282270337a684c34f097d8077fdfbb Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1795348 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by: -
Jakob Gruber authored
To make --trace-zone-stats output more meaningful. Bug: v8:9574 Change-Id: I06cb725b11e3815c23294310270774b7148c64eb Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1795355 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
Maya Lekova <mslekova@chromium.org> Cr-Commit-Position: refs/heads/master@{#63699}
-
Clemens Hammacher authored
This reverts commit 5e0e5829. Reason for revert: Still breaks android builders: https://ci.chromium.org/p/v8/builders/ci/V8%20Android%20Arm64%20-%20builder/28054 and https://ci.chromium.org/p/v8/builders/ci/V8%20Android%20Arm%20-%20builder/28026 Original change's description: > Update V8 DEPS. > > Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/2d9fa32..716ef3d > > Rolling v8/buildtools: https://chromium.googlesource.com/chromium/src/buildtools/+log/74cfb57..cd73d21 > > Rolling v8/buildtools/linux64: git_revision:152c5144ceed9592c20f0c8fd55769646077569b..git_revision:ad9e442d92dcd9ee73a557428cfc336b55cbd533 > > Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/884c81e..c979465 > > Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/e5641be..0910f78 > > Rolling v8/third_party/googletest/src: https://chromium.googlesource.com/external/github.com/google/googletest/+log/3a45039..33a0d4f > > Rolling v8/third_party/icu: https://chromium.googlesource.com/chromium/deps/icu/+log/53f6b23..faee8bc > > Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/51c4acf..e7d79d1 > > TBR=machenbach@chromium.org,tmrts@chromium.org > > Change-Id: Ib53bf18762e6e8828a6e6cf5cd57ee361bfc5ee4 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1799962 > Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> > Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> > Cr-Commit-Position: refs/heads/master@{#63697} TBR=machenbach@chromium.org,v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com,tmrts@chromium.org Change-Id: Ib1a643744ff6b664a6b9164e4005b263d676171f No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1798611Reviewed-by:
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/2d9fa32..716ef3d Rolling v8/buildtools: https://chromium.googlesource.com/chromium/src/buildtools/+log/74cfb57..cd73d21 Rolling v8/buildtools/linux64: git_revision:152c5144ceed9592c20f0c8fd55769646077569b..git_revision:ad9e442d92dcd9ee73a557428cfc336b55cbd533 Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/884c81e..c979465 Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/e5641be..0910f78 Rolling v8/third_party/googletest/src: https://chromium.googlesource.com/external/github.com/google/googletest/+log/3a45039..33a0d4f Rolling v8/third_party/icu: https://chromium.googlesource.com/chromium/deps/icu/+log/53f6b23..faee8bc Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/51c4acf..e7d79d1 TBR=machenbach@chromium.org,tmrts@chromium.org Change-Id: Ib53bf18762e6e8828a6e6cf5cd57ee361bfc5ee4 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1799962Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#63697}
-
Dmitry Gozman authored
Add should_pause to V8StackTraceId in preparation for async stepping simplification [1]. [1] https://chromium-review.googlesource.com/c/v8/v8/+/1783724 BUG=chromium:1000475 TBR=yangguo@chromium.org Change-Id: I3a90d33322c83f624a3d28c18ebdfff80b2cd904 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1799453Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#63696}
-
- 11 Sep, 2019 8 commits
-
-
Ng Zhi An authored
This reduces the runtime from ~20m to ~2m (very unscientific measure based on running the entire asm-wasm-i32 test with and without this change). I removed most of the constants that looked uninteresting, e.g. testing for 10, 20, 30, isn't that interesting. The edge cases are left untouched, min/max signed positive/negative ints and +/- 1 from both. Bug: v8:7783 Bug: v8:9396 Change-Id: Ice363fc3f786dd55ff118ffa42f9ecea07880338 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1791632Reviewed-by:
Bill Budge <bbudge@chromium.org> Commit-Queue: Zhi An Ng <zhin@chromium.org> Cr-Commit-Position: refs/heads/master@{#63695}
-
Ulan Degenbaev authored
This adds a new API function and provides a simple implementation of performance.measureMemory() in d8. The implementation currently immediately resolves the result promise with the current heap size. Bug: chromium:973627 Change-Id: Ia8e1963a49b7df628b5487a2c0d601473f0cb039 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1796502 Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
-
Ng Zhi An authored
Implementations for other architectures will follow in subsequent changes. Bug: v8:8460 Change-Id: I279388ab76b1d88d65cbe179088be5573c17fc58 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1796317 Commit-Queue: Zhi An Ng <zhin@chromium.org> Reviewed-by:
-
Joshua Litt authored
This reverts commit 591d1c9d. Reason for revert: breaks blink Original change's description: > [top-level-await] Implement top-level-await in V8 > > Implements AsyncModules in SourceTextModule. However, there is no > support in the parser or D8 for actually creating / resolving > AsyncModules. Also adds a flag '--top-level-await,' but the only > external facing change with the flag enabled is that Module::Evaluate > returns a promise. > > Bug: v8:9344 > Change-Id: Idc722efc1e2aa780d04bdb985bb7920ab969d34e > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1728037 > Reviewed-by: Ulan Degenbaev <ulan@chromium.org> > Reviewed-by: Georg Neis <neis@chromium.org> > Commit-Queue: Joshua Litt <joshualitt@chromium.org> > Cr-Commit-Position: refs/heads/master@{#63686} TBR=ulan@chromium.org,adamk@chromium.org,neis@chromium.org,joshualitt@chromium.org Change-Id: I6ceeb3a293a948af04bf200ab784ceb03386a3fd No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:9344 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1797656Reviewed-by:
Zhi An Ng <zhin@chromium.org> Commit-Queue: Zhi An Ng <zhin@chromium.org> Cr-Commit-Position: refs/heads/master@{#63692}
-
Ng Zhi An authored
This speeds up the check by ~10x. This was tested by writing a simple test that compares a for-loop and array.every(): for (var i = 0; i < kMemSize; i++) { assertEquals(0, array[i]); } assertTrue(array.every((e => e == 0))); The for-loop takes ~180s, every() takes ~19s. Numbers above are for arm.debug build (simulator). On x64.debug builds we can see a similar 10x improvement, from ~6s to ~400ms. Bug: v8:7783 Bug: v8:9396 Change-Id: I83d46c7ec4a634612032c1d79585339cadb8b641 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1793904 Commit-Queue: Zhi An Ng <zhin@chromium.org> Reviewed-by: -
Francis McCabe authored
Remove unused/unimplementation private method that has a NOLINT comment Bug: v8:9429 Change-Id: I8c5de440c8b456586b3a7c1a92af2d9a1fca4e78 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1792231 Commit-Queue: Andreas Haas <ahaas@chromium.org> Reviewed-by:
-
Igor Sheludko authored
... and the following helper methods: - IntPtrOrSmiConstant - IntPtrOrSmiXXX - Increment - Decrement Bug: v8:9708 Change-Id: I9da8bba4da2012a873fd3f23972c678ff80eec21 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1798623Reviewed-by:
-
Igor Sheludko authored
This is a first step towards removal of dynamic ParameterMode. Bug: v8:9708 Change-Id: I3502584264952dc12b44fd85b91274c9a0ddf31d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1798622Reviewed-by:
-
