• Jakob Gruber's avatar
    [compiler] Optionally apply an offset to stack checks · 4a16305b
    Jakob Gruber authored
    The motivation behind this change is that the frame size of an optimized
    function and its unoptimized version may differ, and deoptimization
    may thus trigger a stack overflow. The solution implemented in this CL
    is to optionally apply an offset to the stack check s.t. the check
    becomes 'sp - offset > limit'. The offset is applied to stack checks at
    function-entry, and is set to the difference between the optimized and
    unoptimized frame size.
    
    A caveat: OSR may not be fully handled by this fix since we've already
    passed the function-entry stack check. A possible solution would be to
    *not* skip creation of function-entry stack checks for inlinees.
    
    This CL: 1. annotates stack check nodes with the stack check kind, where
    kind is one of {function-entry,iteration-body,unknown}. 2. potentially
    allocates a temporary register to store the result of the 'sp - offset'
    in instruction selection (and switches input registers to 'unique'
    mode). 3. Applies the offset in code generation.
    
    Drive-by: Add src/compiler/globals.h for compiler-specific globals.
    
    Bug: v8:9534,chromium:1000887
    Change-Id: I257191c4a4978ccb60cfa5805ef421f30f0e9826
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1762521
    Commit-Queue: Jakob Gruber <jgruber@chromium.org>
    Reviewed-by: 's avatarGeorg Neis <neis@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#63701}
    4a16305b
Name
Last commit
Last update
benchmarks Loading commit data...
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...