- 14 Dec, 2015 21 commits
-
-
neis authored
This CL tries to correctly support the following: - stringifying a proxy, - stringifying with a proxy as replacer (callable or arraylike), - stringifying with a replacer that returns a proxy, - parsing with a callable proxy as reviver, - parsing with a reviver that inserts proxies into the object, - and whatever else you can imagine. This also fixes some bugs observable without proxies. BUG=v8:3139,v8:1543 LOG=n Review URL: https://codereview.chromium.org/1515133002 Cr-Commit-Position: refs/heads/master@{#32843}
-
ahaas authored
The test Run_Wasm_StoreMem_offset_oob contained an I64STORE instruction, which is not yet implemented on 32 bit platforms. I turned off those parts of the test on 32 bit platforms which contain I64 instructions. R=bradnelson@chromium.org Review URL: https://codereview.chromium.org/1526573002 Cr-Commit-Position: refs/heads/master@{#32842}
-
yangguo authored
Debug evaluate no longer writes back changes to the replicated context chain to the original after execution. Changes to the global object or script contexts still stick. Calling functions that bind to the original context chain also have their expected side effects. As far as I can tell, DevTools is not interested in modifying local variable values. Modifying global variable values still works as expected. However, I have not yet removed the old implementation, but merely keep it behind a flag. R=mstarzinger@chromium.org, rossberg@chromium.org Review URL: https://codereview.chromium.org/1513183003 Cr-Commit-Position: refs/heads/master@{#32841}
-
machenbach authored
BUG=chromium:568949 LOG=n NOTRY=true Review URL: https://codereview.chromium.org/1520163003 Cr-Commit-Position: refs/heads/master@{#32840}
-
bradnelson authored
R=mstarzinger@chromium.org BUG= Review URL: https://codereview.chromium.org/1526623002 Cr-Commit-Position: refs/heads/master@{#32839}
-
sigurds authored
Move replacements out of virtual object. Replacements are global to the graph and are not dependent on the virtual state (after they are discovered). R=mstarzinger@chromium.org BUG=v8:4586 LOG=n Review URL: https://codereview.chromium.org/1527533002 Cr-Commit-Position: refs/heads/master@{#32838}
-
mstarzinger authored
This uses the same pipeline entry function for all three assemblers currently supported by TurboFan. The Pipeline::GenerateCodeForCodeStub is by now generic enough to accommodate all uses. R=vogelheim@chromium.org Review URL: https://codereview.chromium.org/1521363003 Cr-Commit-Position: refs/heads/master@{#32837}
-
neis authored
This CL makes proxy-related error messages more accurate and verbose. (Exception: those used in deprecated functions in v8natives.js.) Some of the old error messages were simply wrong. On the side, fix ShouldThrow semantics of JSProxy::SetPrototype and JSProxy::DefineOwnProperty. R=cbruni@chromium.org, jkummerow@chromium.org BUG=v8:1543 LOG=n Review URL: https://codereview.chromium.org/1527583002 Cr-Commit-Position: refs/heads/master@{#32836}
-
yangguo authored
The parser reads one character beyond EOF to have an additional source position that the rewriter can use to insert the implicit return statement at the end of a script. If we break at that return statement, we need to be able to translate the source position to line and column number. R=jkummerow@chromium.org BUG=chromium:569514 LOG=N Committed: https://crrev.com/0b1076a68e1eadba260cec8afc5acec618561c28 Cr-Commit-Position: refs/heads/master@{#32825} Review URL: https://codereview.chromium.org/1521953003 Cr-Commit-Position: refs/heads/master@{#32835}
-
jkummerow authored
BUG=v8:1543 LOG=n Review URL: https://codereview.chromium.org/1514123002 Cr-Commit-Position: refs/heads/master@{#32834}
-
sigurds authored
Bugfixes and improvements in escape analysis include: * Handling of ObjectIsSmi (non-escaping) * Handling of nested phi replacements * Handling of phis with arity > 2 * Resilience against effectful nodes dangling from start * Allocations escape now, if non-const load/store is performed * Fixed a bug where non-allocated objects where tracked * Allow fixed double arrays to be tracked R=mstarzinger@chromium.org BUG=v8:4586 LOG=n Review URL: https://codereview.chromium.org/1510973006 Cr-Commit-Position: refs/heads/master@{#32833}
-
neis authored
BUG=v8:1543 LOG=N R=cbruni@chromium.org,jkummerow@chromium.org Review URL: https://codereview.chromium.org/1519073002 Cr-Commit-Position: refs/heads/master@{#32832}
-
yangguo authored
It has been broken by https://crrev.com/089edbfa97eab324bc463829ea03c167fdc6d45c R=machenbach@chromium.org NOTRY=true Review URL: https://codereview.chromium.org/1522883002 Cr-Commit-Position: refs/heads/master@{#32831}
-
yangguo authored
R=littledan@chromium.org, rossberg@chromium.org BUG=v8:4545 LOG=Y Review URL: https://codereview.chromium.org/1512253003 Cr-Commit-Position: refs/heads/master@{#32830}
-
yangguo authored
Revert of [debugger] correctly find source position of implicit return statement. (patchset #1 id:1 of https://codereview.chromium.org/1521953003/ ) Reason for revert: Layout test failures: https://chromegw.corp.google.com/i/client.v8.fyi/builders/V8-Blink%20Mac/builds/2732/steps/webkit_tests%20%28with%20patch%29/logs/stdio Original issue's description: > [debugger] correctly find source position of implicit return statement. > > The parser reads one character beyond EOF to have an additional source > position that the rewriter can use to insert the implicit return > statement at the end of a script. If we break at that return statement, > we need to be able to translate the source position to line and > column number. > > R=jkummerow@chromium.org > > Committed: https://crrev.com/0b1076a68e1eadba260cec8afc5acec618561c28 > Cr-Commit-Position: refs/heads/master@{#32825} TBR=jkummerow@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/1526583002 Cr-Commit-Position: refs/heads/master@{#32829}
-
yangguo authored
Debug-evaluate used to resolve stack variables that shadow context variables incorrectly, since the stack variable is not visible in the context chain. To fix this, we limit local variables accessible by debug- evaluate to the ones directly referenced inside the function. What is not referenced by the function itself, is considered optimized out and not accessible by debug-evaluate. To achieve this, we duplicate the entire context chain up to the native context, and write back changes after debug- evaluate. Changes to the original context chain will however be overwritten. This already happens for catch and block scopes though. Also fix a crash caused by declaring variables inside debug- evaluate. R=mstarzinger@chromium.org BUG=v8:4593 LOG=N Review URL: https://codereview.chromium.org/1500933002 Cr-Commit-Position: refs/heads/master@{#32828}
-
yangguo authored
BUG=v8:4344 LOG=N R=littledan@chromium.org Review URL: https://codereview.chromium.org/1506353009 Cr-Commit-Position: refs/heads/master@{#32827}
-
yangguo authored
R=littledan@chromium.org BUG=v8:4342 LOG=Y Review URL: https://codereview.chromium.org/1509733010 Cr-Commit-Position: refs/heads/master@{#32826}
-
yangguo authored
The parser reads one character beyond EOF to have an additional source position that the rewriter can use to insert the implicit return statement at the end of a script. If we break at that return statement, we need to be able to translate the source position to line and column number. R=jkummerow@chromium.org Review URL: https://codereview.chromium.org/1521953003 Cr-Commit-Position: refs/heads/master@{#32825}
-
Michael Achenbach authored
Cr-Commit-Position: refs/heads/master@{#32824}
-
bmeurer authored
Since the parser now desugars super constructor calls to simple primitives, we can also easily optimize those in fullcodegen w/ just a few simple lines of native code per architecture. This code in particular should be fast, so it seems worth the code in fullcodegen. BUG=v8:3330 LOG=n Review URL: https://codereview.chromium.org/1524673002 Cr-Commit-Position: refs/heads/master@{#32823}
-
- 12 Dec, 2015 7 commits
-
-
v8-autoroll authored
Rolling v8/tools/clang to ea0740546b2f5aa7dd9dd2ff5128b031717adc02 TBR=machenbach@chromium.org,vogelheim@chromium.org,hablich@chromium.org Review URL: https://codereview.chromium.org/1519353002 Cr-Commit-Position: refs/heads/master@{#32822}
-
paul.lind authored
Invalidate the instanceof cache in proxy-case of InstanceOfStub after the changes in https://codereview.chromium.org/1492243003. This didn't have a test case until https://codereview.chromium.org/1518773003 TEST=mjsunit/es6/instanceof-proxies.js BUG= Review URL: https://codereview.chromium.org/1519303002 Cr-Commit-Position: refs/heads/master@{#32821}
-
dusan.m.milosavljevic authored
TEST=cctest/test-run-machops/RunInt32DivP, mjsunit/asm/uint32div BUG= Review URL: https://codereview.chromium.org/1517243004 Cr-Commit-Position: refs/heads/master@{#32820}
-
littledan authored
A couple of the Intl tests made calls to getDefaultTimeZone(), which doesn't exist in V8; however, these were not core to the test. Rather than marking the whole test as failing, just comment out that unimportant part of the test. R=adamk Review URL: https://codereview.chromium.org/1522533003 Cr-Commit-Position: refs/heads/master@{#32819}
-
adamk authored
Array.prototype.includes shipped in Chrome 47. Review URL: https://codereview.chromium.org/1513843006 Cr-Commit-Position: refs/heads/master@{#32818}
-
adamk authored
This is behind the --harmony-function-name flag, currently disabled. With the flag enabled, we now pass the relevant tests in language/statements/*/fn-name-*. BUG=v8:3699 LOG=y Review URL: https://codereview.chromium.org/1518873004 Cr-Commit-Position: refs/heads/master@{#32817}
-
adamk authored
It shipped in Chrome 47. Review URL: https://codereview.chromium.org/1519073004 Cr-Commit-Position: refs/heads/master@{#32816}
-
- 11 Dec, 2015 12 commits
-
-
adamk authored
BUG=chromium:552100 LOG=y CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_chromium_rel_ng;tryserver.blink:linux_blink_rel Review URL: https://codereview.chromium.org/1515473004 Cr-Commit-Position: refs/heads/master@{#32815}
-
caitpotter88 authored
BUG=v8:811, v8:4599 LOG=N R=adamk@chromium.org, rossberg@chromium.org Review URL: https://codereview.chromium.org/1517973002 Cr-Commit-Position: refs/heads/master@{#32814}
-
danno authored
Review URL: https://codereview.chromium.org/1514323002 Cr-Commit-Position: refs/heads/master@{#32813}
-
ishell authored
During property reconfiguring ensure that the first map that gets new descriptors is the one that owns the whole descriptor array. This is necessary to guarantee that the whole descriptor would be marked, otherwise DescriptorArray pretenuring would cause crashes. Review URL: https://codereview.chromium.org/1520613006 Cr-Commit-Position: refs/heads/master@{#32812}
-
ahaas authored
R=titzer@chromium.org Review URL: https://codereview.chromium.org/1519823002 Cr-Commit-Position: refs/heads/master@{#32811}
-
bmeurer authored
Instead desugar the default constructor for derived classes using the same mechanism we use for normal super constructor calls. TBR=rossberg@chromium.org R=mstarzinger@chromium.org Review URL: https://codereview.chromium.org/1517243002 Cr-Commit-Position: refs/heads/master@{#32810}
-
jochen authored
BUG=v8:4134 R=vogelheim@chromium.org LOG=n Review URL: https://codereview.chromium.org/1521593002 Cr-Commit-Position: refs/heads/master@{#32809}
-
hpayer authored
BUG= Review URL: https://codereview.chromium.org/1514693010 Cr-Commit-Position: refs/heads/master@{#32808}
-
ahaas authored
R=titzer@chromium.org Review URL: https://codereview.chromium.org/1514913003 Cr-Commit-Position: refs/heads/master@{#32807}
-
verwaest authored
BUG= Review URL: https://codereview.chromium.org/1517673002 Cr-Commit-Position: refs/heads/master@{#32806}
-
jkummerow authored
Review URL: https://codereview.chromium.org/1517753003 Cr-Commit-Position: refs/heads/master@{#32805}
-
bmeurer authored
The %GetPrototype runtime function does a lot more than the GetSuperConstructor specified in ES6 12.3.5.2. So this introduces a proper %_GetSuperConstructor instead with support in TurboFan. R=jarin@chromium.org, rossberg@chromium.org Review URL: https://codereview.chromium.org/1522503002 Cr-Commit-Position: refs/heads/master@{#32804}
-