- 11 Jun, 2020 5 commits
-
-
Michael Lippautz authored
Since the registration requires calling into the library, there's no reason to get the heap through a magic getter on API level. Bug: chromium:1056170 Change-Id: I8d2b1d0fcee8c855908bd26c71a22826c493ed29 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2238568 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Anton Bikineev <bikineev@chromium.org> Reviewed-by:
Omer Katz <omerkatz@chromium.org> Cr-Commit-Position: refs/heads/master@{#68315}
-
Ng Zhi An authored
Making them private was a way to hide the functions, we can explicitly delete them, which give a better compilation error message as well. Also see: https://stackoverflow.com/q/55205874 Bug: v8:10488 Change-Id: I0d185063e6e282109627f25b732108905ed36833 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2223233Reviewed-by:
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/7ad9ac5..3405bae Rolling v8/third_party/aemu-linux-x64: pcue74MrtwdptQfnABqz12W-F6Br8-PlTN1pD5o_aQsC..Ov029PFraVEmOQQeqY3kUZj6ERgYTsBY7XgdZYAw76IC Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/03e7ff4..eb9f481 Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/dcb5c85..1dcaaa7 Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/6ddf849..9f3f85f TBR=machenbach@chromium.org,tmrts@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I60847ebd591bafce6640cc7a137ab82bfc07acd5 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2237960Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#68313}
-
Ng Zhi An authored
The constructor of ByteData isn't doing anything interesting, so can be removed. Bug: v8:10488 Change-Id: Ic114b947ff6471075c7df49c98ea7c59c5b522bc Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2233978 Commit-Queue: Zhi An Ng <zhin@chromium.org> Reviewed-by:
Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#68312}
-
Ng Zhi An authored
Match opcodes proposed in https://github.com/WebAssembly/simd/pull/127, and also move them into the list of MVP opcodes. Bug: v8:10553 Change-Id: I02d839002673ac4aad3f863579607aaa17a52338 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2240489Reviewed-by:
Deepti Gandluri <gdeepti@chromium.org> Commit-Queue: Zhi An Ng <zhin@chromium.org> Cr-Commit-Position: refs/heads/master@{#68311}
-
- 10 Jun, 2020 35 commits
-
-
Michael Lippautz authored
Unified heap support in V8 requires having another (at least internal) heap that implements a unfied garbage collection strategy. This will not re-use the already existing cppgc::Heap because there should be no way in creating such a heap externally or scheduling stand-alone garbage collections. In order to have a common token, this CL introduces AllocationHandle which can be passed to MakeGarbageCollected to allocate C++ objects. V8 (soon) and the stand-alone heap both have methods to retrieve such a handle. This works around a problem with creating diamond class hierarchies when a base class would be exposed on the public API level. Fast paths for Blink are still possible because allocation handles can be cached the same way (e.g. global, or TLS) as a heap can be cached. Tbr: yangguo@chromium.org Bug: chromium:1056170 Change-Id: I8e9472a2c24ef82d1178953e8429b1fd8a2344bc Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2238027 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#68310}
-
Ng Zhi An authored
Implements f32x4 and f64x2 ceil, floor, trunc, nearestint, arm64. Bug: v8:10553 Change-Id: I346c6e60719ea953ff1adc9d8791768838e57cb9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2213083Reviewed-by:
-
Ng Zhi An authored
Making them private was a way to hide the functions, we can explicitly delete them, which give a better compilation error message as well. Also see: https://stackoverflow.com/q/55205874 Bug: v8:10488 Change-Id: I3d3227c3a87ee4de983b0d4a52f46203729b99f2 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2233983Reviewed-by:
-
Ng Zhi An authored
Off-by-one error - valid shuffle values are [0..31] (inclusive). Bug: chromium:1092013 Change-Id: Ic9edd79acb148fd2061869a1765b9a50e38403ae Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2239754Reviewed-by:
-
Bill Budge authored
Bug: v8:9891 Change-Id: I601dd2a4e1c7d1e3818a55b92e83ce6b072c7ad0 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2238486Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Commit-Queue: Bill Budge <bbudge@chromium.org> Cr-Commit-Position: refs/heads/master@{#68306}
-
Milad Farazmand authored
Change-Id: Iae7b56504366c7867439b7d7956f1202b2a8dc5a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2239369Reviewed-by:
Junliang Yan <jyan@ca.ibm.com> Commit-Queue: Milad Farazmand <miladfar@ca.ibm.com> Cr-Commit-Position: refs/heads/master@{#68305}
-
Ng Zhi An authored
This is a reland of f7f72b7b This was reverted because of a test timing out on slow_path variant (https://crrev.com/c/2237131 for details). Turns out the test is just really slow, and was skipped on this variant in https://crrev.com/c/2237628. Relanding without changes. Original change's description: > [wasm-simd] Prototype f64x2 rounding instructions > > Implements f64x2 ceil, floor, trunc, nearestint, for interpreter and > x64. > > Bug: v8:10553 > Change-Id: I12a260a3b1d728368e5525d317d30fc9581cae04 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2213082 > Commit-Queue: Zhi An Ng <zhin@chromium.org> > Reviewed-by: Tobias Tebbi <tebbi@chromium.org> > Reviewed-by: Deepti Gandluri <gdeepti@chromium.org> > Cr-Commit-Position: refs/heads/master@{#68241} Tbr: tebbi@chromium.org Bug: v8:10553 Change-Id: I4cdc23d0556f11310d32fa066f40b057fd49d2d7 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2237350 Commit-Queue: Zhi An Ng <zhin@chromium.org> Reviewed-by:
Adam Klein <adamk@chromium.org> Cr-Commit-Position: refs/heads/master@{#68304}
-
Ng Zhi An authored
unsigned is (uint32_t) in both branches, so the cast can be removed. See https://clang.llvm.org/extra/clang-tidy/checks/google-readability-casting.html and https://google.github.io/styleguide/cppguide.html#Casting. Bug: v8:10488 Change-Id: I6d669e36509049fde449d8455c34d140f95b9b8b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2233989 Commit-Queue: Zhi An Ng <zhin@chromium.org> Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#68303}
-
Ng Zhi An authored
Recommended by clang-tidy's modernize-use-nullptr. Bug: v8:10488 Change-Id: I03a6af87f281c52edd01f3ad91f9ec6e28d398d0 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2233985Reviewed-by:
-
Ng Zhi An authored
See https://clang.llvm.org/extra/clang-tidy/checks/google-readability-casting.html and https://google.github.io/styleguide/cppguide.html#Casting. Change-Id: Ib5a3bb8873bc6d050c4d0abe36a3ae813bbd448a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2233987Reviewed-by:
-
Ng Zhi An authored
See https://clang.llvm.org/extra/clang-tidy/checks/google-readability-casting.html and https://google.github.io/styleguide/cppguide.html#Casting. Change-Id: Ic40a585e034e804da9ded1563e85f6dd44506da1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2233988Reviewed-by:
-
Santiago Aboy Solanes authored
This CL adds a linear search test in a DescriptorArray in a known flat object in the background thread, while the main thread exercises the same DescriptorArray. Also sets the foundation for the follow-ups tests in background threads. Bug: v8:7790 Change-Id: I0e99508204808baaf605161d2eeb717eabe712fb Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2207147 Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org> Reviewed-by:
Georg Neis <neis@chromium.org> Reviewed-by:
Dominik Inführ <dinfuehr@chromium.org> Reviewed-by:
Michael Stanton <mvstanton@chromium.org> Cr-Commit-Position: refs/heads/master@{#68299}
-
Ng Zhi An authored
See https://clang.llvm.org/extra/clang-tidy/checks/modernize-use-override.html for more on this warning. Bug: v8:10488 Change-Id: Ic885590553364db58259ed1d211b3ace4bfe9d23 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2233984Reviewed-by:
-
Ng Zhi An authored
vld1 was calling set_neon_register with the wrong size for register. We follow the pseudocode implementation in the manual, by splatting the value into a d register, and writing to the list of registers in a loop. Bug: chromium:1092059 Change-Id: I2ce594594cd59347c20b88926f8ecc18ef9d5514 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2238506Reviewed-by:
-
Victor Gomes authored
Change-Id: I3a624b9cb164dd4a49606f311f71ea0115afe30a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2238572 Commit-Queue: Victor Gomes <victorgomes@chromium.org> Auto-Submit: Victor Gomes <victorgomes@chromium.org> Reviewed-by:
Igor Sheludko <ishell@chromium.org> Reviewed-by:
Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#68296}
-
Tamer Tas authored
This CL fixes the UnboundLocalError in wasm-api-tests testsuite TBR=machenbach@chromium.org Bug: chromium:1091200 Change-Id: I3830153b5bd04c3bbe8bedaa8ed79f79c5139a5d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2238574Reviewed-by:
Tamer Tas <tmrts@chromium.org> Auto-Submit: Tamer Tas <tmrts@chromium.org> Commit-Queue: Tamer Tas <tmrts@chromium.org> Cr-Commit-Position: refs/heads/master@{#68295}
-
Thibaud Michaud authored
R=clemensb@chromium.org Bug: v8:10549 Change-Id: I516d35b0810ce147b568c1b8e32eb084753614e8 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2235697 Commit-Queue: Thibaud Michaud <thibaudm@chromium.org> Reviewed-by:
Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#68294}
-
Jakob Gruber authored
... for more consistent naming and less boilerplate. Getters now use the `lower_case_flag()` style. Setters now use the `set_lower_case_flag()` style. Bug: v8:8888 Change-Id: I5af35b13a013bf303c4ca8d86f926754af28bfce Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2237139 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
-
Georg Neis authored
Foozie came up with a mind-boggling example hitting a similarly mind-boggling bug: object construction (JSObject::New) wants to create the constructor's function initial map (JSFunction::GetDerivedMap -> JSFunction::EnsureHasInitialMap). To do so, it calls JSFunction::CalculateExpectedNofProperties. This harmless sounding function triggers compilation of the function. Since we're running with --always-opt, this is an optimizing compilation. Turbofan ends up depending on the function's "prototype" property, for which it wants to create the initial map so that it can install the code dependency. That is, EnsureHasInitialMap is reentered. At this point there is no further compilation attempt because the bytecode now exists. The initial map is created and installed on the function, and TF records the code dependency on that map. When CalculateExpectedNofProperties returns control to the outer EnsureHasInitialMap, yet another initial map is created and set on the function, forgetting the previous one and thus the code dependency. I'm not sure if this bug can only be observed with --always-opt. The fix is general. Bug: chromium:1092011 Change-Id: I8b972748e49b9eb8f06fa17ea9ca037de2bd7532 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2238570Reviewed-by:
Leszek Swirski <leszeks@chromium.org> Commit-Queue: Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#68292}
-
Jakob Gruber authored
Before: DebugPrint: 0x2f950804030d: [String] in ReadOnlySpace: #undefined ... After: DebugPrint: 0x2f950804030d: [Oddball] in ReadOnlySpace: #undefined ... Bug: v8:10581 Change-Id: I21aebc40426fb17cea41a31195aa5cb553c07e2a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2239570 Auto-Submit: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
-
Jakob Gruber authored
Several uc32 (= int32_t) fields were incorrectly treated as uc16 (= uint16_t): CharacterRange::from() CharacterRange::to() QuickCheckDetails::Position::mask QuickCheckDetails::Position::value Bug: v8:10568 Change-Id: I9ea7d76e4a0cbc6ee681de2136c398cdc622bca2 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2230527 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
-
Santiago Aboy Solanes authored
List: * Create a method so Lower is encapsulated. * Rename phases methods to correspond to their own Phase name. * Move the phases methods closer to Run() and ordered them. * Simplify two for loops into one. * Remove unused method. * Clean up VisitCall. Bug: v8:10424 Change-Id: Iba41f727c79a17cb0abc165ebc3141ac736dc363 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2164786Reviewed-by:
Nico Hartmann <nicohartmann@chromium.org> Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org> Cr-Commit-Position: refs/heads/master@{#68289}
-
Jakob Gruber authored
This is a reland of 8748613f, fixing an issue accessing binary op's BinaryOperationHints. Original change's description: > [compiler] Hook in binary op builtins with feedback in generic lowering > > If --turbo-nci is enabled, use binary op builtins with feedback > collection during generic lowering. > > Bug: v8:8888 > Change-Id: I307dc742488982bdc68006be5bcd1da8e68768f5 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2228614 > Commit-Queue: Jakob Gruber <jgruber@chromium.org> > Reviewed-by: Georg Neis <neis@chromium.org> > Cr-Commit-Position: refs/heads/master@{#68227} Bug: v8:8888,chromium:1092553 Change-Id: I1356659d65a5e46bc57bb6c0ebe2e9e86cb8be81 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2237128 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
-
Jakob Gruber authored
This adds a dedicated --turbo-collect-feedback-in-generic-lowering flag instead of piggy-backing on top of --turbo-nci in order to free that up for upcoming work. The new flag is temporary and can be removed once we've collected enough data and made a decision on whether to enable it unconditionally. Bug: v8:8888 Change-Id: I5c0fd35e46b4c0237c266ba6253b9c5cb4cd7995 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2237137 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
-
Anton Bikineev authored
This fixes two issues: - labs resetting didn't account bytes as beeing freed; - large object were not accounted. The CL introduces a single bottleneck for labs resetting in ObjectAllocator, which is aware of StatsCollector. This way NormalSpace is treated as a value object and all invariants are maintained by ObjectAllocator (and Sweeper). Bug: chromium:1056170 Change-Id: I027cc01fe5028a3dfa81905d7ea53dd12d1c1f20 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2237629 Commit-Queue: Anton Bikineev <bikineev@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
-
Leszek Swirski authored
Previously, for the various customisation points of String builtins (like String.prototype.replace), we skipped the customisation symbol lookup (like for Symbol.replace) for Smis. But, we do need to do the lookup for Smis in case Number.prototype or Object.prototype have the Symbol. This missing lookup was creating an observable difference between Smis and HeapNumbers. Bug: chromium:1092896 Change-Id: I8928d237fa74abeaa2aa81318b8903087c507f0d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2238030 Commit-Queue: Leszek Swirski <leszeks@chromium.org> Auto-Submit: Leszek Swirski <leszeks@chromium.org> Reviewed-by:
Shu-yu Guo <syg@chromium.org> Reviewed-by:
-
Dominik Inführ authored
Move expansion of the new space into the safepoint. Otherwise background threads race with the main thread when accessing the new space capacity. This will most likely also be required to allow the allocation of new space objects from background threads. Reland of https://crrev.com/c/2235539, the timeouts were unrelated to this CL. Bug: v8:10315 Change-Id: I134b4f27ec666cf036c346b847d164255e0fe7d7 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2237626Reviewed-by:
-
Manos Koukoutos authored
As per the latest update to the 'reference types' wasm proposal, the nullref type is removed. Following that, all its uses in V8 were also removed. This CL: - Removes now dead code referencing nullref. - Changes names of functions/exceptions containing 'nullref' to 'null'. - Changes nullref to the corresponding nullable type in some tests. Bug: v8:7748 Change-Id: I5b4606671d7b24dd48a45a3341e8a1c056fcd1d0 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2238026 Commit-Queue: Manos Koukoutos <manoskouk@chromium.org> Reviewed-by:
Andreas Haas <ahaas@chromium.org> Reviewed-by:
-
Jakob Gruber authored
Prior to this change, uc16 was typedef'd to (unsigned) uint16_t while uc32 was typedef'd to (signed) int32_t. For consistency, and to avoid unexpected behavior around signed/unsigned comparisons, this changes uc32 to the unsigned uint32_t type. As part of this change, old-style error passing (return -1, check for negative return values) was updated to use named error values. Bug: v8:10568 Change-Id: I8524e66ee20e8738749cd34c4fe82c14e885dcb3 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2235533Reviewed-by:
-
Leszek Swirski authored
Remove error reporting from parsing::Parse*, since in most cases we didn't actually want them (clear errors afterward), and there was an issue where Compiler::Compile would try to report errors already reported in ParseAny, which ended up triggering unreachable code. As a drive-by, move some one-off parse exception handling in test-parsing into a CHECKED_PARSE_PROGRAM macro which replaces all the "necessarily positive" calls to parsing::ParseProgram. Bug: chromium:1091656 Change-Id: I4d463ec363312aea36ab92f1322cf66a416b9888 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2237134Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Reviewed-by:
-
Clemens Backes authored
{PopToRegister} will most likely find that the stack slot is already holding a register (89% of cases on epic). Thus put the fast path for this in the header, so it can be inlined. Also, {GetUnusedRegister} will mostly find an unused register (95% on epic). Hence, make sure that the code for spilling a register is not inlined. Drive-by: Avoid the call to {LoadToRegister} if we already checked before if the slot is holding a register. R=thibaudm@chromium.org Bug: v8:10576 Change-Id: I13797fa5c12c5359f2578a4dbebb63aa50c00e60 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2237144 Commit-Queue: Clemens Backes <clemensb@chromium.org> Reviewed-by:Thibaud Michaud <thibaudm@chromium.org> Cr-Commit-Position: refs/heads/master@{#68280}
-
Clemens Backes authored
This changes the return type of {CompileCWasmEntry} from a {MaybeHandle} to {Handle}. All call sites used {ToHandleChecked} anyway, and if compiling a c-wasm-entry failed, something seriously went wrong. Hence fail immediately during compilation, instead of returning an empty handle and then failing later. R=jkummerow@chromium.org Change-Id: I19d85e907670c92da74c9a7ab2d9b646682a02cd Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2237133 Commit-Queue: Clemens Backes <clemensb@chromium.org> Reviewed-by: -
Camillo Bruni authored
Change-Id: I4e9a70339a59845c33432fe6a8dcaacebd2046a6 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2237631Reviewed-by:
-
Kim-Anh Tran authored
Pulling out common functionality related to dumping scope properties. Bug: chromium:1093165 Change-Id: I7de377b8812b6181bac21fc0d90c416568b0d640 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2237126 Commit-Queue: Kim-Anh Tran <kimanh@chromium.org> Reviewed-by:
Benedikt Meurer <bmeurer@chromium.org> Reviewed-by:
-
Ng Zhi An authored
This destructor is declared virtual, but the class is not subclassed anywhere. The empty body can be replaced by a =default. But since the destructor doesn't do anything interesting, we can remove it. Bug: v8:10488 Change-Id: Ie9c5f2c2742f644a99d85111dec208b01ad13fba Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2219397 Commit-Queue: Frank Tang <ftang@chromium.org> Reviewed-by:
Frank Tang <ftang@chromium.org> Cr-Commit-Position: refs/heads/master@{#68276}
-
