- 03 Aug, 2018 5 commits
-
-
Vlad Tsyrklevich authored
By using a built-in this functions works with SafeStack and doesn't require an attribute disabling ASan. BUG=chromium:864705 Change-Id: I20cc818f1a0724a017a4f7f9ae3cd8fedb6245ee Reviewed-on: https://chromium-review.googlesource.com/1141045 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#54884}
-
Michael Lippautz authored
This enables direct uses in e.g. unique_ptr<v8::EmbedderHeapTracer> Bug: chromium:843903 Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Change-Id: I11f86c916dca5c31413866d9972178fccda7df9c Reviewed-on: https://chromium-review.googlesource.com/1160538Reviewed-by:
Adam Klein <adamk@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#54883}
-
Clemens Hammacher authored
There is a proposal to make this defined behaviour, so remove the deprecation comment for now. R=jkummerow@chromium.org Bug: v8:3770 Change-Id: Iff50ec544473bed844c586ed242bd062e8d530d8 Reviewed-on: https://chromium-review.googlesource.com/1160238Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#54882}
-
Michael Achenbach authored
This skips two tests in TSAN with stress mode only. The tests are particularly slow with isolates testing, but they're also the two lowest hanging fruits in normal TSAN testing. TBR=sergiyb@chromium.org NOTRY=true Bug: v8:8009 Change-Id: Ic262fc39dee8ee0d8d1fdad10beced0e8f9c87a0 Reviewed-on: https://chromium-review.googlesource.com/1160860 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#54881}
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/cc35cac..641e460 Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/2acd8e0..eae13a4 Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/6f812e1..29b7b99 Rolling v8/third_party/fuchsia-sdk: https://chromium.googlesource.com/chromium/src/third_party/fuchsia-sdk/+log/e4f38ff..c8d8248 Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/bb4cc1a..2175972 TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org Change-Id: Ifce98c452f5b852a19a967b98620a0d07d6032b1 Reviewed-on: https://chromium-review.googlesource.com/1161611Reviewed-by:
V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#54880}
-
- 02 Aug, 2018 28 commits
-
-
Jungshik Shin authored
Etc/GMT* time zones are listed in the INAN time zone database and they should be accepted as valid. This CL will be followed by a CL for moving time zone name checks to C++ that will accept all the time zone names (e.g. EST5EDT, Hongkong, ROK, Zulu). Bug: chromium:364374 Test: intl/date-format/timezone.js Test: mjsunit/regress/regress-crbug-364374 Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng Change-Id: If0e5327d7e980504a9cb3d2b641e907ebce61180 Reviewed-on: https://chromium-review.googlesource.com/1159546 Commit-Queue: Jungshik Shin <jshin@chromium.org> Reviewed-by:
Sathya Gunasekaran <gsathya@chromium.org> Cr-Commit-Position: refs/heads/master@{#54879}
-
Vlad Tsyrklevich authored
While working on crrev.com/c/1141045 I caused 3 assertThrows() tests under the 'Deeply nested target' tests to fail. The tests for defineProperty, isExtensible, and preventExtensions began to fail under a couple build configurations because my change modified the stack check code such that it no longer inhibited tail call optimization. Under some build configurations the methods responsible for causing a stack oveflow for those 3 methods were tail call optimized and the tests no longer threw an exception. Other built-in implementations of proxy handler methods could also fail in the future due to refactors moving variables off the stack. Change the test to ensure v8 doesn't crash but don't rely on stack overflow exceptions being thrown for the 'deeply nested target' test. BUG=chromium:864705 Change-Id: Iefeaa1d5402986c1831d0f259f83025452756387 Reviewed-on: https://chromium-review.googlesource.com/1159356Reviewed-by:
Georg Neis <neis@chromium.org> Commit-Queue: Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#54878}
-
Toon Verwaest authored
Change-Id: Iaad8bc94e9222d309749491df9a500544b5b37da Reviewed-on: https://chromium-review.googlesource.com/1158687 Commit-Queue: Toon Verwaest <verwaest@chromium.org> Reviewed-by:
Marja Hölttä <marja@chromium.org> Cr-Commit-Position: refs/heads/master@{#54877}
-
Adam Klein authored
When TypedArray builtin code was still in JS, we used to completely elide IterableToList when passed an array. This meant that it was possible for the builtins to observe side-effects which mutated the array when that should have been impossible. When IterableToList was ported to CSA, it changed to clone the passed-in array instead of passing it through. This means that there's now no need to guard against side-effects due to ToNumber conversions, so we can simply return the result of Object::IterationHasObservableEffects. Though no test changes are included here, this code is covered by the regression tests added previously when this runtime function was added (and later modified). This still leaves a future TODO to port IterationHasObservableEffects to CSA. Change-Id: If913c035b124ecb59a5f647344b653429a162a2b Reviewed-on: https://chromium-review.googlesource.com/1159733Reviewed-by:
Camillo Bruni <cbruni@chromium.org> Reviewed-by:
Peter Marshall <petermarshall@chromium.org> Commit-Queue: Adam Klein <adamk@chromium.org> Cr-Commit-Position: refs/heads/master@{#54876}
-
Marja Hölttä authored
Previously, removing an element in the middle made it consume space forever. This fixes that, without changing the complexity of removal / addition. The trade-off is that RemoveOne will shuffle indices (which should be OK for the current users). BUG=v8:7308 Change-Id: I0373e30f2d9d1ffb93a78d383d41b500dbbf3429 Reviewed-on: https://chromium-review.googlesource.com/1159371 Commit-Queue: Marja Hölttä <marja@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#54875}
-
Sigurd Schneider authored
Trampolines to off-heap targets may get inlined. In this case, it is hard to tell where the trampoline is going to; this CL adds code comments which identify the target builtin by name. Bug: v8:6666 Change-Id: Ib085ad118ad64551af2522f9187b4faaad6ce315 Reviewed-on: https://chromium-review.googlesource.com/1160536 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#54874}
-
Sathya Gunasekaran authored
Bug: v8:5751 Change-Id: Iabf1310f98d675f86ee7923715cb3fc754da7c8f Reviewed-on: https://chromium-review.googlesource.com/1160650Reviewed-by:
-
Andreas Haas authored
This reverts commit b556c9ea. Reason for revert: Flakes in layout tests: https://crbug.com/870187 Original change's description: > [wasm] Implement the new API for WebAssembly.instantiateStreaming > > This is the second V8 CL to refactor WebAssembly.instantiateStreaming to > make it spec compliant again. The design doc where the whole change is > discussed is available in the tracking bug. The tracking bug also > references prototype implementations of the whole change, which includes > the changes in this CL. > > R=mstarzinger@chromium.org > > Bug: chromium:860637 > Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng > Change-Id: I776c0f24959ab5663727d3dfee0248a9b0642a42 > Reviewed-on: https://chromium-review.googlesource.com/1143187 > Commit-Queue: Andreas Haas <ahaas@chromium.org> > Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> > Cr-Commit-Position: refs/heads/master@{#54834} TBR=mstarzinger@chromium.org,ahaas@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: chromium:860637 Change-Id: Icbf2603143068a49c61de162aa7185a753703e5d Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Reviewed-on: https://chromium-review.googlesource.com/1160261Reviewed-by:
Michael Starzinger <mstarzinger@chromium.org> Reviewed-by:
Andreas Haas <ahaas@chromium.org> Commit-Queue: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#54872}
-
Michael Starzinger authored
This is a reland of c5c447d4 Original change's description: > [wasm] Enable --wasm-shared-engine by default. > > R=titzer@chromium.org > BUG=v8:7424 > > Change-Id: I3bb3be92b6c1bf855904cf0bf334ad98dce74dd4 > Reviewed-on: https://chromium-review.googlesource.com/1156310 > Reviewed-by: Ben Titzer <titzer@chromium.org> > Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> > Cr-Commit-Position: refs/heads/master@{#54855} Bug: v8:7424 Change-Id: I58153f05bd1eb764f5e58968de1daaaed79215dc Reviewed-on: https://chromium-review.googlesource.com/1160361Reviewed-by:
Sigurd Schneider <sigurds@chromium.org> Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#54871}
-
Michael Achenbach authored
TBR=sergiyb@chromium.org NOTRY=true Bug: v8:8009 Change-Id: I044fffd027f76ad8d76b6546af508e7df7486a61 Reviewed-on: https://chromium-review.googlesource.com/1160522Reviewed-by:
-
Sigurd Schneider authored
This adds two tests that generate calls to embedded builtins, one test inlines the trampoline, and the other uses an indirect load from the roots array. Bug: v8:6666, v8:7997 Change-Id: I077f4e9ed311021edb8ee74db625ebb048fdf66b Reviewed-on: https://chromium-review.googlesource.com/1160237 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
-
Michael Starzinger authored
R=clemensh@chromium.org Change-Id: I3453dbc7aa8be25730672a11b818d7fff01a987b Reviewed-on: https://chromium-review.googlesource.com/1156695Reviewed-by:
-
Georg Neis authored
R=sigurds@chromium.org Change-Id: I9d07847ef92ff7a512c1624b492b37b6991e3c56 Reviewed-on: https://chromium-review.googlesource.com/1160304Reviewed-by:
-
Michael Starzinger authored
R=yangguo@chromium.org BUG=v8:8009 Change-Id: I20f911efc1ec1ee229e827d88d78cecc168c82f3 Reviewed-on: https://chromium-review.googlesource.com/1160231Reviewed-by:
Yang Guo <yangguo@chromium.org> Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#54866}
-
Michael Achenbach authored
TBR=sergiyb@chromium.org NOTRY=true NOTREECHECKS=true Bug: v8:8009 Change-Id: Ie779b21a488d8a542faa78ffaa625c90058adc35 Reviewed-on: https://chromium-review.googlesource.com/1160489Reviewed-by:
Sergiy Byelozyorov <sergiyb@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#54865}
-
Michael Achenbach authored
The TSAN builder will be split into builder and tester. This adds the config for the builder, but keeps the configs for the testers to be removed after the infra side switch. This also cleans up redundant concurrent-marking configs, since concurrent marking is on by default. This also removes a config of a builder that no longer exists. TBR=sergiyb@chromium.org NOTRY=true Bug: v8:8009 Change-Id: Ic7b146505b5059a2508da94d01d156d5e5e2b997 Reviewed-on: https://chromium-review.googlesource.com/1160308 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by:
-
Florian Sattler authored
This is a reland of baa055c7 Original change's description: > Applied noexcept to all mctors and massigns > > Refactoring the code base to use noexcept for their move constructors and move > assignment operators. > > Bug: v8:7999 > > Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel > Change-Id: I13d24eddba3bfa601cff26fd680a040cf4e71426 > Reviewed-on: https://chromium-review.googlesource.com/1152817 > Reviewed-by: Yang Guo <yangguo@chromium.org> > Reviewed-by: Marja Hölttä <marja@chromium.org> > Reviewed-by: Jakob Gruber <jgruber@chromium.org> > Reviewed-by: Andreas Haas <ahaas@chromium.org> > Commit-Queue: Florian Sattler <sattlerf@google.com> > Cr-Commit-Position: refs/heads/master@{#54841} Bug: v8:7999 Change-Id: I72394e326a4f8da462ee6285511d721440ceb21d Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel Reviewed-on: https://chromium-review.googlesource.com/1158646Reviewed-by:
-
Ben L. Titzer authored
The wasm/ directory is inconsistent in many places, often within the same file. For all code that exists in a v8::internal::wasm namespace, this CL removes any wasm:: qualifiers, which is especially helpful since most types are already Wasm-named, such as WasmCode, WasmModule, etc. Namespace qualifiers are redundant inside the wasm:: namespace and thus go against the main point of using namespaces. Removing the qualifiers for non Wasm-named classes also makes the code somewhat more future-proof, should we move some things that are not really WASM-specific (such as ErrorThrower and Decoder) into a higher namespace. R=clemensh@chromium.org,mstarzinger@chromium.org Change-Id: Ibff3e1e93c64c12dcb53c46c03d1bfb2fb0b7586 Reviewed-on: https://chromium-review.googlesource.com/1160232 Commit-Queue: Ben Titzer <titzer@chromium.org> Reviewed-by:
-
Clemens Hammacher authored
R=titzer@chromium.org Bug: v8:7754, v8:7965 Change-Id: I810f362f57a690f890d962a88f80df14c7de65db Reviewed-on: https://chromium-review.googlesource.com/1160226Reviewed-by:
Ben Titzer <titzer@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#54861}
-
Clemens Hammacher authored
R=titzer@chromium.org Bug: v8:7754, v8:7965 Change-Id: Ie7eb8243186238e71e8c51d133d2c334f946727f Reviewed-on: https://chromium-review.googlesource.com/1160223Reviewed-by:
-
Michael Starzinger authored
R=clemensh@chromium.org TEST=mjsunit/wasm/data-segments BUG=v8:7424,v8:8009 Change-Id: I6578b77f69d0d56d7f824486acd4c150e4d20ad0 Reviewed-on: https://chromium-review.googlesource.com/1160224Reviewed-by:
-
Clemens Hammacher authored
The generate-header-include-checks.py script generates the cc files to check that headers can be included in isolation. It currently always writes to all the cc files. This means that after "gclient runhooks", all these files have to be recompiled. This CL fixes this by not touching the file if it already contains the expected content. This avoids hundreds of recompilations after running the hook. R=machenbach@chromium.org Bug: v8:7965 Change-Id: I93a0abb936863f6c21ed22ba1b7d900b96725fa3 Reviewed-on: https://chromium-review.googlesource.com/1156514 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
-
Creddy authored
Bug: chromium:868473 Change-Id: I6a2f9be15cdc05cfa793650436c7ec3dd583bef4 Reviewed-on: https://chromium-review.googlesource.com/1158833Reviewed-by:
-
Sigurd Schneider authored
This reverts commit c5c447d4. Reason for revert: Race condition https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8%20Linux/26284 Original change's description: > [wasm] Enable --wasm-shared-engine by default. > > R=titzer@chromium.org > BUG=v8:7424 > > Change-Id: I3bb3be92b6c1bf855904cf0bf334ad98dce74dd4 > Reviewed-on: https://chromium-review.googlesource.com/1156310 > Reviewed-by: Ben Titzer <titzer@chromium.org> > Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> > Cr-Commit-Position: refs/heads/master@{#54855} TBR=mstarzinger@chromium.org,titzer@chromium.org Change-Id: I46b00693b087af0076c634480c15ab109dcbbcce No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:7424 Reviewed-on: https://chromium-review.googlesource.com/1160241Reviewed-by:
-
Michael Starzinger authored
R=titzer@chromium.org BUG=v8:7424 Change-Id: I3bb3be92b6c1bf855904cf0bf334ad98dce74dd4 Reviewed-on: https://chromium-review.googlesource.com/1156310Reviewed-by:
-
Rodrigo Bruno authored
This CL introduces a new MemoryController that will be used to control the size of external memory (array buffers and external string for now). Bug: chromium:845409 Change-Id: I119506ce0243ac33cec2b783b888b53ee11225a9 Reviewed-on: https://chromium-review.googlesource.com/1156393 Commit-Queue: Rodrigo Bruno <rfbpb@google.com> Reviewed-by:
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/e9eade2..cc35cac Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/5c2d9e7..2acd8e0 Rolling v8/third_party/proguard: https://chromium.googlesource.com/chromium/src/third_party/proguard/+log/63f6c0b..d901b76 Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/af36d66..bb4cc1a TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org Change-Id: Ib6fa819faf6a542c60bd4ef51d362abe133ef9ad Reviewed-on: https://chromium-review.googlesource.com/1159847Reviewed-by:
-
Deepti Gandluri authored
Bug: v8:6532 Change-Id: Ib486a1c0d80a14b778dde5ef6655e11d326b4c73 Reviewed-on: https://chromium-review.googlesource.com/1157068Reviewed-by:
Bill Budge <bbudge@chromium.org> Reviewed-by:
Ben Smith <binji@chromium.org> Reviewed-by:
-
- 01 Aug, 2018 7 commits
-
-
Sergiy Byelozyorov authored
All status messages will be printed into STDERR and only the results will continue to be written to STDOUT as documentation suggests. Additionally the following changes are made: - on Buildbot each log entry will have a timestamp to make it easy to measure time between status messages printed by test runner, users will continue to see just the message itself - when devil (or any other module) logs error, they will not be interleaved with our own output since logging module is thread-safe - critical logs replaced with warning since they do not immediately stop the test runner - logging.exception is used for all exceptions to get formatted stack trace TBR=machenbach@chromium.org No-Try: true Bug: chromium:838864 Change-Id: I197fcc3bc5890130ce8b35c3e21237f9614fc468 Reviewed-on: https://chromium-review.googlesource.com/1159361 Commit-Queue: Sergiy Byelozyorov <sergiyb@chromium.org> Reviewed-by:
-
Wez authored
This is a temporary rename of zx_task_suspend(), to allow the API signature to be updated. It will be followed by a rename back to the old name, with the new signature. Change-Id: I896d714e556dad2e0740891ff99cb0b51c6c1943 Reviewed-on: https://chromium-review.googlesource.com/1158998Reviewed-by:
-
Clemens Hammacher authored
Very minor cleanup to reduce code complexity. R=mstarzinger@chromium.org Bug: chromium:869420 Change-Id: I53d1776792b3918d489fe002e2cb17b7a3e0ff73 Reviewed-on: https://chromium-review.googlesource.com/1158686Reviewed-by:
-
Toon Verwaest authored
This templatizes CharacterStream by char type, and makes them subclass ScannerStream. Methods that are widely used by tests are marked virtual on ScannerStream and final on CharacterStream<T> so the specialized scanner will know what to call. ParseInfo passes around ScannerStream, but the scanner requires the explicit CharacterStream<T>. Since AdvanceUntil is templatized by FunctionType, I couldn't mark that virtual; so instead I adjusted those tests to operate directly on ucs2 (not utf8 since we'll drop that in the future). In the end no functionality was changed. Some calls became virtual in tests. This is mainly just preparation. Change-Id: I0b4def65d3eb8fa5c806027c7e9123a590ebbdb5 Reviewed-on: https://chromium-review.googlesource.com/1156690 Commit-Queue: Toon Verwaest <verwaest@chromium.org> Reviewed-by:
-
Clemens Hammacher authored
The background compilation logic moved to the {CompilationState}, so the {NumberOfBackgroundTasks} is now always 1. R=mstarzinger@chromium.org Bug: chromium:869420 Change-Id: I5860f46db953778890c842af4507e8d989e34784 Reviewed-on: https://chromium-review.googlesource.com/1158581 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by: -
Clemens Hammacher authored
We have complicated logic in place to ensure that an {AsyncCompileJob} is not removed as long as a foreground task is still pending. This CL changes that to just cancel the pending foreground task and remove the {AsyncCompileJob} immediately. R=mstarzinger@chromium.org Bug: chromium:869420 Change-Id: Ia064dae4a0e31416675e5d77c46879254fc817c4 Reviewed-on: https://chromium-review.googlesource.com/1158578Reviewed-by: -
Sigurd Schneider authored
uses of the function where that was assumed to not be the case. RelocInfo: :NONE satisfies IsShareableRelocMode; this cleans up some Change-Id: Iafd7262496edc389131966f07f4e5b4fa8b5c1e6 Reviewed-on: https://chromium-review.googlesource.com/1158574Reviewed-by:
-
