- 15 Mar, 2021 21 commits
-
-
Almothana Athamneh authored
Bug: v8:11454 Change-Id: I44ed59d5ca7d998ff1affd8acb30862b532a8b3b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2759519 Auto-Submit: Almothana Athamneh <almuthanna@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#73411}
-
Clemens Backes authored
asm validation and translation to wasm is disabled in no-wasm builds, hence remove respective detection and marking of scopes and functions. R=verwaest@chromium.org Bug: v8:11238 Change-Id: I2ac8a84024fa37a0c5896a0f85ea4beea4d93137 Cq-Include-Trybots: luci.v8.try:v8_linux64_no_wasm_compile_rel Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2757689Reviewed-by:
Toon Verwaest <verwaest@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#73410}
-
Thibaud Michaud authored
"FinishCall" is also unnecessary after a tail call, move it inside the condition too. R=clemensb@chromium.org Bug: chromium:1187484 Change-Id: I258dd736565546277deb33e52a4619d6aaa2fe25 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2759512Reviewed-by:
Clemens Backes <clemensb@chromium.org> Commit-Queue: Thibaud Michaud <thibaudm@chromium.org> Cr-Commit-Position: refs/heads/master@{#73409}
-
Milad Fa authored
Change-Id: I5608c6123433b1378d92c534e8f38dba68ac3d15 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2760778Reviewed-by:
Junliang Yan <junyan@redhat.com> Commit-Queue: Milad Fa <mfarazma@redhat.com> Cr-Commit-Position: refs/heads/master@{#73408}
-
Clemens Backes authored
Add a module-wide cache to cache both TurboFan code and Liftoff debug code, such that we can quickly tier up or down a module without repeated recompilation. R=thibaudm@chromium.org Bug: v8:11556 Change-Id: Iec56e67b53e5a40c11ca24dae0728cb569a7c68f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2757688 Commit-Queue: Clemens Backes <clemensb@chromium.org> Reviewed-by:
Thibaud Michaud <thibaudm@chromium.org> Cr-Commit-Position: refs/heads/master@{#73407}
-
Thibaud Michaud authored
R=clemensb@chromium.org Bug: v8:11453 Change-Id: Ie50e5c85eaed04b4e90dd51261838f7f1a5f65a9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2743884 Commit-Queue: Thibaud Michaud <thibaudm@chromium.org> Reviewed-by:
-
Clemens Backes authored
This is just adding an early exit, to avoid a big if-block spanning the whole method. Instead of doing this in the follow-up CL, which adds even more code to that block, I pulled it out for easier review. R=thibaudm@chromium.org Bug: v8:11556 Change-Id: Ie4f2e0635fe9875c90d32be8224f1b0709c82e00 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2757687Reviewed-by:
-
Junliang Yan authored
Port 3e689a7d Original Message: Only support empty exceptions for now. Unpacking i32s, and eventually arbitrary types, will be done in separate CLs. Bug: v8:11453 Change-Id: I4f019330bfb1753b424ef3a8c541054f5fa27e84 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2760777Reviewed-by:
Milad Fa <mfarazma@redhat.com> Commit-Queue: Junliang Yan <junyan@redhat.com> Cr-Commit-Position: refs/heads/master@{#73404}
-
Frank Emrich authored
This CL: a) Adds an unsigned 64 bit type to Torque, called uint64. b) Makes more operations on 64 bit integers from the raw machine assembler available in CSA and Torque. Change-Id: I147501d65882892e4628ec22088c0940df79a974 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2742204 Commit-Queue: Frank Emrich <emrich@google.com> Reviewed-by:
Nico Hartmann <nicohartmann@chromium.org> Reviewed-by:
Igor Sheludko <ishell@chromium.org> Cr-Commit-Position: refs/heads/master@{#73403}
-
Thibaud Michaud authored
Only support empty exceptions for now. Unpacking i32s, and eventually arbitrary types, will be done in separate CLs. R=clemensb@chromium.org Bug: v8:11453 Change-Id: Ic3233e0bbdaad8b710cd836be9aef647d3131c9d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2739590 Commit-Queue: Thibaud Michaud <thibaudm@chromium.org> Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#73402}
-
Marja Hölttä authored
(Reland: removed the d8 changes, will land them separately.) The minimal implementation which does something useful. Initial machinery for serializing / deserializing objects and functions (only the very simple cases are supported). For more info, see https://docs.google.com/document/d/1Qierkg3b3klIwCQt-oZCHqhcc1_9DXNIErBwvdpD4wU/edit?usp=sharing Previous version: Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2716288 TBR=leszeks@chromium.org,syg@chromium.org,hpayer@chromium.org Bug: v8:11525 Change-Id: Ia61ed7de36f371d931eff68156ab467723915704 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2759510Reviewed-by:
Marja Hölttä <marja@chromium.org> Reviewed-by:
Hannes Payer <hpayer@chromium.org> Reviewed-by:
Leszek Swirski <leszeks@chromium.org> Commit-Queue: Marja Hölttä <marja@chromium.org> Cr-Commit-Position: refs/heads/master@{#73401}
-
Victor Costan authored
One of the x86 ISA extensions is confusingly named SSSE3 (*Supplemental* Streaming SIMD Extensions 3). SSSE3 supersedes SSE3, and is superseded by SSE4. This CL adds testing coverage for x86 CPUs that support SSE3 instructions, but do not support SSSE3 instructions. Chrome supports these CPUs, and they are used by a non-trivial amount of Chrome's users on Windows. Change-Id: I7b1f1e0167708ae285a71530a01b9b474cb08352 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2757893 Auto-Submit: Victor Costan <pwnall@chromium.org> Commit-Queue: Liviu Rau <liviurau@chromium.org> Reviewed-by:
Liviu Rau <liviurau@chromium.org> Cr-Commit-Position: refs/heads/master@{#73400}
-
Thibaud Michaud authored
R=clemensb@chromium.org Bug: v8:11453 Change-Id: Iecc78f14cd514cd650e00f1a4731fddba53e47a5 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2752878 Commit-Queue: Thibaud Michaud <thibaudm@chromium.org> Reviewed-by:
-
Patrick Thier authored
If a Proxy is passed as argument to d8.test.verifySourcePositions, unwrap the target function. Bug: chromium:1186491 Change-Id: Iaacbf800f023121a07035a88745919df68f79217 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2748081Reviewed-by:
Camillo Bruni <cbruni@chromium.org> Commit-Queue: Patrick Thier <pthier@chromium.org> Cr-Commit-Position: refs/heads/master@{#73398}
-
Seth Brenith authored
Torque generally supports marking things as unused by adding a single underscore to the front of identifiers. For locals, this feature works fine. For macros, it's only half-implemented: attempting to look up a macro that starts with _ fails (as it should), but the compiler also complains if the macro is unused. This change avoids emitting the latter error. Bug: v8:7793 Change-Id: Ib021c053004a180dd31993d3ad06cde463bafd5d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2757208 Commit-Queue: Nico Hartmann <nicohartmann@chromium.org> Reviewed-by:
-
Clemens Backes authored
This reverts commit 74960db4. Reason for revert: Segfaults on CFI: https://ci.chromium.org/ui/p/v8/builders/ci/V8%20Linux%20-%20arm64%20-%20sim%20-%20CFI/4999/overview Original change's description: > [wasm] Emit safepoint info for callee-saved registers in the deopt-index > > Encode safepoint info of callee-saved registers in the deopt index of > the normal safepoint. > > Change-Id: I93bd0d2330b7f592b767860743c04a65ddaa92f5 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2739977 > Commit-Queue: Andreas Haas <ahaas@chromium.org> > Reviewed-by: Clemens Backes <clemensb@chromium.org> > Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> > Cr-Commit-Position: refs/heads/master@{#73395} Change-Id: Ic4803b06a64b615f2258c594b601b4e8fd4b7bff No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2759513 Auto-Submit: Clemens Backes <clemensb@chromium.org> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#73396}
-
Andreas Haas authored
Encode safepoint info of callee-saved registers in the deopt index of the normal safepoint. Change-Id: I93bd0d2330b7f592b767860743c04a65ddaa92f5 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2739977 Commit-Queue: Andreas Haas <ahaas@chromium.org> Reviewed-by:
-
Michael Lippautz authored
Cleanups around tracing bottlenecks and tests. Bug: chromium:1056170 Change-Id: I1f9ddd6d8727971db3bed5294f4ff3fdd20a9e34 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2757696 Auto-Submit: Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Omer Katz <omerkatz@chromium.org> Reviewed-by:
Omer Katz <omerkatz@chromium.org> Cr-Commit-Position: refs/heads/master@{#73394}
-
Hong Zheng authored
Add a V8 API to update load start time for RAIL PERFORMANCE_LOAD mode Bug: v8:10947 Change-Id: If86a815f8974b47a6f4ba82c3661c21b73f39553 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2423403 Auto-Submit: Hong Zheng <hong.zheng@intel.com> Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#73393}
-
Kim-Anh Tran authored
This changes the behavior of SetBreakpointForScript to find more accurate break positions. Previously, setting a breakpoint would only consider the shared function info that contained the requested position for setting a breakpoint. More intuitively, a breakpoint should not necessarily be set in a function that contains the position, but in the closest breakable location that comes after the position we requested. To achieve this we: 1. find the shared function info of the inner most function that contains the requested_position. This function's end position is used to find other shared function infos in step 2. 2. search for all shared function infos that intersect with the range [requested_position, inner_most_function.break_position[. 3. From the shared function infos extracted in 2, find the one that has the closest breakable location to requested_position. Also-By: bmeurer@chromium.org Fixed: chromium:1137141 Change-Id: I4f4c6c3aac1ebea50cbcad9543b539ab1ded2b05 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2742198 Commit-Queue: Kim-Anh Tran <kimanh@chromium.org> Reviewed-by:
Benedikt Meurer <bmeurer@chromium.org> Cr-Commit-Position: refs/heads/master@{#73392}
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/421f3e0..5f2e66e Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/58bac68..6e87bdd Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/bb890d6..159efca Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/e645571..91db20b TBR=v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I496ee15bb259471bc77e856d91dbb29ab70ae657 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2758919Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#73391}
-
- 14 Mar, 2021 1 commit
-
-
v8-ci-autoroll-builder authored
Rolling v8/buildtools/linux64: git_revision:e0358b49272c8b354eda0a595e1d7887343fab27..git_revision:64b3b9401c1c3ed5f3c43c1cac00b91f83597ab8 TBR=v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I9f79e66b832ab46ffbc3b3065613cd8a8e4ce563 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2758912Reviewed-by:
-
- 13 Mar, 2021 3 commits
-
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/7633fcf..421f3e0 Rolling v8/buildtools: https://chromium.googlesource.com/chromium/src/buildtools/+log/7242196..69cc9b8 Rolling v8/buildtools/linux64: git_revision:dfcbc6fed0a8352696f92d67ccad54048ad182b3..git_revision:e0358b49272c8b354eda0a595e1d7887343fab27 Rolling v8/third_party/aemu-linux-x64: xkJqHNeFPOJ9cNmeaij9qrxQTAP8oRjXHcuTdg2nny8C..fU_J9KtzLrfiXhqpf_1eV01gy30M641raluN5uaKPNAC Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/7a3a736..58bac68 Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/e8b56fb..bb890d6 TBR=v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I529b8768c8f7efd2d5960a8d10fa16fe914848df Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2758100Reviewed-by:
-
Junliang Yan authored
Change-Id: I61af83e5f6399d82cd6cabdb2a4399f98f71cdb1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2756712Reviewed-by:
-
Ng Zhi An authored
Bug: v8:11384 Change-Id: I5da5cc11c69844833ab703bd2fb439e4f51db501 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2750727Reviewed-by:
Bill Budge <bbudge@chromium.org> Commit-Queue: Zhi An Ng <zhin@chromium.org> Cr-Commit-Position: refs/heads/master@{#73387}
-
- 12 Mar, 2021 15 commits
-
-
Ng Zhi An authored
If AVX is supported, don't need dst == src, this can save a move. Move the Andnps macro around, and update callsites in Liftoff. Bug: v8:11190 Change-Id: I7307b70943fdd91550d608cb91e9890f23d1b3ad Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2750726Reviewed-by:
-
Ng Zhi An authored
We no longer need unique register for src, since I64x2Abs macro-assembler handles the case when dst == src (by using the scratch). This is equivalent to calling the VisitRRSimd helper. Bug: v8:11190 Change-Id: Ibabb6da970e983ca2c9326057a6dc43cc7b7c435 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2750725Reviewed-by:
-
Milad Fa authored
Change-Id: I614d1ccf83e1275d06211917906e7094bfad5bc4 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2757691Reviewed-by:
-
Bill Budge authored
This reverts commit fb03b88e. Reason for revert: Very speculative revert to make Win64 ASAN bot green: https://ci.chromium.org/p/v8/builders/ci/V8%20Win64%20ASAN/17685 Original change's description: > [web snapshots] Web Snapshots Version 0.01 > > The minimal implementation which does something useful. Initial > machinery for serializing / deserializing objects and functions (only > the very simple cases are supported). > > For more info, see https://docs.google.com/document/d/1Qierkg3b3klIwCQt-oZCHqhcc1_9DXNIErBwvdpD4wU/edit?usp=sharing > > Bug: v8:11525 > > Change-Id: I73c4de11285c7912bf9870868d203d4b3d2b4e5f > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2716288 > Reviewed-by: Hannes Payer <hpayer@chromium.org> > Reviewed-by: Shu-yu Guo <syg@chromium.org> > Reviewed-by: Leszek Swirski <leszeks@chromium.org> > Commit-Queue: Marja Hölttä <marja@chromium.org> > Cr-Commit-Position: refs/heads/master@{#73371} Bug: v8:11525 Change-Id: I8e1ea8666f2d4d6eac3575a364e0532167dd3316 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2757891 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Reviewed-by:
-
Milad Fa authored
Also fixed the disassembler to include 10th bit of instruction. Change-Id: Idc6659a8a9d6a291b68537bae533a32970a4441d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2757567 Commit-Queue: Milad Fa <mfarazma@redhat.com> Reviewed-by:
-
Clemens Backes authored
Just saw this on an unrelated change. This is a left-over from https://crrev.com/c/2007490. R=jkummerow@chromium.org Bug: v8:11384 Change-Id: Iaa6134458e05b58a15ff465b01a86d18bfabd746 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2756528Reviewed-by:
-
Clemens Backes authored
A little cleanup after https://crrev.com/c/2752867. R=jkummerow@chromium.org Bug: v8:11238 Change-Id: I6e8b29c852ce6f8267f4b2fb4afe404659503a64 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2756527Reviewed-by:
-
Milad Fa authored
Port 8d0f5a04 Original Commit Message: Due to a recent change Liftoff used different register configurations in the pointer-compression and no-pointer-compression setups. This caused a mismatch between the registers used by Liftoff and the registers spilled by the WasmDebugBreak builtin. With this CL the same register configuration is used both with and without pointer compression. Even without x28 there are 24 registers that can be used. Moreover, 24 registers can be spilled without padding, which would be needed with 25 registers to preserve stack alignment. Drive-by change: Use Reglist in frame-constants on all platforms. R=ahaas@chromium.org, joransiu@ca.ibm.com, junyan@redhat.com, midawson@redhat.com BUG= LOG=N Change-Id: Ibad93faeaba88f929db16d239858da6e45ca673b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2756550 Commit-Queue: Milad Fa <mfarazma@redhat.com> Reviewed-by:
Andreas Haas <ahaas@chromium.org> Reviewed-by:
-
Michael Achenbach authored
This reverts commit 3094d598. Reason for revert: Breaks on Mac arm64: https://ci.chromium.org/p/v8/builders/ci/V8%20Mac%20-%20arm64%20-%20release/3109 Original change's description: > [wx] Keep the execute bit while making code writable > > Otherwise SMC perturbs the icache too much it seems. > > Change-Id: Iceea779a7e3deee90efe29df568732d6ac5bcffa > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2753768 > Commit-Queue: Toon Verwaest <verwaest@chromium.org> > Auto-Submit: Toon Verwaest <verwaest@chromium.org> > Reviewed-by: Hannes Payer <hpayer@chromium.org> > Cr-Commit-Position: refs/heads/master@{#73355} Change-Id: I4e85f6308ca22e366cdad4b621d233c3b1e3ed90 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2756539 Auto-Submit: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#73378}
-
Michael Lippautz authored
Actually apply the folding on allocation. Bug: chromium:1056170 Change-Id: Ief25fac49c5caff40579fd44249bba0ae82f9689 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2756536 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Omer Katz <omerkatz@chromium.org> Auto-Submit: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
-
Milad Fa authored
This reverts commit 4fb19d56. Reason for revert: intermittent test failure on s390 native: d8 --test test/wasm-spec-tests/tests/proposals/reference-types/select.js --random-seed=1408892184 --nohard-abort --testing-d8-test-runner --stress-background-compile --finalize-streaming-on-background --stress-wasm-code-gc --experimental-wasm-reftypes --wasm-staging Original change's description: > s390x: [liftoff] implement Indirect/CallIndirect > > Change-Id: I953d1f9e1789cb6f754b1206edcac752e4f22801 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2749575 > Reviewed-by: Milad Fa <mfarazma@redhat.com> > Commit-Queue: Junliang Yan <junyan@redhat.com> > Cr-Commit-Position: refs/heads/master@{#73327} Change-Id: I64fbf9a8ff9294500cac70142831f02806653e51 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2756548Reviewed-by:
-
Ulan Degenbaev authored
Bug: v8:9380 Change-Id: I47d23dda133c3838c7f0e8e5ccfdbe3b9520684f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2720306Reviewed-by:
-
Junliang Yan authored
Change-Id: I3f96414aa58fb7e5810036c669539b8593509ccf Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2756547Reviewed-by:
-
Clemens Backes authored
We still get e.g. ClusterFuzz reports with enums printed as non-printable single-character strings (see linked bug). This CL fixes this, and also includes the integral enum value for enum that come with their own output operator. This makes error messages strictly better, at the cost of some more code per enum which is being used in a CHECK/DCHECK. Note that binary size of release builds is not affected, since we do not print the values there. R=nicohartmann@chromium.org Bug: v8:11384, chromium:1187484 Change-Id: I066b32f68440096babed9b629c7ffe3f2285cba8 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2756226Reviewed-by:
-
Santiago Aboy Solanes authored
Don't call UpdateDescriptors twice on {map} in the cases where {map} is not the initial map. Change-Id: I2005b8dda1b15c87e0bf1d933a16a2aedfa7ac6b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2743888Reviewed-by:
-
