- 15 Jul, 2019 25 commits
-
-
Thibaud Michaud authored
The context was not set during streaming compilation. The initial upload is the original CL and patch set 1 is the fix. Original CL: > [wasm] Compile JS to WASM wrappers asynchronously > > R=mstarzinger@chromium.org, ahaas@chromium.org > > Bug: v8:9231 > Change-Id: I9e18073bbe25bf8c9c5f9ace102316e6209d0459 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1669699 > Commit-Queue: Thibaud Michaud <thibaudm@chromium.org> > Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> > Reviewed-by: Andreas Haas <ahaas@chromium.org> > Cr-Commit-Position: refs/heads/master@{#62672} R=mstarzinger@chromium.org, ahaas@chromium.org Cq-Include-Trybots: luci.v8.try:v8_linux_blink_rel Bug: v8:9231 Change-Id: I61fc11a6de54cc6e93f3600487a89fa5d2350f0e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1701850Reviewed-by:
Andreas Haas <ahaas@chromium.org> Reviewed-by:
Michael Starzinger <mstarzinger@chromium.org> Commit-Queue: Thibaud Michaud <thibaudm@chromium.org> Auto-Submit: Thibaud Michaud <thibaudm@chromium.org> Cr-Commit-Position: refs/heads/master@{#62721}
-
Sathya Gunasekaran authored
If the lookup of the resolve property on the constructor throws, we need to call IteratroClose before rejecting the promise. Bug: v8:9431 Change-Id: Idb33ffe09d339723ef0cd2469335598ab27b49bf Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1701857Reviewed-by:
Mathias Bynens <mathias@chromium.org> Reviewed-by:
Maya Lekova <mslekova@chromium.org> Commit-Queue: Sathya Gunasekaran <gsathya@chromium.org> Cr-Commit-Position: refs/heads/master@{#62720}
-
Seth Brenith authored
This change is mostly mechanical, but it's worth mentioning a few slightly interesting cases: - A couple of field definitions didn't match the signedness of their corresponding accessors. - The generated accessors for Smi data use Smi values directly, but usually we want C++ accessors to use ints instead. I added a macro that hides the generated Smi accessors and exposes int accessors, but we might consider generating int accessors directly. - The data held in some fields is described in comments next to the accessor definition for those fields. With automatically generated accessors, those comments need a new home. In this change I put them in the Torque object definition, but I'm open to other suggestions. - gen-postmortem-metadata couldn't find updated class definitions after they got split across multiple lines, so I changed its matching logic. (Ideally debug-support.cc should be a Torque compiler output rather than something that involves parsing C++ with regexes, but this makes it correctly report subclass relationships for now.) - The end offsets generated by Torque were off by one from the values that would be generated by DEFINE_FIELD_OFFSET_CONSTANTS. Change-Id: I3df4fcd27997b46c41ca879065b9d97f6c939f07 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1692192Reviewed-by:
Tobias Tebbi <tebbi@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Seth Brenith <seth.brenith@microsoft.com> Cr-Commit-Position: refs/heads/master@{#62719}
-
Nico Hartmann authored
RepresentationChanger::GetTaggedPointerRepresentation did not handle kCompressed cases correctly for BigInts. This led to a crash of BigInt benchmarks in js-perf-test. Bug: v8:9407 Change-Id: Id1d60a81afc528c8d4180bd5de9d237f2f0abd0a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1701848Reviewed-by:
Georg Neis <neis@chromium.org> Reviewed-by:
Sigurd Schneider <sigurds@chromium.org> Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#62718}
-
Michael Starzinger authored
Also see: https://github.com/WebAssembly/exception-handling/pull/84 R=ahaas@chromium.org BUG=v8:8091 Change-Id: Ibcf9a2bba019cbd634884cb217e1507231a5bcf8 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1700077Reviewed-by:
-
Clemens Hammacher authored
R=ahaas@chromium.org Bug: v8:9429, v8:9396 Change-Id: I06657a7e339ed2f2c93f560bfcd3413761ad0733 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1701844Reviewed-by:
-
Georg Neis authored
This is a reland of a6eabacf. We decided that this feature needs more work. Bug: v8:9088 Change-Id: I937f722e9356be5eca72cdf1edd552d132ee25be Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1701855Reviewed-by:
-
Jakob Gruber authored
This is a convenience flag to trace and debug invalidations. The assumption used to be that protectors are rarely invalidated, but this may happen more frequently than expected in practice. Bug: v8:9463,v8:9466 Change-Id: Ice051593bda647070bc48d535edd03ba96c7dfcd Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1695469 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#62714}
-
Georg Neis authored
This reverts commit 060b9ec4, as the issue has been resolved. Bug: v8:7790 Change-Id: Id8a56ad50a508eacd191f2777cc5afc0b838364f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1700078 Commit-Queue: Georg Neis <neis@chromium.org> Commit-Queue: Michael Stanton <mvstanton@chromium.org> Reviewed-by:
Michael Stanton <mvstanton@chromium.org> Reviewed-by:
-
Georg Neis authored
The bytecode graph builder may insert additional jumps for the SwitchOnGeneratorState bytecode and for loop headers. This plays into what the graph builder considers dead/alive. We want the serializer to process all the bytecodes that the graph builder will process, so the serializer needs to do something similar. Bug: v8:7790 Change-Id: I1f1d51f4a8951149e365b3c998cef7f613bb4953 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1647694 Commit-Queue: Georg Neis <neis@chromium.org> Reviewed-by:
-
Georg Neis authored
When --concurrent-inlining is on, run bytecode analysis for all relevant functions at serialization time, and store the results in the broker. Change bytecode analysis such that running it for OSR produces information that subsumes the non-OSR case. This lets us avoid doing and storing two analyses for the top-level function in case we do OSR and the function gets inlined into itself. Bug: v8:7790 Change-Id: I7d5df0b2652e6e5c758c85578e51b4f8d041b0d9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1690959 Commit-Queue: Georg Neis <neis@chromium.org> Reviewed-by:
-
Yang Guo authored
R=verwaest@chromium.org Change-Id: Ibbf382ec1f7200142ebccc8eed6fe5dd1c2804bd Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1701846Reviewed-by:
Toon Verwaest <verwaest@chromium.org> Commit-Queue: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#62710}
-
Benedikt Meurer authored
When passing promises from other contexts to an `await`, the --harmony-await-optimization doesn't kick in, and as such the promise will be wrapped in a "native promise" (from this context). That means the promises aren't chained immediately, but delayed via a PromiseResolveThenableJob, which chains these promises on the next turn of this contexts' microtask queue. If there's anything happening on the macro task queue in between this and the point when an exception is raised, the chaining will have happened and we actually find our way back via the promise chains. And this CL adds support for exactly that case. For other cases, it's currently impossible to reconstruct the async stack unfortunately, but we hope that this will help with the major use cases, where the developer awaits on I/O. Bug: v8:7522, v8:8673, v8:9487 Ref: nodejs/node#28680 Change-Id: Icc06c7df12644c2d8d43b6c7580ee06bb8f1024a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1701847 Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Reviewed-by:
-
Toon Verwaest authored
The object itself is already decompressed, and we're simply re-decompressing by nuking the upper bits through sign extension. Additionally this CL changes the branchless decompression sequence on x64 to be cmov-based since that's shorter and faster. It's still slower than branchful though, so we likely won't use it. Change-Id: Ie6f9d38fb390b7300a236bf85d0db58d1ee959b0 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1701842Reviewed-by:
-
Clemens Hammacher authored
We had both jump slots and lazy compile slots in the same table. This increases the space per slot to the maximum of the two, even though we often do not use lazy compilation and could have smaller jump slots. This CL splits the two into two separate tables. The lazy compile table will only be created on demand, and will never be patched. The jump table now only contains jumps, and is more compact (which might improve performance because of improved locality). R=mstarzinger@chromium.org Bug: v8:9477 Change-Id: Ie182873a1ec612f71d1b54447021a9a8f8ca59db Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1698393Reviewed-by:
-
Benedikt Meurer authored
Bug: v8:9487 Change-Id: I38e38195c803d048b858acca577ba43fc5c61ac5 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1701841Reviewed-by:
-
Georg Neis authored
... by making them const or converting them to pointers. Bug: v8:9429 Change-Id: If4a7832944f5dc35cec04c11087499a552a7469a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1700073 Commit-Queue: Georg Neis <neis@chromium.org> Auto-Submit: Georg Neis <neis@chromium.org> Reviewed-by:
-
Peter Marshall authored
We never call GetTraceRecordMode() on the TraceConfig produced in D8 but instead always create the default ring buffer. That means we ignore the "record_mode" argument supplied in config json file. Given we never use this we can remove the parsing code. The same thing is true for enable_systrace and enable_argument_filter. All of these are never used in V8 (they were copied from Chrome) but are part of the public API so this CL just removes our parsing code for them but leaves them in the API for now. Bug: v8:8339 Change-Id: Iab5169536e20c19a784a55d013765125dd701773 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1698397Reviewed-by:
-
Clemens Hammacher authored
According to the specification, class-specific {operator new} and {operator delete} should be static methods. Interestingly, if the {static} keyword is missing, the methods are implicitly static anyway. This is confusing, so this CL adds the {static} keywords explicitly. It also removes the redundant {Malloced::New} and {Malloced::Delete} methods. R=mlippautz@chromium.org Bug: v8:9396 Change-Id: I1db7c87b816567cc1a9153d0b18e3dd4ae81dd6f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1700080Reviewed-by: -
Georg Neis authored
This test no longer fails with concurrent inlining. (Concurrent inlining is actually disabled in 'future' at the moment but will be turned on again soon.) Bug: v8:9094 Change-Id: I4d3f8021a7accff8cd670f3fef95a7995f1a9ba7 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1700076Reviewed-by:
-
Georg Neis authored
Bug: v8:9429 Change-Id: I4274206875edd61f36ac51c05d53158b6c1e17fd Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1700072 Auto-Submit: Georg Neis <neis@chromium.org> Commit-Queue: Tobias Tebbi <tebbi@chromium.org> Reviewed-by:
-
Georg Neis authored
Bug: v8:9429 Change-Id: I48ae73fbd32b0ea4694bea738c42e34bd921c3c6 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1700074 Auto-Submit: Georg Neis <neis@chromium.org> Commit-Queue: Tobias Tebbi <tebbi@chromium.org> Reviewed-by:
-
Nico Hartmann authored
This CL introduces new non-speculative operators BigIntAdd and BigIntNegate. Instead of keeping speculative operators until effect-control-linearization phase, they are now lowered to non-speculative variants in the simplified lowering and surrounded by the necessary checks. This adapts BigInt operators to the common style of other operators (like Numbers). Bug: v8:9407 Change-Id: I89ea7aef0d78c67b103971f8f63525b196ad3c0c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1695467 Commit-Queue: Nico Hartmann <nicohartmann@google.com> Reviewed-by:
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/3454c48..0998f8c TBR=machenbach@chromium.org,sergiyb@chromium.org,tmrts@chromium.org Change-Id: I821c7151d57d8b67daa49b1ed35198692c292fc1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1698440Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#62698}
-
jiepan authored
Problem description: For prefixed WASM opcode, opcode prefix is printed as Unknown, not the opcode itself. Take v128.load as an example: before fix -> after fix Unknown, 0x00, 0x04, 0x00, -> kExprS128LoadMem, 0x04, 0x00, Change-Id: Id0cc5c723d19f60ad4f4f6c6ca338b5658c98c7e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1694613 Commit-Queue: Jie Pan <jie.pan@intel.com> Reviewed-by:
Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#62697}
-
- 14 Jul, 2019 1 commit
-
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/2c98e63..3454c48 TBR=machenbach@chromium.org,sergiyb@chromium.org,tmrts@chromium.org Change-Id: Iae143d41177d135ca2d0b4a49bd83ef8563a72b4 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1698427Reviewed-by:
-
- 13 Jul, 2019 3 commits
-
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/c989268..2c98e63 Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/1abe66f..982e952 Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/78dec04..d3af699 Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/7cefad2..efd0971 TBR=machenbach@chromium.org,sergiyb@chromium.org,tmrts@chromium.org Change-Id: If8b78b71bc89c03f3b87e87868e363eed85eb63f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1698815Reviewed-by:
-
Leszek Swirski authored
This reverts commit 13a04aba. Reason for revert: Breaks v8 roll (https://chromium-review.googlesource.com/c/chromium/src/+/1698024) Original change's description: > fix: move V8_EXPORT_PRIVATE marks to prevent unresolvable references > > This change fixes missing symbol errors in the Windows 10 on ARM build > of Node.js. > > When a whole class is marked for export, all of its members are marked > as well. This can be a problem when inline members call undefined yet > inline members of other classes: the exported function will contain a > reference to the undefined inline function that should be satisfied at > link time, but because the other function is inline no symbol will be > produced that will satisfy that reference. > > Clang gets around this by masking inlined class members from export > using /Fc:dllexportInlines-. This is why b0a2a567 worked. > > Node.js' Windows builds use MSVC and so do not have access to this > flag. This results in unresolved symbols at link time. > > Bug: v8:9465 > Change-Id: Ief9c7ab6ba35d22f995939eb62a64d6f1992ed85 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1696771 > Reviewed-by: Sigurd Schneider <sigurds@chromium.org> > Reviewed-by: Jakob Gruber <jgruber@chromium.org> > Commit-Queue: Sigurd Schneider <sigurds@chromium.org> > Cr-Commit-Position: refs/heads/master@{#62660} TBR=sigurds@chromium.org,jgruber@chromium.org,ishell@chromium.org,jkunkee@microsoft.com Change-Id: Ief2ccb35fc19b00975e78a63791a558525d49ee9 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:9465 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1700069Reviewed-by:
Leszek Swirski <leszeks@chromium.org> Commit-Queue: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/master@{#62694}
-
Deepti Gandluri authored
Change-Id: I9e9cc357cdadf81e8689b54626cff5ccdda2aa41 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1700437Reviewed-by:
Bill Budge <bbudge@chromium.org> Commit-Queue: Deepti Gandluri <gdeepti@chromium.org> Cr-Commit-Position: refs/heads/master@{#62693}
-
- 12 Jul, 2019 11 commits
-
-
Jakob Kummerow authored
...from the Store constructor/destructor. They were preventing embedders from using several Stores with overlapping but non-nested lifetimes. Without Isolate::Enter, such use cases are supported; the only consequence is that Isolate::Current will not work and therefore must not be called; but it is deprecated and not called from the Wasm C API anyway. Change-Id: I65eda00243126e189febb0fd8b38a953c4ee078f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1698387 Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by:
-
Jakob Kummerow authored
The code to create wrapper modules on the fly was dead already. The code to read wire bytes has been replaced with accesses to V8's internal decoded form of the same data. Change-Id: I736c8467df3ded9de08f2d567dbfd5e695dcfb0e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1698384 Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by:
-
Santiago Aboy Solanes authored
Reorganized folder as well. Bug: v8:9451 Change-Id: I65203aa88791dd05d6ca0127d5b832ccd898aa52 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1695901 Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org> Reviewed-by:
Dan Elphick <delphick@chromium.org> Cr-Commit-Position: refs/heads/master@{#62690}
-
Frank Tang authored
Move to stage for harmony_intl_dateformat_day_period harmony_intl_dateformat_fractional_second_digits after ECMA402 SC reach consensus July 11 2019 to treat them as Stage 3. Aiming to flip to ship for m78. Just get ready before sending out I2S after m77 branch off in end of July. Bug: v8:9283, v8:9284 Change-Id: I9bb145827157af9debc75cc4fc3859a60a5a023c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1699301Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Frank Tang <ftang@chromium.org> Cr-Commit-Position: refs/heads/master@{#62689}
-
Jakob Kummerow authored
Change-Id: I51c25c3e41d11ac2419aac1041fe92192f8fdb9e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1698382 Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by:
-
Dan Elphick authored
Make stress mode collect source positions for functions that weren't lazily compiled. Bug: v8:8510 Change-Id: I632f4b39746a7500ced3b7de9840601c4681856e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1700063 Auto-Submit: Dan Elphick <delphick@chromium.org> Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Cr-Commit-Position: refs/heads/master@{#62687}
-
Jeremy Roman authored
Bug: chromium:982304 Change-Id: I1a313ca67d6e3a9430f74f519a236c7dd4f88418 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1698923 Commit-Queue: Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Simon Zünd <szuend@chromium.org> Cr-Commit-Position: refs/heads/master@{#62686}
-
Jakob Kummerow authored
Change-Id: Ie7a8b7fe22bed8092135c0e48cb681fbdd14b9fd Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1698381 Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by:
-
Nico Hartmann authored
This CL adds a speculative operator for BigInt negation that is lowered to the respective builtin call and is optimized to native 64 bit machine operations if truncated. In particular, this change allows negative BigInt constants (e.g. -5n) to be lowered. Bug: v8:9407 Change-Id: Ia98fd6dee18a31ce56efbe537f4352b1582539e7 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1695463 Commit-Queue: Nico Hartmann <nicohartmann@google.com> Reviewed-by:
-
Nico Hartmann authored
The code generated for ChangeUint64ToBigInt in the EffectControlLinearizer did not initialize the optional padding field of newly allocated BigInts. This padding field is present on 64 bit builds without pointer compression enabled. This CL fixes this by 0-filling the padding field if present. Bug: v8:9407 Change-Id: I511e163e676dc966a3eb6dfb92b5065e36329225 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1695464Reviewed-by:
-
Michael Achenbach authored
Bug: v8:9476 Change-Id: Id3660d40fe219ee0816ac8550ee8affd1be4b95b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1698399Reviewed-by:
-
