• Peter Marshall's avatar
    [cleanup] Remove parsing for ignored options in D8 TraceConfig · 29e70b40
    Peter Marshall authored
    We never call GetTraceRecordMode() on the TraceConfig produced in D8
    but instead always create the default ring buffer.
    
    That means we ignore the "record_mode" argument supplied in config json
    file.
    
    Given we never use this we can remove the parsing code. The same thing
    is true for enable_systrace and enable_argument_filter. All of these
    are never used in V8 (they were copied from Chrome) but are part of the
    public API so this CL just removes our parsing code for them but leaves
    them in the API for now.
    
    Bug: v8:8339
    Change-Id: Iab5169536e20c19a784a55d013765125dd701773
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1698397Reviewed-by: 's avatarYang Guo <yangguo@chromium.org>
    Commit-Queue: Peter Marshall <petermarshall@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#62704}
    29e70b40
Name
Last commit
Last update
benchmarks Loading commit data...
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...