- 17 Aug, 2020 1 commit
-
-
Jakob Kummerow authored
This is a comment-only CL. Change-Id: I002b1765bfa839982ab11c22f744734fdd34d4ce Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2352788Reviewed-by: Yang Guo <yangguo@chromium.org> Reviewed-by: Jakob Gruber <jgruber@chromium.org> Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#69417}
-
- 27 Jul, 2020 1 commit
-
-
Dominik Inführ authored
Change-Id: Ia071e8cfcb021ff7e80888370cafcc58c6cb0fca Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2317947 Auto-Submit: Dominik Inführ <dinfuehr@chromium.org> Commit-Queue: Peter Marshall <petermarshall@chromium.org> Reviewed-by: Peter Marshall <petermarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#69070}
-
- 27 May, 2019 1 commit
-
-
Clemens Hammacher authored
This replaces all typedefs that define types and not functions by the equivalent "using" declaration. This was done mostly automatically using this command: ag -l '\btypedef\b' src test | xargs -L1 \ perl -i -p0e 's/typedef ([^*;{}]+) (\w+);/using \2 = \1;/sg' Patchset 2 then adds some manual changes for typedefs for pointer types, where the regular expression did not match. R=mstarzinger@chromium.org TBR=yangguo@chromium.org, jarin@chromium.org Bug: v8:9183 Change-Id: I6f6ee28d1793b7ac34a58f980b94babc21874b78 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1631409 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#61849}
-
- 30 Apr, 2019 1 commit
-
-
Alexei Filippov authored
Remove extra allocation observer. Minor tweaks. Change-Id: Ic7e6e2f8cb39ff960960cca6cc3ece46438a4bd5 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1588405Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Commit-Queue: Alexei Filippov <alph@chromium.org> Cr-Commit-Position: refs/heads/master@{#61130}
-
- 18 Oct, 2018 1 commit
-
-
Alexei Filippov authored
Make heap profiler provide information about each sample currently alive. That information can be used to build diagrams of memory allocations over time. BUG=chromium:889545 Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Change-Id: Ibcbe2f5302263d0b3976ee4cd3601eff11375cae Reviewed-on: https://chromium-review.googlesource.com/c/1285130 Commit-Queue: Alexei Filippov <alph@chromium.org> Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#56793}
-
- 08 Oct, 2018 1 commit
-
-
Alexei Filippov authored
Change-Id: I8843796be4a9da39fad96150593837189e452c07 Reviewed-on: https://chromium-review.googlesource.com/c/1262997Reviewed-by: Ali Ijaz Sheikh <ofrobots@google.com> Commit-Queue: Alexei Filippov <alph@chromium.org> Cr-Commit-Position: refs/heads/master@{#56450}
-
- 03 Oct, 2018 1 commit
-
-
Alexei Filippov authored
unordered_map is supposedly faster on deleting items. BUG=chromium:889545 Change-Id: Id92d9d663e8b9ab2978b8016ef5dccfc93dc104e Reviewed-on: https://chromium-review.googlesource.com/1255554Reviewed-by: Ali Ijaz Sheikh <ofrobots@google.com> Commit-Queue: Alexei Filippov <alph@chromium.org> Cr-Commit-Position: refs/heads/master@{#56354}
-
- 19 Sep, 2018 1 commit
-
-
Florian Sattler authored
Fixing clang-tidy warning. Bug: v8:8015 Change-Id: I5645a85ca7d85ca9abf2cde9ed4191b1ae06ca73 Reviewed-on: https://chromium-review.googlesource.com/1224170Reviewed-by: Hannes Payer <hpayer@chromium.org> Commit-Queue: Florian Sattler <sattlerf@google.com> Cr-Commit-Position: refs/heads/master@{#56046}
-
- 17 Sep, 2018 1 commit
-
-
Florian Sattler authored
Fixing clang-tidy warning. Bug: v8:8015 Change-Id: Ibdb4b81e1ba764d73bac6592eeef5783097076fc Reviewed-on: https://chromium-review.googlesource.com/1225896Reviewed-by: Hannes Payer <hpayer@chromium.org> Commit-Queue: Florian Sattler <sattlerf@google.com> Cr-Commit-Position: refs/heads/master@{#55965}
-
- 12 Feb, 2018 1 commit
-
-
Franziska Hinkelmann authored
Change-Id: Ic0e513e61e3bd1a8ac8f06a1f81c27d35a7d29af Reviewed-on: https://chromium-review.googlesource.com/911249Reviewed-by: Andreas Haas <ahaas@chromium.org> Commit-Queue: Franziska Hinkelmann <franzih@chromium.org> Cr-Commit-Position: refs/heads/master@{#51253}
-
- 25 Sep, 2017 1 commit
-
-
Ali Ijaz Sheikh authored
This is a reland of ec952aaa. Included is a fix that ensures that top_on_previous_step_ is cleared when we release a page. Original change's description: > Reland "[profiler] proper observation of old space inline allocations" > > This is a reland of 672a41c3 > Original change's description: > > [profiler] proper observation of old space inline allocations > > > > Bug: chromium:633920 > > Change-Id: I9a2f4a89f6b9c0f63cb3b166b06a88a12f0a203c > > Reviewed-on: https://chromium-review.googlesource.com/631696 > > Commit-Queue: Ali Ijaz Sheikh <ofrobots@google.com> > > Reviewed-by: Ulan Degenbaev <ulan@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#48043} > > Bug: chromium:633920 > Change-Id: I6fe743d31b8ff26f3858488d4c014c62d3c85add > Reviewed-on: https://chromium-review.googlesource.com/671127 > Reviewed-by: Ulan Degenbaev <ulan@chromium.org> > Commit-Queue: Ali Ijaz Sheikh <ofrobots@google.com> > Cr-Commit-Position: refs/heads/master@{#48085} Bug: chromium:633920 Change-Id: I8a0dcc4eaffc1f1d3ac5b3f8d344001cdae36606 Reviewed-on: https://chromium-review.googlesource.com/677407Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Commit-Queue: Ali Ijaz Sheikh <ofrobots@google.com> Cr-Commit-Position: refs/heads/master@{#48141}
-
- 21 Sep, 2017 1 commit
-
-
Ulan Degenbaev authored
This reverts commit ec952aaa. Reason for revert: https://bugs.chromium.org/p/chromium/issues/detail?id=767144 Original change's description: > Reland "[profiler] proper observation of old space inline allocations" > > This is a reland of 672a41c3 > Original change's description: > > [profiler] proper observation of old space inline allocations > > > > Bug: chromium:633920 > > Change-Id: I9a2f4a89f6b9c0f63cb3b166b06a88a12f0a203c > > Reviewed-on: https://chromium-review.googlesource.com/631696 > > Commit-Queue: Ali Ijaz Sheikh <ofrobots@google.com> > > Reviewed-by: Ulan Degenbaev <ulan@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#48043} > > Bug: chromium:633920 > Change-Id: I6fe743d31b8ff26f3858488d4c014c62d3c85add > Reviewed-on: https://chromium-review.googlesource.com/671127 > Reviewed-by: Ulan Degenbaev <ulan@chromium.org> > Commit-Queue: Ali Ijaz Sheikh <ofrobots@google.com> > Cr-Commit-Position: refs/heads/master@{#48085} TBR=ulan@chromium.org,mlippautz@chromium.org,ofrobots@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: chromium:633920 Change-Id: I576cdab4a03f9fe057ebe1bf7da9dfe3c7bf62cd Reviewed-on: https://chromium-review.googlesource.com/676683Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#48098}
-
- 20 Sep, 2017 1 commit
-
-
Ali Ijaz Sheikh authored
This is a reland of 672a41c3 Original change's description: > [profiler] proper observation of old space inline allocations > > Bug: chromium:633920 > Change-Id: I9a2f4a89f6b9c0f63cb3b166b06a88a12f0a203c > Reviewed-on: https://chromium-review.googlesource.com/631696 > Commit-Queue: Ali Ijaz Sheikh <ofrobots@google.com> > Reviewed-by: Ulan Degenbaev <ulan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#48043} Bug: chromium:633920 Change-Id: I6fe743d31b8ff26f3858488d4c014c62d3c85add Reviewed-on: https://chromium-review.googlesource.com/671127Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Commit-Queue: Ali Ijaz Sheikh <ofrobots@google.com> Cr-Commit-Position: refs/heads/master@{#48085}
-
- 15 Sep, 2017 2 commits
-
-
Ali Ijaz Sheikh authored
This reverts commit 672a41c3. Reason for revert: Linux64 TSAN bot failures Original change's description: > [profiler] proper observation of old space inline allocations > > Bug: chromium:633920 > Change-Id: I9a2f4a89f6b9c0f63cb3b166b06a88a12f0a203c > Reviewed-on: https://chromium-review.googlesource.com/631696 > Commit-Queue: Ali Ijaz Sheikh <ofrobots@google.com> > Reviewed-by: Ulan Degenbaev <ulan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#48043} TBR=ulan@chromium.org,mlippautz@chromium.org,ofrobots@google.com Change-Id: Ib71baf69b29b067fa0ba76027170054b8faa78d3 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:633920 Reviewed-on: https://chromium-review.googlesource.com/669559Reviewed-by: Ali Ijaz Sheikh <ofrobots@google.com> Commit-Queue: Ali Ijaz Sheikh <ofrobots@google.com> Cr-Commit-Position: refs/heads/master@{#48052}
-
Ali Ijaz Sheikh authored
Bug: chromium:633920 Change-Id: I9a2f4a89f6b9c0f63cb3b166b06a88a12f0a203c Reviewed-on: https://chromium-review.googlesource.com/631696 Commit-Queue: Ali Ijaz Sheikh <ofrobots@google.com> Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#48043}
-
- 25 Jul, 2016 1 commit
-
-
jochen authored
R=ishell@chromium.org,bmeurer@chromium.org TBR=rossberg@chromium.org BUG= Review-Url: https://codereview.chromium.org/2175233003 Cr-Commit-Position: refs/heads/master@{#38009}
-
- 13 May, 2016 1 commit
-
-
alph authored
Review-Url: https://codereview.chromium.org/1967673002 Cr-Commit-Position: refs/heads/master@{#36253}
-
- 04 May, 2016 1 commit
-
-
alph authored
BUG=v8:4959 LOG=N Review-Url: https://codereview.chromium.org/1949693003 Cr-Commit-Position: refs/heads/master@{#36042}
-
- 28 Apr, 2016 2 commits
-
-
alph authored
Review-Url: https://codereview.chromium.org/1919223003 Cr-Commit-Position: refs/heads/master@{#35884}
-
alph authored
Do not hold bare pointers to scripts during sampling heap tree construction, as string conversions may lead to an allocation that in turn could cause GC which renders all pointers invalid. Review-Url: https://codereview.chromium.org/1929813002 Cr-Commit-Position: refs/heads/master@{#35883}
-
- 24 Feb, 2016 1 commit
-
-
mattloring authored
Implements poisson unsampling. A poisson process is used to determine which samples to collect based on a sample rate. Unsampling will approximate the true number of allocations at each site taking into account that smaller allocations are less likley to be sampled. This work was originally being done in the agent that consumes profiles but it is more efficient to do it here and individual consumers of the API should not have to worry about the mathematical details of the sampling process. R=ofrobots@google.com BUG= Review URL: https://codereview.chromium.org/1706343002 Cr-Commit-Position: refs/heads/master@{#34234}
-
- 19 Feb, 2016 1 commit
-
-
machenbach authored
Reland of Sampling heap profiler data structure changes (patchset #1 id:1 of https://codereview.chromium.org/1708363002/ ) Reason for revert: Failure keeps lurking around after the revert. I'll reland, sorry for the inconvenience! Original issue's description: > Revert of Sampling heap profiler data structure changes (patchset #10 id:180001 of https://codereview.chromium.org/1697903002/ ) > > Reason for revert: > [Sheriff] Speculative revert for cpu profiler crashes on chromebooks: > https://build.chromium.org/p/client.v8/builders/V8%20Arm%20-%20debug/builds/549 > https://build.chromium.org/p/client.v8/builders/V8%20Arm%20-%20debug/builds/550 > > Original issue's description: > > Sampling heap profiler data structure changes > > > > Previously, the sampling heap profiler stored a list of samples and then > > built a tree representation when the profile was queried by calling > > GetAllocationProfile. This change reduces duplication by removing stacks > > from all samples. Also, less information is stored in the tree > > maintained by the profiler and remaining information (script name, line > > no, etc) is resolved when a profile is requested. > > > > BUG= > > > > Committed: https://crrev.com/cdd55e2a3717723492d76f66810bf56b8de7f198 > > Cr-Commit-Position: refs/heads/master@{#34119} > > TBR=ofrobots@google.com,ulan@chromium.org,hpayer@chromium.org,mattloring@google.com > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG= > > Committed: https://crrev.com/4578e52aefb8c4727742ce2e254613e482fdad1f > Cr-Commit-Position: refs/heads/master@{#34128} TBR=ofrobots@google.com,ulan@chromium.org,hpayer@chromium.org,mattloring@google.com # Skipping CQ checks because original CL landed less than 1 days ago. Review URL: https://codereview.chromium.org/1714493003 Cr-Commit-Position: refs/heads/master@{#34140}
-
- 18 Feb, 2016 2 commits
-
-
machenbach authored
Revert of Sampling heap profiler data structure changes (patchset #10 id:180001 of https://codereview.chromium.org/1697903002/ ) Reason for revert: [Sheriff] Speculative revert for cpu profiler crashes on chromebooks: https://build.chromium.org/p/client.v8/builders/V8%20Arm%20-%20debug/builds/549 https://build.chromium.org/p/client.v8/builders/V8%20Arm%20-%20debug/builds/550 Original issue's description: > Sampling heap profiler data structure changes > > Previously, the sampling heap profiler stored a list of samples and then > built a tree representation when the profile was queried by calling > GetAllocationProfile. This change reduces duplication by removing stacks > from all samples. Also, less information is stored in the tree > maintained by the profiler and remaining information (script name, line > no, etc) is resolved when a profile is requested. > > BUG= > > Committed: https://crrev.com/cdd55e2a3717723492d76f66810bf56b8de7f198 > Cr-Commit-Position: refs/heads/master@{#34119} TBR=ofrobots@google.com,ulan@chromium.org,hpayer@chromium.org,mattloring@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Review URL: https://codereview.chromium.org/1708363002 Cr-Commit-Position: refs/heads/master@{#34128}
-
mattloring authored
Previously, the sampling heap profiler stored a list of samples and then built a tree representation when the profile was queried by calling GetAllocationProfile. This change reduces duplication by removing stacks from all samples. Also, less information is stored in the tree maintained by the profiler and remaining information (script name, line no, etc) is resolved when a profile is requested. BUG= Review URL: https://codereview.chromium.org/1697903002 Cr-Commit-Position: refs/heads/master@{#34119}
-
- 12 Feb, 2016 1 commit
-
-
mattloring authored
This change expands allocation sampling to include old, map, code, and large object spaces. This involved refactoring much of the observation logic out of NewSpace into Space and overriding as needed in sub-classes. Additionally, the sampling heap profiler now maintains a pair of heap observers. One observer is used for observing new space and resetting the inline allocation limit to be periodically notified of allocations. The other observes allocation across the other spaces where there is no additional work required to observe allocations. Tests have been updated to ensure that allocations are observed correctly for Paged and LargeObject spaces. R=ofrobots@google.com, hpayer@chromium.org, ulan@chromium.org BUG= Review URL: https://codereview.chromium.org/1625753002 Cr-Commit-Position: refs/heads/master@{#33959}
-
- 22 Jan, 2016 1 commit
-
-
ofrobots authored
Revert "Revert of [profiler] Implement POC Sampling Heap Profiler (patchset #12 id:220001 of https://codereview.chromium.org/1555553002/ )" This reverts commit 77df8659. BUG= Review URL: https://codereview.chromium.org/1618693004 Cr-Commit-Position: refs/heads/master@{#33473}
-
- 21 Jan, 2016 2 commits
-
-
ofrobots authored
Revert of [profiler] Implement POC Sampling Heap Profiler (patchset #12 id:220001 of https://codereview.chromium.org/1555553002/ ) Reason for revert: The random nature of the tests caused the following buildbot to fail: https://build.chromium.org/p/client.v8/builders/V8%20Linux%20gcc%204.8/builds/4724/steps/Check/logs/stdio Original issue's description: > [profiler] Implement POC Sampling Heap Profiler > > This implements a proof-of-concept sampling based heap profiler inspired by > tcmalloc's heap profiler [1] and Go's mprof/memprofile [2]. > > The basic idea is the sample allocations using a randomized Poisson process. At > any point in time we can cheaply request the set of live sample objects that > should be a representative sample of heap. Samples include stack-traces from the > allocation sites, making this an effective tool for memory leak debugging. > > Unlike AllocationTracking, this is intended to be cheap and usable online in > production. > > The proof-of-concept is only sampling new-space allocations at this point. > Support for sampling paged space and native allocations is anticipated in the > future. > > [1] http://goog-perftools.sourceforge.net/doc/heap_profiler.html > [2] http://blog.golang.org/profiling-go-programs > > Committed: https://crrev.com/e5a9947811db9c9e23557dbad27f8b8a349b3262 > Cr-Commit-Position: refs/heads/master@{#33448} TBR=jochen@chromium.org,alph@chromium.org,hpayer@chromium.org,yangguo@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/1615173002 Cr-Commit-Position: refs/heads/master@{#33449}
-
ofrobots authored
This implements a proof-of-concept sampling based heap profiler inspired by tcmalloc's heap profiler [1] and Go's mprof/memprofile [2]. The basic idea is the sample allocations using a randomized Poisson process. At any point in time we can cheaply request the set of live sample objects that should be a representative sample of heap. Samples include stack-traces from the allocation sites, making this an effective tool for memory leak debugging. Unlike AllocationTracking, this is intended to be cheap and usable online in production. The proof-of-concept is only sampling new-space allocations at this point. Support for sampling paged space and native allocations is anticipated in the future. [1] http://goog-perftools.sourceforge.net/doc/heap_profiler.html [2] http://blog.golang.org/profiling-go-programs Review URL: https://codereview.chromium.org/1555553002 Cr-Commit-Position: refs/heads/master@{#33448}
-