- 24 Jun, 2021 14 commits
-
-
Nico Hartmann authored
This reverts commit 9701d4a4. Reason for revert: https://ci.chromium.org/ui/p/v8/builders/ci/V8%20Mac64/40802/overview Original change's description: > [base] Move most of src/numbers into base > > Moves all but conversions.*, hash-seed-inl.h and math-random.* into > base, in preparation for moving the parts of conversions that don't > access HeapObjects. > > Also moves uc16 and uc32 out of commons/globals.h into base/strings.h. > > Bug: v8:11917 > Change-Id: Ife359148bb0961a63833aff40d26331454b6afb6 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2979595 > Reviewed-by: Ross McIlroy <rmcilroy@chromium.org> > Reviewed-by: Clemens Backes <clemensb@chromium.org> > Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> > Auto-Submit: Dan Elphick <delphick@chromium.org> > Cr-Commit-Position: refs/heads/master@{#75354} Bug: v8:11917 Change-Id: Iacf796c95256016fa74f0a910c5bb1a86baa425a No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2982605 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Reviewed-by: Nico Hartmann <nicohartmann@chromium.org> Commit-Queue: Nico Hartmann <nicohartmann@chromium.org> Cr-Commit-Position: refs/heads/master@{#75356}
-
Thibaud Michaud authored
Because of catch-less try blocks, we have to check the exception stack one more time so that we don't try to rethrow to an outer try scope if this is already the outermost one. R=clemensb@chromium.org Bug: chromium:1219746 Change-Id: I6ad7e4afec669f04bc10197998db5d6eb38a2205 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2983205Reviewed-by: Clemens Backes <clemensb@chromium.org> Commit-Queue: Thibaud Michaud <thibaudm@chromium.org> Cr-Commit-Position: refs/heads/master@{#75355}
-
Dan Elphick authored
Moves all but conversions.*, hash-seed-inl.h and math-random.* into base, in preparation for moving the parts of conversions that don't access HeapObjects. Also moves uc16 and uc32 out of commons/globals.h into base/strings.h. Bug: v8:11917 Change-Id: Ife359148bb0961a63833aff40d26331454b6afb6 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2979595Reviewed-by: Ross McIlroy <rmcilroy@chromium.org> Reviewed-by: Clemens Backes <clemensb@chromium.org> Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> Auto-Submit: Dan Elphick <delphick@chromium.org> Cr-Commit-Position: refs/heads/master@{#75354}
-
Mathias Bynens authored
The lists are to be sorted line by line, which is easier to do than sorting based on an arbitrarily-positioned substring within each line. Change-Id: Ie5e6552e2468545a5800c4bc145cc2b4da1ed4a0 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2982601 Auto-Submit: Mathias Bynens <mathias@chromium.org> Reviewed-by: Clemens Backes <clemensb@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#75353}
-
Ross McIlroy authored
Adds support for Turboprop, limiting the amount of bytecode that can be inlined into a function compared with TurboFan using a scaling factor, currently set to 1/4. To enable inlining, we make sure to only emit the tierup check for the main (non-inlined) function and skip it for any inlined functions. BUG=v8:9684 Change-Id: I1399e2b275f797a5d3fd49c89f23296f75439eee Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2982337Reviewed-by: Santiago Aboy Solanes <solanes@chromium.org> Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> Cr-Commit-Position: refs/heads/master@{#75352}
-
Camillo Bruni authored
This is a reland of 2588380d Fixes arm compilation. Original change's description: > [assembler][arm64][arm][ia32] Add more Assembler::CodeComment > > Use more code comments to better document generated assembler code. > This CL also attaches a CodeComment to FrameScope. > > Change-Id: I45afc3e4078dc161316b877fbbd1ae8bcd6e821d > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2964392 > Reviewed-by: Nico Hartmann <nicohartmann@chromium.org> > Reviewed-by: Victor Gomes <victorgomes@chromium.org> > Commit-Queue: Camillo Bruni <cbruni@chromium.org> > Cr-Commit-Position: refs/heads/master@{#75277} Change-Id: I150c9166e0d31e4af857f76c567b829d16da87e4 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2976651Reviewed-by: Victor Gomes <victorgomes@chromium.org> Reviewed-by: Nico Hartmann <nicohartmann@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#75351}
-
Liu Yu authored
Port: e699762e Bug: v8:11856 Change-Id: Ib832dfcee864b21b4e56498fca54e9ae01c44ae7 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2983711 Auto-Submit: Liu yu <liuyu@loongson.cn> Reviewed-by: Zhao Jiazhong <zhaojiazhong-hf@loongson.cn> Commit-Queue: Zhao Jiazhong <zhaojiazhong-hf@loongson.cn> Cr-Commit-Position: refs/heads/master@{#75350}
-
Sigurd Schneider authored
Bug: chromium:1213393 Change-Id: I56817237424bb83aa9e5d06a47187f245c3cae0e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2983200 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#75349}
-
Timothy Gu authored
Change-Id: I3ec23a8969e311be3afe684df4a545bec0453449 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2971404Reviewed-by: Hannes Payer <hpayer@chromium.org> Commit-Queue: Hannes Payer <hpayer@chromium.org> Auto-Submit: Timothy Gu <timothygu@chromium.org> Cr-Commit-Position: refs/heads/master@{#75348}
-
Lei Zhang authored
Change-Id: I9dbca09523644934eefb14fdb60f360b28417fa2 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2983712Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#75347}
-
Mathias Bynens authored
Bug: chromium:1213438 Change-Id: I52e381841b888e0f5edc0bad9e0319e840829914 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2982600 Commit-Queue: Mathias Bynens <mathias@chromium.org> Commit-Queue: Hannes Payer <hpayer@chromium.org> Auto-Submit: Mathias Bynens <mathias@chromium.org> Reviewed-by: Hannes Payer <hpayer@chromium.org> Cr-Commit-Position: refs/heads/master@{#75346}
-
Patrick Thier authored
- Increase initial queue capacity from 4 to 32 to reduce growing/copying of the queue. - In addition remove the HandleScopes to reduce overhead. The only caller (BytecodeBudgetInterruptFromBytecode) already creates one. Bug: v8:11790 Change-Id: I33cb9222706f9b349c56a7ea14142a930b8ecbf8 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2982012Reviewed-by: Toon Verwaest <verwaest@chromium.org> Commit-Queue: Patrick Thier <pthier@chromium.org> Cr-Commit-Position: refs/heads/master@{#75345}
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/e589a83..9dc1297 Rolling v8/buildtools: https://chromium.googlesource.com/chromium/src/buildtools/+log/9c143ac..46bcd59 Rolling v8/buildtools/linux64: git_revision:e9b8433248ae2c117644b4e40b33203e7d3da192..git_revision:d924640c25f9d90386716116a53957f24d709042 Rolling v8/buildtools/third_party/libc++abi/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi/+log/f4328ad..bf260ac Rolling v8/third_party/aemu-linux-x64: LieFB6bFq-7RUGMVRhbOR3IXo6WdPE7fCzCMv4PnaScC..JZYvEBpGNCDNOK3uLHlpKn_AN6roNsL0YVup96egRSEC Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/09f358b..cf60c0a Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/8dd9dda..098695c TBR=v8-waterfall-sheriff@grotations.appspotmail.com,mtv-sf-v8-sheriff@grotations.appspotmail.com Change-Id: I29cdcfc4ef39ce45c615634b1b1452d776af5604 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2983847Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#75344}
-
Zheng Liu authored
Check whether the right most 16 bits are all-zero. Change-Id: I13bb8856888cbabc19c1f9354048f05ff9e4aacb Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2983839Reviewed-by: Ji Qiu <qiuji@iscas.ac.cn> Commit-Queue: Ji Qiu <qiuji@iscas.ac.cn> Cr-Commit-Position: refs/heads/master@{#75343}
-
- 23 Jun, 2021 26 commits
-
-
Milad Fa authored
Port e699762e Original Commit Message: Instrument floating-point operations to set a flag if the result is NaN. Does not handle f32x4 and f64x2 results yet. R=thibaudm@chromium.org, joransiu@ca.ibm.com, junyan@redhat.com, midawson@redhat.com BUG= LOG=N Change-Id: If81861b65d2a0a98389eebb480127069fd1b5509 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2983458Reviewed-by: Clemens Backes <clemensb@chromium.org> Commit-Queue: Milad Fa <mfarazma@redhat.com> Cr-Commit-Position: refs/heads/master@{#75342}
-
Milad Fa authored
The immediate offset passed to `lay` might be bigger than the allowed 20 bits, in which case we need to add it to the base register manually. Issue came up after this CL https://crrev.com/c/2904926 when a related test case started failing as the offset was changed. Change-Id: I9997bf0ed4e42e32ac52bbd2771bbcb13a328e64 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2983164Reviewed-by: Junliang Yan <junyan@redhat.com> Commit-Queue: Milad Fa <mfarazma@redhat.com> Cr-Commit-Position: refs/heads/master@{#75341}
-
Timothy Gu authored
https://github.com/tc39/ecma262/pull/1490 changed the spec so that the "name" property of a class should be installed after "length" but before "prototype". This CL adapts accordingly. After this change, there is now no need for the separate code path to set the "name" accessor at runtime. Delete the relevant runtime code as well. Bug: v8:8771 Change-Id: I8f809b45bf209c899cf5df76d0ebf6d9a45a6d4e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2974772 Commit-Queue: Timothy Gu <timothygu@chromium.org> Reviewed-by: Marja Hölttä <marja@chromium.org> Cr-Commit-Position: refs/heads/master@{#75340}
-
Adam Kallai authored
SNPrintF function is moved into base/strings.h [1], so it needs to fix the scope of this function for Windows on ARM related source as well. [1] https://chromium-review.googlesource.com/c/v8/v8/+/2972732 Bug: None Change-Id: Ia9934f17941558b6338f28900f069766507c87b2 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2982016Reviewed-by: Dan Elphick <delphick@chromium.org> Reviewed-by: Clemens Backes <clemensb@chromium.org> Commit-Queue: Dan Elphick <delphick@chromium.org> Cr-Commit-Position: refs/heads/master@{#75339}
-
Clemens Backes authored
This is a reland of ac654646. Two constants defined in {AssemblerBase} were not defined anywhere, which is fixed now. Original change's description: > [wasm] Remove WasmInstructionBuffer > > {WasmInstructionBuffer} was basically a wrapper around {AssemblerBuffer} > which remembered the last {AssemblerBuffer} on {Grow()}. Since the > {Assembler} itself already keeps track of the latest {AssemblerBuffer}, > this functionality is mostly redundant. All we need instead is a method > to retrieve the {AssemblerBuffer} from the {Assembler}. > > This CL thus removes {WasmInstructionBuffer} and instead adds > {AssemblerBase::ReleaseBuffer}. > > R=jkummerow@chromium.org, mslekova@chromium.org > CC=dlehmann@google.com > > Bug: v8:11714 > Change-Id: Id07945b67992802a6177bf09e5f5c5be08f657b0 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2982013 > Commit-Queue: Clemens Backes <clemensb@chromium.org> > Reviewed-by: Maya Lekova <mslekova@chromium.org> > Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> > Cr-Commit-Position: refs/heads/master@{#75336} Bug: v8:11714 Change-Id: I8797de1a7a78a93aaef936e46bfd1e73ec2cc9d5 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2982015Reviewed-by: Maya Lekova <mslekova@chromium.org> Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#75338}
-
Maya Lekova authored
This reverts commit ac654646. Reason for revert: Breaks ASAN no-inline - https://ci.chromium.org/ui/p/v8/builders/ci/V8%20Clusterfuzz%20Linux64%20ASAN%20no%20inline%20-%20release%20builder/22909/overview Original change's description: > [wasm] Remove WasmInstructionBuffer > > {WasmInstructionBuffer} was basically a wrapper around {AssemblerBuffer} > which remembered the last {AssemblerBuffer} on {Grow()}. Since the > {Assembler} itself already keeps track of the latest {AssemblerBuffer}, > this functionality is mostly redundant. All we need instead is a method > to retrieve the {AssemblerBuffer} from the {Assembler}. > > This CL thus removes {WasmInstructionBuffer} and instead adds > {AssemblerBase::ReleaseBuffer}. > > R=jkummerow@chromium.org, mslekova@chromium.org > CC=dlehmann@google.com > > Bug: v8:11714 > Change-Id: Id07945b67992802a6177bf09e5f5c5be08f657b0 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2982013 > Commit-Queue: Clemens Backes <clemensb@chromium.org> > Reviewed-by: Maya Lekova <mslekova@chromium.org> > Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> > Cr-Commit-Position: refs/heads/master@{#75336} Bug: v8:11714 Change-Id: Iff32952f712ab2f0f9a16d91906d0135c084f4df No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2982014 Auto-Submit: Maya Lekova <mslekova@chromium.org> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#75337}
-
Clemens Backes authored
{WasmInstructionBuffer} was basically a wrapper around {AssemblerBuffer} which remembered the last {AssemblerBuffer} on {Grow()}. Since the {Assembler} itself already keeps track of the latest {AssemblerBuffer}, this functionality is mostly redundant. All we need instead is a method to retrieve the {AssemblerBuffer} from the {Assembler}. This CL thus removes {WasmInstructionBuffer} and instead adds {AssemblerBase::ReleaseBuffer}. R=jkummerow@chromium.org, mslekova@chromium.org CC=dlehmann@google.com Bug: v8:11714 Change-Id: Id07945b67992802a6177bf09e5f5c5be08f657b0 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2982013 Commit-Queue: Clemens Backes <clemensb@chromium.org> Reviewed-by: Maya Lekova <mslekova@chromium.org> Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#75336}
-
Thibaud Michaud authored
Instrument floating-point operations to set a flag if the result is NaN. Does not handle f32x4 and f64x2 results yet. R=clemensb@chromium.org Bug: v8:11856 Change-Id: I1c3603e2c0c92e71bea8418e85852c01904379af Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2979600 Commit-Queue: Thibaud Michaud <thibaudm@chromium.org> Reviewed-by: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#75335}
-
Clemens Backes authored
If we were unlucky and start wrapper compilation exactly after the isolate started shutting down, we would not have an isolate info any more in the isolate and would access a nullptr. This CL fixes that by just returning an invalid operations barrier token in that case. R=ahaas@chromium.org Bug: v8:11878 Change-Id: I6dcb28a21debb12ba812f705cd5c6387c76eda09 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2982339Reviewed-by: Andreas Haas <ahaas@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#75334}
-
Maya Lekova authored
This CL adds support in TurboFan for passing JSArrays as arguments to fast API callbacks. It also extends the v8::Array class with a CopyAndConvertArrayToCppBuffer method to allow the embedder to perform quick conversions of their JSArrays to a C++ buffer. The CL also adds tests in d8. Design doc: https://docs.google.com/document/d/1BNKKZNgrGYafx8kqSfNEQqQYY5n4A6mGufss_Vz-h-4/edit#heading=h.c0kgf82jnlpp Bug: chromium:1052746, chromium:715122 Change-Id: If47ac60d9ebe6462bbf3adff002e2da8e14e8fc8 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2940900 Commit-Queue: Maya Lekova <mslekova@chromium.org> Reviewed-by: Camillo Bruni <cbruni@chromium.org> Reviewed-by: Georg Neis <neis@chromium.org> Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#75333}
-
Milad Fa authored
Detect if Simd is enabled and if so push/pop the entire 128 bit value, if not then only push/pop the double values. Change-Id: I45d54dcf799a685066559cc3521ef44cd884b788 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2979352Reviewed-by: Junliang Yan <junyan@redhat.com> Commit-Queue: Milad Fa <mfarazma@redhat.com> Cr-Commit-Position: refs/heads/master@{#75332}
-
Santiago Aboy Solanes authored
Bug: v8:7790 Change-Id: I617d076a0f2a63bcd0ba5b896b14dee5370bbbc9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2982237Reviewed-by: Georg Neis <neis@chromium.org> Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org> Cr-Commit-Position: refs/heads/master@{#75331}
-
Michael Lippautz authored
When checks are enabled, ensure that the global handle zap value never leaks into user code as it indicates that the garbage collector failed to keep alive an object. Bug: chromium:1056170 Change-Id: I4836fe49cd6e443d689068af10276ed99b46eb10 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2972729 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by: Dominik Inführ <dinfuehr@chromium.org> Cr-Commit-Position: refs/heads/master@{#75330}
-
Victor Gomes authored
Bug: v8:11872 Change-Id: Ibd26b025fc5eb12d90c3a1c932bd9b8473612016 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2978254Reviewed-by: Leszek Swirski <leszeks@chromium.org> Commit-Queue: Victor Gomes <victorgomes@chromium.org> Cr-Commit-Position: refs/heads/master@{#75329}
-
Al Muthanna Athamina authored
Bug: v8:11902 Change-Id: Id7b19d540bf9b4047febb7fcc2193f3c08fb1ca5 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2979872 Commit-Queue: Almothana Athamneh <almuthanna@chromium.org> Reviewed-by: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#75328}
-
Santiago Aboy Solanes authored
Mark: * ArrayBoilerplateDescription * ObjectBoilerplateDescription as NeverEverSerialized, disable their Data classes and remove the related code. Bug: v8:7790 Change-Id: I9ac1f27d9d7a0d36a04214422261e157cbbcd4b7 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2979604Reviewed-by: Georg Neis <neis@chromium.org> Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org> Cr-Commit-Position: refs/heads/master@{#75327}
-
Igor Sheludko authored
... which didn't properly handle non-Smi integer indices with JSTypedArray receivers. The addition of new JSReceiver::OrdinaryDefineOwnProperty() overload with LookupIterator::Key caused circular dependency between lookup.h and js-objects.h, so the LookupIterator::Key was moved out of the LookupIterator class in order to make it forward-declarable. Bug: chromium:1209405 Change-Id: I265f0c00f65ab6476c8f1d0ca1264f555d43465f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2972727 Auto-Submit: Igor Sheludko <ishell@chromium.org> Commit-Queue: Toon Verwaest <verwaest@chromium.org> Reviewed-by: Toon Verwaest <verwaest@chromium.org> Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#75326}
-
Jakob Kummerow authored
LargeObjectSpace doesn't make use of filler objects, so if we create them when right-trimming objects, then that's a waste of time at best, and causes a segfault in a SLOW_DCHECK at worst, namely when CreateFillerObjectAt calls GetHeapFromWritableObject on what's effectively an inner pointer (on some random LO page). Change-Id: I91bbcaa219db78a0f98660590d5156c4b4a5414e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2972914Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#75325}
-
Ross McIlroy authored
In preperation for enabling limited inlining in Turboprop, add support for lowering of Wasm JS calls that could be inlined as a result. BUG=v8:9684 Change-Id: I744e190d6f14eeed7a9758cbd7f784f759785f4a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2979601Reviewed-by: Santiago Aboy Solanes <solanes@chromium.org> Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> Cr-Commit-Position: refs/heads/master@{#75324}
-
Mihir Shah authored
The change is made since for switch statements with lots of cases, where each case is a constant integer, the emitted bytecode is still a series of jumps, when we can instead use a jump table. If there are 6 or more cases (similar to GCC) of Smi literals, and if the max Smi case minus the min Smi case is not more than 3 times the number of cases, we use a jump table up front to handle Smi's, and then use traditional if-else logic for the rest of the cases. We then use the jump table in interpreter/bytecode-jump-table to do the optimization. This tries to go off issue 9738 in v8's issue tracker. It is not exactly the same, since that recommends doing the work at JIT-time, but has similar ideas. It also partially goes off issue 10764. Bug: v8:9738 Change-Id: Ic805682ee3abf9ce464bb733b427fa0c83a6e10c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2904926Reviewed-by: Leszek Swirski <leszeks@chromium.org> Commit-Queue: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/master@{#75323}
-
Yoshisato Yanagisawa authored
Fetch re-client binaries CIPD package via CIPD during gclient sync step. Bug: chromium:1222951 Change-Id: I7c748b6555df293ee8a43a8b523f63a40cb70f6f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2981692 Commit-Queue: Yoshisato Yanagisawa <yyanagisawa@chromium.org> Auto-Submit: Yoshisato Yanagisawa <yyanagisawa@chromium.org> Reviewed-by: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#75322}
-
Timothy Gu authored
Code such as var a; (a) = function() {}; should not lead to a.name being set to "a". This fixes the last of the anonymous function naming bugs. Bug: v8:4709 Change-Id: I70c2fcbcec1a57752fd58038262d02aefe26e28a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2970705Reviewed-by: Leszek Swirski <leszeks@chromium.org> Reviewed-by: Shu-yu Guo <syg@chromium.org> Commit-Queue: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/master@{#75321}
-
Michael Achenbach authored
This increases the base factor for timeouts on tsan as testing got slower after https://crrev.com/c/2953321 Due to overall slower runtime we also increase the shards. Bug: v8:11906 Change-Id: Ic5de5859755266a1e327433ce8efe6c171490a8d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2979671 Auto-Submit: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Nico Hartmann <nicohartmann@chromium.org> Reviewed-by: Nico Hartmann <nicohartmann@chromium.org> Cr-Commit-Position: refs/heads/master@{#75320}
-
Leszek Swirski authored
This is a reland of 3296de2f It includes pthier@'s fix of overzealous OSR Original change's description: > [sparkplug] Trigger compilation when a FBV exists > > We were gating baseline compilation on FBV allocation, but in some > cases, the feedback vector may be allocated eagerly (notably, if we are > logging function events). Instead, unconditionally try baseline > compilation after ensuring the feedback vector exists. > > Bug: v8:11420 > Change-Id: I1264a1d541a74d4eccb5caf65c360ac23836a1a8 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2953161 > Auto-Submit: Leszek Swirski <leszeks@chromium.org> > Commit-Queue: Patrick Thier <pthier@chromium.org> > Reviewed-by: Patrick Thier <pthier@chromium.org> > Cr-Commit-Position: refs/heads/master@{#75242} Bug: v8:11420 Change-Id: Ia6864856926d6760bbe6c89ee010fa62cf23b6ca Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2976660 Auto-Submit: Leszek Swirski <leszeks@chromium.org> Commit-Queue: Patrick Thier <pthier@chromium.org> Reviewed-by: Patrick Thier <pthier@chromium.org> Cr-Commit-Position: refs/heads/master@{#75319}
-
John Xu authored
These are the changes Cobalt currently has in V8's cpu related code. - Add missing Starboard CPU code - Replace some V8_OS_WIN with V8_TARGET_OS_WIN, they are found when cross-compiling for Linux platforms on Windows Bug: v8:10927 Change-Id: Id63ae8614cbe6fe0eb53df89060c8ca2c9969ef4 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2963803 Commit-Queue: John Xu <johnx@google.com> Reviewed-by: Clemens Backes <clemensb@chromium.org> Reviewed-by: Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#75318}
-
John Xu authored
This is part of Cobalt's upstream effort to be more in sync with V8. Cobalt does not trigger the atomics functions in runtime-atomics.cc so we use dummy implementations for now. Bug: v8:10927 Change-Id: I2da75b7f9b22b41a1ff00af1ab4b43641e9a33bf Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2963801 Commit-Queue: John Xu <johnx@google.com> Reviewed-by: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#75317}
-