• Maya Lekova's avatar
    Revert "[wasm] Remove WasmInstructionBuffer" · f8182a8e
    Maya Lekova authored
    This reverts commit ac654646.
    
    Reason for revert: Breaks ASAN no-inline - https://ci.chromium.org/ui/p/v8/builders/ci/V8%20Clusterfuzz%20Linux64%20ASAN%20no%20inline%20-%20release%20builder/22909/overview
    
    Original change's description:
    > [wasm] Remove WasmInstructionBuffer
    >
    > {WasmInstructionBuffer} was basically a wrapper around {AssemblerBuffer}
    > which remembered the last {AssemblerBuffer} on {Grow()}. Since the
    > {Assembler} itself already keeps track of the latest {AssemblerBuffer},
    > this functionality is mostly redundant. All we need instead is a method
    > to retrieve the {AssemblerBuffer} from the {Assembler}.
    >
    > This CL thus removes {WasmInstructionBuffer} and instead adds
    > {AssemblerBase::ReleaseBuffer}.
    >
    > R=​jkummerow@chromium.org, mslekova@chromium.org
    > CC=​dlehmann@google.com
    >
    > Bug: v8:11714
    > Change-Id: Id07945b67992802a6177bf09e5f5c5be08f657b0
    > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2982013
    > Commit-Queue: Clemens Backes <clemensb@chromium.org>
    > Reviewed-by: Maya Lekova <mslekova@chromium.org>
    > Reviewed-by: Jakob Kummerow <jkummerow@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#75336}
    
    Bug: v8:11714
    Change-Id: Iff32952f712ab2f0f9a16d91906d0135c084f4df
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2982014
    Auto-Submit: Maya Lekova <mslekova@chromium.org>
    Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
    Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#75337}
    f8182a8e
Name
Last commit
Last update
.github Loading commit data...
bazel Loading commit data...
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.bazelrc Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.mailmap Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.bazel Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
DEPS Loading commit data...
DIR_METADATA Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
RISCV_OWNERS Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
WORKSPACE Loading commit data...
codereview.settings Loading commit data...