- 18 Feb, 2022 11 commits
-
-
Nico Hartmann authored
This CL adds handling of the BigInt types to TurbofanType to allow verification of BigInt values in %VerifyType. Change-Id: I1fc6dea16cbff4d22cfbb5483c5dee50fa932f75 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3256687Reviewed-by:
Tobias Tebbi <tebbi@chromium.org> Commit-Queue: Nico Hartmann <nicohartmann@chromium.org> Cr-Commit-Position: refs/heads/main@{#79169}
-
Nico Hartmann authored
This reverts commit a1838956. Reason for revert: https://bugs.chromium.org/p/v8/issues/detail?id=12642 Original change's description: > [heap] Allow shared references in WeakMap > > Shared references can also be stored in WeakMaps and during marking we > need to be able to deal with such references. In a client GC shared > objects are treated as live, so we don't need to update or check mark > bits for such objects. > > Bug: v8:11708 > Change-Id: I0dbf797472c4779f462750dab63cc9b012aad091 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3447365 > Reviewed-by: Michael Lippautz <mlippautz@chromium.org> > Commit-Queue: Dominik Inführ <dinfuehr@chromium.org> > Cr-Commit-Position: refs/heads/main@{#79153} Bug: v8:11708 Change-Id: I113672aceba0ef5aa71f6fbedda7e0df854a437d No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3474673 Auto-Submit: Nico Hartmann <nicohartmann@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Nico Hartmann <nicohartmann@chromium.org> Owners-Override: Nico Hartmann <nicohartmann@chromium.org> Cr-Commit-Position: refs/heads/main@{#79168}
-
Samuel Groß authored
Previously, V8_OS_MACOSX was, somewhat confusingly, also used for iOS. With this CL, V8_OS_DARWIN will be set on both macOS and iOS, V8_OS_MACOS only on macOS, and V8_OS_IOS only on iOS. This CL also renames V8_TARGET_OS_MACOSX to V8_TARGET_OS_MACOS and renames platform-xnu.cc to platform-darwin.cc. Change-Id: I4bcafc7c337586662114144f6c7ccf47d978da1f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3468577Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Reviewed-by:
Igor Sheludko <ishell@chromium.org> Reviewed-by:
Toon Verwaest <verwaest@chromium.org> Commit-Queue: Samuel Groß <saelo@chromium.org> Cr-Commit-Position: refs/heads/main@{#79167}
-
Lu Yahan authored
Port 89ea44bf Change-Id: I2fb42032f174f1e8af4903c663f97ea27ab3600f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3467157Reviewed-by:
ji qiu <qiuji@iscas.ac.cn> Commit-Queue: ji qiu <qiuji@iscas.ac.cn> Cr-Commit-Position: refs/heads/main@{#79166}
-
Dominik Inführ authored
Now that we are able to compact map space, we can also get rid of the map space and allocate maps in the old space instead. This CL introduces a FLAG_map_space for enabling/disabling the map space but the map space remains enabled by default for now. Without a separate space for maps, the GC can't prevent relocation of maps anymore. Therefore this CL always allows compaction of maps when running without a map space. Rename flag to --compact-maps to better fit this scenario. mkgrokdump and debug_helper also need to be updated to look for maps also in the old space. The map space is now optional. Bug: v8:12578 Change-Id: Ic4e4abd0b58bee26e64329b1c92dbccb07d8105a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3424483Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Seth Brenith <seth.brenith@microsoft.com> Reviewed-by:
Leszek Swirski <leszeks@chromium.org> Commit-Queue: Dominik Inführ <dinfuehr@chromium.org> Cr-Commit-Position: refs/heads/main@{#79165}
-
Clemens Backes authored
Message tests check the output of a test against an expected file. Executing with --stress-opt changes the output, since the test will be run multiple times. For that reason, most message tests explicitly add the --no-stress-opt flag. Since this is redundant, and not a per-test setting, just configure this globally for all message tests instead. R=machenbach@chromium.org Bug: v8:12425 Change-Id: I52f1b43da2781fcb6f6bd37e67d483ca69c1c929 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3471637Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/main@{#79164}
-
Dominik Inführ authored
Start the implementation of the shared heap write barrier by renaming CLIENT_TO_SHARED to OLD_TO_SHARED. I planned to do this with the CL introducing the write barrier but in order to keep that CL smaller do this here already. Bug: v8:11708 Change-Id: I204c728e333a4e80c30c0992e43c3cb6752fc660 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3468351Reviewed-by:
-
Benedikt Meurer authored
When a terminate_exception is raised while executing one of the promise related jobs on the microtask queue, we don't clean up properly, leaving the async stack in the inspector in an inconsistent state, not cleaning up the promise stack on the Isolate, and also not resetting the global current_microtask slot. This CL adds appropriate logic to perform the correct cleanup. Fixed: chromium:1297964 Change-Id: I4ec64405d4c66bfe1f0115e7039866447fb10f02 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3471815 Auto-Submit: Benedikt Meurer <bmeurer@chromium.org> Reviewed-by:
Jaroslav Sevcik <jarin@chromium.org> Commit-Queue: Jaroslav Sevcik <jarin@chromium.org> Cr-Commit-Position: refs/heads/main@{#79162}
-
Frank Tang authored
Change NumberFormat.prototpe.resolvedOptions to return new options in v3. Also fix a heap allocation assertion bug in GetStringOrBooleanOption while the useGrouping option is an invalid argument. https://github.com/tc39/proposal-intl-numberformat-v3 https://chromestatus.com/guide/edit/5707621009981440 Design Doc: https://docs.google.com/document/d/19jAogPBb6W4Samt8NWGZKu47iv0_KoQhBvLgQH3xvr8/edit Bug: v8:10776 Change-Id: Iaeeb0398b77394db3c941a2706d44b734a1f9d8c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3427298Reviewed-by:
Shu-yu Guo <syg@chromium.org> Commit-Queue: Frank Tang <ftang@chromium.org> Cr-Commit-Position: refs/heads/main@{#79161}
-
Dominik Inführ authored
When we know that the value in a write barrier is a map, we know that we are not going to have an old-to-new reference (maps are always in old generation). Therefore we also don't really need the generational barrier in RecordWrite. While this is technically correct, we don't gain much from this optimization. The inline and out-of-line generated code for the barrier is still the same as in all other cases. Which means that outside marking we don't even reach the RecordWrite builtin. Most write barrier executions happen outside incremental marking, hence performance of the incremental marking barrier isn't critical. This CL always uses the full RecordWrite builtin using a flag in order to allow for an easy revert. This CL is motivated by the shared heap work, which needs an additional always-on barrier in the future (similar to OLD_TO_NEW) to keep a OLD_TO_SHARED remembered set up-to-date. While maps are always in the old generation, they maybe by located in the shared heap. Bug: v8:11708 Change-Id: I71a6ded2547a0b2bbb9bbbd796dbcae0987b2232 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3471854Reviewed-by:
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/996f747..2fb4402 Rolling v8/buildtools: https://chromium.googlesource.com/chromium/src/buildtools/+log/f413334..93c1552 Rolling v8/buildtools/third_party/libunwind/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libunwind/+log/1e0047c..7539622 Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/7504934..1fe0550 Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/e293d3d..988c0af Rolling v8/third_party/zlib: https://chromium.googlesource.com/chromium/src/third_party/zlib/+log/901a5d9..31e5ad1 Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/0a9dd77..3730026 Rolling v8/tools/luci-go: git_revision:b32c149b6abb5e4e9aead1651c7a65562a956858..git_revision:582e828c5a8aaf5cdd0ad1d5465fb9092b71eab8 Rolling v8/tools/luci-go: git_revision:b32c149b6abb5e4e9aead1651c7a65562a956858..git_revision:582e828c5a8aaf5cdd0ad1d5465fb9092b71eab8 R=v8-waterfall-sheriff@grotations.appspotmail.com,mtv-sf-v8-sheriff@grotations.appspotmail.com Change-Id: If8d8a68c179681c363ac4ef967ef94a4309741bf Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3473206 Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#79159}
-
- 17 Feb, 2022 26 commits
-
-
Francis McCabe authored
Bug: v8:12638 Change-Id: I88a28b8a17b25ead4a5771870323425772f4f45a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3472873Reviewed-by:
-
Milad Fa authored
Change-Id: I86f34d698bf34590359a980282fa60d6501a6da9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3469628Reviewed-by:
Junliang Yan <junyan@redhat.com> Commit-Queue: Milad Farazmand <mfarazma@redhat.com> Cr-Commit-Position: refs/heads/main@{#79157}
-
Shu-yu Guo authored
Unlike the Stage 1 proposal, for simplicity the prototype does not add any new syntax, instead opting for exposing a SharedStructType constructor which takes an array of field names. This type constructor returns constructors for shared structs. Shared structs can be shared across Isolates, are fixed layout, have no prototype, have no .constructor, and can only store primitives and other shared structs. The initial prototype does not have TurboFan support. Bug: v8:12547 Change-Id: I23bdd819940b42139692bcdb53d372099b0d4426 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3390643Reviewed-by:
Marja Hölttä <marja@chromium.org> Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Reviewed-by:
Dominik Inführ <dinfuehr@chromium.org> Commit-Queue: Shu-yu Guo <syg@chromium.org> Cr-Commit-Position: refs/heads/main@{#79156}
-
Camillo Bruni authored
- Remove debug printing in callstats.py - Handle non-version nested JSON files better in callstats.html - Harden RCS extraction from telemetry JSON files Change-Id: Ied921e54e6281a456c0a6369d797c21785080036 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3471856Reviewed-by:
-
Milad Fa authored
https://crrev.com/c/3471558 is causing the following compilation error on gcc: ``` error: suggest explicit braces to avoid ambiguous 'else' ``` Bug: chromium:1298417 Change-Id: I84a34603664c5ee148cc9ea282c0f8c53319b6d8 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3472403Reviewed-by:
-
Dominik Inführ authored
Shared references can also be stored in WeakMaps and during marking we need to be able to deal with such references. In a client GC shared objects are treated as live, so we don't need to update or check mark bits for such objects. Bug: v8:11708 Change-Id: I0dbf797472c4779f462750dab63cc9b012aad091 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3447365Reviewed-by:
-
Milad Fa authored
Change-Id: Id5295f5afe3bc850f2e8726d696f42fd26f07a51 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3470565Reviewed-by:
-
Benoît Lizé authored
Guard pages are 4k areas at the beginning and end of each oilpan page (128kiB) which are meant to be inaccessible. However on ARM64 macOS, the OS page size is 16kiB, meaning that these are not inaccessible. But we do pay for these, as they are part of the first and last OS page. Meaning that we effectively waste 2 * 4kiB = 6.25% of each Oilpan page. Since these are not serving their purpose, disable them on this platform. Another fix could be to make the guard page 16kiB, but given that the entire oilpan page is 128kiB, this may have adverse effects on e.g. fragmentation. Note that this doesn't regress security, as the regions were never protected to begin with on this platform. Bug: chromium:1298417 Change-Id: Iad5d05670962780e6d1eeab2bb8a331deb7aa1f3 Cq-Include-Trybots: luci.v8.try:v8_linux_arm64_rel_ng Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3471558Reviewed-by:
-
Nico Hartmann authored
Tests are flaky on arm64 sim and arm64 sim - msan bots. Bug: v8:12637 Change-Id: If9570ceb8af375d12ddd375274aea1ebc0078e63 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3471634 Owners-Override: Nico Hartmann <nicohartmann@chromium.org> Auto-Submit: Nico Hartmann <nicohartmann@chromium.org> Reviewed-by:
Maya Lekova <mslekova@chromium.org> Commit-Queue: Maya Lekova <mslekova@chromium.org> Cr-Commit-Position: refs/heads/main@{#79150}
-
Nico Hartmann authored
Bug: chromium:1298421 Change-Id: I3489b2ce8b11052cdf7c23d89255b30258cc9157 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3471555Reviewed-by:
-
Thibaud Michaud authored
Use the existing generic js-to-wasm wrapper to handle arguments in the stack-switching export wrapper, by combining them into a single helper function parameterized by a boolean. If the stack_switch parameter is false, the generated js-to-wasm wrapper is the same as before. If the stack_switch parameter is true, we allocate and switch to the new stack before starting to process the parameters. To load the parameters, we also keep a pointer to the old stack. After the call, we convert the return value according to the return type as usual, and then switch back to the parent stack (which may be different than the original stack, but has a compatible stack frame layout). If the stack suspends during the call, control-flow jumps right before we deconstruct and leave the frame, and returns the Promise as an externref in the return register. R=ahaas@chromium.org,jkummerow@chromium.org CC=fgm@chromium.org Bug: v8:12191 Change-Id: If3f8eaba8edebe6e98d4738f79f895fdb5322adc Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3460410Reviewed-by:
Andreas Haas <ahaas@chromium.org> Commit-Queue: Thibaud Michaud <thibaudm@chromium.org> Cr-Commit-Position: refs/heads/main@{#79148}
-
Junliang Yan authored
Change-Id: I08f3ad3987f633de5073c7f44ebb7a71de2425e2 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3470564Reviewed-by:
Milad Farazmand <mfarazma@redhat.com> Commit-Queue: Junliang Yan <junyan@redhat.com> Cr-Commit-Position: refs/heads/main@{#79147}
-
Samuel Groß authored
Using shm_open with a constant name can lead to race conditions with other V8 instances using (and unlinking) the same shared memory object. Bug: v8:12636 Change-Id: Ic2d2317f99c1df7aedec2dc52b187c64eea11d2c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3468899Reviewed-by:
-
Junliang Yan authored
Change-Id: If34e7927b8d243a22cbcc0e717541c237993ef4e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3470563Reviewed-by:
-
Clemens Backes authored
For large modules, the current limit of 100k bytes create a large amount of batches to be processed by the concurrent tasks. Choosing the batch size larger removes communication overhead. R=ahaas@chromium.org Bug: v8:11974, chromium:1297999 Change-Id: Ia03f42895cb0e6bab8fdc52b82ff2ed59869b749 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3468904Reviewed-by:
Thibaud Michaud <thibaudm@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/main@{#79144}
-
Michael Lippautz authored
There's only a single callsite that performs retries after allocations which already can determine the proper GC to invoke without requiring threading the space backwards. Bug: v8:12615 Change-Id: I5d5d886162b3eca33eb2fe7bde1e113cd08a094c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3468905Reviewed-by:
-
Camillo Bruni authored
Avoiding handles in tight loops and setup code improves performance and reduces code size. This CL also makes more non-allocating mode more explicit by adding more DisallowGarbageCollection scopes. Change-Id: I95b5b1a29204c27a23c42ccd67fff150b3fa4a3e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3460740Reviewed-by:
-
Omer Katz authored
Outside of unittests, if someone tried to delete a GCed object manually they would get a silent crash without a stacktrace or any error messages. This CL replaces the silent crash with an informative message. Change-Id: Ied8895dab43ce7e3a9bf778b13e77d377d269fce Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3468346 Commit-Queue: Omer Katz <omerkatz@chromium.org> Auto-Submit: Omer Katz <omerkatz@chromium.org> Reviewed-by:
-
Jakob Kummerow authored
which the "no-wasm" build refactoring had accidentally disabled. Bug: v8:11238 Change-Id: Ia2a4be89024f0bc22a1548dcef21e065e4bb5268 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3468341Reviewed-by:
-
Clemens Backes authored
In order to create less tasks that each need to swap permissions for writing to the code space, merge the two {CopyAndRelocTask} and {PublishTask} into a single {DeserializeCodeTask}. This also makes the code a lot shorter, and removes stress from the scheduler. R=ahaas@chromium.org Bug: v8:11974, chromium:1297999 Change-Id: I8866bf7225b0bc2dd4caef79e64cacca9de15519 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3468902Reviewed-by: -
Michael Lippautz authored
Avoid the lookup via heap()->incremental_marking() and instead cache the marking state on GlobalHandles itself. Change-Id: I2665681ad38983bf16d22e0a82dd10743877e520 Bug: chromium:1294661 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3468903Reviewed-by:
-
Manos Koukoutos authored
Changes: - Simplify GetRefTypeName. - Simplify WasmModuleDebug::GetWasmValue. - Fix some signature issues in tests. Change-Id: I61b9a48c0fbce0bc9cc74771412bdb8977880697 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3468344Reviewed-by:
-
V8 Autoroll authored
Change-Id: I2c4bcabe00d85188675441dc242cd2efc90c5fca Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3470561Reviewed-by:
Lutz Vahl <vahl@chromium.org> Commit-Queue: Lutz Vahl <vahl@chromium.org> Cr-Commit-Position: refs/heads/main@{#79136}
-
Clemens Backes authored
Publishing Wasm code often happens in a loop (in particular for deserialization), so hold the {CodeSpaceWriteScope} outside that loop to avoid repeated switching between writable and executable. R=ahaas@chromium.org Bug: v8:11974, chromium:1297999 Change-Id: Ic4bf859685e66c4ba297fed968d0df6ae7d24cba Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3468896Reviewed-by: -
Camillo Bruni authored
Historically the tool only combined files where the run number was separate by a hash: domain#1.txt , domain#2.txt... Fix this to allow for underscores and/or abitrary number suffixes. Change-Id: I85253a1b871eb75fce60fef9a61b7d50afe72abd Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3468900Reviewed-by:
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/62a6377..996f747 Rolling v8/buildtools: https://chromium.googlesource.com/chromium/src/buildtools/+log/169eef5..f413334 Rolling v8/buildtools/third_party/libunwind/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libunwind/+log/b323ac8..1e0047c Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/6fbe580..7504934 Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/d6a3040..e293d3d Rolling v8/third_party/zlib: https://chromium.googlesource.com/chromium/src/third_party/zlib/+log/9538f41..901a5d9 Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/62e2cd9..0a9dd77 Rolling v8/tools/luci-go: git_revision:c4791d15e395b201e6a85336f7d8a21cce973dfa..git_revision:b32c149b6abb5e4e9aead1651c7a65562a956858 Rolling v8/tools/luci-go: git_revision:c4791d15e395b201e6a85336f7d8a21cce973dfa..git_revision:b32c149b6abb5e4e9aead1651c7a65562a956858 R=v8-waterfall-sheriff@grotations.appspotmail.com,mtv-sf-v8-sheriff@grotations.appspotmail.com Change-Id: Icd4bf05c19d156a1266ce51b4b8ab9af0d4782ca Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3468735 Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#79133}
-
- 16 Feb, 2022 3 commits
-
-
Milad Fa authored
Change-Id: I45f3379b3656ee2bc939c97c37d3f15bd730de5a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3469177Reviewed-by:
-
Samuel Groß authored
The new shared memory API should only be used on macOS, but platform-macos.cc was also included on iOS, causing build failures. This CL splits platform-macos.cc into platform-xnu.cc (common code for macOS and iOS) and platform-macos.cc (the macOS specific parts) Bug: chromium:1218005 Change-Id: Iab332865ffd8990ddd246bb9c08802909464d7e6 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3468895Reviewed-by:
-
Camillo Bruni authored
Don't print command line invocations by default. Change-Id: Ie67c883c92557a645fc8a681722f49a2c7c4bd17 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3468901Reviewed-by:
-
