- 15 May, 2019 4 commits
-
-
Yang Guo authored
R=bmeurer@chromium.org, clemensh@chromium.org, jkummerow@chromium.org, sigurds@chromium.org, ulan@chromium.org, verwaest@chromium.org Bug: v8:9247 Change-Id: I153a6bbfc55989fe7a86c052f95c5cb8ee61e841 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1613244 Commit-Queue: Yang Guo <yangguo@chromium.org> Auto-Submit: Yang Guo <yangguo@chromium.org> Reviewed-by: Sigurd Schneider <sigurds@chromium.org> Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by: Clemens Hammacher <clemensh@chromium.org> Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Reviewed-by: Jakob Gruber <jgruber@chromium.org> Reviewed-by: Toon Verwaest <verwaest@chromium.org> Cr-Commit-Position: refs/heads/master@{#61557}
-
Clemens Hammacher authored
All macros defined in "format-macros.h" are dead now (after https://crrev.com/c/1613243). This CL removes this header, and includes <cinttypes> instead wherever we use format macros for the types defined in <cstdint>. Plus some drive-by cleanup of includes. R=mlippautz@chromium.org Bug: v8:9183 Change-Id: Ic379759b79edb50e38833defb1577cc3af7c8150 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1611800 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by: Yang Guo <yangguo@chromium.org> Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#61540}
-
Yang Guo authored
R=tmrts@chromium.org Bug: v8:9247 Change-Id: I9b34ee96e03d3cbca165452fc8427679cf6e7582 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1612900 Commit-Queue: Yang Guo <yangguo@chromium.org> Reviewed-by: Tamer Tas <tmrts@chromium.org> Cr-Commit-Position: refs/heads/master@{#61518}
-
Jakob Kummerow authored
We don't need the full "types" array, just the number of parameters and the type of the result. Avoiding unnecessary malloc/free calls significantly cuts down on overhead. Change-Id: I738f0ee4c269731cf1ff79a56f910e8f7e97c83e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1601505 Commit-Queue: Yang Guo <yangguo@chromium.org> Auto-Submit: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by: Yang Guo <yangguo@chromium.org> Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#61511}
-
- 10 May, 2019 2 commits
-
-
Johannes Henkel authored
In the longer run we only want the CBOR code path, for now we need to handle JSON as well. So we convert if possible. Change-Id: I726b737f4cd2602d4fb676ce7cf996fcd1ba33e9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1598254Reviewed-by: Alexei Filippov <alph@chromium.org> Commit-Queue: Johannes Henkel <johannes@chromium.org> Cr-Commit-Position: refs/heads/master@{#61424}
-
Santiago Aboy Solanes authored
Everything after UNREACHABLE is dead code, so it makes sense to remove them. Bug: v8:9183 Change-Id: If76468a73b926d74717cc2348fd5b36d30f680c1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1605727Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> Reviewed-by: Yang Guo <yangguo@chromium.org> Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org> Cr-Commit-Position: refs/heads/master@{#61411}
-
- 09 May, 2019 3 commits
-
-
Milad Farazmand authored
<limits> header is needed to compile successfully on PPC. Needed for std::numeric_limits Change-Id: Ice2d3c6416dec4ff09d15a20fcba9659239faa09 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1601729Reviewed-by: Alexei Filippov <alph@chromium.org> Commit-Queue: Alexei Filippov <alph@chromium.org> Cr-Commit-Position: refs/heads/master@{#61392}
-
Yang Guo authored
This reverts commit 4faf5a7f. Reason for revert: change of plans. Original change's description: > Add more OWNERS for DevTools protocol definitions > > R=alph@chromium.org > > Change-Id: I615b9274cd0f6128d3f2377ef9dacb6aa1980446 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1601494 > Reviewed-by: Alexei Filippov <alph@chromium.org> > Reviewed-by: Pavel Feldman <pfeldman@chromium.org> > Reviewed-by: Dmitry Gozman <dgozman@chromium.org> > Commit-Queue: Yang Guo <yangguo@chromium.org> > Cr-Commit-Position: refs/heads/master@{#61365} TBR=dgozman@chromium.org,alph@chromium.org,pfeldman@chromium.org,yangguo@chromium.org Change-Id: Ida51f3b315d020abe0b34dceb4e54f7d92971035 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1601501Reviewed-by: Yang Guo <yangguo@chromium.org> Commit-Queue: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#61367}
-
Yang Guo authored
R=alph@chromium.org Change-Id: I615b9274cd0f6128d3f2377ef9dacb6aa1980446 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1601494Reviewed-by: Alexei Filippov <alph@chromium.org> Reviewed-by: Pavel Feldman <pfeldman@chromium.org> Reviewed-by: Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#61365}
-
- 08 May, 2019 2 commits
-
-
Johannes Henkel authored
This will allow me to reuse the routines for the inspector_protocol/encoding/encoding_test, rather than copy them. I've already verified that this works. Change-Id: I5b61e4f48c2d00d9d0a5305c9790093c66b3c765 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1600360 Commit-Queue: Johannes Henkel <johannes@chromium.org> Reviewed-by: Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#61355}
-
Aleksei Koziatinskii authored
There are two possible type: - scriptParsed - breakpoint for any script, - scriptWithSourceMapParsed - breakpoint for script with sourceMappingURL. When one of the breakpoints is set then for each matched script we add breakpoint on call to top level function of that script. Node: https://github.com/nodejs/node/issues/24687 R=dgozman@chromium.org Bug: chromium:887384,chromium:724793,chromium:882909 Change-Id: I9c08b2a2a5ba7006adfedd85fc92ae191517af00 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1354245Reviewed-by: Jakob Gruber <jgruber@chromium.org> Reviewed-by: Yang Guo <yangguo@chromium.org> Reviewed-by: Dmitry Gozman <dgozman@chromium.org> Reviewed-by: Alexei Filippov <alph@chromium.org> Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Cr-Commit-Position: refs/heads/master@{#61353}
-
- 03 May, 2019 2 commits
-
-
Johannes Henkel authored
Keep the existing method for compatibility, by converting to json from CBOR using the inspector_protocol_encoding library, via a v8 specific interface library that directs routines for converting between strings and doubles to v8's implementations. This change also brings in the encoding.h / encoding.cc files from the upstream inspector_protocol project. The only modification here are the header guards, and the namespace. I will fix roll.py to make it so that we pick up future changes. third_party/inspector_protocol/BUILD.gn is specific to v8, by necessity. third_party/inspector_protocol/.clang-format is a copy of the upstream file. If we don't put this, we'll find ourselves auto-formatting the roll, which is annoying. This is a reland of https://chromium-review.googlesource.com/c/v8/v8/+/1590627 with the only modification in the DEPS file; this time I'm including third_party/inspector_protocol/encoding/encoding{.h,cc} in addition to the relative include there. Not sure why this is needed but I'm hoping it gets me past the presubmit which may resolve the include path relative to the V8 base (the ../../third_party is needed for when V8 is embedded into Chromium). Change-Id: Ic76b2b5faa7e1cbdceb15aff3f369e9a303e3e85 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1593646Reviewed-by: Alexei Filippov <alph@chromium.org> Reviewed-by: Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Johannes Henkel <johannes@chromium.org> Cr-Commit-Position: refs/heads/master@{#61214}
-
Simon Zünd authored
This new function forwards to v8::Object::CreationContext but has special handling for JSGlobalProxy objects to prevent the former from crashing. R=yangguo@chromium.org Bug: chromium:952057 Change-Id: I5ade682976efd1724c13f52b468e4fb30bb9ade7 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1569425 Commit-Queue: Simon Zünd <szuend@chromium.org> Reviewed-by: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#61197}
-
- 02 May, 2019 2 commits
-
-
Johannes Henkel authored
This reverts commit b7134d3a. Reason for revert: breaks presubmit Original change's description: > [DevTools] Add V8InspectorSession::state(), which returns binary (CBOR). > > Keep the existing method for compatibility, by converting > to json from CBOR using the inspector_protocol_encoding library, > via a v8 specific interface library that directs routines for > converting between strings and doubles to v8's implementations. > > This change also brings in the encoding.h / encoding.cc files from the > upstream inspector_protocol project. The only modification here > are the header guards, and the namespace. I will fix roll.py to > make it so that we pick up future changes. > > third_party/inspector_protocol/BUILD.gn is specific to v8, by necessity. > third_party/inspector_protocol/.clang-format is a copy of the upstream > file. If we don't put this, we'll find ourselves auto-formatting the roll, > which is annoying. > > Change-Id: I20fa8759164e7a39f8a7c30e0d2a3f8a7e4be227 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1590627 > Reviewed-by: Alexei Filippov <alph@chromium.org> > Reviewed-by: Dmitry Gozman <dgozman@chromium.org> > Commit-Queue: Johannes Henkel <johannes@chromium.org> > Cr-Commit-Position: refs/heads/master@{#61187} TBR=dgozman@chromium.org,alph@chromium.org,caseq@chromium.org,johannes@chromium.org Change-Id: I67f297ef8454499036c94bf88e0d23657a579140 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1592130Reviewed-by: Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Johannes Henkel <johannes@chromium.org> Cr-Commit-Position: refs/heads/master@{#61189}
-
Johannes Henkel authored
Keep the existing method for compatibility, by converting to json from CBOR using the inspector_protocol_encoding library, via a v8 specific interface library that directs routines for converting between strings and doubles to v8's implementations. This change also brings in the encoding.h / encoding.cc files from the upstream inspector_protocol project. The only modification here are the header guards, and the namespace. I will fix roll.py to make it so that we pick up future changes. third_party/inspector_protocol/BUILD.gn is specific to v8, by necessity. third_party/inspector_protocol/.clang-format is a copy of the upstream file. If we don't put this, we'll find ourselves auto-formatting the roll, which is annoying. Change-Id: I20fa8759164e7a39f8a7c30e0d2a3f8a7e4be227 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1590627Reviewed-by: Alexei Filippov <alph@chromium.org> Reviewed-by: Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Johannes Henkel <johannes@chromium.org> Cr-Commit-Position: refs/heads/master@{#61187}
-
- 25 Apr, 2019 1 commit
-
-
Dave Tapuska authored
An additional wpt test (console-label-conversion.any.js) verifies that calling toString will cause exception propagation. Remove the TryCatch block. BUG=chromium:948257 R=dgozman@chromium.org Change-Id: Idaaf264b7675f7df8ead128c085ac4d4c044005d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1579541 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by: Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#61023}
-
- 03 Apr, 2019 1 commit
-
-
Dave Tapuska authored
Just rely on calling toString. This matches other vendor's implementations. BUG=chromium:948257 R=dgozman@chromium.org Change-Id: I325a12dd47712263a1ef4deee0bb2de9c4a1c656 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1545124Reviewed-by: Pavel Feldman <pfeldman@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#60617}
-
- 29 Mar, 2019 1 commit
-
-
Alexei Filippov authored
That saves some bytes on the frontend side and some cycles when generating and parsing protocol JSON for stacks. BUG=chromium:946411 Change-Id: I36b3a48b5d8246a05b877bc21f36c08803a1c304 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1542800 Commit-Queue: Alexei Filippov <alph@chromium.org> Reviewed-by: Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#60532}
-
- 16 Mar, 2019 1 commit
-
-
Alexei Filippov authored
This is a reland of 5a61630d Original change's description: > [inspector] Allow limiting the total size of collected scripts. > > Introduces the setMaxCollectedScriptsSize Debugger protocol method. > If the max size is set, the debugger will hold collected (not referenced by other v8 heap objects) > scripts up to the specified total size of their sources. > > BUG=v8:8988 > > Change-Id: I94d52866494102add91ca2d569a2044b08c9c593 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1518556 > Commit-Queue: Alexei Filippov <alph@chromium.org> > Reviewed-by: Dmitry Gozman <dgozman@chromium.org> > Cr-Commit-Position: refs/heads/master@{#60227} TBR=dgozman@chromium.org Bug: v8:8988 Change-Id: I9b1db01856a43636c1eb8ad2ec36e3727353228d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1524668 Commit-Queue: Alexei Filippov <alph@chromium.org> Reviewed-by: Pavel Feldman <pfeldman@chromium.org> Cr-Commit-Position: refs/heads/master@{#60271}
-
- 15 Mar, 2019 2 commits
-
-
Maya Lekova authored
This reverts commit ba00d8b7. Reason for revert: Breaks arm64 bots (native & simulator) - https://ci.chromium.org/p/v8/builders/ci/V8%20Linux%20-%20arm64%20-%20sim/17252 Original change's description: > Reland: [inspector] Allow limiting the total size of collected scripts. > > Introduces the setMaxCollectedScriptsSize Debugger protocol method. > If the max size is set, the debugger will hold collected (not referenced by other v8 heap objects) > scripts up to the specified total size of their sources. > > > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1518556 > > Commit-Queue: Alexei Filippov <alph@chromium.org> > > Reviewed-by: Dmitry Gozman <dgozman@chromium.org> > > BUG=v8:8988 > TBR=dgozman@chromium.org > > Change-Id: I6f7da07c4c9ae35b5252aabddb98b693ec77b4e8 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1524662 > Reviewed-by: Alexei Filippov <alph@chromium.org> > Commit-Queue: Alexei Filippov <alph@chromium.org> > Cr-Commit-Position: refs/heads/master@{#60255} TBR=dgozman@chromium.org,alph@chromium.org Change-Id: I04e3616d46620f33d0ec349fb7b0c393f276dc0c No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:8988 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1524484Reviewed-by: Maya Lekova <mslekova@chromium.org> Commit-Queue: Maya Lekova <mslekova@chromium.org> Cr-Commit-Position: refs/heads/master@{#60257}
-
Alexei Filippov authored
Introduces the setMaxCollectedScriptsSize Debugger protocol method. If the max size is set, the debugger will hold collected (not referenced by other v8 heap objects) scripts up to the specified total size of their sources. > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1518556 > Commit-Queue: Alexei Filippov <alph@chromium.org> > Reviewed-by: Dmitry Gozman <dgozman@chromium.org> BUG=v8:8988 TBR=dgozman@chromium.org Change-Id: I6f7da07c4c9ae35b5252aabddb98b693ec77b4e8 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1524662Reviewed-by: Alexei Filippov <alph@chromium.org> Commit-Queue: Alexei Filippov <alph@chromium.org> Cr-Commit-Position: refs/heads/master@{#60255}
-
- 14 Mar, 2019 2 commits
-
-
Maya Lekova authored
This reverts commit 5a61630d. Reason for revert: Breaking gc stress bot - https://ci.chromium.org/p/v8/builders/ci/V8%20Linux%20-%20gc%20stress/21477 Original change's description: > [inspector] Allow limiting the total size of collected scripts. > > Introduces the setMaxCollectedScriptsSize Debugger protocol method. > If the max size is set, the debugger will hold collected (not referenced by other v8 heap objects) > scripts up to the specified total size of their sources. > > BUG=v8:8988 > > Change-Id: I94d52866494102add91ca2d569a2044b08c9c593 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1518556 > Commit-Queue: Alexei Filippov <alph@chromium.org> > Reviewed-by: Dmitry Gozman <dgozman@chromium.org> > Cr-Commit-Position: refs/heads/master@{#60227} TBR=dgozman@chromium.org,alph@chromium.org,kozyatinskiy@chromium.org Change-Id: I26de645e425f0f7d5aa8212eeefda76dad695b78 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:8988 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1522988Reviewed-by: Maya Lekova <mslekova@chromium.org> Commit-Queue: Maya Lekova <mslekova@chromium.org> Cr-Commit-Position: refs/heads/master@{#60229}
-
Alexei Filippov authored
Introduces the setMaxCollectedScriptsSize Debugger protocol method. If the max size is set, the debugger will hold collected (not referenced by other v8 heap objects) scripts up to the specified total size of their sources. BUG=v8:8988 Change-Id: I94d52866494102add91ca2d569a2044b08c9c593 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1518556 Commit-Queue: Alexei Filippov <alph@chromium.org> Reviewed-by: Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#60227}
-
- 08 Mar, 2019 2 commits
-
-
Sathya Gunasekaran authored
This allows the devtools to preview the private fields that are installed on an object. Change-Id: I6d8aad7ad0e51cdf18f6139b4bb8665e4b606aa5 Bug: v8:8773, v8:8337 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1487914 Commit-Queue: Sathya Gunasekaran <gsathya@chromium.org> Reviewed-by: Alexei Filippov <alph@chromium.org> Reviewed-by: Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#60134}
-
Takuto Ikuta authored
inspector target has header come from protocol_generated_sources in sources. So protocol_generated_sources needs to be in public_deps. Bug: chromium:931596 Change-Id: I3b5ea390e79549b48930b16819840e1a0f87304b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1506994 Commit-Queue: Yang Guo <yangguo@chromium.org> Reviewed-by: Yang Guo <yangguo@chromium.org> Auto-Submit: Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#60125}
-
- 07 Mar, 2019 1 commit
-
-
Takuto Ikuta authored
Because string-util.h includes src/base/logging.h Bug: chromium:931596 Change-Id: Ia6f49ec4629471e8a4a20578c6073b47eab8c4df Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1507000 Auto-Submit: Takuto Ikuta <tikuta@chromium.org> Reviewed-by: Yang Guo <yangguo@chromium.org> Commit-Queue: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#60095}
-
- 06 Mar, 2019 1 commit
-
-
tzik authored
This adds overloads of v8::Isolate::{Add,Remove}MicrotaskCompletedCallback, that use MicrotasksCompletedCallbackWithData, and marks the original one as V8_DEPRECATE_SOON for transition. Bug: v8:8124 Change-Id: I124c3108545e1a2b29cd95620f36901431663c65 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1493766Reviewed-by: Yang Guo <yangguo@chromium.org> Commit-Queue: Taiju Tsuiki <tzik@chromium.org> Cr-Commit-Position: refs/heads/master@{#60045}
-
- 01 Mar, 2019 1 commit
-
-
Johannes Henkel authored
... to b13e24ccee66d7e0590ce1266db9c906e3648561 to support UTF16 strings with binary protocol (v8). Original review here: https://chromium-review.googlesource.com/c/deps/inspector_protocol/+/1493312 Change-Id: I401c5d52d233805dc681bb23b40df99f2ea14992 Reviewed-on: https://chromium-review.googlesource.com/c/1493291 Commit-Queue: Johannes Henkel <johannes@chromium.org> Reviewed-by: Pavel Feldman <pfeldman@chromium.org> Cr-Commit-Position: refs/heads/master@{#59956}
-
- 27 Feb, 2019 4 commits
-
-
Alexei Filippov authored
Change-Id: I1863f9d93ed36956f0c66540df4f44ecd809b5e8 Reviewed-on: https://chromium-review.googlesource.com/c/1492516Reviewed-by: Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Alexei Filippov <alph@chromium.org> Cr-Commit-Position: refs/heads/master@{#59926}
-
Sathya Gunasekaran authored
This will allow the devtools UI to display private fields on the scope panel. Instead of extending GetInternalProperties, we expose a separate GetPrivateFields method on the debug interface. This allows us to do better type checking, for example, we can directly cast to a v8::Private as this can only contain private fields. This also allows us to have better constraints on the input type -- v8::Object, as opposed to a v8::Value. The KeyAccumulator is extended to collect private names for the PRIVATE_NAMES_ONLY PropertyFilter. Bug: v8:8773 Change-Id: Id47c551186c59dae9a06721074ef78144f25892f Reviewed-on: https://chromium-review.googlesource.com/c/1475664 Commit-Queue: Sathya Gunasekaran <gsathya@chromium.org> Reviewed-by: Yang Guo <yangguo@chromium.org> Reviewed-by: Dmitry Gozman <dgozman@chromium.org> Reviewed-by: Daniel Ehrenberg <littledan@chromium.org> Cr-Commit-Position: refs/heads/master@{#59920}
-
Raphael Kubo da Costa authored
This fixes the libstdc++ build after commit 4b6b8cf6 ("[cleanup] Start cleaning up utils.h"), as string-util.cc was including <cmath> indirectly via src/conversions.h. Bug: chromium:819294 Change-Id: I5be7eac355d0c316a432eab4c50ae66d885b03d7 Reviewed-on: https://chromium-review.googlesource.com/c/1491591Reviewed-by: Sigurd Schneider <sigurds@chromium.org> Reviewed-by: Yang Guo <yangguo@chromium.org> Commit-Queue: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#59905}
-
Maya Lekova authored
Moved CoverageMode and TypeProfileMode enums to interface-types.h to save one include in isolate.h. This reduces the expanded lines of code count by ~45k. Bug: v8:8834 R=yangguo@chromium.org Change-Id: I399fe8cf66b1aec79bcb5831afd46a74e358244d Reviewed-on: https://chromium-review.googlesource.com/c/1489072Reviewed-by: Yang Guo <yangguo@chromium.org> Commit-Queue: Maya Lekova <mslekova@chromium.org> Cr-Commit-Position: refs/heads/master@{#59886}
-
- 26 Feb, 2019 2 commits
-
-
Alexei Filippov authored
The master protocol description file is js_protocol.pdl, not .json TBR=yangguo@chromium.org Change-Id: Ibaef314a63c3e1665ed56bc8c66ca18a00c7fd4f Reviewed-on: https://chromium-review.googlesource.com/c/1489976Reviewed-by: Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Alexei Filippov <alph@chromium.org> Cr-Commit-Position: refs/heads/master@{#59882}
-
Sigurd Schneider authored
Remove EmbeddedVector from utils.h Bug: v8:8834, v8:8912 Change-Id: I04e9f12121757bd0b87c68d7a4a5b213c2d8b686 Reviewed-on: https://chromium-review.googlesource.com/c/1486473Reviewed-by: Yang Guo <yangguo@chromium.org> Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#59854}
-
- 25 Feb, 2019 1 commit
-
-
Anna Henningsen authored
Do not leak handles to the outer scopes from inspector methods. Add `SealHandleScope`s to the tests and the d8 binding, and `HandleScope`s in the places in the inspector source where handles are actually used. Change-Id: I80b1bb0ccc4778b32e9198513f63d5c0652c8f59 Reviewed-on: https://chromium-review.googlesource.com/c/1484304Reviewed-by: Yang Guo <yangguo@chromium.org> Commit-Queue: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#59812}
-
- 16 Feb, 2019 1 commit
-
-
Andrey Kosyakov authored
DevTools protocol is not supposed to carry structurally invalid utf8 as string payload. Bug: chromium:929862 Change-Id: I701eeb553e6bf22d887947dcd9f4b29af7a43e2b Reviewed-on: https://chromium-review.googlesource.com/c/1475665Reviewed-by: Pavel Feldman <pfeldman@chromium.org> Reviewed-by: Alexei Filippov <alph@chromium.org> Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#59643}
-
- 15 Feb, 2019 2 commits
-
-
Sigurd Schneider authored
This is a step towards making gn check pass on v8 without third_party Change-Id: I6a256d65159695e2ba2a5d44c0437cac9b28aa3a Bug: v8:8834, v8:8855 Reviewed-on: https://chromium-review.googlesource.com/c/1475460Reviewed-by: Yang Guo <yangguo@chromium.org> Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#59641}
-
Sigurd Schneider authored
Change-Id: I43efddcbd381be3d61deb94515842e582069ffb9 Bug: v8:8834 Reviewed-on: https://chromium-review.googlesource.com/c/1475465Reviewed-by: Yang Guo <yangguo@chromium.org> Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#59640}
-
- 14 Feb, 2019 2 commits
-
-
Andrey Kosyakov authored
... to revision c40253f87c475880d1bdad4a90cf21c38dadf4ac Also, preseve binary protocol when restoring session. Bug: chromium:929862 Change-Id: Icb1cb04b42ca7238b46e2978337b36e32398665f Reviewed-on: https://chromium-review.googlesource.com/c/1474556 Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Pavel Feldman <pfeldman@chromium.org> Reviewed-by: Pavel Feldman <pfeldman@chromium.org> Cr-Commit-Position: refs/heads/master@{#59614}
-
Johannes Henkel authored
... to ec358ccfd63a2a657c147329c7793d217e278a58. This adds support for CBOR <-> Value. v8 changes: - Add StringUTF8Adapter (from Pavel's change) - Add Binary::fromSpan (needed for the cbor->BinaryValue conversion). Change-Id: I09746dc361df0b150b23697a20b287613558c003 Reviewed-on: https://chromium-review.googlesource.com/c/1470955 Commit-Queue: Pavel Feldman <pfeldman@chromium.org> Reviewed-by: Pavel Feldman <pfeldman@chromium.org> Cr-Commit-Position: refs/heads/master@{#59583}
-