- 09 Mar, 2017 18 commits
-
-
yangguo authored
We used to embed a string address as description right after a stop instruction, which the simulator would read and print. We removed that a while ago to make the snapshot predictable. R=petermarshall@chromium.org BUG=v8:6071 Review-Url: https://codereview.chromium.org/2744503003 Cr-Commit-Position: refs/heads/master@{#43698}
-
yangguo authored
R=vogelheim@chromium.org BUG=v8:6072 Review-Url: https://codereview.chromium.org/2738213002 Cr-Commit-Position: refs/heads/master@{#43697}
-
Michael Lippautz authored
We need to check whether advancing the iterator moved us beyong the end of the bitmap. This has not been flushed out as our inlined bitmap is still in valid memory. In practice this is not a problem because the value is never used as we are at the end of the bitmap. Asan rightfully complains when using an external bitmap though. BUG=chromium:651354 Change-Id: I8b141a467e9552f8ac2287dd62a725a14a289a37 Reviewed-on: https://chromium-review.googlesource.com/452497Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
Hannes Payer <hpayer@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#43696}
-
jkummerow authored
Review-Url: https://codereview.chromium.org/2734323004 Cr-Commit-Position: refs/heads/master@{#43695}
-
Michael Achenbach authored
BUG=chromium:682617 NOTRY=true R=mvstanton@chromium.org,petermarshall@chromium.org Change-Id: I5902c4ac3c8fb4230142896addbb75a9e7d28fbb Reviewed-on: https://chromium-review.googlesource.com/451378Reviewed-by:
Michael Stanton <mvstanton@chromium.org> Reviewed-by:
Peter Marshall <petermarshall@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#43694}
-
Igor Sheludko authored
BUG=v8:5495 Change-Id: I731ddaa34169f6f57d3719e6170bfe00e6d66241 Reviewed-on: https://chromium-review.googlesource.com/451638 Commit-Queue: Igor Sheludko <ishell@chromium.org> Reviewed-by:
Toon Verwaest <verwaest@chromium.org> Cr-Commit-Position: refs/heads/master@{#43693}
-
yangguo authored
And a drive-by clean up of unused flag. R=jgruber@chromium.org BUG=v8:5530 Review-Url: https://codereview.chromium.org/2744553002 Cr-Commit-Position: refs/heads/master@{#43692}
-
Igor Sheludko authored
BUG=chromium:686010 Change-Id: I7bd4ab48f90a1013132bf037fd352ab55747189c Reviewed-on: https://chromium-review.googlesource.com/451377 Commit-Queue: Igor Sheludko <ishell@chromium.org> Reviewed-by:
Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#43691}
-
yangguo authored
R=ishell@chromium.org BUG=v8:6071 Review-Url: https://codereview.chromium.org/2740073002 Cr-Commit-Position: refs/heads/master@{#43690}
-
Georg Neis authored
BUG= Change-Id: Ibf49df830153a829015723826dacc6939fb42189 Reviewed-on: https://chromium-review.googlesource.com/452377Reviewed-by:
-
yangguo authored
We actually do want to make changes in debug-evaluate stick. R=jgruber@chromium.org BUG=v8:6071 Review-Url: https://codereview.chromium.org/2743613002 Cr-Commit-Position: refs/heads/master@{#43688}
-
Igor Sheludko authored
It depends on constant field tracking and currently disabled. BUG=v8:5495 Change-Id: I6202cddfc2d32b5a06c5ab00c42caa6e276a3eb1 Reviewed-on: https://chromium-review.googlesource.com/451639 Commit-Queue: Igor Sheludko <ishell@chromium.org> Reviewed-by:
-
jgruber authored
This fixes an incorrect usage of String::Flatten in EscapeRegExpSource. It also adds %ConstructConsString (to easily and reliably construct cons strings in tests) and Factory::NewConsString (to enable guaranteed cons string construction without preemptive flattening attempts). BUG=chromium:698790 Review-Url: https://codereview.chromium.org/2736383003 Cr-Commit-Position: refs/heads/master@{#43686}
-
Camillo Bruni authored
- supporting appending new data instead of simply replacing the current set - fix issue when not filtering out groups on initial loading Change-Id: I77d508e644b247fa236ea64ef919639cac6ee425 NOTRY=true Change-Id: I77d508e644b247fa236ea64ef919639cac6ee425 Reviewed-on: https://chromium-review.googlesource.com/451276 Commit-Queue: Camillo Bruni <cbruni@chromium.org> Reviewed-by:
Jaroslav Sevcik <jarin@chromium.org> Cr-Commit-Position: refs/heads/master@{#43685}
-
mvstanton authored
_____ _ _ _ |_ _| (_) | (_) | | __ _ _ __ _| |_ _ ___ _ __ | | / _` | '_ \| | __| |/ _ \| '_ \ _| || (_| | | | | | |_| | (_) | | | | \___/\__, |_| |_|_|\__|_|\___/|_| |_| __/ | |___/ _ _| |_ |_ _| |_| _____ _ ______ |_ _| | | | ___| | |_ _ _ __| |__ ___ | |_ __ _ _ __ | | | | | '__| '_ \ / _ \| _/ _` | '_ \ | | |_| | | | |_) | (_) | || (_| | | | | \_/\__,_|_| |_.__/ \___/\_| \__,_|_| |_| BUG=v8:5267, v8:4280, chromium:692409 NOTREECHECKS=true Review-Url: https://codereview.chromium.org/2736723006 Cr-Original-Commit-Position: refs/heads/master@{#43663} Committed: https://chromium.googlesource.com/v8/v8/+/e7f8575851a0a56ffe6772d98fd8d90602e6876b Review-Url: https://codereview.chromium.org/2736723006 Cr-Commit-Position: refs/heads/master@{#43684} -
bmeurer authored
The BitcastWordToTagged operator is used for bump pointer allocation to construct the actual HeapObject pointer. The input to this operator is a naked pointer (derived from the allocation top). If this input value is live across an allocation, then the resulting tagged pointer is invalid because the GC might have scavenged new space in the meantime. That means we must not allow Node splitting (in the Scheduler) for these instructions, as that could extend the live range of the naked pointer input across arbitrary code. As such, this operator must not be marked as pure. R=jarin@chromium.org BUG=v8:6059 Review-Url: https://codereview.chromium.org/2739093002 Cr-Commit-Position: refs/heads/master@{#43683}
-
v8-autoroll authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/5f4c2a0..33b29e1 Rolling v8/third_party/catapult: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+log/299d02a..38ed490 Rolling v8/third_party/instrumented_libraries: https://chromium.googlesource.com/chromium/src/third_party/instrumented_libraries/+log/e905e0f..6227538 TBR=machenbach@chromium.org,vogelheim@chromium.org,hablich@chromium.org Change-Id: If7cb4e575b769ba2154845c421a5d6b30b9b8ecd Reviewed-on: https://chromium-review.googlesource.com/452157Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#43682}
-
bbudge authored
- Changes input filtering to test NaNs, but skip very large or very small inputs, which may cause imprecision on some platforms. - Changes expected result filtering to only skip NaNs. LOG=N BUG=6020 Review-Url: https://codereview.chromium.org/2738703006 Cr-Commit-Position: refs/heads/master@{#43681}
-
- 08 Mar, 2017 22 commits
-
-
bjaideep authored
Port 301c1237 R=binji@chromium.org, aseemgarg@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com BUG=v8:4614 LOG=N Review-Url: https://codereview.chromium.org/2733953004 Cr-Commit-Position: refs/heads/master@{#43680}
-
hpayer authored
BUG=chromium:694255 Review-Url: https://codereview.chromium.org/2492263002 Cr-Commit-Position: refs/heads/master@{#43679}
-
bjaideep authored
Port e82b7ccd Original Commit Message: I originally needed this for the initialization of a constexpr array in the wasm lazy compile builtin, but since it's a bigger change, I now split it off as this separate CL. The style guide recommends constexpr over const. I thus apply the constexprificaton over all headers that I touched anyway. I also remove the ARM64_DEFINE_REG_STATICS hack. It was introduced when merging in arm64 support more than three years ago, and I don't see the purpose for this. Also, some #defines can now be constexpr definitions, which was not possible before according to the comment. R=clemensh@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com BUG= LOG=N Review-Url: https://codereview.chromium.org/2733323003 Cr-Commit-Position: refs/heads/master@{#43678}
-
Ross McIlroy authored
The compiler dispatcher is not being used yet by Ignition, so we shouldn't enable it when enabling Ignition + TurboFan by default. Change-Id: I2806608ba95080df3538ef66373165107ac3beb6 Reviewed-on: https://chromium-review.googlesource.com/451279 Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Cr-Commit-Position: refs/heads/master@{#43677}
-
bjaideep authored
Port e1fde266 R=neis@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com BUG=v8:6048 LOG=N Review-Url: https://codereview.chromium.org/2739813002 Cr-Commit-Position: refs/heads/master@{#43676}
-
Michael Starzinger authored
This bumps the required stack space gap when the bootstrapper kicks off compilation of native scripts during genesis. The stack requirements are now higher for simulators in no-snapshot mode with Ignition being used. R=jochen@chromium.org TEST=mjsunit/regress/regress-681984 BUG=v8:6066 Change-Id: I65df388d1b57c09db124ac9a85d380b4edb7d260 Reviewed-on: https://chromium-review.googlesource.com/451275 Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Reviewed-by:
-
Ilija.Pavlovic authored
From declarations of bit() member functions (for structures Register, FPURegister and FPUControlRegister) are removed constexpr specificators. Build V8 will fail if function bit() is declared as a constant expression. TEST= BUG= Review-Url: https://codereview.chromium.org/2737143002 Cr-Commit-Position: refs/heads/master@{#43674}
-
leszeks authored
Adds a bar below the current timeline view which can show the time when an individual function was on the stack. Functions in the call stack are now clickable to show them in this view. Sections where the function was on the stack, but not at the top, are displayed at half height. Review-Url: https://codereview.chromium.org/2737083003 Cr-Commit-Position: refs/heads/master@{#43673}
-
Michael Starzinger authored
This fixes various allocator methods to properly propagate {nullptr} to callers without accidentally dereferencing it. We also disable one test case for stress mode as it runs out of memory due to inlining limits being lifted in the stress mode. R=bmeurer@chromium.org TEST=mjsunit/array-natives-elements BUG=v8:6061 Change-Id: Id0a7b826a8612d00b4f4ae8aa0bea011c50890ca Reviewed-on: https://chromium-review.googlesource.com/451365Reviewed-by:Benedikt Meurer <bmeurer@chromium.org> Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#43672}
-
bmeurer authored
The immediate passed to cmpw can be either a signed 16-bit or an unsigned 16-bit integer, but the DCHECK was testing for signed 16-bit values only. R=mstarzinger@chromium.org BUG=v8:6063 Review-Url: https://codereview.chromium.org/2735363002 Cr-Commit-Position: refs/heads/master@{#43671}
-
Michael Lippautz authored
Reuse the last LAB's unused area for further newspace allocation. This is relevant when we expect GCs that use evacuation to compact down new space to just live bytes for single tasks. BUG=chromium:651354 Change-Id: Ic418521d98f418a93d3748b824e3ddb6ff7a40c3 Reviewed-on: https://chromium-review.googlesource.com/451398 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
-
Michael Lippautz authored
Markbits should be verified in VerifyMarking and friends. The function may also be used then e.g. iterating just black objects while incremental marking is active for the fast promotion mode. BUG=chromium:694255 Change-Id: Ia719a983fec27b2bae03f8c6c3332003a10e8823 Reviewed-on: https://chromium-review.googlesource.com/451363Reviewed-by:
-
Jochen Eisinger authored
BUG=chromium:696464 R=yangguo@chromium.org Change-Id: Ie873e8af6af4dd95897f5f85e0eac5a350f59b32 Reviewed-on: https://chromium-review.googlesource.com/449714Reviewed-by:
-
Georg Neis authored
BUG= Change-Id: I7aed8e7bd35f59196b1b178942355aef4c97bca8 Reviewed-on: https://chromium-review.googlesource.com/451379Reviewed-by:
-
cwhan.tunz authored
BUG=v8:5953 Review-Url: https://codereview.chromium.org/2733393002 Cr-Commit-Position: refs/heads/master@{#43666}
-
Michael Lippautz authored
BUG=chromium:651354 Change-Id: Iaa2be2504474842d101f19fa2f6c15baa88544c6 Reviewed-on: https://chromium-review.googlesource.com/451497Reviewed-by:
-
machenbach authored
Revert of Turn on Ignition + TurboFan. (patchset #2 id:20001 of https://codereview.chromium.org/2736723006/ ) Reason for revert: Collected enough test failures: http://crbug.com/698746 Original issue's description: > Turn on Ignition + TurboFan. > > _____ _ _ _ > |_ _| (_) | (_) > | | __ _ _ __ _| |_ _ ___ _ __ > | | / _` | '_ \| | __| |/ _ \| '_ \ > _| || (_| | | | | | |_| | (_) | | | | > \___/\__, |_| |_|_|\__|_|\___/|_| |_| > __/ | > |___/ > > _ > _| |_ > |_ _| > |_| > > > > _____ _ ______ > |_ _| | | | ___| > | |_ _ _ __| |__ ___ | |_ __ _ _ __ > | | | | | '__| '_ \ / _ \| _/ _` | '_ \ > | | |_| | | | |_) | (_) | || (_| | | | | > \_/\__,_|_| |_.__/ \___/\_| \__,_|_| |_| > > > BUG=v8:5267, v8:4280, chromium:692409 > NOTREECHECKS=true > > Review-Url: https://codereview.chromium.org/2736723006 > Cr-Commit-Position: refs/heads/master@{#43663} > Committed: https://chromium.googlesource.com/v8/v8/+/e7f8575851a0a56ffe6772d98fd8d90602e6876b TBR=mstarzinger@chromium.org,danno@chromium.org,bmeurer@chromium.org,rmcilroy@chromium.org,mvstanton@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:5267, v8:4280, chromium:692409 Review-Url: https://codereview.chromium.org/2732113005 Cr-Commit-Position: refs/heads/master@{#43664}
-
mvstanton authored
_____ _ _ _ |_ _| (_) | (_) | | __ _ _ __ _| |_ _ ___ _ __ | | / _` | '_ \| | __| |/ _ \| '_ \ _| || (_| | | | | | |_| | (_) | | | | \___/\__, |_| |_|_|\__|_|\___/|_| |_| __/ | |___/ _ _| |_ |_ _| |_| _____ _ ______ |_ _| | | | ___| | |_ _ _ __| |__ ___ | |_ __ _ _ __ | | | | | '__| '_ \ / _ \| _/ _` | '_ \ | | |_| | | | |_) | (_) | || (_| | | | | \_/\__,_|_| |_.__/ \___/\_| \__,_|_| |_| BUG=v8:5267, v8:4280, chromium:692409 NOTREECHECKS=true Review-Url: https://codereview.chromium.org/2736723006 Cr-Commit-Position: refs/heads/master@{#43663} -
yangguo authored
R=caseq@chromium.org, pfeldman@chromium.org BUG=v8:5808 Review-Url: https://codereview.chromium.org/2733783002 Cr-Commit-Position: refs/heads/master@{#43662}
-
jarin authored
This introduces a new truncation bit for truncation of minus-zero to zero. At the moment it is only used to handle the limit cases of deopt, such as the one in the Google maps workload (see simplified version below), where the -q (which is desugared to q * -1.0) currently deoptimizes because the result would produce minus zero. To handle this situation, we exploit the knowledge that righthand side of + cannot be -0, so even if lefthand side was -0, the result would still be 0 (so the + operation cannot distinguish between left hand side 0 and -0). function f(q) { q -= 4; return (-q) + q; } f(10); f(10); %OptimizeFunctionOnNextCall(f); f(4); Review-Url: https://codereview.chromium.org/2734253002 Cr-Commit-Position: refs/heads/master@{#43661} -
bmeurer authored
For nodes NumberMin(lhs, rhs) NumberMax(lhs, rhs) we might have feedback types for lhs and rhs that would allow us to generate unsigned32 or signed32 versions of this operator, which is way more efficient that going to the full Float64Min/Float64Max operator. However we cannot promise word32 truncations in this case, since we based this decision on the feedback types. This allows us to generate better code for Math.min and Math.max when one of the inputs is a speculative number operator that provides better typing during representation selection. We've seen such code in the hottest function on Google Maps for example. BUG=v8:5267 R=jarin@chromium.org,mvstanton@chromium.org Review-Url: https://codereview.chromium.org/2734193003 Cr-Commit-Position: refs/heads/master@{#43660}
-
v8-autoroll authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/789a49b..5f4c2a0 Rolling v8/third_party/catapult: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+log/353ee60..299d02a Rolling v8/third_party/instrumented_libraries: https://chromium.googlesource.com/chromium/src/third_party/instrumented_libraries/+log/f68b0bb..e905e0f TBR=machenbach@chromium.org,vogelheim@chromium.org,hablich@chromium.org Change-Id: I4ea92a14f0533e39cc4ec1cf556e4cb8480d0d13 Reviewed-on: https://chromium-review.googlesource.com/450761Reviewed-by:
-
