- 07 Jul, 2022 26 commits
-
-
Michael Lippautz authored
Parallel marking is running at the beginning of the atomic pause, so the extraction of these objects must happen atomically. Bug: v8:13045 Change-Id: I90d489597847e76ade7185cd7120816eddcdc9fe Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3749204Reviewed-by:
Omer Katz <omerkatz@chromium.org> Commit-Queue: Omer Katz <omerkatz@chromium.org> Auto-Submit: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/main@{#81593}
-
Toon Verwaest authored
Now that we have block-lists this isn't strictly necessary anymore. As a side-effect, AllocateRegister for results now can't use registers used as inputs anymore either. We could explicitly use FreeSomeRegister without blocklist in that case, but this CL doesn't do that yet. Bug: v8:7700 Change-Id: If4aef1face138e528dc4f8da674326805e4af67c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3749194 Auto-Submit: Toon Verwaest <verwaest@chromium.org> Reviewed-by:
Leszek Swirski <leszeks@chromium.org> Commit-Queue: Toon Verwaest <verwaest@chromium.org> Cr-Commit-Position: refs/heads/main@{#81592}
-
Jakob Kummerow authored
Either the whole module or a single function: $ out/x64.release/wami my_module.wasm --single-wat 42 $ out/x64.release/wami my_module.wasm --full-wat Change-Id: Ifa1088a78bb6f86427074806b05226c4bf583b9a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3747677 Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by:
Manos Koukoutos <manoskouk@chromium.org> Cr-Commit-Position: refs/heads/main@{#81591}
-
Michael Lippautz authored
Merging typed slots in the marking barrier may require allocating a new typed slots set. We need a CodePageHeaderModificationScope since that slot set is actually written into the code page. Bug: chromium:1336850, v8:12797 Change-Id: If3f7d2bb179c2554ea2888c5ad92f098bd29b1c5 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3751210Reviewed-by:
Igor Sheludko <ishell@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/main@{#81590}
-
Michael Achenbach authored
Bug: v8:13005 Change-Id: I25f44231d936d7b3688898e6941d3877f31fafd3 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3751205 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by:
-
Michael Achenbach authored
No-Try: true Bug: v8:13005 Change-Id: I940d78696885f94afee8b6222b439227b22a3ea5 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3751209 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by:
Liviu Rau <liviurau@chromium.org> Cr-Commit-Position: refs/heads/main@{#81588}
-
Michael Achenbach authored
The test mjsunit/wasm/shared-memory-worker-gc is too slow on the gcov bot. No-Try: true Bug: v8:13005 Change-Id: Idac2a6df836c981195d61f9c2737c06d548edb28 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3751204 Auto-Submit: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Leszek Swirski <leszeks@chromium.org> Reviewed-by:
-
Milad Fa authored
Port 1f16e67b Original Commit Message: Mostly src/codegen, src/compiler, src/snapshot, src/utils. R=manoskouk@chromium.org, joransiu@ca.ibm.com, junyan@redhat.com, midawson@redhat.com BUG= LOG=N Change-Id: I8d3c2296aa82332e854ba6c3c8f99346d9561168 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3749827 Commit-Queue: Milad Farazmand <mfarazma@redhat.com> Reviewed-by:
Junliang Yan <junyan@redhat.com> Cr-Commit-Position: refs/heads/main@{#81586}
-
v8-ci-autoroll-builder authored
Rolling v8/third_party/google_benchmark/src: https://chromium.googlesource.com/external/github.com/google/benchmark/+log/7280499..ac8a6d3 cleanup comments (Dominic Hamon) https://chromium.googlesource.com/external/github.com/google/benchmark/+/ac8a6d3 fix sanitizer builds by using clang 13 (#1426) (Dominic Hamon) https://chromium.googlesource.com/external/github.com/google/benchmark/+/8205547 fix dependabot numpy version warning (Dominic Hamon) https://chromium.googlesource.com/external/github.com/google/benchmark/+/0a95a42 fix cmake warning for libcxx setup (Dominic Hamon) https://chromium.googlesource.com/external/github.com/google/benchmark/+/a8bc318 Expose default help printer function (#1425) (Yuri Khan) https://chromium.googlesource.com/external/github.com/google/benchmark/+/4136c4a Fix DoNotOptimize() GCC compile error with some types (#1340) (#1424) (Alexander Popov) https://chromium.googlesource.com/external/github.com/google/benchmark/+/dfdda57 R=v8-waterfall-sheriff@grotations.appspotmail.com,mtv-sf-v8-sheriff@grotations.appspotmail.com,mlippautz@chromium.org Change-Id: I3e08e9e4f0374c836b9fb96d80feff125664589f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3750518 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/main@{#81585}
-
Jakob Kummerow authored
DevTools needs this. Bug: v8:12917 Change-Id: Id63f290ebc9eff4ab87e88b97d81ae4d5ac3283a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3747676Reviewed-by:
-
Darius M authored
Bug: v8:12783 Change-Id: I5495aac4213b0f9783b5e239b2d90047d25552d8 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3721497 Commit-Queue: Darius Mercadier <dmercadier@chromium.org> Reviewed-by:
Tobias Tebbi <tebbi@chromium.org> Cr-Commit-Position: refs/heads/main@{#81583}
-
Andy Wingo authored
See https://github.com/WebAssembly/stringref/issues/24. Bug: v8:12868 Change-Id: Ib3854625aa18ae0e59f8d62d04e7132ca7381f60 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3749179 Commit-Queue: Andy Wingo <wingo@igalia.com> Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/main@{#81582}
-
Ben Noordhuis authored
std::is_same is the wrong predicate to use because `unsigned long` need not be equivalent to either `unsigned int` or `unsigned long long`. Fixes: https://github.com/nodejs/node-v8/issues/229 Bug: v8:12982 Change-Id: Iafff3c6a33f841490fa66d48649d24f720c869f1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3749192 Auto-Submit: Ben Noordhuis <info@bnoordhuis.nl> Commit-Queue: Tobias Tebbi <tebbi@chromium.org> Commit-Queue: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-by:
Darius Mercadier <dmercadier@chromium.org> Reviewed-by:
-
Leszek Swirski authored
Refactor register saving (both general and double registers) as using a PushAll helper taking a RegList. Change-Id: I0ccdec091f60988cbdb6893eb9cdda11efd8e1eb Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3749176 Auto-Submit: Leszek Swirski <leszeks@chromium.org> Reviewed-by:
-
Samuel Groß authored
This field points to the start of an ArrayBuffer backing store, which is guaranteed to be located inside the sandbox if it is enabled. As such, this simply turns the field into a sandboxed pointer field. Bug: chromium:1342548 Change-Id: I5a76e23cfc83b2a04cd461def1cd04337ccf5cf7 Cq-Include-Trybots: luci.v8.try:v8_linux64_heap_sandbox_dbg_ng,v8_linux_arm64_sim_heap_sandbox_dbg_ng Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3749190Reviewed-by:
Clemens Backes <clemensb@chromium.org> Commit-Queue: Samuel Groß <saelo@chromium.org> Cr-Commit-Position: refs/heads/main@{#81579}
-
Samuel Groß authored
Page allocation in a partially-reserved sandbox is generally best-effort once the reserved part is fully allocated, which happens in this test. As such, there is no guarantee that this test succeeds, and it does seem to fail in practice on some bots with memory sanitizers enabled. The same logic is essentially tested by the VirtualAddressSpaceTest.TestEmulatedSubspace test so simply deleting this test should be fine. Bug: v8:13040 Change-Id: I1469bd9d2e330a6e834bb565ce4e7f5985be28a9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3749180Reviewed-by:
-
Clemens Backes authored
Instead of just failing with a CHECK failure, do print the actual cycle. Before: # Check failed: iteration++ < 1000. After: # Cycle in flag implications: --assert-types -> --no-concurrent-recompilation --stress-concurrent-inlining -> --concurrent-recompilation R=tebbi@chromium.org Bug: chromium:1336577 Change-Id: I9707fbe19fbc3c27b54cf2ef7626a5f8825e8c60 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3707275 Commit-Queue: Clemens Backes <clemensb@chromium.org> Reviewed-by:
-
Toon Verwaest authored
To implement this, this cl introduces explicit check smi/heapobject nodes that we use for the value (and also separate from CheckMaps now). This will allow us to remove duplicate checks later. The performance of StoreField itself isn't vastly better due to fixed register requirements though. Bug: v8:7700 Change-Id: I98caa290c88be64f41154fd232bde98fb46ce497 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3747870 Commit-Queue: Toon Verwaest <verwaest@chromium.org> Reviewed-by:
-
Manos Koukoutos authored
Mostly src/codegen, src/compiler, src/snapshot, src/utils. Bug: v8:13006 Change-Id: I2fb31acc749a7376e6f2a7424ed2e67ff479d971 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3749178 Commit-Queue: Manos Koukoutos <manoskouk@chromium.org> Reviewed-by:
Toon Verwaest <verwaest@chromium.org> Cr-Commit-Position: refs/heads/main@{#81575}
-
Manos Koukoutos authored
Bug: v8:7748 Change-Id: I8da40c9443747ec8004ec78f0b1f82b83535944e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3749181 Commit-Queue: Manos Koukoutos <manoskouk@chromium.org> Reviewed-by:
Maya Lekova <mslekova@chromium.org> Cr-Commit-Position: refs/heads/main@{#81574}
-
Paul Semel authored
This adds support for a better error message when wasm code generation is not allowed. Chrome will use this new API here: https://chromium-review.googlesource.com/c/chromium/src/+/3738183. Bug: chromium:1255058 Change-Id: I8c9639c4fd08d1dff0a5a2fc6a8360f40a7e140e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3740721Reviewed-by:
-
Andy Wingo authored
See https://github.com/WebAssembly/stringref/pull/32. Bug: v8:12868 Change-Id: Ia804809b01eb06163c4477b3f06ac09e016b6277 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3747875Reviewed-by:
-
Andy Wingo authored
See https://github.com/WebAssembly/stringref/pull/31. Bug: v8:12868 Change-Id: Iefe6b8e6c1b6f2eed8a2aca1818d5edbf6ab48ae Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3747874 Commit-Queue: Andy Wingo <wingo@igalia.com> Reviewed-by:
-
Andy Wingo authored
See https://github.com/WebAssembly/stringref/pull/29. Bug: v8:12868 Change-Id: I5a1e3662a7c3457c6835d7dfccf3a1583ef49f2a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3747873 Commit-Queue: Andy Wingo <wingo@igalia.com> Reviewed-by:
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/f855a2b..ea8947a Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/c8f1e5e..8bd72d6 R=v8-waterfall-sheriff@grotations.appspotmail.com,mtv-sf-v8-sheriff@grotations.appspotmail.com Change-Id: I6a322050d37383935b05174fda14b0ee2b6c7627 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3750517 Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#81569}
-
v8-ci-autoroll-builder authored
Rolling v8/third_party/fuchsia-sdk/sdk: version:8.20220705.3.1..version:8.20220706.2.1 R=v8-waterfall-sheriff@grotations.appspotmail.com,mtv-sf-v8-sheriff@grotations.appspotmail.com Change-Id: I4e01266cbfacd70405ddaa228182872749fc7d36 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3750516 Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#81568}
-
- 06 Jul, 2022 14 commits
-
-
Dominic Cooney authored
Bug: v8:13004 Change-Id: I6b29094a7fcea75d46328e686961e7a1f25343fd Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3746216Reviewed-by:
Andreas Haas <ahaas@chromium.org> Commit-Queue: Dominic Cooney <dpc@fb.com> Reviewed-by:
-
Jakob Kummerow authored
Unused as of this CL; users will follow. Bug: v8:12917 Change-Id: I6c615fc53e782f7f00c8a20a00aabea08f3e4605 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3742699Reviewed-by:
-
Matthias Liedtke authored
with struct.new Bug: v8:7748 Change-Id: Icc4868910832556f4c31081fb4af336f492db28e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3747868Reviewed-by:
-
Leszek Swirski authored
Maglev groups all its tagged spill slots together, and the number of them doesn't change. This means that the generality of the existing safepoint mechanism is massive overkill for maglev code. This patch adds a maglev-specific safepoint table, which is the safepoint of a code object if-and-only-if that code object has maglev code. This safepoint stores the number of tagged and untagged slots once, globally, and individual entries are just used for deopts and for storing the state of pushed registers (this is currently unused, but will be used in the future for pushing registers in deferred calls). Bug: v8:7700 Change-Id: I15f84a6e957357825e84e33238f8a36f2e0b3012 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3747858 Commit-Queue: Leszek Swirski <leszeks@chromium.org> Reviewed-by:
-
Michael Achenbach authored
We don't build with bundled sysroot on gcc builders, hence we need to match the sysroot on tester bots. There is already a number of Focal bots in chromium.tests and the capacity needed for these gcc bots is insignificant. No-Try: true Bug: chromium:1307180 Change-Id: Id9d3d08bdb09923cf919b17286c949c6ac9005ed Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3747872Reviewed-by:
Alexander Schulze <alexschulze@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/main@{#81563}
-
Jakob Kummerow authored
We currently don't have a way to visit parameter stack slots being passed from Wasm to the runtime during GC, so while we usually access them as if they were handles, they're not actually GC-safe in this case. Until we find a way to fix this differently, force manual creation of safe handles. Bug: v8:13036 Change-Id: I9ffec58348d912bd56fb199e9d0bc90bf753b87c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3745372 Commit-Queue: Tobias Tebbi <tebbi@chromium.org> Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Auto-Submit: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by:
-
Michael Achenbach authored
Remove configs for bots that were removed. Dedicated focal bots and x86 gcc bots. Bug: chromium:1307180, v8:13005 Change-Id: I482829f6644642b3d9fe1b380b2a3edaba2045d4 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3747869Reviewed-by:
-
Shu-yu Guo authored
Change-Id: I7996f49f5358d8be684a39b64020bc6bef82b7bb Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3739228 Commit-Queue: Shu-yu Guo <syg@chromium.org> Reviewed-by:
-
Shu-yu Guo authored
Code in client heaps can embed pointers to shared objects. In non-shared GC, these pointers can be weak. During shared GC, unconditionally consider Code-embedded client->shared pointers as strong so we don't have to deoptimize and clear embedded objects in all client Isolates' Code instances. Bug: v8:13027 Change-Id: Id34d7e707153191639e8e531fc12d917b9382a26 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3739231Reviewed-by:
-
Andy Wingo authored
See https://github.com/WebAssembly/stringref/issues/1. Bug: v8:12868 Change-Id: Icd197b4872a72ae84878b2ac48a66f7026ab90cd Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3745369 Commit-Queue: Andy Wingo <wingo@igalia.com> Reviewed-by:
-
Joyee Cheung authored
When the failed access callback is configured but it doesn't throw, we should return instead of expecting an exception, otherwise it would crash because there isn't one. This patch also adds --throw-on-failed-access-check and --noop-on-failed-access-check in d8 to mimic the behavior of the failed access check callback in chromium. Bug: chromium:1339722 Change-Id: Ie1db9d2fb364c6f8259eb9b8d81a21071c280a80 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3737305 Commit-Queue: Joyee Cheung <joyee@igalia.com> Reviewed-by:
-
Manos Koukoutos authored
Mainly src/compiler-dispatcher, src/d8, src/debug, src/runtime. Drive-by: Restore CONDITIONAL_WRITE_BARRIER invocation, which was accidentally changed. Bug: v8:13006 Change-Id: If07334b654b9ba2d4bec14a11cfdeeb1aa953b7d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3745402 Commit-Queue: Manos Koukoutos <manoskouk@chromium.org> Reviewed-by:
-
Thibaud Michaud authored
Fix some issues with nested suspenders: - Fix scratch register conflict when returning from an inner suspender - The outer suspender should stay in 'Active' state - Suspenders should become 'Inactive' when they return CC=ahaas@chromium.org Bug: v8:12191 Change-Id: Ic6c6108c4f8df3d32417d7813eb04e0e2a46d27a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3743386Reviewed-by:
-
Clemens Backes authored
The streaming decoder did not properly check the ordering of sections relative to the code section. This CL fixes that for both empty and non-empty code sections. The special path for empty code sections is not actually needed, so remove it to simplify code paths. Drive-by: 1. Refactor the existing code for checking section ordering to make it more structured and readable. 2. Ensure that we either call {DecodeCodeSection} or {StartCodeSection}, but not both. 3. Remove {set_code_section}, merge it into {StartCodeSection}. 4. Simplify calls to {CalculateGlobalOffsets} (make them unconditional and remove one redundant one). R=ahaas@chromium.org Bug: chromium:1336380 Change-Id: Ia2c5c115d43d2b5315e3b3c9e4a21175a36aa326 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3747860Reviewed-by:
-
