- 07 Nov, 2016 12 commits
-
-
cbruni authored
Drive-by-fix 1: be more precise in machine representations for AllocateNameDictionary to make --turbo_verify_machine_graph happy. Drive-by-fix 2: Improve graph verifier output by printing input representation. BUG= Review-Url: https://codereview.chromium.org/2475913002 Cr-Commit-Position: refs/heads/master@{#40797}
-
cbruni authored
R=jkummerow@chromium.org BUG= Review-Url: https://codereview.chromium.org/2461993002 Cr-Commit-Position: refs/heads/master@{#40796}
-
neis authored
R=adamk@chromium.org BUG=v8:1569 Review-Url: https://codereview.chromium.org/2473993002 Cr-Commit-Position: refs/heads/master@{#40795}
-
jgruber authored
The test case did not test anything in its original form. Fix it and add documentation. BUG=v8:5339 Review-Url: https://codereview.chromium.org/2481733002 Cr-Commit-Position: refs/heads/master@{#40794}
-
yangguo authored
BUG=v8:5581 R=jgruber@chromium.org Review-Url: https://codereview.chromium.org/2469043003 Cr-Commit-Position: refs/heads/master@{#40793}
-
bmeurer authored
We need to rename the receiver on CheckHeapObject, because we don't canonicalize numbers in SignedSmall range, and thus we the representation selection can hand out TaggedSigned values for receiver uses, even though we checked for TaggedPointerness first. Note that this is rather hacky and just intended to fix the bug ASAP. We need to think about how to deal with representations in earlier compilation stages. BUG=chromium:662410 R=jarin@chromium.org Review-Url: https://codereview.chromium.org/2485563002 Cr-Commit-Position: refs/heads/master@{#40792}
-
ahaas authored
TBR=mtrofin@chromium.org NOTRY=true Review-Url: https://codereview.chromium.org/2481133002 Cr-Commit-Position: refs/heads/master@{#40791}
-
bmeurer authored
TBR=machenbach@chromium.org NOTRY=true Review-Url: https://codereview.chromium.org/2477303002 Cr-Commit-Position: refs/heads/master@{#40790}
-
yangguo authored
Using _exit on windows may cause race conditions in threads. BUG=chromium:603131 Review-Url: https://codereview.chromium.org/2478473003 Cr-Commit-Position: refs/heads/master@{#40789}
-
bmeurer authored
This adds support to track Float64 fields on 64-bit platforms, which is necessary to properly deal with unboxed double fields there. Drive-by-fix: Crash if we see Simd128 representation here. R=jarin@chromium.org BUG=v8:5608 Review-Url: https://codereview.chromium.org/2485543002 Cr-Commit-Position: refs/heads/master@{#40788}
-
bmeurer authored
In Crankshaft we unconditionally assume that accesses to arguments[i] will be in-bounds and don't take into account IC feedback that would eventually teach us about out-of-bounds accesses that have happened in the past, so there's no real guard to protect the bounds check in optimized code. TEST=mjsunit/compiler/deopt-arguments-oob R=jarin@chromium.org BUG=v8:5606 Review-Url: https://codereview.chromium.org/2481053002 Cr-Commit-Position: refs/heads/master@{#40787}
-
jing.bao authored
fix schedule viewing for text like 1756: HeapConstant[0x3ff62d29 <FixedArray[31]>] : HeapConstant(0x3ff62d29 <FixedArray[31]>) BUG= Review-Url: https://codereview.chromium.org/2471573007 Cr-Commit-Position: refs/heads/master@{#40786}
-
- 05 Nov, 2016 1 commit
-
-
machenbach authored
Revert of [Tracing] Use TracingCategoryObserver in gc statistics (patchset #5 id:100001 of https://codereview.chromium.org/2459903003/ ) Reason for revert: Speculative revert for blocking roll: https://codereview.chromium.org/2473003006/ E.g.: https://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/331898 Original issue's description: > [Tracing] Use TracingCategoryObserver in gc statistics > > This patch is a follow-up patch to enable gc statistics to use > TracingCategoryObserver. > > Previously we need to pass --track_gc_object_stats to v8 if we want to enable > gc statistics in tracing. In this patch, we introducce an integer flag > FLAG_gc_stats, and FLAG_track_gc_object_stats and FLAG_trace_gc_object_stats > will set it to 0x01, tracing will set it to 0x10 when we start tracing and > reset the bit when we stop tracing. > > BUG=v8:5590 TBR=fmeawad@chromium.org,mlippautz@chromium.org,lpy@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:5590 Review-Url: https://codereview.chromium.org/2477143002 Cr-Commit-Position: refs/heads/master@{#40785}
-
- 04 Nov, 2016 27 commits
-
-
kozyatinskiy authored
This roll includes: - [inspector_protocol] remove old style domains support - Add missing virtual destructor to backend callbacks. [2] [1] https://codereview.chromium.org/2479693002/ [2] https://codereview.chromium.org/2473393002/ BUG=none R=dgozman@chromium.org Review-Url: https://codereview.chromium.org/2478853002 Cr-Commit-Position: refs/heads/master@{#40784}
-
kozyatinskiy authored
This method iterates through all shared function info which are related to passed script, compiles debug code for SFI in range if needed and returns possible break locations. BUG=chromium:566801 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel Review-Url: https://codereview.chromium.org/2465553003 Cr-Commit-Position: refs/heads/master@{#40783}
-
kozyatinskiy authored
BUG=none R=dgozman@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel Review-Url: https://codereview.chromium.org/2471583003 Cr-Commit-Position: refs/heads/master@{#40782}
-
vogelheim authored
BUG=chromium:662388 Review-Url: https://codereview.chromium.org/2468423008 Cr-Commit-Position: refs/heads/master@{#40781}
-
adamk authored
The flag has been on since at least Chrome 53. R=littledan@chromium.org Review-Url: https://codereview.chromium.org/2478883002 Cr-Commit-Position: refs/heads/master@{#40780}
-
littledan authored
R=adamk@chromium.org BUG=v8:4806 Review-Url: https://codereview.chromium.org/2475383003 Cr-Commit-Position: refs/heads/master@{#40779}
-
littledan authored
This patch fixes two bugs in V8 to allow the global object to have a frozen proto: - The immutable prototype map check is done on the map of the "real receiver", the one that's found after the hidden prototype traversal, rather than the object that SetPrototype is called on. - The immutable prototype bit from the ObjectTemplate used to instantiate the global object, as passed to Context::New, is respected when instantiating the global object. R=adamk BUG=v8:5149 Review-Url: https://codereview.chromium.org/2474843003 Cr-Commit-Position: refs/heads/master@{#40778}
-
lpy authored
This patch is a follow-up patch to enable gc statistics to use TracingCategoryObserver. Previously we need to pass --track_gc_object_stats to v8 if we want to enable gc statistics in tracing. In this patch, we introducce an integer flag FLAG_gc_stats, and FLAG_track_gc_object_stats and FLAG_trace_gc_object_stats will set it to 0x01, tracing will set it to 0x10 when we start tracing and reset the bit when we stop tracing. BUG=v8:5590 Review-Url: https://codereview.chromium.org/2459903003 Cr-Commit-Position: refs/heads/master@{#40777}
-
mstarzinger authored
This removes the deprecated flag in question which has been enabled by default a while ago. All components can by now deal with activations of a single function being mixed between Ignition and other compilers. The maintenance overhead to support a mode that clears bytecode is no longer warranted. R=rmcilroy@chromium.org BUG=v8:4280 Review-Url: https://codereview.chromium.org/2475203003 Cr-Commit-Position: refs/heads/master@{#40776}
-
jbroman authored
Compatible with the current (unshipped) Blink implementation. BUG=chromium:148757 Review-Url: https://codereview.chromium.org/2471923002 Cr-Commit-Position: refs/heads/master@{#40775}
-
ziyang authored
Port 9b308dca R=jarin@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, bjaideep@ca.ibm.com, michael_dawson@ca.ibm.com, mbrandy@us.ibm.com BUG= Review-Url: https://codereview.chromium.org/2470043006 Cr-Commit-Position: refs/heads/master@{#40774}
-
mstarzinger authored
R=jarin@chromium.org TEST=mjsunit/regress/regress-crbug-662367 BUG=chromium:662367 Review-Url: https://codereview.chromium.org/2472413002 Cr-Commit-Position: refs/heads/master@{#40773}
-
ivica.bogosavljevic authored
If a HeapObject field is 8 bytes long and 8 bytes aligned, but we use only four bytes of it on little endian architectures we will access to lower 4 bytes of the field using the same base address as accessing the whole eight bytes On big-endian architectures however we use base address to access the full 8 bytes, but base address + 4 to access to lower 4 bytes. For this reason, the assert in OffsetForFieldAccess fails on MIPS64 big endian. We fix the issue by removing the assert that checks that offset is pointer size aligned. TEST=mjsunit/regress/regress-crbug-648737 BUG= Review-Url: https://codereview.chromium.org/2453333002 Cr-Commit-Position: refs/heads/master@{#40772}
-
verwaest authored
Parameters of a lazily parsed function used to be parsed eagerly, and parameter handling was split between Parser::ParseFunctionLiteral and ParseEagerFunctionBody, leading to inconsistencies. After this CL, we preparse (lazy parse) the parameters of lazily parsed functions. (For arrow functions, we cannot do that ofc.) This is needed for later features (PreParser with scope analysis). -- CL adapted from marja's https://codereview.chromium.org/2411793003/ BUG= Review-Url: https://codereview.chromium.org/2472063002 Cr-Commit-Position: refs/heads/master@{#40771}
-
henrique.ferreiro authored
This was removed from ECMAScript in the September 2016 TC39 meeting, see https://github.com/tc39/ecma262/issues/670. BUG=v8:5535 Review-Url: https://codereview.chromium.org/2430383004 Cr-Commit-Position: refs/heads/master@{#40770}
-
mlippautz authored
API was highly experimental. Embedders should use V8::RegisterExternalReference instead. BUG=chromium:468240 R=jochen@chromium.org Review-Url: https://codereview.chromium.org/2474163002 Cr-Commit-Position: refs/heads/master@{#40769}
-
yangguo authored
The old code path is going to be removed with the debug context api. R=kozyatinskiy@chromium.org Review-Url: https://codereview.chromium.org/2465833002 Cr-Commit-Position: refs/heads/master@{#40768}
-
predrag.rudic authored
Reason for the failure is that the test enumeration is 32-bit wide, whereas AtomicWord is 64-bit wide on 64-bit machines. On 64-big endian, this loads the random four bytes located after the 32-bit value that is tested. BUG= TEST=unittests/NoBarrierAtomicValue.Construction Review-Url: https://codereview.chromium.org/2464703003 Cr-Commit-Position: refs/heads/master@{#40767}
-
neis authored
- Remove (one version of) InterpreterAssembler::LoadContextSlot in favor of the identical CodeStubAssembler::LoadContextElement. - Use CodeStubAssembler::LoadNativeContext instead of doing the load manually. R=rmcilroy@chromium.org BUG= Review-Url: https://codereview.chromium.org/2470253003 Cr-Commit-Position: refs/heads/master@{#40766}
-
vogelheim authored
Some accessors requires little to no computation at all, its result can be cached in a private property, avoiding the call overhead. Calls to the getter are translated into a cheap property load. Follow-on to crrev.com/2347523003, from peterssen@google.com BUG=chromium:634276, v8:5548 Review-Url: https://codereview.chromium.org/2405213002 Cr-Commit-Position: refs/heads/master@{#40765}
-
machenbach authored
Revert of [debugger] simplify fetching scripts for inspector. (patchset #6 id:100001 of https://codereview.chromium.org/2465833002/ ) Reason for revert: https://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Linux%2064/builds/11118 Rule of thumb: As long as the tests have not migrated yet, you most certainly need a blink rebase whenever you change expectations. Original issue's description: > [debugger] simplify fetching scripts for inspector. > > The old code path is going to be removed with the debug context api. > > R=kozyatinskiy@chromium.org TBR=kozyatinskiy@chromium.org,yangguo@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review-Url: https://codereview.chromium.org/2473273005 Cr-Commit-Position: refs/heads/master@{#40764}
-
ivica.bogosavljevic authored
Fix 4447405b A typo in the patch caused failures on MIPS64. There were no failures on MIPS32, but I guess the same patch needs to be applied there as well. BUG= Review-Url: https://codereview.chromium.org/2473343002 Cr-Commit-Position: refs/heads/master@{#40763}
-
mythria authored
Some cleanup after the cl to fix --trace-ic to work with ignition (https://codereview.chromium.org/2405173007/). In GetSharedFunctionInfo, we used to skip the bytecode handler frame, which is no longer required. BUG=v8:4280 Review-Url: https://codereview.chromium.org/2437593003 Cr-Commit-Position: refs/heads/master@{#40762}
-
yangguo authored
This is no longer necessary. Isolates created for serialization have optimization disabled anyways. R=jkummerow@chromium.org Review-Url: https://codereview.chromium.org/2479823002 Cr-Commit-Position: refs/heads/master@{#40761}
-
mythria authored
When checking for marking a function for optimization, we had a check if the function is already optimized to return early. This works in non-OSR cases. For Turbofan OSR even when the current execution of the function has already been optimized, the function itself will not be replaced with optimized code. Hence, we may end up checking a function that is already marked for optimization again. A check for the frame being optimized avoids these checks. BUG= Review-Url: https://codereview.chromium.org/2450233002 Cr-Commit-Position: refs/heads/master@{#40760}
-
yangguo authored
The old code path is going to be removed with the debug context api. R=kozyatinskiy@chromium.org Review-Url: https://codereview.chromium.org/2465833002 Cr-Commit-Position: refs/heads/master@{#40759}
-
ivica.bogosavljevic authored
Port f07d2cdd Original commit message: A load instruction will implicitely clear the top 32 bits when writing to a W register. This patch avoids generating a `mov` instruction to zero-extend the result in this case. For example, this occurs in the generated code for dispatching to the next bytecode in the interpreter: kind = BYTECODE_HANDLER name = LdaZero compiler = turbofan Instructions (size = 36) 0x32e64c60 0 add x19, x19, #0x1 (1) 0x32e64c64 4 ldrb w0, [x20, x19] 0x32e64c68 8 mov w0, w0 ^^^^^^^^^^ 0x32e64c6c 12 lsl x0, x0, #3 0x32e64c70 16 ldr x1, [x21, x0] 0x32e64c74 20 movz x0, #0x0 0x32e64c78 24 br x1 Review-Url: https://codereview.chromium.org/2469253002 Cr-Commit-Position: refs/heads/master@{#40758}
-