• ivica.bogosavljevic's avatar
    MIPS64: Fix VirtualObject field offset calculation on Big-endian architectures · 84852475
    ivica.bogosavljevic authored
    If a HeapObject field is 8 bytes long and 8 bytes aligned, but we use only four bytes of it
    on little endian architectures we will access to lower 4 bytes of the field using the same
    base address as accessing the whole eight bytes
    On big-endian architectures however we use base address to access the full 8 bytes, but base
    address + 4 to access to lower 4 bytes. For this reason, the assert in OffsetForFieldAccess
    fails on MIPS64 big endian.
    We fix the issue by removing the assert that checks that offset is pointer size aligned.
    
    TEST=mjsunit/regress/regress-crbug-648737
    BUG=
    
    Review-Url: https://codereview.chromium.org/2453333002
    Cr-Commit-Position: refs/heads/master@{#40772}
    84852475
Name
Last commit
Last update
benchmarks Loading commit data...
build_overrides Loading commit data...
docs Loading commit data...
gni Loading commit data...
gypfiles Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
Makefile Loading commit data...
Makefile.android Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...
snapshot_toolchain.gni Loading commit data...