- 14 Dec, 2018 1 commit
-
-
peterwmwong authored
Enable --harmony-string-matchall by default. String.prototype.matchAll behaves similarly to String.prototype.match, but returns a full regexp result object for each match in a global or sticky regexp. This offers a simple way to iterate over matches when access to e.g. capture groups is needed. const string = 'a b c'; const regex = /[ac]/g; for (const match of string.matchAll(regex)) { console.log(`${match[0]} at ${match.index}`); } // a at 0 // c at 4 More information can be found here: https://github.com/tc39/proposal-string-matchall Drive-by: Update debug evaluate side effect expectations to handle String.p.matchAll and RegExp.p[@@matchAll] Bug: v8:6890 Change-Id: Ie3e712af66689936b7d2a15df705b792ccf06bd3 Reviewed-on: https://chromium-review.googlesource.com/c/1377774Reviewed-by: Mathias Bynens <mathias@chromium.org> Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org> Reviewed-by: Jakob Gruber <jgruber@chromium.org> Commit-Queue: Peter Wong <peter.wm.wong@gmail.com> Cr-Commit-Position: refs/heads/master@{#58250}
-
- 16 Oct, 2018 1 commit
-
-
peterwmwong authored
This also includes ports of Array.p.toString and Array.p.toLocaleString. Many parts of the old JS implementation are preserved, because TypedArray.p.join still relies on it. These will be removed once TypedArray.p.join is ported to Torque. To simplify implementation, special handling of extremely sparse arrays has been removed. Performance improvements vary by array size, elements, and sparse-ness. Some quick numbers and graphs are here: https://docs.google.com/spreadsheets/d/125VLmRMudk8XaomLCsZQ1ewc94WCqht-8GQwU3s9BW8/edit#gid=2087673710 Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;luci.v8.try:v8_linux_noi18n_rel_ng;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Ia4069a068403ce36676c37401d349aefc976b045 Reviewed-on: https://chromium-review.googlesource.com/c/1196693 Commit-Queue: Peter Wong <peter.wm.wong@gmail.com> Reviewed-by: Jakob Gruber <jgruber@chromium.org> Reviewed-by: Tobias Tebbi <tebbi@chromium.org> Cr-Commit-Position: refs/heads/master@{#56699}
-
- 27 Sep, 2018 1 commit
-
-
Creddy authored
This is a reland of eccf1867 Original change's description: > [interpreter] Separate bytecodes for one-shot property loads and stores > > Create LdaNamedPropertyNoFeedback and StaNamedPropertyNoFeedback > for one-shot property loads and stores. This CL replaces the runtime > calls with new bytecodes for named property load stores in one-shot code. > the runtime calls needed extra set of consecutive registers and > additional move instructions. This increased the size of > bytecode-array and possibly extended the life time of objects. > By replacing them with NoFeedback bytecodes we avoid these issues. > > Bug: v8:8072 > Change-Id: I20a38a5ce9940026171d870d354787fe0b7c5a6f > Reviewed-on: https://chromium-review.googlesource.com/1196725 > Reviewed-by: Ross McIlroy <rmcilroy@chromium.org> > Reviewed-by: Jaroslav Sevcik <jarin@chromium.org> > Reviewed-by: Yang Guo <yangguo@chromium.org> > Reviewed-by: Georg Neis <neis@chromium.org> > Commit-Queue: Chandan Reddy <chandanreddy@google.com> > Cr-Commit-Position: refs/heads/master@{#56211} Bug: v8:8072 Change-Id: Ie8e52b37daf35c7bc08bb910d7b15a9b783354e4 Reviewed-on: https://chromium-review.googlesource.com/1245742 Commit-Queue: Chandan Reddy <chandanreddy@google.com> Reviewed-by: Ross McIlroy <rmcilroy@chromium.org> Reviewed-by: Georg Neis <neis@chromium.org> Reviewed-by: Camillo Bruni <cbruni@chromium.org> Reviewed-by: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#56266}
-
- 26 Sep, 2018 1 commit
-
-
Maya Lekova authored
This reverts commit eccf1867. Reason for revert: Speculative revert because it seems to introduce a pretty stable flake on gc stress tests, see https://bugs.chromium.org/p/v8/issues/detail?id=8229 Original change's description: > [interpreter] Separate bytecodes for one-shot property loads and stores > > Create LdaNamedPropertyNoFeedback and StaNamedPropertyNoFeedback > for one-shot property loads and stores. This CL replaces the runtime > calls with new bytecodes for named property load stores in one-shot code. > the runtime calls needed extra set of consecutive registers and > additional move instructions. This increased the size of > bytecode-array and possibly extended the life time of objects. > By replacing them with NoFeedback bytecodes we avoid these issues. > > Bug: v8:8072 > Change-Id: I20a38a5ce9940026171d870d354787fe0b7c5a6f > Reviewed-on: https://chromium-review.googlesource.com/1196725 > Reviewed-by: Ross McIlroy <rmcilroy@chromium.org> > Reviewed-by: Jaroslav Sevcik <jarin@chromium.org> > Reviewed-by: Yang Guo <yangguo@chromium.org> > Reviewed-by: Georg Neis <neis@chromium.org> > Commit-Queue: Chandan Reddy <chandanreddy@google.com> > Cr-Commit-Position: refs/heads/master@{#56211} TBR=rmcilroy@chromium.org,yangguo@chromium.org,jarin@chromium.org,neis@chromium.org,cbruni@chromium.org,chandanreddy@google.com Change-Id: I445db58e6d4c275b434fabad5fad775bf259033f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:8072 Reviewed-on: https://chromium-review.googlesource.com/1245421Reviewed-by: Maya Lekova <mslekova@chromium.org> Commit-Queue: Maya Lekova <mslekova@chromium.org> Cr-Commit-Position: refs/heads/master@{#56232}
-
- 25 Sep, 2018 1 commit
-
-
Creddy authored
Create LdaNamedPropertyNoFeedback and StaNamedPropertyNoFeedback for one-shot property loads and stores. This CL replaces the runtime calls with new bytecodes for named property load stores in one-shot code. the runtime calls needed extra set of consecutive registers and additional move instructions. This increased the size of bytecode-array and possibly extended the life time of objects. By replacing them with NoFeedback bytecodes we avoid these issues. Bug: v8:8072 Change-Id: I20a38a5ce9940026171d870d354787fe0b7c5a6f Reviewed-on: https://chromium-review.googlesource.com/1196725Reviewed-by: Ross McIlroy <rmcilroy@chromium.org> Reviewed-by: Jaroslav Sevcik <jarin@chromium.org> Reviewed-by: Yang Guo <yangguo@chromium.org> Reviewed-by: Georg Neis <neis@chromium.org> Commit-Queue: Chandan Reddy <chandanreddy@google.com> Cr-Commit-Position: refs/heads/master@{#56211}
-
- 17 Sep, 2018 1 commit
-
-
Creddy authored
Temporarily disable one-shot optimization for debug-evaluate-no-side-effect-builtins-2 to fix the gc stress test. This issue will be fixed in the future CL (https://chromium-review.googlesource.com/c/v8/v8/+/1196725) that adds new bytecodes for loads and stores and one-shot optimizations will be enabled again. Change-Id: I6475557778da4553b5b6cbba1fda14c52d3dd91b Reviewed-on: https://chromium-review.googlesource.com/1228063Reviewed-by: Igor Sheludko <ishell@chromium.org> Commit-Queue: Chandan Reddy <chandanreddy@google.com> Cr-Commit-Position: refs/heads/master@{#55969}
-
- 14 Sep, 2018 1 commit
-
-
Creddy authored
This reland of the commit e938b7a3. Original change's description: > Enable OneShot optimizations by default > > BUG=v8:8072 > > Change-Id: I2068d66644628fe1de7a6be30b8d43ecfae04e93 > Reviewed-on: https://chromium-review.googlesource.com/1220047 > Commit-Queue: Chandan Reddy <chandanreddy@google.com> > Reviewed-by: Camillo Bruni <cbruni@chromium.org> > Cr-Commit-Position: refs/heads/master@{#55875} TBR=cbruni@chromium.org,chandanreddy@google.com Change-Id: I2152d4f3886913ef7ffabf8611c3448299560d2b No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:8072 Reviewed-on: https://chromium-review.googlesource.com/1224933 Commit-Queue: Chandan Reddy <chandanreddy@google.com> Reviewed-by: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#55893}
-
- 13 Sep, 2018 2 commits
-
-
Deepti Gandluri authored
This reverts commit e938b7a3. Reason for revert: Reverting because of gc-stress failures - https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8%20Linux%20-%20gc%20stress/18299 Original change's description: > Enable OneShot optimizations by default > > BUG=v8:8072 > > Change-Id: I2068d66644628fe1de7a6be30b8d43ecfae04e93 > Reviewed-on: https://chromium-review.googlesource.com/1220047 > Commit-Queue: Chandan Reddy <chandanreddy@google.com> > Reviewed-by: Camillo Bruni <cbruni@chromium.org> > Cr-Commit-Position: refs/heads/master@{#55875} TBR=cbruni@chromium.org,chandanreddy@google.com Change-Id: If3bfb5e142a873f534f831da413d26e78d2e3716 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:8072 Reviewed-on: https://chromium-review.googlesource.com/1224481Reviewed-by: Deepti Gandluri <gdeepti@chromium.org> Commit-Queue: Deepti Gandluri <gdeepti@chromium.org> Cr-Commit-Position: refs/heads/master@{#55876}
-
Creddy authored
BUG=v8:8072 Change-Id: I2068d66644628fe1de7a6be30b8d43ecfae04e93 Reviewed-on: https://chromium-review.googlesource.com/1220047 Commit-Queue: Chandan Reddy <chandanreddy@google.com> Reviewed-by: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#55875}
-
- 04 Sep, 2018 1 commit
-
-
Yang Guo authored
Also extend the API to reflect this new feature. R=jgruber@chromium.org, szuend@google.com, ulan@chromium.org Bug: v8:8125 Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Change-Id: Ic7a7604a8c663ba04b324eb8902ff325a25654e7 Reviewed-on: https://chromium-review.googlesource.com/1202087Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Reviewed-by: Jakob Gruber <jgruber@chromium.org> Commit-Queue: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#55604}
-
- 29 May, 2018 1 commit
-
-
Mathias Bynens authored
Intent to ship: https://groups.google.com/d/msg/v8-users/15GL4-UHEcE/OEKOou3bBgAJ Bug: v8:7220 Change-Id: Ib1efde29e27b956db3d8ebf12ff7a3f163db7c22 Reviewed-on: https://chromium-review.googlesource.com/1076335Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org> Commit-Queue: Mathias Bynens <mathias@chromium.org> Cr-Commit-Position: refs/heads/master@{#53419}
-
- 04 May, 2018 1 commit
-
-
Erik Luo authored
Side effect free whitelist now - supports 'typeof' when it performs Load operations - runtime checks for Array.p.splice Bug: v8:7588 Change-Id: I45bcd705f8d3f2d2ee61f018566439bf56d1bcbc Reviewed-on: https://chromium-review.googlesource.com/1037926Reviewed-by: Yang Guo <yangguo@chromium.org> Commit-Queue: Erik Luo <luoe@chromium.org> Cr-Commit-Position: refs/heads/master@{#52976}
-
- 20 Apr, 2018 1 commit
-
-
Alexey Kozyatinskiy authored
.. for side effect free debug evaluate. R=yangguo@chromium.org Bug: v8:7588 Change-Id: Iac4d782dbf996d9c11430fc681f38a648d89435b Reviewed-on: https://chromium-review.googlesource.com/1000527 Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Reviewed-by: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#52699}
-
- 11 Apr, 2018 1 commit
-
-
Alexey Kozyatinskiy authored
This CL allows SetPrototypeAdd and ArrayIteratorPrototypeNext to be called on temporary objects during side effect free evaluation. Bug: v8:7588 Change-Id: Id77848e48d98c243de91bc6c0fae5a0877e693d4 Reviewed-on: https://chromium-review.googlesource.com/998439 Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Reviewed-by: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#52548}
-
- 10 Apr, 2018 1 commit
-
-
Erik Luo authored
This whitelists Function-related builtins used by Blink callbacks at the DOM wrapping stage, and other BigInt methods. Bug: chromium:810176 Change-Id: If036114cd7f133f2c30247dff836698c2eb16a51 Reviewed-on: https://chromium-review.googlesource.com/1004000Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by: Yang Guo <yangguo@chromium.org> Commit-Queue: Erik Luo <luoe@chromium.org> Cr-Commit-Position: refs/heads/master@{#52530}
-
- 06 Apr, 2018 2 commits
-
-
Alexey Kozyatinskiy authored
This is a reland of 0340874b Original change's description: > [debug] add runtime side effect check for StaCurrentContextSlot > > R=yangguo@chromium.org > > Bug: v8:7588 > Change-Id: If78f6dd460c7423923800a98d44520c1bf71663c > Reviewed-on: https://chromium-review.googlesource.com/996236 > Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> > Reviewed-by: Yang Guo <yangguo@chromium.org> > Cr-Commit-Position: refs/heads/master@{#52398} Bug: v8:7588 Change-Id: Ife6b039ea3291103a54ae04c3007fe4610371c3f Reviewed-on: https://chromium-review.googlesource.com/998801Reviewed-by: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Cr-Commit-Position: refs/heads/master@{#52452}
-
Jakob Gruber authored
This reverts commit 0340874b. Reason for revert: Tentative revert for https://crbug.com/v8/7626 Original change's description: > [debug] add runtime side effect check for StaCurrentContextSlot > > R=yangguo@chromium.org > > Bug: v8:7588 > Change-Id: If78f6dd460c7423923800a98d44520c1bf71663c > Reviewed-on: https://chromium-review.googlesource.com/996236 > Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> > Reviewed-by: Yang Guo <yangguo@chromium.org> > Cr-Commit-Position: refs/heads/master@{#52398} TBR=yangguo@chromium.org,kozyatinskiy@chromium.org Change-Id: I77a679649a6149607aefd44f6b7f3f6dfe548776 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:7588 Reviewed-on: https://chromium-review.googlesource.com/998036Reviewed-by: Jakob Gruber <jgruber@chromium.org> Commit-Queue: Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#52428}
-
- 05 Apr, 2018 2 commits
-
-
Alexey Kozyatinskiy authored
R=yangguo@chromium.org Bug: v8:7588 Change-Id: If78f6dd460c7423923800a98d44520c1bf71663c Reviewed-on: https://chromium-review.googlesource.com/996236 Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Reviewed-by: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#52398}
-
Alexey Kozyatinskiy authored
This is a reland of 7a2c3713 Original change's description: > [debug] introduced runtime side effect check > > This CL demonstrates minimum valuable addition to existing debug evaluate > without side effects mechanism. > With this CL user can evaluate expressions like: > [a,b] // create any kind of temporary array literals > [a,b].reduce((x,y) => x + y, 0); // use reduce method > [1,2,3].fill(2); // change temporary arrays > > The core idea: any change of the object created during evaluation without > side effects is side effect free. As soon as we try to store this temporary > object to object existed before evaluation we will terminate execution. > > Implementation: > - track all objects allocated during evaluation and mark them as temporary, > - patch all bytecodes which change objects. > > A little more details (including performance analysis): [1]. > > [1] https://docs.google.com/document/d/10qqAtZADspPnpYa6SEdYRxrddfKIZJIzbLtGpsZQkRo/edit# > > Bug: v8:7588 > Change-Id: I69f7b96e1ebd7ad0022219e8213211c7be72a111 > Reviewed-on: https://chromium-review.googlesource.com/972615 > Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> > Reviewed-by: Yang Guo <yangguo@chromium.org> > Reviewed-by: Ulan Degenbaev <ulan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#52370} Bug: v8:7588 Change-Id: Ibc92bf19155f2ddaedae39b0c576b994e84afcf8 Reviewed-on: https://chromium-review.googlesource.com/996760Reviewed-by: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Cr-Commit-Position: refs/heads/master@{#52373}
-
- 04 Apr, 2018 2 commits
-
-
Aleksey Kozyatinskiy authored
This reverts commit 7a2c3713. Reason for revert: msan is broken Original change's description: > [debug] introduced runtime side effect check > > This CL demonstrates minimum valuable addition to existing debug evaluate > without side effects mechanism. > With this CL user can evaluate expressions like: > [a,b] // create any kind of temporary array literals > [a,b].reduce((x,y) => x + y, 0); // use reduce method > [1,2,3].fill(2); // change temporary arrays > > The core idea: any change of the object created during evaluation without > side effects is side effect free. As soon as we try to store this temporary > object to object existed before evaluation we will terminate execution. > > Implementation: > - track all objects allocated during evaluation and mark them as temporary, > - patch all bytecodes which change objects. > > A little more details (including performance analysis): [1]. > > [1] https://docs.google.com/document/d/10qqAtZADspPnpYa6SEdYRxrddfKIZJIzbLtGpsZQkRo/edit# > > Bug: v8:7588 > Change-Id: I69f7b96e1ebd7ad0022219e8213211c7be72a111 > Reviewed-on: https://chromium-review.googlesource.com/972615 > Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> > Reviewed-by: Yang Guo <yangguo@chromium.org> > Reviewed-by: Ulan Degenbaev <ulan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#52370} TBR=ulan@chromium.org,rmcilroy@chromium.org,yangguo@chromium.org,kozyatinskiy@chromium.org,leszeks@chromium.org Change-Id: Ied1739c6308b13a4981189e0999f5912316cf456 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:7588 Reviewed-on: https://chromium-review.googlesource.com/996135Reviewed-by: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Cr-Commit-Position: refs/heads/master@{#52371}
-
Alexey Kozyatinskiy authored
This CL demonstrates minimum valuable addition to existing debug evaluate without side effects mechanism. With this CL user can evaluate expressions like: [a,b] // create any kind of temporary array literals [a,b].reduce((x,y) => x + y, 0); // use reduce method [1,2,3].fill(2); // change temporary arrays The core idea: any change of the object created during evaluation without side effects is side effect free. As soon as we try to store this temporary object to object existed before evaluation we will terminate execution. Implementation: - track all objects allocated during evaluation and mark them as temporary, - patch all bytecodes which change objects. A little more details (including performance analysis): [1]. [1] https://docs.google.com/document/d/10qqAtZADspPnpYa6SEdYRxrddfKIZJIzbLtGpsZQkRo/edit# Bug: v8:7588 Change-Id: I69f7b96e1ebd7ad0022219e8213211c7be72a111 Reviewed-on: https://chromium-review.googlesource.com/972615 Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Reviewed-by: Yang Guo <yangguo@chromium.org> Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#52370}
-
- 30 Mar, 2018 1 commit
-
-
Jakob Kummerow authored
This is a reland of 16aecc5d Intent to ship: https://groups.google.com/d/msg/v8-users/ShhW0Xewph0/1-OT9q0_DQAJ Originally reviewed at: Reviewed-on: https://chromium-review.googlesource.com/981596 Bug: v8:6791 Change-Id: I772af807b9486081d7cd96b538bf5bc98d4dcffe Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng;luci.v8.try:v8_linux_blink_rel Reviewed-on: https://chromium-review.googlesource.com/984857Reviewed-by: Georg Neis <neis@chromium.org> Reviewed-by: Mathias Bynens <mathias@chromium.org> Reviewed-by: Adam Klein <adamk@chromium.org> Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#52307}
-
- 28 Mar, 2018 2 commits
-
-
Michael Achenbach authored
This reverts commit 16aecc5d. Reason for revert: Breaks several layout tests: https://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Linux%2064/builds/22624 Original change's description: > Ship BigInts > > Intent to ship: > https://groups.google.com/d/msg/v8-users/ShhW0Xewph0/1-OT9q0_DQAJ > > Bug: v8:6791 > Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng > Change-Id: Ibcf5ac09c0099496ef2c6a3c23bef9f9e72658f1 > Reviewed-on: https://chromium-review.googlesource.com/981596 > Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> > Reviewed-by: Mathias Bynens <mathias@chromium.org> > Reviewed-by: Adam Klein <adamk@chromium.org> > Reviewed-by: Georg Neis <neis@chromium.org> > Cr-Commit-Position: refs/heads/master@{#52256} TBR=adamk@chromium.org,jkummerow@chromium.org,neis@chromium.org,mathias@chromium.org Change-Id: I32e9f32b501cb72aa364e89d5b2210c0861c68fc No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:6791 Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng Reviewed-on: https://chromium-review.googlesource.com/983293Reviewed-by: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#52261}
-
Jakob Kummerow authored
Intent to ship: https://groups.google.com/d/msg/v8-users/ShhW0Xewph0/1-OT9q0_DQAJ Bug: v8:6791 Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng Change-Id: Ibcf5ac09c0099496ef2c6a3c23bef9f9e72658f1 Reviewed-on: https://chromium-review.googlesource.com/981596 Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by: Mathias Bynens <mathias@chromium.org> Reviewed-by: Adam Klein <adamk@chromium.org> Reviewed-by: Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#52256}
-
- 06 Mar, 2018 1 commit
-
-
Yang Guo authored
Instead of a hard-coded list of function addresses, we now use a flag on the AccessorInfo object to annotate whether the getter can cause any side effect. Future changes will extend this to InterceptorInfo, CallHandlerInfo, and expose this through the API. R=jgruber@chromium.org, luoe@chromium.org Bug: v8:7515 Change-Id: Id0fedf03493c3bd81913557a5681f8f63660f6a4 Reviewed-on: https://chromium-review.googlesource.com/945909 Commit-Queue: Yang Guo <yangguo@chromium.org> Reviewed-by: Jakob Gruber <jgruber@chromium.org> Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#51756}
-
- 22 Feb, 2018 3 commits
-
-
Erik Luo authored
This is a reland of ba5bac8c. Original change's description: > [debug] add tests, mark side-effect-free (Typed)Array, WeakMap/Set fns > > Adds more whitelisted methods in debug-evaluate for: > Array, TypedArray, ArrayBuffer, DataView, WeakMap, WeakSet > > Bug: chromium:810176 > Change-Id: I502776ad3191ccc2a355e5684b5f885a5f58d186 > Reviewed-on: https://chromium-review.googlesource.com/923414 > Reviewed-by: Yang Guo <yangguo@chromium.org> > Commit-Queue: Erik Luo <luoe@chromium.org> > Cr-Commit-Position: refs/heads/master@{#51456} Bug: chromium:810176 Change-Id: I64ff0aa632ddf77ad683de76b61ebe4e85d5f879 Reviewed-on: https://chromium-review.googlesource.com/931987Reviewed-by: Yang Guo <yangguo@chromium.org> Commit-Queue: Erik Luo <luoe@chromium.org> Cr-Commit-Position: refs/heads/master@{#51483}
-
Erik Luo authored
This reverts commit ba5bac8c. Reason for revert: Breaks the build, needs investigation Original change's description: > [debug] add tests, mark side-effect-free (Typed)Array, WeakMap/Set fns > > Adds more whitelisted methods in debug-evaluate for: > Array, TypedArray, ArrayBuffer, DataView, WeakMap, WeakSet > > Bug: chromium:810176 > Change-Id: I502776ad3191ccc2a355e5684b5f885a5f58d186 > Reviewed-on: https://chromium-review.googlesource.com/923414 > Reviewed-by: Yang Guo <yangguo@chromium.org> > Commit-Queue: Erik Luo <luoe@chromium.org> > Cr-Commit-Position: refs/heads/master@{#51456} TBR=yangguo@chromium.org,luoe@chromium.org Change-Id: I864e5747fa3277e27feffba08a50c8c241291f41 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:810176 Reviewed-on: https://chromium-review.googlesource.com/929922Reviewed-by: Yang Guo <yangguo@chromium.org> Commit-Queue: Erik Luo <luoe@chromium.org> Cr-Commit-Position: refs/heads/master@{#51457}
-
Erik Luo authored
Adds more whitelisted methods in debug-evaluate for: Array, TypedArray, ArrayBuffer, DataView, WeakMap, WeakSet Bug: chromium:810176 Change-Id: I502776ad3191ccc2a355e5684b5f885a5f58d186 Reviewed-on: https://chromium-review.googlesource.com/923414Reviewed-by: Yang Guo <yangguo@chromium.org> Commit-Queue: Erik Luo <luoe@chromium.org> Cr-Commit-Position: refs/heads/master@{#51456}
-
- 19 Feb, 2018 1 commit
-
-
Erik Luo authored
Bug: chromium:810176 Change-Id: I089a1678dfbe0c3bb664e54818a6853f66d364b2 Reviewed-on: https://chromium-review.googlesource.com/923387 Commit-Queue: Yang Guo <yangguo@chromium.org> Reviewed-by: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#51347}
-