- 16 Sep, 2019 7 commits
-
-
Maya Lekova authored
Bug: v8:9396 Change-Id: Icfaa04f02f1d3114cd42ad42e97572ac3cf8f985 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1801841Reviewed-by:
Santiago Aboy Solanes <solanes@chromium.org> Reviewed-by:
Sathya Gunasekaran <gsathya@chromium.org> Commit-Queue: Maya Lekova <mslekova@chromium.org> Cr-Commit-Position: refs/heads/master@{#63784}
-
Victor Gomes authored
Uses templates to dispath the allocation flag statically. Bug: v8:9714 Change-Id: I1998ae47be2f7d872d34b3bc2390d01cbfad6afa Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1801848 Auto-Submit: Victor Gomes <victorgomes@google.com> Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
Leszek Swirski <leszeks@chromium.org> Reviewed-by:
Toon Verwaest <verwaest@chromium.org> Commit-Queue: Toon Verwaest <verwaest@chromium.org> Cr-Commit-Position: refs/heads/master@{#63783}
-
Dan Elphick authored
All converted except for two calls to PrepareValueForWriteToTypedArray. Bug: v8:6949, v8:9396 Change-Id: I3c695b8067487bd8845e38cf760519bef1f37f2b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1803351 Auto-Submit: Dan Elphick <delphick@chromium.org> Reviewed-by:
-
Mu Tao authored
Port 0a8ddb13 Original Commit Message: If the jump is too large for a near jump, we patch the far jump table instead, and patch the (near) jump table to jump to the far jump table slot. Change-Id: Id9f12dee885b369a4946642301720d110dfe4f31 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1803641 Auto-Submit: Mu Tao <pamilty@gmail.com> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#63781}
-
Igor Sheludko authored
Bug: v8:9708, v8:9396 Change-Id: Id957a937a6801292dd31972dd16b188951aa05c4 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1803350Reviewed-by:
-
Georg Neis authored
This reverts commit 46f9d400. Reason for revert: as planned Original change's description: > Reland "[turbofan] Temporarily disable future=>concurrent_inlining" > > This is a reland of ce421122. > Speculatively relanding, because the failure seems unrelated. > > Original change's description: > > [turbofan] Temporarily disable future=>concurrent_inlining > > > > ... in order to reset the benchmarks now that we are actually running > > in the background. > > > > Bug: v8:7790 > > Change-Id: Ifa811fbcc51eccef790e6215d330f8b45c31a492 > > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1801836 > > Reviewed-by: Georg Neis <neis@chromium.org> > > Commit-Queue: Georg Neis <neis@chromium.org> > > Auto-Submit: Maya Lekova <mslekova@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#63741} > > Bug: v8:7790 > Change-Id: I49316516b300e6d2754043848d95ac5511fc6015 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1801849 > Reviewed-by: Georg Neis <neis@chromium.org> > Commit-Queue: Georg Neis <neis@chromium.org> > Auto-Submit: Maya Lekova <mslekova@chromium.org> > Cr-Commit-Position: refs/heads/master@{#63755} TBR=neis@chromium.org,mslekova@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: v8:7790 Change-Id: Ic31f1bf47c0b00ec497452fd29d8c09a32e14316 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1803642Reviewed-by:
Georg Neis <neis@chromium.org> Commit-Queue: Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#63779}
-
Liviu Rau authored
No-Try: true Bug: v8:9396 Change-Id: Ife254c964a418b5a2c666acf618b66e5273f31d7 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1800284 Commit-Queue: Liviu Rau <liviurau@chromium.org> Reviewed-by:
Tamer Tas <tmrts@chromium.org> Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Reviewed-by:
-
- 15 Sep, 2019 1 commit
-
-
v8-ci-autoroll-builder authored
Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/5966abc..ecd1092 Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/9d25ad4..73ec83f TBR=machenbach@chromium.org,tmrts@chromium.org Change-Id: Ie6097de34386108c51e80f45fe5f687f5b510bdd Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1805514Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#63777}
-
- 14 Sep, 2019 2 commits
-
-
Peter Marshall authored
- Get rid of a bunch of unnecessary friend classes. This required making the constructor public - Remove log_events_ field which is not used - Use unique_ptr for owned members - Use make_unique instead of bare constructors - Use a scoped vector instead of a unique ptr to array for the dynamically sized array of WasmModules Bug: v8:9396 Change-Id: Icdca904e7227d2ce2d75caf092f259d47ff15809 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1803339Reviewed-by:
-
v8-ci-autoroll-builder authored
Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/3732ed1..5966abc Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/2d75cf6..9d25ad4 Rolling v8/third_party/googletest/src: https://chromium.googlesource.com/external/github.com/google/googletest/+log/c7a03da..cad3bc4 Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/6706ebf..27f1edd TBR=machenbach@chromium.org,tmrts@chromium.org Change-Id: I563cfd03b18f3feb452ab5852434737c4a19c315 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1805014Reviewed-by:
-
- 13 Sep, 2019 30 commits
-
-
Shu-yu Guo authored
Install intrinsic default prototypes for Intl.ListFormat, Intl.PluralRules, Intl.RelativeTimeFormat, and Intl.Segmenter. Observable when attempting to construct cross-realm via a new.target with a non-Object .prototype property. Bug: v8:9712 Change-Id: I77ae75e5ea1ee8e9a01cf5788b664a5945aa1f7e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1801252Reviewed-by:
-
Milad Farazmand authored
Port 213504b9 Original Commit Message: The code fields in a JSRegExp object now either contain irregexp compiled code or a trampoline to the interpreter. This way the code can be executed without explicitly checking if the regexp shall be interpreted or executed natively. In case of interpreted regexp the generated bytecode is now stored in its own fields instead of the code fields for Latin1 and UC16 respectively. The signatures of the jitted irregexp match and the regexp interpreter have been equalized. R=pthier@google.com, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com BUG= LOG=N Change-Id: Ia2a80ce927afa644441c0749add0fc35111eb720 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1803657Reviewed-by:
Junliang Yan <jyan@ca.ibm.com> Commit-Queue: Milad Farazmand <miladfar@ca.ibm.com> Cr-Commit-Position: refs/heads/master@{#63773}
-
Michael Achenbach authored
TBR=yangguo@chromium.org NOTRY=true NOPRESUBMIT=true Change-Id: I20d3a60e406c47725b9c02da69912fcf84cb7166 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1803638 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by:
-
Ng Zhi An authored
Bug: v8:8460 Change-Id: I2a96d5bad3dbcfe6a437931d7e9756646610f74b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1796319Reviewed-by:
Bill Budge <bbudge@chromium.org> Commit-Queue: Zhi An Ng <zhin@chromium.org> Cr-Commit-Position: refs/heads/master@{#63771}
-
Dan Elphick authored
Convert all but 4 Node*s to TNode and all Variables to TVariable. In the process this also deletes several unused functions. Bug: v8:6949, v8:9396 Change-Id: I83db40eefacf8a4a1b155249c5bb8217e6c7da83 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1803347 Commit-Queue: Dan Elphick <delphick@chromium.org> Reviewed-by:
-
Milad Farazmand authored
Port 0a8ddb13 Original Commit Message: If the jump is too large for a near jump, we patch the far jump table instead, and patch the (near) jump table to jump to the far jump table slot. R=clemensh@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com BUG= LOG=N Change-Id: Ic42dfea83799ba6aae1d6d32607391393353815a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1802742Reviewed-by:
Milad Farazmand <miladfar@ca.ibm.com> Reviewed-by:
-
Frank Tang authored
By rolling icu to faee8bc which contains the upstream CLDR fix. Bug: v8:992694 Change-Id: I073d15396fa0e7c5054aa4e0806e5842228955f0 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1799424Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Reviewed-by:
-
Clemens Hammacher authored
After https://crrev.com/c/1800575 and https://crrev.com/c/1803343, which tried to fix this on occuring compile errors, this CL systematically adds the <memory> include to each header that uses {std::unique_ptr}. R=sigurds@chromium.org TBR=mlippautz@chromium.org,alph@chromium.org,rmcilroy@chromium.org,verwaest@chromium.org Bug: v8:9396 Change-Id: If7f9c3140842f9543135dddd7344c0f357999da0 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1803349Reviewed-by:
Sigurd Schneider <sigurds@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#63767}
-
Santiago Aboy Solanes authored
Follow-up CL that finishes TNodifying builtins collection gen. Added a TODO in CSA since I was encountering errors when trying to return a JSIteratorResult. Bug: v8:6949, v8:9396 Change-Id: I1e8a9cf8bce54327dd1fad5bd9531058f096469d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1803344 Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org> Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Cr-Commit-Position: refs/heads/master@{#63766}
-
Victor Gomes authored
Discussing with Toon, we've decided that these flags are no longer needed. Bug: v8:9714 Change-Id: Ic5ae8b4c0b2f470fad915ada8fec753a5d7e50ab Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1801844 Commit-Queue: Victor Gomes <victorgomes@google.com> Reviewed-by:
-
Frank Tang authored
Bug: v8:9464 Change-Id: Ibdc6f9797661e357e01c2f02565eeca12abbf8ae Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1801251Reviewed-by:
-
Santiago Aboy Solanes authored
TNodified several methods, such as the ones regarding CollectionType. Eliminated unneeded Context parameters Removed Sloppy-ness from TNodes. Bug: v8:6949, v8:9396 Change-Id: Ib4c7643957629b651aa39051f89a90bc70e215c9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1803335 Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org> Reviewed-by:
Mythri Alle <mythria@chromium.org> Cr-Commit-Position: refs/heads/master@{#63763}
-
Sigurd Schneider authored
Tbr: yangguo@chromium.org Change-Id: I9e774efdbff94be909470ab848c75e5120bb520e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1803343 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
-
Ross McIlroy authored
- HasInPrototypeChain - OrdinaryHasInstance - ObjectPrototypeIsPrototype - ObjectHasInstance BUG=v8:6949, v8:9396 Change-Id: I85b21f1e74aa869f212dc788a1dbe76c50a0d96e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1803342 Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org> Auto-Submit: Ross McIlroy <rmcilroy@chromium.org> Reviewed-by:
-
Clemens Hammacher authored
This adds logic to choose the closest jump table for each call in wasm code. The "main jump table" (held in {NativeModule::main_jump_table_}) is still kept though and used for any external or indirect call. Any direct call from within wasm now chooses the jump table that corresponds to the code space that the code lives in. R=mstarzinger@chromium.org Bug: v8:9477 Change-Id: Ie52b5bb3a4a160cb754b8702c530f6feb182b3a9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1800576 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by:Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#63760}
-
Igor Sheludko authored
... and from AccessorAssembler::LoadGlobalIC(). Tbr: tebbi@chromium.org Bug: v8:9708 Change-Id: Ia7d2ab30cfcfd513257655eb30a466d929ac774a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1801853 Commit-Queue: Igor Sheludko <ishell@chromium.org> Reviewed-by:
-
Clemens Hammacher authored
CL https://crrev.com/c/1801846 made the presubmit bot red: ERROR in /b/s/w/ir/cache/builder/v8/src/wasm/jump-table-assembler.cc Illegal include: "src/wasm/jump-table-assembler.h" Because of "-src" from src/wasm's specific_include_rules. This CL fixes that. R=mstarzinger@chromium.org No-Try: true Change-Id: I7cd947d9086bbf968a1ae89cb38f016abd819c05 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1803338Reviewed-by:
Andreas Haas <ahaas@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#63758}
-
Ross McIlroy authored
Also TNodify TypeOf in code-stub-assembler. BUG=v8:6949, v8:9396 Change-Id: I12a66a077fe82df44ce3c46a87f1fda754be9423 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1803334Reviewed-by:
-
Clemens Hammacher authored
Just two functions instead of partially specialized structs. Also, no need to compute the return type(s), just use {auto}. R=tebbi@chromium.org Bug: v8:9396 Change-Id: I840af52c3caac622aded8bd7656a5437abb2c8ef Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1801845 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by:Tobias Tebbi <tebbi@chromium.org> Cr-Commit-Position: refs/heads/master@{#63756}
-
Maya Lekova authored
This is a reland of ce421122. Speculatively relanding, because the failure seems unrelated. Original change's description: > [turbofan] Temporarily disable future=>concurrent_inlining > > ... in order to reset the benchmarks now that we are actually running > in the background. > > Bug: v8:7790 > Change-Id: Ifa811fbcc51eccef790e6215d330f8b45c31a492 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1801836 > Reviewed-by: Georg Neis <neis@chromium.org> > Commit-Queue: Georg Neis <neis@chromium.org> > Auto-Submit: Maya Lekova <mslekova@chromium.org> > Cr-Commit-Position: refs/heads/master@{#63741} Bug: v8:7790 Change-Id: I49316516b300e6d2754043848d95ac5511fc6015 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1801849Reviewed-by:
-
Clemens Hammacher authored
If the jump is too large for a near jump, we patch the far jump table instead, and patch the (near) jump table to jump to the far jump table slot. R=mstarzinger@chromium.org Bug: v8:9477 Change-Id: Ic9a929b405492c1cfe744738e0807ad4357c53ff Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1799543 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
-
Santiago Aboy Solanes authored
TNodify: * Equal * StrictEqual * RelationalComparison Also TNodify some low hanging Node* in interpreter generator Bug: v8:6949, v8:9396 Change-Id: I8d6ef775abd10db79cae740e4e26446d7117af25 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1801842Reviewed-by:
-
Clemens Hammacher authored
This reimplements the {base::make_array} helper using {std::index_sequence}. This avoids the need to recursively create index lists in template argument packs, and replaces a partially specialized struct by a single function. R=tebbi@chromium.org Bug: v8:9396 Change-Id: I60369bfac6cb9abc889ed658208411949ca9ec07 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1800575 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by: -
Joey Gouly authored
Make TryEmitCbzOrTbz a template, so it can be used for Word64 as well as Word32. 0.09% reduction of embedded builtins size with a arm64 ptr-compr build. Some of the unittests weren't ported to Word64 as they don't pass, this is due to VisitWordCompare missing a loop to remove Word64Equal comparisons against 0. This can be added in a different CL if needed. Change-Id: I927129d934083b71abe5b77991c39286470a228d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1792908 Commit-Queue: Martyn Capewell <martyn.capewell@arm.com> Reviewed-by:
-
Michael Starzinger authored
R=clemensh@chromium.org BUG=v8:9396 Change-Id: I3233a311e2ee56d9874365eb898a3316622ff6d2 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/997452Reviewed-by:
-
Clemens Hammacher authored
The {JumpTableAssembler} should not include {wasm-code-manager.h}. It only depends on assembler headers in {src/codegen}. This removes the {flush_i_cache} parameter which is always set anyway, removes the last include from {src/wasm} and updates the DEPS file to forbid such includes for the future. R=mstarzinger@chromium.org Bug: v8:9396, v8:9477 Change-Id: Id57b35c93155c3eac7c4c9b6a41d3a1c98c0dddc Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1801846 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by: -
Peter Marshall authored
These were deprecated in 7.8 via: https://chromium-review.googlesource.com/c/v8/v8/+/1735316 Use Detach() instead. Bug: chromium:913887, v8:9396 Change-Id: I7d0b0c0273188c99f5afee18d4880852f5e59d10 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1801850 Commit-Queue: Peter Marshall <petermarshall@chromium.org> Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Auto-Submit: Peter Marshall <petermarshall@chromium.org> Reviewed-by:
-
Clemens Hammacher authored
This reverts commit 7b7df7db. Reason for revert: Still breaks gc-stress bots: https://ci.chromium.org/p/v8/builders/ci/V8%20Linux%20-%20gc%20stress/24466 Original change's description: > Reland "[Heap] Create a fast path for young allocations." > > Disable a flaky test. > > This is a reland of cbf028e8 > > Original change's description: > > [Heap] Create a fast path for young allocations. > > > > Bug: v8:9714 > > Change-Id: I3be6ea615142c8282bb67370626c7596cedf826c > > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1800304 > > Reviewed-by: Ulan Degenbaev <ulan@chromium.org> > > Commit-Queue: Victor Gomes <victorgomes@google.com> > > Auto-Submit: Victor Gomes <victorgomes@google.com> > > Cr-Commit-Position: refs/heads/master@{#63729} > > Bug: v8:9714 > Change-Id: Ifbd8617be1b8c58cb1552fe88c52eafd9d6e9c7d > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1801840 > Commit-Queue: Victor Gomes <victorgomes@google.com> > Commit-Queue: Ulan Degenbaev <ulan@chromium.org> > Auto-Submit: Victor Gomes <victorgomes@google.com> > Reviewed-by: Ulan Degenbaev <ulan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#63744} TBR=ulan@chromium.org,verwaest@chromium.org,victorgomes@google.com Change-Id: Ie041a7ff25adb9edc7c44ebb259912e66dfb9da1 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:9714 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1801852Reviewed-by:
-
Victor Gomes authored
NewTuple3 is not used anywhere in the source code. Bug: v8:9714 Change-Id: Iac3b3c17eafa01f5bb3de12a50afb4da0215e923 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1801843 Commit-Queue: Victor Gomes <victorgomes@google.com> Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Auto-Submit: Victor Gomes <victorgomes@google.com> Reviewed-by:
-
Leszek Swirski authored
For minified files especially, the line number alone isn't enough to identify an IC site. Change-Id: I93f54f8fca1002072af0d702c155768fa2a8dbcb Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1800566Reviewed-by:
Igor Sheludko <ishell@chromium.org> Reviewed-by:
Peter Marshall <petermarshall@chromium.org> Commit-Queue: Peter Marshall <petermarshall@chromium.org> Auto-Submit: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/master@{#63745}
-
