- 13 Jan, 2017 7 commits
-
-
machenbach authored
The fuzz test cases now print the original test paths during execution. This exploits this extra information and reports a hash of only one original source file from the section that caused a difference. The hash size is now limited to 3 to avoid possible duplicate explosion, in case this doesn't work out as expected. This prepares for patch 3 of: https://chromereviews.googleplex.com/550337016/ BUG=chromium:673246 NOTRY=true TBR=tandrii@chromium.org,mbarbella@chromium.org Review-Url: https://codereview.chromium.org/2620343005 Cr-Commit-Position: refs/heads/master@{#42305}
-
bjaideep authored
Revert of PPC/s390: Internalize strings in-place (reland) (patchset #1 id:1 of https://codereview.chromium.org/2628643002/ ) Reason for revert: Original CL https://codereview.chromium.org/2626893005 got reverted. Original issue's description: > PPC/s390: Internalize strings in-place (reland) > > Port 4c699e34 > > Original Commit Message: > > using newly introduced ThinStrings, which store a pointer to the actual, > internalized string they represent. > > (Previously landed as #42168 / af51befe. > > R=jkummerow@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com > BUG=v8:4520 > LOG=N > > Review-Url: https://codereview.chromium.org/2628643002 > Cr-Commit-Position: refs/heads/master@{#42202} > Committed: https://chromium.googlesource.com/v8/v8/+/aa0cb2eaf830e03fced1e00134fb65938df02388 TBR=jkummerow@chromium.org,joransiu@ca.ibm.com,jyan@ca.ibm.com,michael_dawson@ca.ibm.com # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=v8:4520 Review-Url: https://codereview.chromium.org/2628923004 Cr-Commit-Position: refs/heads/master@{#42304}
-
bradnelson authored
We allocate console timing messages for now, as previously skipping this tickled unrelated flake. Use a fixed message to make them consistent in predictable mode. BUG=v8:4203 TBR=titzer@chromium.org Review-Url: https://codereview.chromium.org/2628173003 Cr-Commit-Position: refs/heads/master@{#42303}
-
v8-autoroll authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/9c22ce7..15635a4 Rolling v8/third_party/catapult: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+log/ed0540f..fe8a3c8 Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/c30c6ff..0147ef9 TBR=machenbach@chromium.org,vogelheim@chromium.org,hablich@chromium.org Review-Url: https://codereview.chromium.org/2633463005 Cr-Commit-Position: refs/heads/master@{#42302}
-
bradnelson authored
We recently started emitting an error because a module's validation doesn't reach the end (due to lack of exports). This contained a mistake that prevents many most other types of errors from actually getting out. Ensuring export errors (or not reaching then end) doesn't clobber other errors. TODO(bradnelson): Figure out a way to structure tests so this gets caught. BUG=v8:4203 R=gdeepti@chromium.org Review-Url: https://codereview.chromium.org/2632593002 Cr-Commit-Position: refs/heads/master@{#42301}
-
bradnelson authored
This directs all asm.js traffic via the Wasm backend. Make asm.js console output less noisy. R=titzer@chromium.org,aseemgarg@chromium.org BUG=v8:4203 Review-Url: https://codereview.chromium.org/2624813002 Cr-Original-Original-Commit-Position: refs/heads/master@{#42194} Committed: https://chromium.googlesource.com/v8/v8/+/946cc371ed4b34d1a9f5cc615b14c41b652562ad Review-Url: https://codereview.chromium.org/2624813002 Cr-Original-Commit-Position: refs/heads/master@{#42244} Committed: https://chromium.googlesource.com/v8/v8/+/3169fb94c98953f002908974a606b51a35178046 Review-Url: https://codereview.chromium.org/2624813002 Cr-Commit-Position: refs/heads/master@{#42300}
-
bradnelson authored
BUG=None LOG=None R=mtrofin@chromium.org Review-Url: https://codereview.chromium.org/2621373005 Cr-Commit-Position: refs/heads/master@{#42299}
-
- 12 Jan, 2017 33 commits
-
-
littledan authored
Revert of [wasm] Enforce that function bodies end with the \"end\" opcode. (patchset #1 id:1 of https://codereview.chromium.org/2628203003/ ) Reason for revert: OK, the failure really does seem to be due to this patch: It triggers Clang to crash FAILED: obj/test/unittests/unittests/function-body-decoder-unittest.obj E:\b\build\slave\cache\cipd\goma/gomacc.exe ../../third_party/llvm-build/Release+Asserts/bin/clang-cl.exe /nologo /showIncludes /FC @obj/test/unittests/unittests/function-body-decoder-unittest.obj.rsp /c ../../test/unittests/wasm/function-body-decoder-unittest.cc /Foobj/test/unittests/unittests/function-body-decoder-unittest.obj /Fd"obj/test/unittests/unittests_cc.pdb" Assertion failed: (NumGaps == 0 || Bias < MaxDefRange) && "large ranges should not have gaps", file E:\b\build\slave\win_upload_clang\build\src\third_party\llvm\lib\MC\MCCodeView.cpp, line 531 Wrote crash dump file "C:\Users\CHROME~2\AppData\Local\Temp\goma_temp.5068\clang-cl.exe-563144.dmp" Let's leave it out for now. Original issue's description: > Reland of [wasm] Enforce that function bodies end with the \"end\" opcode. (patchset #1 id:1 of https://codereview.chromium.org/2628883006/ ) > > Reason for revert: > Try a reland; this might not have been the source of tree-closing. > > Original issue's description: > > Revert of [wasm] Enforce that function bodies end with the \"end\" opcode. (patchset #3 id:40001 of https://codereview.chromium.org/2630553002/ ) > > > > Reason for revert: > > Caused tree to close by failing compilation: > > > > https://build.chromium.org/p/client.v8/builders/V8%20Win64%20-%20clang/builds/4451 > > > > Original issue's description: > > > [wasm] Enforce that function bodies end with the \"end\" opcode. > > > > > > R=rossberg@chromium.org > > > BUG=chromium:575167 > > > > > > Review-Url: https://codereview.chromium.org/2630553002 > > > Cr-Commit-Position: refs/heads/master@{#42286} > > > Committed: https://chromium.googlesource.com/v8/v8/+/fcc6e85ec6b01e5367795f98aff104b1ff23f619 > > > > TBR=mtrofin@chromium.org,rossberg@chromium.org,jbroman@chromium.org,titzer@chromium.org > > # Skipping CQ checks because original CL landed less than 1 days ago. > > NOPRESUBMIT=true > > NOTREECHECKS=true > > NOTRY=true > > BUG=chromium:575167 > > > > Review-Url: https://codereview.chromium.org/2628883006 > > Cr-Commit-Position: refs/heads/master@{#42287} > > Committed: https://chromium.googlesource.com/v8/v8/+/1d32a3989bc474745eeb618ebf094634f4efbb36 > > TBR=mtrofin@chromium.org,rossberg@chromium.org,jbroman@chromium.org,titzer@chromium.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=chromium:575167 > > Review-Url: https://codereview.chromium.org/2628203003 > Cr-Commit-Position: refs/heads/master@{#42296} > Committed: https://chromium.googlesource.com/v8/v8/+/e539bd8e0eb6afc8e7c98c38584928d6bc799b5b TBR=mtrofin@chromium.org,rossberg@chromium.org,jbroman@chromium.org,titzer@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:575167 Review-Url: https://codereview.chromium.org/2633583002 Cr-Commit-Position: refs/heads/master@{#42298}
-
jyan authored
R=joransiu@ca.ibm.com, bjaideep@ca.ibm.com BUG= Review-Url: https://codereview.chromium.org/2622073006 Cr-Commit-Position: refs/heads/master@{#42297}
-
littledan authored
Reland of [wasm] Enforce that function bodies end with the \"end\" opcode. (patchset #1 id:1 of https://codereview.chromium.org/2628883006/ ) Reason for revert: Try a reland; this might not have been the source of tree-closing. Original issue's description: > Revert of [wasm] Enforce that function bodies end with the \"end\" opcode. (patchset #3 id:40001 of https://codereview.chromium.org/2630553002/ ) > > Reason for revert: > Caused tree to close by failing compilation: > > https://build.chromium.org/p/client.v8/builders/V8%20Win64%20-%20clang/builds/4451 > > Original issue's description: > > [wasm] Enforce that function bodies end with the \"end\" opcode. > > > > R=rossberg@chromium.org > > BUG=chromium:575167 > > > > Review-Url: https://codereview.chromium.org/2630553002 > > Cr-Commit-Position: refs/heads/master@{#42286} > > Committed: https://chromium.googlesource.com/v8/v8/+/fcc6e85ec6b01e5367795f98aff104b1ff23f619 > > TBR=mtrofin@chromium.org,rossberg@chromium.org,jbroman@chromium.org,titzer@chromium.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=chromium:575167 > > Review-Url: https://codereview.chromium.org/2628883006 > Cr-Commit-Position: refs/heads/master@{#42287} > Committed: https://chromium.googlesource.com/v8/v8/+/1d32a3989bc474745eeb618ebf094634f4efbb36 TBR=mtrofin@chromium.org,rossberg@chromium.org,jbroman@chromium.org,titzer@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:575167 Review-Url: https://codereview.chromium.org/2628203003 Cr-Commit-Position: refs/heads/master@{#42296}
-
gsathya authored
Before, in `var p1 = p.then(() => {}) we would trigger the before/after callbacks with p as the associated promise, but we must call it with p1. Also removes promise from PromiseReactionJobInfo. Review-Url: https://codereview.chromium.org/2633443002 Cr-Commit-Position: refs/heads/master@{#42295}
-
ishell authored
The constant field tracking implies data constants to be stored in fields instead of descriptor arrays. This CL does necessary modifications to the JSModuleNamespace map setup. BUG=v8:1569, v8:5495 Review-Url: https://codereview.chromium.org/2625093005 Cr-Commit-Position: refs/heads/master@{#42294}
-
mtrofin authored
enabled TODO-ed compile tests BUG=v8:5833 Review-Url: https://codereview.chromium.org/2628053004 Cr-Commit-Position: refs/heads/master@{#42293}
-
bjaideep authored
Port aa75904e R=yangguo@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com BUG=v8:5821 LOG=N Review-Url: https://codereview.chromium.org/2632513002 Cr-Commit-Position: refs/heads/master@{#42292}
-
ishell authored
BUG= Review-Url: https://codereview.chromium.org/2627003005 Cr-Commit-Position: refs/heads/master@{#42291}
-
v8-autoroll authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/497761f..9c22ce7 Rolling v8/third_party/catapult: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+log/d71b471..ed0540f TBR=machenbach@chromium.org,vogelheim@chromium.org,hablich@chromium.org Review-Url: https://codereview.chromium.org/2623403003 Cr-Commit-Position: refs/heads/master@{#42290}
-
scottmg authored
This is part of removing the dependency of the Chromium browser DLL on Windows on V8. R=jochen@chromium.org BUG=chromium:581766 Review-Url: https://codereview.chromium.org/2621983002 Cr-Original-Commit-Position: refs/heads/master@{#42243} Committed: https://chromium.googlesource.com/v8/v8/+/45938454177f53fa24cfc08ad97ccbc162c3ba6d Review-Url: https://codereview.chromium.org/2621983002 Cr-Commit-Position: refs/heads/master@{#42289}
-
rossberg authored
R=titzer@chromium.org BUG= Review-Url: https://codereview.chromium.org/2620263003 Cr-Commit-Position: refs/heads/master@{#42288}
-
littledan authored
Revert of [wasm] Enforce that function bodies end with the \"end\" opcode. (patchset #3 id:40001 of https://codereview.chromium.org/2630553002/ ) Reason for revert: Caused tree to close by failing compilation: https://build.chromium.org/p/client.v8/builders/V8%20Win64%20-%20clang/builds/4451 Original issue's description: > [wasm] Enforce that function bodies end with the \"end\" opcode. > > R=rossberg@chromium.org > BUG=chromium:575167 > > Review-Url: https://codereview.chromium.org/2630553002 > Cr-Commit-Position: refs/heads/master@{#42286} > Committed: https://chromium.googlesource.com/v8/v8/+/fcc6e85ec6b01e5367795f98aff104b1ff23f619 TBR=mtrofin@chromium.org,rossberg@chromium.org,jbroman@chromium.org,titzer@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:575167 Review-Url: https://codereview.chromium.org/2628883006 Cr-Commit-Position: refs/heads/master@{#42287}
-
titzer authored
R=rossberg@chromium.org BUG=chromium:575167 Review-Url: https://codereview.chromium.org/2630553002 Cr-Commit-Position: refs/heads/master@{#42286}
-
clemensh authored
As functions are relinked at instantiation anyway, we can just completely skip the LinkFunctions pass at wasm compile time. This way, we also don't need to create one placeholder per wasm function, but we just use one placeholder everywhere. The function index which was stored in the placeholder before is now retrieved from the wire bytes anyway. R=titzer@chromium.org Review-Url: https://codereview.chromium.org/2624383003 Cr-Commit-Position: refs/heads/master@{#42285}
-
adamk authored
This function was only needed for extrasUtils. Since it was simply calling a builtin function, just expose that builtin instead. This requires an arguments adapter frame for the builtin. As a drive-by fix, also added an arguments adapter for the extrasUtils.resolvePromise (and a regression test). Other cleanup: removed unused native context slot for PROMISE_SET_AND_CREATE. R=gsathya@chromium.org BUG=v8:5343 Review-Url: https://codereview.chromium.org/2626793003 Cr-Commit-Position: refs/heads/master@{#42284}
-
clemensh authored
... because we want to use BreakLocation also for wasm, but we don't instantiate a DebugInfo for wasm. R=yangguo@chromium.org, titzer@chromium.org BUG=v8:5822 Review-Url: https://codereview.chromium.org/2621953002 Cr-Commit-Position: refs/heads/master@{#42283}
-
clemensh authored
R=titzer@chromium.org BUG=chromium:673297 Review-Url: https://codereview.chromium.org/2623203003 Cr-Commit-Position: refs/heads/master@{#42282}
-
littledan authored
With the new initialization semantics, the V8 ECMA 402 (Intl) implementation does not need to indirect through a symbol to get at the underlying object. This patch removes that indirection, simplifying the implementation. R=yangguo@chromium.org BUG=v8:5751 CQ_INCLUDE_TRYBOTS=master.tryserver.v8:v8_linux_noi18n_rel_ng Review-Url: https://codereview.chromium.org/2601833002 Cr-Commit-Position: refs/heads/master@{#42281}
-
bjaideep authored
Port b8294aaa Original Commit Message: Literal arrays and feedback vectors for a function can be garbage collected if we don't have a rooted closure for the function, which happens often. It's expensive to come back from this (recreating boilerplates and gathering feedback again), and the cost is disproportionate if the function was inlined into optimized code. To guard against losing these arrays when we need them, we'll now create literal arrays when creating the feedback vector for the outer closure, and root them strongly in that vector. R=mvstanton@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com BUG=v8:5456 LOG=N Review-Url: https://codereview.chromium.org/2626263002 Cr-Commit-Position: refs/heads/master@{#42280}
-
clemensh authored
Wasm frames can be either compiled or interpreted. For interpreted wasm frames, there is only one physical stack frame representing an arbitrary stack of interpreted functions. Hence the physical stack frame needs to provide a summary of the underlying functions. Summaries were tailored for JavaScript frames before. Now they are universal. The refactored FrameSummaries are now also used in the FrameInspector, and from the StackFrame objects themselves, to avoid code duplication. All dispatch is implemented "manually", making the FrameSummary still stack-allocatable. BUG=v8:5822 R=yangguo@chromium.org, titzer@chromium.org Review-Url: https://codereview.chromium.org/2619353006 Cr-Commit-Position: refs/heads/master@{#42279}
-
mtrofin authored
- updated WebAssembly.Instance ctor uses in our tests to match spec - disallowing mem section *and* mem import, as per spec BUG=v8:5824 Review-Url: https://codereview.chromium.org/2627763002 Cr-Commit-Position: refs/heads/master@{#42278}
-
ishell authored
This is a necessary cleanup before introducing PropertyConstness bit. BUG=v8:5495 Review-Url: https://codereview.chromium.org/2624903003 Cr-Commit-Position: refs/heads/master@{#42277}
-
vogelheim authored
The inlining does not seem to actually improve performance, and hence outlining makes the code a bit more readable. Performance + binary size appear to be at least as good as with inlining. On gcc I get several 10kBs savings in binary size, but only ~100B on clang. In no case have I observed a performance regression. R=marja@chromium.org BUG=v8:3437 Review-Url: https://codereview.chromium.org/2611993002 Cr-Commit-Position: refs/heads/master@{#42276}
-
verwaest authored
BUG= Review-Url: https://codereview.chromium.org/2629143002 Cr-Commit-Position: refs/heads/master@{#42275}
-
marja authored
The bug was caused by AstTraversalVisitor refactoring: https://codereview.chromium.org/2169833002/ InitializerRewriter::VisitRewritableExpression in parser.cc didn't recurse; so it fails when a rewritable expression contains another rewritable expression. See the bug for more details. BUG=chromium:679727 Review-Url: https://codereview.chromium.org/2629623002 Cr-Commit-Position: refs/heads/master@{#42274}
-
bbudge authored
LOG=N BUG=v8:4124 Review-Url: https://codereview.chromium.org/2620343002 Cr-Commit-Position: refs/heads/master@{#42273}
-
bjaideep authored
Add VSX instructions to perform add/sub/mul/div R=jyan@ca.ibm.com, joransiu@ca.ibm.com, michael_dawson@ca.ibm.com, danno@chromium.org, jkummerow@chromium.org, jochen@chromium.org BUG= LOG=N Review-Url: https://codereview.chromium.org/2619763003 Cr-Commit-Position: refs/heads/master@{#42272}
-
jkummerow authored
Revert of Internalize strings in-place (patchset #20 id:380001 of https://codereview.chromium.org/2549773002/ ) Reason for revert: Blocks roll, ASan detects leaking ExternalStrings. Original issue's description: > Internalize strings in-place (reland^2) > > using newly introduced ThinStrings, which store a pointer to the actual, > internalized string they represent. > > BUG=v8:4520 > > (Previously landed as #42168 / af51befe) > (Previously landed as #42193 / 4c699e34) > > Review-Url: https://codereview.chromium.org/2549773002 > Cr-Commit-Position: refs/heads/master@{#42235} > Committed: https://chromium.googlesource.com/v8/v8/+/ec45e6ed2e11698c713e664b1510bc31bcdbbdba TBR=ishell@chromium.org,hpayer@chromium.org,bmeurer@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:4520 Review-Url: https://codereview.chromium.org/2626893005 Cr-Commit-Position: refs/heads/master@{#42271}
-
yangguo authored
R=jgruber@chromium.org, mstarzinger@chromium.org BUG=v8:5821 Review-Url: https://codereview.chromium.org/2622863003 Cr-Commit-Position: refs/heads/master@{#42270}
-
mlippautz authored
Embedders should use the EmbedderHeapTracer API. BUG=v8:5828 Review-Url: https://codereview.chromium.org/2628893003 Cr-Commit-Position: refs/heads/master@{#42269}
-
yangguo authored
R=jochen@chromium.org, peria@chromium.org BUG=chromium:617892 Review-Url: https://codereview.chromium.org/2628093003 Cr-Commit-Position: refs/heads/master@{#42268}
-
titzer authored
BUG=chromium:575167 R=rossberg@chromium.org,ahaas@chromium.org,clemensh@chromium.org,bradnelson@chromium.org Review-Url: https://codereview.chromium.org/2623743003 Cr-Original-Original-Commit-Position: refs/heads/master@{#42197} Committed: https://chromium.googlesource.com/v8/v8/+/34b63f050b1a247bb64ddc91c967501ce04e011f Review-Url: https://codereview.chromium.org/2623743003 Cr-Original-Commit-Position: refs/heads/master@{#42214} Committed: https://chromium.googlesource.com/v8/v8/+/71f5650828ffd0162fcd67d9c6ef570a346a8a84 Review-Url: https://codereview.chromium.org/2623743003 Cr-Commit-Position: refs/heads/master@{#42267}
-
machenbach authored
BUG=chromium:680110 TBR=clemensh@chromium.org, titzer@chromium.org, ahaas@chromium.org NOTRY=true Review-Url: https://codereview.chromium.org/2625333002 Cr-Commit-Position: refs/heads/master@{#42266}
-