Commit d270056f authored by Tamer Tas's avatar Tamer Tas Committed by Commit Bot

[perf] mask timeout failures if they succeed after retries

perfrunner returns a failure if the build timeouts at any point even if it's
successful after retries. It tries to surface up the timeout issue. Due to this,
some bots stay red consistently, and confuses the sheriffs.

This CL masks the timeouts if the suite succeeds in the end.

TBR=verwaest@chromium.org,sergiyb@chromium.org

Bug: v8:9494
Change-Id: I8e107e80dfaa51095501bb2e855d9fbbe4023da9
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1702612Reviewed-by: 's avatarTamer Tas <tmrts@chromium.org>
Auto-Submit: Tamer Tas <tmrts@chromium.org>
Commit-Queue: Tamer Tas <tmrts@chromium.org>
Cr-Commit-Position: refs/heads/master@{#62735}
parent 4334e2b8
......@@ -1089,8 +1089,11 @@ def Main(argv):
break
attempts_left -= 1
have_failed_tests = True
if attempts_left:
if not attempts_left:
logging.info('>>> Suite %s failed after %d retries',
runnable_name, runnable.retry_count + 1)
have_failed_tests = True
else:
logging.info('>>> Retrying suite: %s', runnable_name)
except MaxTotalDurationReachedError:
have_failed_tests = True
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment