Commit a48d7ce2 authored by littledan's avatar littledan Committed by Commit bot

Reland of [test] Speculatively remove local-tests from archive (patchset #1...

Reland of [test] Speculatively remove local-tests from archive (patchset #1 id:1 of https://codereview.chromium.org/2640223003/ )

Reason for revert:
With the Windows bots fixed in https://chromium-review.googlesource.com/445786 , this should be good to reland. Thanks, Michael!

Original issue's description:
> Revert of [test] Speculatively remove local-tests from archive (patchset #2 id:20001 of https://codereview.chromium.org/2643983002/ )
>
> Reason for revert:
> Breaks all windows bots:
> https://build.chromium.org/p/client.v8/builders/V8%20Win32%20-%20debug/builds/6811
>
> Original issue's description:
> > [test] Remove local-tests from test262 archive and add to .isolate
> >
> > This might help fix the bots, which are broken in e.g.,
> > https://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel_ng_triggered/builds/14011
> >
> > The archive was added in order to transmit test262 tests more rapidly.
> > It doesn't serve much of a purpose for local-tests. I naively added
> > local-tests there out of symmetry. However, the BUILD.gn file does not
> > regenerate an archive when files are only deleted and not added or
> > changed. Since the performance concern is not present for the small
> > volume of local-tests, this patch reverts to the more normal mechanism
> > for sending over dependencies, with test262.isolate.
> >
> > R=adamk
> >
> > Review-Url: https://codereview.chromium.org/2643983002
> > Cr-Commit-Position: refs/heads/master@{#42485}
> > Committed: https://chromium.googlesource.com/v8/v8/+/9f545ea96f18b7036ac6ec43e359d63f41c3686a
>
> TBR=adamk@chromium.org,littledan@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
>
> Review-Url: https://codereview.chromium.org/2640223003
> Cr-Commit-Position: refs/heads/master@{#42491}
> Committed: https://chromium.googlesource.com/v8/v8/+/4ffe0850dbb238dca4c1e2d14fb2984442a1fa24

TBR=adamk@chromium.org,machenbach@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.

Review-Url: https://codereview.chromium.org/2725643002
Cr-Commit-Position: refs/heads/master@{#43488}
parent a35616e3
...@@ -29,7 +29,6 @@ def filter_git(tar_info): ...@@ -29,7 +29,6 @@ def filter_git(tar_info):
with tarfile.open('data.tar', 'w') as tar: with tarfile.open('data.tar', 'w') as tar:
tar.add('data', filter=filter_git) tar.add('data', filter=filter_git)
tar.add('harness', filter=filter_git) tar.add('harness', filter=filter_git)
tar.add('local-tests')
# Workaround for GN. We can't specify the tarfile as output because it's # Workaround for GN. We can't specify the tarfile as output because it's
# not in the product directory. Therefore we track running of this script # not in the product directory. Therefore we track running of this script
......
...@@ -10,8 +10,7 @@ from itertools import chain ...@@ -10,8 +10,7 @@ from itertools import chain
os.chdir(os.path.dirname(os.path.abspath(__file__))) os.chdir(os.path.dirname(os.path.abspath(__file__)))
for root, dirs, files in chain(os.walk("data"), os.walk("harness"), for root, dirs, files in chain(os.walk("data"), os.walk("harness")):
os.walk("local-tests")):
dirs[:] = [d for d in dirs if not d.endswith('.git')] dirs[:] = [d for d in dirs if not d.endswith('.git')]
for name in files: for name in files:
# These names are for gyp, which expects slashes on all platforms. # These names are for gyp, which expects slashes on all platforms.
......
...@@ -10,6 +10,7 @@ ...@@ -10,6 +10,7 @@
'harness-agent.js', 'harness-agent.js',
'test262.status', 'test262.status',
'testcfg.py', 'testcfg.py',
'local-tests/',
], ],
}, },
'includes': [ 'includes': [
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment