Commit 9a3a73c1 authored by Omer Katz's avatar Omer Katz Committed by V8 LUCI CQ

cppgc: Remove redundant TODOs

Bug: chromium:1056170
Change-Id: Ia5a507b462498b4e10722a7052a19a41ad7e41ef
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2897088
Commit-Queue: Michael Lippautz <mlippautz@chromium.org>
Auto-Submit: Omer Katz <omerkatz@chromium.org>
Reviewed-by: 's avatarMichael Lippautz <mlippautz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#74584}
parent 05180004
......@@ -328,10 +328,6 @@ void CppHeap::TracePrologue(TraceFlags flags) {
}
bool CppHeap::AdvanceTracing(double deadline_in_ms) {
// TODO(chromium:1154636): The kAtomicMark/kIncrementalMark scope below is
// needed for recording all cpp marking time. Note that it can lead to double
// accounting since this scope is also accounted under an outer v8 scope.
// Make sure to only account this scope once.
cppgc::internal::StatsCollector::EnabledScope stats_scope(
stats_collector(),
in_atomic_pause_ ? cppgc::internal::StatsCollector::kAtomicMark
......
......@@ -52,8 +52,6 @@ void TraceConservatively(ConservativeTracingVisitor* conservative_visitor,
void ConservativeTracingVisitor::TraceConservativelyIfNeeded(
const void* address) {
// TODO(chromium:1056170): Add page bloom filter
const BasePage* page = reinterpret_cast<const BasePage*>(
page_backend_.Lookup(static_cast<ConstAddress>(address)));
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment