Commit 05180004 authored by Wenyu Zhao's avatar Wenyu Zhao Committed by V8 LUCI CQ

[heap] Fix TPH heap capacity checks and skip three more tests

This CL fixes a failed DCHECK due to incorrect heap capacity.

Also skips three new tests that create multiple isolates.

Bug: v8:11641
Change-Id: I1061b3370efbe2b272bd490705fc728d6bb26910
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2896644
Auto-Submit: Wenyu Zhao <wenyu.zhao@anu.edu.au>
Commit-Queue: Dominik Inführ <dinfuehr@chromium.org>
Reviewed-by: 's avatarDominik Inführ <dinfuehr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#74583}
parent b67f2282
......@@ -324,6 +324,8 @@ size_t Heap::SemiSpaceSizeFromYoungGenerationSize(
size_t Heap::Capacity() {
if (!HasBeenSetUp()) return 0;
if (FLAG_enable_third_party_heap) return tp_heap_->Capacity();
return NewSpaceCapacity() + OldGenerationCapacity();
}
......
......@@ -42,6 +42,8 @@ class Heap {
HeapObject NextObject();
bool CollectGarbage();
size_t Capacity();
};
} // namespace third_party_heap
......
......@@ -213,6 +213,8 @@
################################################################################
['third_party_heap', {
# Requires a second isolate
'regress/regress-crbug-1207867': [SKIP],
'regress/regress-crbug-1197392': [SKIP],
'debugger/command-line-api-with-arrow-function': [SKIP],
'regress/regress-crbug-1199919': [SKIP],
'console/destroy-context-during-log': [SKIP],
......
......@@ -1526,6 +1526,7 @@
'regress/regress-356053': [SKIP],
'regress/regress-embedded-cons-string': [SKIP],
# Requires a second isolate
'resizablearraybuffer-growablesharedarraybuffer': [SKIP],
'regress/regress-1205290': [SKIP],
'compiler/regress-725743': [SKIP],
'd8/d8-fuzzable-worker': [SKIP],
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment