Commit 61b5124e authored by Jaroslav Sevcik's avatar Jaroslav Sevcik Committed by Commit Bot

[turbofan] Remove overflow check on integer additive op if truncated.

This removes overflow check in addition when we have Smi or
Int32 feedback for the addition, and the result is truncated
to word32. Here is an example, assuming that we passed only
integers to this function so far.

function f(a) { return a + 1 | 0; }

If the result of the addition is word32-truncated, there is no need
for an overflow check.

Until now, we would only eliminate the overflow check
if we knew that the static types of the inputs guaranteed that
the result is in safe integer range. With this CL, we use the
checked type from the feedback, too (but we do not propagate the
truncation!).

Bug: v8:5267,v8:6764
Change-Id: Ia2f929600758f58e6e7db52fef638a0e56c936a9
Reviewed-on: https://chromium-review.googlesource.com/635083
Commit-Queue: Jaroslav Sevcik <jarin@chromium.org>
Reviewed-by: 's avatarGeorg Neis <neis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#47668}
parent 6b6691f1
...@@ -1312,11 +1312,13 @@ class RepresentationSelector { ...@@ -1312,11 +1312,13 @@ class RepresentationSelector {
Type::Signed32()); Type::Signed32());
} }
if (lower()) { if (lower()) {
if (CanOverflowSigned32(node->op(), left_feedback_type, if (truncation.IsUsedAsWord32() ||
right_feedback_type, graph_zone())) { !CanOverflowSigned32(node->op(), left_feedback_type,
ChangeToInt32OverflowOp(node); right_feedback_type, graph_zone())) {
} else {
ChangeToPureOp(node, Int32Op(node)); ChangeToPureOp(node, Int32Op(node));
} else {
ChangeToInt32OverflowOp(node);
} }
} }
return; return;
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment