• Jaroslav Sevcik's avatar
    [turbofan] Remove overflow check on integer additive op if truncated. · 61b5124e
    Jaroslav Sevcik authored
    This removes overflow check in addition when we have Smi or
    Int32 feedback for the addition, and the result is truncated
    to word32. Here is an example, assuming that we passed only
    integers to this function so far.
    
    function f(a) { return a + 1 | 0; }
    
    If the result of the addition is word32-truncated, there is no need
    for an overflow check.
    
    Until now, we would only eliminate the overflow check
    if we knew that the static types of the inputs guaranteed that
    the result is in safe integer range. With this CL, we use the
    checked type from the feedback, too (but we do not propagate the
    truncation!).
    
    Bug: v8:5267,v8:6764
    Change-Id: Ia2f929600758f58e6e7db52fef638a0e56c936a9
    Reviewed-on: https://chromium-review.googlesource.com/635083
    Commit-Queue: Jaroslav Sevcik <jarin@chromium.org>
    Reviewed-by: 's avatarGeorg Neis <neis@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#47668}
    61b5124e
Name
Last commit
Last update
benchmarks Loading commit data...
build_overrides Loading commit data...
docs Loading commit data...
gni Loading commit data...
gypfiles Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.editorconfig Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
Makefile Loading commit data...
Makefile.android Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...
snapshot_toolchain.gni Loading commit data...