Commit 3be8651f authored by bmeurer's avatar bmeurer Committed by Commit bot

Revert of Re-enable on-heap typed array allocation (patchset #1 id:1 of...

Revert of Re-enable on-heap typed array allocation (patchset #1 id:1 of https://codereview.chromium.org/1166433004/)

Reason for revert:
Win32 breakage

Original issue's description:
> Re-enable on-heap typed array allocation
>
> BUG=v8:3996
> R=mstarzinger@chromium.org
> LOG=y
>
> Committed: https://crrev.com/f91df1f25dec4f1982c40af6118da8b699777475
> Cr-Commit-Position: refs/heads/master@{#28722}

TBR=mstarzinger@chromium.org,jochen@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=v8:3996

Review URL: https://codereview.chromium.org/1158193004

Cr-Commit-Position: refs/heads/master@{#28723}
parent f91df1f2
...@@ -9727,18 +9727,8 @@ HValue* HGraphBuilder::BuildAllocateEmptyArrayBuffer(HValue* byte_length) { ...@@ -9727,18 +9727,8 @@ HValue* HGraphBuilder::BuildAllocateEmptyArrayBuffer(HValue* byte_length) {
native_context, nullptr, native_context, nullptr,
HObjectAccess::ForContextSlot(Context::ARRAY_BUFFER_MAP_INDEX))); HObjectAccess::ForContextSlot(Context::ARRAY_BUFFER_MAP_INDEX)));
HConstant* empty_fixed_array = Add<HStoreNamedField>(result, HObjectAccess::ForJSArrayBufferBackingStore(),
Add<HConstant>(isolate()->factory()->empty_fixed_array()); Add<HConstant>(ExternalReference()));
Add<HStoreNamedField>(
result, HObjectAccess::ForJSArrayOffset(JSArray::kPropertiesOffset),
empty_fixed_array);
Add<HStoreNamedField>(
result, HObjectAccess::ForJSArrayOffset(JSArray::kElementsOffset),
empty_fixed_array);
Add<HStoreNamedField>(
result, HObjectAccess::ForJSArrayBufferBackingStore().WithRepresentation(
Representation::Smi()),
graph()->GetConstant0());
Add<HStoreNamedField>(result, HObjectAccess::ForJSArrayBufferByteLength(), Add<HStoreNamedField>(result, HObjectAccess::ForJSArrayBufferByteLength(),
byte_length); byte_length);
Add<HStoreNamedField>(result, HObjectAccess::ForJSArrayBufferBitFieldSlot(), Add<HStoreNamedField>(result, HObjectAccess::ForJSArrayBufferBitFieldSlot(),
...@@ -9945,7 +9935,7 @@ void HOptimizedGraphBuilder::GenerateTypedArrayInitialize( ...@@ -9945,7 +9935,7 @@ void HOptimizedGraphBuilder::GenerateTypedArrayInitialize(
CHECK_ALIVE(VisitForValue(arguments->at(kObjectArg))); CHECK_ALIVE(VisitForValue(arguments->at(kObjectArg)));
HValue* obj = Pop(); HValue* obj = Pop();
if (!arguments->at(kArrayIdArg)->IsLiteral()) { if (arguments->at(kArrayIdArg)->IsLiteral()) {
// This should never happen in real use, but can happen when fuzzing. // This should never happen in real use, but can happen when fuzzing.
// Just bail out. // Just bail out.
Bailout(kNeedSmiLiteral); Bailout(kNeedSmiLiteral);
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment