Commit 11513893 authored by Ulan Degenbaev's avatar Ulan Degenbaev Committed by Commit Bot

[test] Remove fragile assertion in test-spaces/SizeOfInitialHeap

The assertion states that compilation of an empty script does not add
new pages. This doesn't not necessarily hold if the existing pages are
almost full.

Bug: v8:10988
Change-Id: I71735e6736fb94e1ccde7f6430a2c4b0d48c43f3
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2461728Reviewed-by: 's avatarMichael Lippautz <mlippautz@chromium.org>
Commit-Queue: Ulan Degenbaev <ulan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#70417}
parent b2925688
...@@ -386,15 +386,7 @@ TEST(SizeOfInitialHeap) { ...@@ -386,15 +386,7 @@ TEST(SizeOfInitialHeap) {
CHECK_LE(heap->paged_space(i)->CommittedMemory(), kMaxInitialSizePerSpace); CHECK_LE(heap->paged_space(i)->CommittedMemory(), kMaxInitialSizePerSpace);
} }
// Executing the empty script gets by with the same number of pages, i.e.,
// requires no extra space.
CompileRun("/*empty*/"); CompileRun("/*empty*/");
for (int i = FIRST_GROWABLE_PAGED_SPACE; i <= LAST_GROWABLE_PAGED_SPACE;
i++) {
// Skip CODE_SPACE, since we had to generate code even for an empty script.
if (i == CODE_SPACE) continue;
CHECK_EQ(page_count[i], isolate->heap()->paged_space(i)->CountTotalPages());
}
// No large objects required to perform the above steps. // No large objects required to perform the above steps.
CHECK_EQ(initial_lo_space, CHECK_EQ(initial_lo_space,
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment