• Samuel Groß's avatar
    V8 Sandbox rebranding · 277fdd1d
    Samuel Groß authored
    This CL renames a number of things related to the V8 sandbox.
    Mainly, what used to be under V8_HEAP_SANDBOX is now under
    V8_SANDBOXED_EXTERNAL_POINTERS, while the previous V8 VirtualMemoryCage
    is now simply the V8 Sandbox:
    
    V8_VIRTUAL_MEMORY_CAGE => V8_SANDBOX
    V8_HEAP_SANDBOX => V8_SANDBOXED_EXTERNAL_POINTERS
    V8_CAGED_POINTERS => V8_SANDBOXED_POINTERS
    V8VirtualMemoryCage => Sandbox
    CagedPointer => SandboxedPointer
    fake cage => partially reserved sandbox
    src/security => src/sandbox
    
    This naming scheme should simplify things: the sandbox is now the large
    region of virtual address space inside which V8 mainly operates and
    which should be considered untrusted. Mechanisms like sandboxed pointers
    are then used to attempt to prevent escapes from the sandbox (i.e.
    corruption of memory outside of it). Furthermore, the new naming scheme
    avoids the confusion with the various other "cages" in V8, in
    particular, the VirtualMemoryCage class, by dropping that name entirely.
    
    Future sandbox features are developed under their own V8_SANDBOX_X flag,
    and will, once final, be merged into V8_SANDBOX. Current future features
    are sandboxed external pointers (using the external pointer table), and
    sandboxed pointers (pointers guaranteed to point into the sandbox, e.g.
    because they are encoded as offsets). This CL then also introduces a new
    build flag, v8_enable_sandbox_future, which enables all future features.
    
    Bug: v8:10391
    Change-Id: I5174ea8f5ab40fb96a04af10853da735ad775c96
    Cq-Include-Trybots: luci.v8.try:v8_linux64_heap_sandbox_dbg_ng,v8_linux_arm64_sim_heap_sandbox_dbg_ng
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3322981Reviewed-by: 's avatarHannes Payer <hpayer@chromium.org>
    Reviewed-by: 's avatarIgor Sheludko <ishell@chromium.org>
    Reviewed-by: 's avatarMichael Achenbach <machenbach@chromium.org>
    Reviewed-by: 's avatarToon Verwaest <verwaest@chromium.org>
    Commit-Queue: Samuel Groß <saelo@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#78384}
    277fdd1d