• tzik's avatar
    Use local MicrotaskQueue in unittests · eebdb0f5
    tzik authored
    MicrotaskQueueTest uses Isolate's default_microtask_queue for testing,
    however the instance is shared between test cases, and causes flaky
    failure of MicrotaskQueueTest.BufferGrowth.
    
    This CL adds a MicrotaskQueue instance for each test fixture, so that
    each test cases use separate ones.
    
    Also, this CL removes the DCHECK that denies non-default MicrotaskQueue
    to run, which is unneeded after https://crrev.com/c/1369906.
    
    Bug: v8:8124
    Change-Id: I4ff236c327bf0be14f582b3ca8c802fd72661b42
    Reviewed-on: https://chromium-review.googlesource.com/c/1417315Reviewed-by: 's avatarBenedikt Meurer <bmeurer@chromium.org>
    Commit-Queue: Taiju Tsuiki <tzik@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#58901}
    eebdb0f5
microtask-queue-unittest.cc 6.07 KB