• tzik's avatar
    Use local MicrotaskQueue in unittests · eebdb0f5
    tzik authored
    MicrotaskQueueTest uses Isolate's default_microtask_queue for testing,
    however the instance is shared between test cases, and causes flaky
    failure of MicrotaskQueueTest.BufferGrowth.
    
    This CL adds a MicrotaskQueue instance for each test fixture, so that
    each test cases use separate ones.
    
    Also, this CL removes the DCHECK that denies non-default MicrotaskQueue
    to run, which is unneeded after https://crrev.com/c/1369906.
    
    Bug: v8:8124
    Change-Id: I4ff236c327bf0be14f582b3ca8c802fd72661b42
    Reviewed-on: https://chromium-review.googlesource.com/c/1417315Reviewed-by: 's avatarBenedikt Meurer <bmeurer@chromium.org>
    Commit-Queue: Taiju Tsuiki <tzik@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#58901}
    eebdb0f5
Name
Last commit
Last update
benchmarks Loading commit data...
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...
snapshot_toolchain.gni Loading commit data...