• Ben Smith's avatar
    [wasm] Rename CheckCallViaJS with argument array · ea9e5a76
    Ben Smith authored
    WasmRunner provides CheckCallViaJS, which calls a wasm function through
    JS and checks its result.
    
    There are currently two overloads, one that takes a variable number of
    arguments, and another more general 4-argument version that takes an
    array of arguments. This means if you run code like:
    
        r.CheckCallViaJS(0, 0, 0, 0);
    
    The overload resolution kicks in, and chooses the general version, which
    will always segfault.
    
    This CL renames the general version to `CheckCallApplyViaJS` so the
    above example will call the variable-argument version instead.
    
    Change-Id: I14a742c467692e09e84f03504cec2306a794fc24
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1529990Reviewed-by: 's avatarMichael Starzinger <mstarzinger@chromium.org>
    Commit-Queue: Ben Smith <binji@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#60345}
    ea9e5a76
test-run-wasm-js.cc 18.5 KB