• Ben Smith's avatar
    [wasm] Rename CheckCallViaJS with argument array · ea9e5a76
    Ben Smith authored
    WasmRunner provides CheckCallViaJS, which calls a wasm function through
    JS and checks its result.
    
    There are currently two overloads, one that takes a variable number of
    arguments, and another more general 4-argument version that takes an
    array of arguments. This means if you run code like:
    
        r.CheckCallViaJS(0, 0, 0, 0);
    
    The overload resolution kicks in, and chooses the general version, which
    will always segfault.
    
    This CL renames the general version to `CheckCallApplyViaJS` so the
    above example will call the variable-argument version instead.
    
    Change-Id: I14a742c467692e09e84f03504cec2306a794fc24
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1529990Reviewed-by: 's avatarMichael Starzinger <mstarzinger@chromium.org>
    Commit-Queue: Ben Smith <binji@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#60345}
    ea9e5a76
Name
Last commit
Last update
benchmarks Loading commit data...
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...
snapshot_toolchain.gni Loading commit data...