• Leszek Swirski's avatar
    [turbofan] Add deopt reason to CheckIf · b4deef61
    Leszek Swirski authored
    CheckIf is lowered to DeoptimizeIfNot, but there is no deoptimization
    reason given in the deopt if that check fails (the reason is hardcoded
    to "no reason"). These deopts are annoying to track down.
    
    This patch makes CheckIf an operator with a DeoptimizeReason parameter,
    which is passed through to the DeoptimizeIfNot when lowered.
    A couple of checks are converted to give good deoptimize reasons (some
    new reasons are introduced), and the others are defaulted to kNoReason
    until someone else finds a use for them.
    
    Change-Id: I7e910cc9579ccf978dfe9d270ba7b98c8f6c2492
    Reviewed-on: https://chromium-review.googlesource.com/716479Reviewed-by: 's avatarJaroslav Sevcik <jarin@chromium.org>
    Commit-Queue: Leszek Swirski <leszeks@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#48506}
    b4deef61
js-builtin-reducer.cc 126 KB