- 13 Oct, 2017 29 commits
-
-
Clemens Hammacher authored
Not all interface implementations can handle unreachable code correctly. The baseline compiler will fail if it tries to pop a value from an empty stack. Instead of fixing this in the interface (the baseline compiler in this case), this CL fixes this by not calling the interface for unreachable instructions. R=titzer@chromium.org Bug: v8:6600 Change-Id: I567783ce4191ff907b2f90e73b66274728064092 Reviewed-on: https://chromium-review.googlesource.com/715638 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Commit-Queue: Ben Titzer <titzer@chromium.org> Reviewed-by:
Andreas Rossberg <rossberg@chromium.org> Reviewed-by:
Ben Titzer <titzer@chromium.org> Cr-Commit-Position: refs/heads/master@{#48544}
-
Michael Starzinger authored
This adds and explicit check for the constructability of the new.target value in the lowering of {JSCall} nodes known to call Reflect.construct. The {JSConstruct} operator does not perform this check and relies on the implicit validity of new.target in all other use cases. R=jarin@chromium.org TEST=mjsunit/regress/regress-crbug-768080 BUG=chromium:768080 Change-Id: I7c1921e787bae64ba83de3eb08aa00fc5523e251 Reviewed-on: https://chromium-review.googlesource.com/718100Reviewed-by:Jaroslav Sevcik <jarin@chromium.org> Reviewed-by:
Benedikt Meurer <bmeurer@chromium.org> Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#48543}
-
Camillo Bruni authored
Bug: v8:6921 Change-Id: I7602cd68aec6e91e6e59ed78a5e27196e2d28835 Reviewed-on: https://chromium-review.googlesource.com/718101Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#48542}
-
Clemens Hammacher authored
Repeatedly allocating >1GB fails on stress bots, hence run a GC in-between to free the array buffer. R=titzer@chromium.org CC=mlippautz@chromium.org, ulan@chromium.org Bug: v8:6924 Change-Id: I44761e83f62b8225148eecbc569748cd3be21d6a Reviewed-on: https://chromium-review.googlesource.com/718109Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#48541}
-
sreten.kovacevic authored
First allocatable register must be same as the argument count register. This change fixes problems with optimized tests. Bug: Change-Id: I06731c7f27c5f6a761ebdeb3c3c7b2a6c14d7c1d Reviewed-on: https://chromium-review.googlesource.com/716224Reviewed-by:
Ivica Bogosavljevic <ivica.bogosavljevic@imgtec.com> Commit-Queue: Ivica Bogosavljevic <ivica.bogosavljevic@imgtec.com> Cr-Commit-Position: refs/heads/master@{#48540}
-
Toon Verwaest authored
Bug: v8:6921 Change-Id: I82e0d29aba237dff22dd8dfa80ddecd7fd724df3 Reviewed-on: https://chromium-review.googlesource.com/718421Reviewed-by:
Camillo Bruni <cbruni@chromium.org> Commit-Queue: Toon Verwaest <verwaest@chromium.org> Cr-Commit-Position: refs/heads/master@{#48539}
-
Michael Achenbach authored
TBR=ulan@chromium.org Bug: v8:6927 Change-Id: I6e76cc3e967b9136ed50612afb9159a404ccbfad Reviewed-on: https://chromium-review.googlesource.com/718599Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#48538}
-
Mythri authored
Unwinding info keeps track of the frame pointer by tracking the changes to the stack if a frame wasn't constructed. Once the frame is constructed we no longer need to keep track of this. The code generator informs the unwinding info writer about frame constructions. This information was not passed for JSFunctions calls. This cl fixes it to pass also for JSFunctions. Bug: Change-Id: Ia39980039a5f063435fa3b3ab145256909011606 Reviewed-on: https://chromium-review.googlesource.com/718596Reviewed-by:
-
Toon Verwaest authored
Bug: v8:6921 Change-Id: I9f6457812007f72b5fcc714b8baab59fc8337795 Reviewed-on: https://chromium-review.googlesource.com/718104 Commit-Queue: Toon Verwaest <verwaest@chromium.org> Reviewed-by:
Igor Sheludko <ishell@chromium.org> Reviewed-by:
Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#48536}
-
Toon Verwaest authored
[code-stubs] All keys in name dictionaries are internalized so stop checking in NameDictionaryLookupStub Bug: v8:6921 Change-Id: Idaa4a7e31525ccd3f599115c54845aac2fcfa430 Reviewed-on: https://chromium-review.googlesource.com/707251 Commit-Queue: Toon Verwaest <verwaest@chromium.org> Reviewed-by:
-
Igor Sheludko authored
Bug: chromium:764219 Change-Id: Ic68111e49da508aba255b1c651a85b2b00e62947 Reviewed-on: https://chromium-review.googlesource.com/718108Reviewed-by:
Toon Verwaest <verwaest@chromium.org> Commit-Queue: Igor Sheludko <ishell@chromium.org> Cr-Commit-Position: refs/heads/master@{#48534}
-
Toon Verwaest authored
Bug: v8:6921 Change-Id: I1a2b67c60361a28d8604dbe096b2907674d971cb Reviewed-on: https://chromium-review.googlesource.com/718105Reviewed-by:
-
Ulan Degenbaev authored
The test uses more than 10GB memory in stress mode and causes OOM failures on TSAN bots. NOTRY=true Bug: v8:6924 Change-Id: Ifaab153316432a5c59869ef312b43d84827480df Reviewed-on: https://chromium-review.googlesource.com/718110 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by:
-
Camillo Bruni authored
- console.assert now fails properly - console.trace dumps a low-level stack trace - console.time/End dumps a timer event to the log file - console.timeStamp dumps a timer event to the log Drive-by-fixes: - simplify test-log.cc - fix test-log.cc log parser JS helper - always start the default timer int the logger Change-Id: I0bb26b9410a4e0d1d5bc8621d8b2243922fe3f29 Reviewed-on: https://chromium-review.googlesource.com/702459Reviewed-by:
Yang Guo <yangguo@chromium.org> Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#48531}
-
Camillo Bruni authored
- LoadJSArrayLength - LoadStringLength - LoadElements - LoadFixedArrayBaseLength Bug: v8:6921 Change-Id: I6bc72e99f4f8c993cb6923f19df1fbaec82881d0 Reviewed-on: https://chromium-review.googlesource.com/718199Reviewed-by:
Peter Marshall <petermarshall@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#48530}
-
ccyongwang authored
In PersistentValueMap, SetWeak function should supply WeakCallbackType arguments. Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_rel_ng Change-Id: I70a59e90b7ea0a10f695419e57ae9bfb8d5ba852 Reviewed-on: https://chromium-review.googlesource.com/684002 Commit-Queue: Marja Hölttä <marja@chromium.org> Reviewed-by:
Marja Hölttä <marja@chromium.org> Cr-Commit-Position: refs/heads/master@{#48529}
-
Toon Verwaest authored
Bug: v8:6921 Change-Id: I1bd9e5425ddad59ae9ac25c5eb6f05472072a358 Reviewed-on: https://chromium-review.googlesource.com/718103Reviewed-by:
-
Toon Verwaest authored
Bug: v8:6921 Change-Id: Ice3d280619dd26054affabb7a128714b9aeb422d Reviewed-on: https://chromium-review.googlesource.com/707241 Commit-Queue: Toon Verwaest <verwaest@chromium.org> Reviewed-by:
-
Toon Verwaest authored
Bug: v8:6921 Change-Id: Ic40a0fbf042c684f6ce8e0c4e3e8cc7cc0215fc3 Reviewed-on: https://chromium-review.googlesource.com/707243 Commit-Queue: Toon Verwaest <verwaest@chromium.org> Reviewed-by:
-
Benedikt Meurer authored
Bug: v8:6921 Change-Id: I3d45197dfd92b725d8caf5b6e5ebacd4b5b7b0d7 Reviewed-on: https://chromium-review.googlesource.com/718341 Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Reviewed-by:
Mathias Bynens <mathias@chromium.org> Cr-Commit-Position: refs/heads/master@{#48525}
-
Marja Hölttä authored
There was a helpful TODO telling where it should live. BUG=v8:5402,v8:6921 Change-Id: Id9022c72c9e7de8d76ea0db964217b766299195d Reviewed-on: https://chromium-review.googlesource.com/718337Reviewed-by:
-
Igor Sheludko authored
This is a reland of 3d023952 Original change's description: > [runtime] Make JSFunction::prototype_or_initial_map field optional. > > Functions that don't have prototype need to store neither prototype nor > initial map, so the |prototype_or_initial_map| field is not required for > such maps. > > Bug: v8:6459 > Change-Id: I4b3066bd6a4fed42c19f217bae82a8bce552bdca > Reviewed-on: https://chromium-review.googlesource.com/570250 > Reviewed-by: Jaroslav Sevcik <jarin@chromium.org> > Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> > Commit-Queue: Igor Sheludko <ishell@chromium.org> > Cr-Commit-Position: refs/heads/master@{#46840} Bug: v8:6459 Change-Id: I54e3516ea70474c6d4f873f7b91e74cb8a7d622a Reviewed-on: https://chromium-review.googlesource.com/583307Reviewed-by:
-
Marja Hölttä authored
This file was somehow inexplicably not moved when other parsing files were. BUG=v8:6921 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_rel_ng Change-Id: Iea92c61f83dbb5a8688c404ba87d35fa58e749b9 Reviewed-on: https://chromium-review.googlesource.com/718197 Commit-Queue: Marja Hölttä <marja@chromium.org> Reviewed-by:
-
Michal Majewski authored
Preparation for sharing more code between deopt fuzzer and normal test runner. Bug: v8:6917 Change-Id: Id8022c7597544ffddf5d1b0a0d73bb4a9d163fc3 Reviewed-on: https://chromium-review.googlesource.com/715417 Commit-Queue: Michał Majewski <majeski@google.com> Reviewed-by:
-
Toon Verwaest authored
Bug: v8:6921 Change-Id: I651b54a061a1ea401bb345569b96763daef0abe4 Reviewed-on: https://chromium-review.googlesource.com/707238 Commit-Queue: Toon Verwaest <verwaest@chromium.org> Reviewed-by:
-
Michael Achenbach authored
NOTRY=true TBR=ulan@chromium.org Bug: v8:6927 Change-Id: I84e239c94ed6b545544bc3db30689b8ff1b158ae Reviewed-on: https://chromium-review.googlesource.com/718098 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by:
-
sreten.kovacevic authored
These tests use too much memory on MIPS. Bug: Change-Id: I9ab15b04ad8cec94ab1b1c022e819a2d802e375d Reviewed-on: https://chromium-review.googlesource.com/716497Reviewed-by:
-
Andreas Haas authored
This flag describes that the memory defined in a wasm module has a maximum size. Therefore I think kHasMaximumFlag is more appropriate. R=titzer@chromium.org Bug: v8:6921 Change-Id: Ie794d670f74e7f1f9a42822e2f774da85aaaaa4b Reviewed-on: https://chromium-review.googlesource.com/718198Reviewed-by:
-
v8-autoroll authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/ddb142b..c6001bd Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/072921b..67c0157 TBR=machenbach@chromium.org,hablich@chromium.org Change-Id: I583aa49a52c136c5a331da2c226aafef5d2dcf05 Reviewed-on: https://chromium-review.googlesource.com/717896Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#48516}
-
- 12 Oct, 2017 11 commits
-
-
Ali Ijaz Sheikh authored
This reverts commit e770879e. Reason for revert: broke on this build: https://build.chromium.org/p/client.v8/builders/V8%20Mac%20-%20debug/builds/16703 Original change's description: > [heap] Add missing steps for Add/Remove observers > > Change-Id: I9935ff4debc623af674e606c006085258b685ced > Reviewed-on: https://chromium-review.googlesource.com/715118 > Reviewed-by: Ulan Degenbaev <ulan@chromium.org> > Commit-Queue: Ali Ijaz Sheikh <ofrobots@google.com> > Cr-Commit-Position: refs/heads/master@{#48513} TBR=ulan@chromium.org,mlippautz@chromium.org,ofrobots@google.com Change-Id: Idc53870cbcb692e79764dfe0984ff765ed2458f3 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/717318Reviewed-by:
Ali Ijaz Sheikh <ofrobots@google.com> Commit-Queue: Ali Ijaz Sheikh <ofrobots@google.com> Cr-Commit-Position: refs/heads/master@{#48515}
-
Jakob Kummerow authored
We can bump it up later if there is need. Taking digit size into account for the max length in digits makes the max length in bits consistent across architectures. Bug: v8:6791 Change-Id: Id5205d2d308bbe6a38f8ff1ee19c082bedbeb74a Reviewed-on: https://chromium-review.googlesource.com/717176 Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by:
Adam Klein <adamk@chromium.org> Cr-Commit-Position: refs/heads/master@{#48514}
-
Ali Ijaz Sheikh authored
Change-Id: I9935ff4debc623af674e606c006085258b685ced Reviewed-on: https://chromium-review.googlesource.com/715118Reviewed-by:
-
Jakob Kummerow authored
In preparation for adding more separate test files. Bug: v8:6791 Change-Id: I92e2a3ab6fd35e2f902179a005ed9640851ca1b6 Reviewed-on: https://chromium-review.googlesource.com/716927Reviewed-by:
-
Marja Hölttä authored
Parser creates a FunctionState for default ctors, which affects the next_function_is_likely_called logic. PreParser needs to match that logic, so that Parser and PreParser agree about which functions are skippable. BUG=v8:5515, chromium:773576 Change-Id: I96cb6f5aa68e74389a863355f70a34693a2d1329 Reviewed-on: https://chromium-review.googlesource.com/712579 Commit-Queue: Marja Hölttä <marja@chromium.org> Reviewed-by:
-
Andrii Shyshkalov authored
Rietveld CQ has already been disabled and is no longer supoorted. TBR=sergiyb@chromium.org No-Try: True Bug: chromium:770592 Change-Id: If4411aaf15402b3c6d44fd0a8126d1db2150cb46 Reviewed-on: https://chromium-review.googlesource.com/716838Reviewed-by:
Sergiy Byelozyorov <sergiyb@chromium.org> Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org> Cr-Commit-Position: refs/heads/master@{#48510}
-
Clemens Hammacher authored
The current Control::unreachable flag served two things at the same time: It tracked whether the label of that block is reachable (anyone jumps / falls through to there), and it tracked whether that block was ended by an unconditional branch or something similar. It turns out that these two things cannot be tracked with a single boolean per control struct. This CL introduces a Merge::reached flag, which tracks whether a merge point was reached so far. Also, the boolean flag to track unreachability of instructions within a block is extended to track implicitly unreachable instructions. According to the spec, a new block inside of unreachable code must be validated as reachable code again, and also code after a block which never returns has to be validated. It's not needed to generate code for such instructions, however. This new state will be particularly needed for the baseline compiler. A follow-up CL will avoid calling interface methods for unreachable code. R=titzer@chromium.org Bug: v8:6600 Change-Id: I54c97a19121eace65e25c448639330d06f61b1c8 Reviewed-on: https://chromium-review.googlesource.com/715637 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
-
Jakob Kummerow authored
Bug: v8:6791 Change-Id: Ib807ac94dca646cddfe2eb5fafe18999cf0764a2 Reviewed-on: https://chromium-review.googlesource.com/714450Reviewed-by:
Georg Neis <neis@chromium.org> Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#48508}
-
Jakob Kummerow authored
Contrary to other Absolute-bitwise operations, it is not symmetric. Bug: v8:6791 Change-Id: Id0d57e3cf61177af0b77a3d9d4a4e17e5737ae11 Reviewed-on: https://chromium-review.googlesource.com/714301Reviewed-by:
-
Leszek Swirski authored
CheckIf is lowered to DeoptimizeIfNot, but there is no deoptimization reason given in the deopt if that check fails (the reason is hardcoded to "no reason"). These deopts are annoying to track down. This patch makes CheckIf an operator with a DeoptimizeReason parameter, which is passed through to the DeoptimizeIfNot when lowered. A couple of checks are converted to give good deoptimize reasons (some new reasons are introduced), and the others are defaulted to kNoReason until someone else finds a use for them. Change-Id: I7e910cc9579ccf978dfe9d270ba7b98c8f6c2492 Reviewed-on: https://chromium-review.googlesource.com/716479Reviewed-by:
-
Daniel Ehrenberg authored
The use of object literals comes with Object.prototype as the prototype. Some of these were required by the specification, but a change to the specification is proposed in https://github.com/tc39/ecma402/pull/170 to eliminate this. Some of them are unobservable, since Object.prototype is always shadowed, and defineProperty is used rather than ordinary set. However, just to be cautious, all object literals in intl.js except the ones that need it (namely the result of resolvedOptions()) are changed to a null prototype Tests are in the test262 PR https://github.com/tc39/test262/pull/1220 Cq-Include-Trybots: master.tryserver.v8:v8_linux_noi18n_rel_ng Change-Id: I1f684615e60b523441baf31350d752585d8f96d1 Reviewed-on: https://chromium-review.googlesource.com/657839Reviewed-by:
-
