• Ng Zhi An's avatar
    [wasm-simd] Fix lowering of load transform · f996d50d
    Ng Zhi An authored
    Load transform nodes can be effect inputs, so we need to update the node
    in place. Otherwise, if a load transform node is both an value and an
    effect input, only the value input will be updated with replacements,
    the effect input will still be the unlowered load transform node.
    This is because DefaultLowering only lowers value inputs.
    
    This is consistent with normal loads in the scalar lowering,
    and also how int64 does it.
    
    Bug: v8:10984,v8:10507
    Change-Id: I04b0f0b1cff95e39589de979ecae6cb4b085a3cf
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2453861Reviewed-by: 's avatarBill Budge <bbudge@chromium.org>
    Commit-Queue: Zhi An Ng <zhin@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#70391}
    f996d50d
simd-scalar-lowering.cc 91.4 KB