• Ng Zhi An's avatar
    [x64] Refactor pinsrb family of instructions · e30c50f3
    Ng Zhi An authored
    The existing macro assembler define Pinsrb, which expects 3 arguments:
    
    - XMMRegister dst
    - Register/Operand src
    - uint8_t imm
    
    which overwrites dst with src at lane specified by imm.
    
    That means we cannot use the AVX version, which has 4 arguments, and
    does not overwrite dst.
    
    This refactoring defines the 4 argument AVX version instead, and if AVX
    is not supported, fall back to the SSE version, and ensure that the
    value is copied over into dst first.
    
    For convenience, we define an overload with 3 arguments that duplicates
    dst, this replicates the SSE behavior, so that not all callers have to
    be updated.
    
    Bug: v8:10975, v8:10933
    Change-Id: I6f9b9d37fa08d3f5cff4f040ae7d5e1f0cf36455
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2444096
    Commit-Queue: Zhi An Ng <zhin@chromium.org>
    Reviewed-by: 's avatarBill Budge <bbudge@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#70392}
    e30c50f3
Name
Last commit
Last update
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
DEPS Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...