• Nico Hartmann's avatar
    Revert "cppgc: Minor fix in cppgc efficiency calculation" · da12b9ac
    Nico Hartmann authored
    This reverts commit 543acf34.
    
    Reason for revert: https://ci.chromium.org/ui/p/v8/builders/ci/V8%20Mac%20-%20arm64%20-%20release/10365/overview
    
    Original change's description:
    > cppgc: Minor fix in cppgc efficiency calculation
    >
    > Efficiency calculation (freed bytes over GC duration) assumes that the
    > duration of the GC is non zero. However, if the clock resolution is
    > not small enough and the entire GC is very short, the timed value
    > appears to be zero. This leads to NaN values showing in metrics and
    > CHECKs failing. This CL fixes the issue.
    >
    > Bug: chromium:1338256
    > Change-Id: I1dbc52072fcde3411aa38fa0c11da25afd107ca8
    > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3714356
    > Reviewed-by: Omer Katz <omerkatz@chromium.org>
    > Commit-Queue: Nikolaos Papaspyrou <nikolaos@chromium.org>
    > Cr-Commit-Position: refs/heads/main@{#81329}
    
    Bug: chromium:1338256
    Change-Id: Ie9a23651494fc28a11bb59485a9812ee1a7cff48
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3721697
    Commit-Queue: Nico Hartmann <nicohartmann@chromium.org>
    Owners-Override: Nico Hartmann <nicohartmann@chromium.org>
    Auto-Submit: Nico Hartmann <nicohartmann@chromium.org>
    Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/main@{#81331}
    da12b9ac
stats-collector.cc 13.6 KB