• Junliang Yan's avatar
    PPC/s390: DISALLOW_IMPLICIT_CONSTRUCTORS for MacroAssembler · 47270ebf
    Junliang Yan authored
    Port 9e060e47
    
    Original Commit Message:
    
        When BUILDING_V8_SHARED in release builds __declspec(dllexport)
        causes generation of implicit constructors in the forwarding class
        while its deleted in TurboAssemblerBase, which leads to compilation
        errors like:
    
        In file included from gen/v8/v8_base_jumbo_6.cc:41:
        In file included from .\../../v8/src/interface-descriptors.cc:7:
        In file included from ../../v8\src/macro-assembler.h:40:
        ../../v8\src/x64/macro-assembler-x64.h(92,9):  error: call to deleted constructor of 'v8::internal::TurboAssemblerBase'
              : TurboAssemblerBase(std::forward<Args>(args)...) {}
                ^                  ~~~~~~~~~~~~~~~~~~~~~~~~
        ../../v8\src/x64/macro-assembler-x64.h(536,25):  note: in instantiation of function template specialization 'v8::internal::TurboAssembler::TurboAssembler<v8::internal::TurboAssembler>' requested here
        class V8_EXPORT_PRIVATE MacroAssembler : public TurboAssembler {
                                ^
        ../../v8\src/turbo-assembler.h(127,34):  note: 'TurboAssemblerBase' has been explicitly marked deleted here
          DISALLOW_IMPLICIT_CONSTRUCTORS(TurboAssemblerBase);
                                         ^
        1 error generated.
    
        The original changes were made in https://chromium-review.googlesource.com/c/v8/v8/+/1414913
    
    R=hop2deep@gmail.com, joransiu@ca.ibm.com, michael_dawson@ca.ibm.com
    BUG=
    LOG=N
    
    Change-Id: I2a6e555b028583b89402b257e40757f34f3301c1
    Reviewed-on: https://chromium-review.googlesource.com/c/1463179Reviewed-by: 's avatarMilad Farazmand <miladfar@ca.ibm.com>
    Commit-Queue: Junliang Yan <jyan@ca.ibm.com>
    Cr-Commit-Position: refs/heads/master@{#59499}
    47270ebf
macro-assembler-s390.h 51.9 KB