Commit 47270ebf authored by Junliang Yan's avatar Junliang Yan Committed by Commit Bot

PPC/s390: DISALLOW_IMPLICIT_CONSTRUCTORS for MacroAssembler

Port 9e060e47

Original Commit Message:

    When BUILDING_V8_SHARED in release builds __declspec(dllexport)
    causes generation of implicit constructors in the forwarding class
    while its deleted in TurboAssemblerBase, which leads to compilation
    errors like:

    In file included from gen/v8/v8_base_jumbo_6.cc:41:
    In file included from .\../../v8/src/interface-descriptors.cc:7:
    In file included from ../../v8\src/macro-assembler.h:40:
    ../../v8\src/x64/macro-assembler-x64.h(92,9):  error: call to deleted constructor of 'v8::internal::TurboAssemblerBase'
          : TurboAssemblerBase(std::forward<Args>(args)...) {}
            ^                  ~~~~~~~~~~~~~~~~~~~~~~~~
    ../../v8\src/x64/macro-assembler-x64.h(536,25):  note: in instantiation of function template specialization 'v8::internal::TurboAssembler::TurboAssembler<v8::internal::TurboAssembler>' requested here
    class V8_EXPORT_PRIVATE MacroAssembler : public TurboAssembler {
                            ^
    ../../v8\src/turbo-assembler.h(127,34):  note: 'TurboAssemblerBase' has been explicitly marked deleted here
      DISALLOW_IMPLICIT_CONSTRUCTORS(TurboAssemblerBase);
                                     ^
    1 error generated.

    The original changes were made in https://chromium-review.googlesource.com/c/v8/v8/+/1414913

R=hop2deep@gmail.com, joransiu@ca.ibm.com, michael_dawson@ca.ibm.com
BUG=
LOG=N

Change-Id: I2a6e555b028583b89402b257e40757f34f3301c1
Reviewed-on: https://chromium-review.googlesource.com/c/1463179Reviewed-by: 's avatarMilad Farazmand <miladfar@ca.ibm.com>
Commit-Queue: Junliang Yan <jyan@ca.ibm.com>
Cr-Commit-Position: refs/heads/master@{#59499}
parent d8a457cb
......@@ -969,6 +969,8 @@ class V8_EXPORT_PRIVATE MacroAssembler : public TurboAssembler {
// Needs access to SafepointRegisterStackIndex for compiled frame
// traversal.
friend class StandardFrame;
DISALLOW_IMPLICIT_CONSTRUCTORS(MacroAssembler);
};
// -----------------------------------------------------------------------------
......
......@@ -1281,6 +1281,8 @@ class V8_EXPORT_PRIVATE MacroAssembler : public TurboAssembler {
// Needs access to SafepointRegisterStackIndex for compiled frame
// traversal.
friend class StandardFrame;
DISALLOW_IMPLICIT_CONSTRUCTORS(MacroAssembler);
};
// -----------------------------------------------------------------------------
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment