• Andreas Haas's avatar
    [wasm][liftoff][arm64] Avoid x28 even without pointer compression · 8d0f5a04
    Andreas Haas authored
    Due to a recent change Liftoff used different register configurations
    in the pointer-compression and no-pointer-compression setups. This
    caused a mismatch between the registers used by Liftoff and the
    registers spilled by the WasmDebugBreak builtin.
    
    With this CL the same register configuration is used both with and
    without pointer compression. Even without x28 there are 24 registers
    that can be used. Moreover, 24 registers can be spilled without
    padding, which would be needed with 25 registers to preserve stack
    alignment.
    
    Drive-by change: Use Reglist in frame-constants on all platforms.
    
    R=jkummerow@chromium.org
    
    Bug: v8:7581
    Change-Id: Iae2892718e905a7995a3fdd7be7fd4d75bebb3dd
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2752884
    Commit-Queue: Andreas Haas <ahaas@chromium.org>
    Reviewed-by: 's avatarJakob Kummerow <jkummerow@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#73366}
    8d0f5a04
builtins-arm.cc 123 KB