• Mythri A's avatar
    [runtime] Remove try_fast path from GetOwnPropertyNames builtin · b048429e
    Mythri A authored
    GetOwnPropertyNameTryFast uses ENUMERABLE_STRINGS filter to trigger fast
    path in KeyAccumulator::GetKeys conditionally when all properties on the
    receiver are enumerable. It is not easy to verify if all properties are
    enumerable and the current check is incorrect in some cases.
    For ex: when we have non-enumerable properties when we have elements on
    the receiver. This cl removes this try_fast path from the builtin. This
    could impact performance. The long term fix for this would be to fix
    KeyAccumulator::GetKeys to use fast path for more cases.
    
    
    Bug: chromium:977870
    Change-Id: Iecde730739c2c452ffa0d893d0d1b3612a45d1b2
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1679499Reviewed-by: 's avatarJakob Gruber <jgruber@chromium.org>
    Reviewed-by: 's avatarIgor Sheludko <ishell@chromium.org>
    Commit-Queue: Mythri Alle <mythria@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#62649}
    b048429e
builtins-object-gen.cc 59.7 KB