• Mythri A's avatar
    [runtime] Remove try_fast path from GetOwnPropertyNames builtin · b048429e
    Mythri A authored
    GetOwnPropertyNameTryFast uses ENUMERABLE_STRINGS filter to trigger fast
    path in KeyAccumulator::GetKeys conditionally when all properties on the
    receiver are enumerable. It is not easy to verify if all properties are
    enumerable and the current check is incorrect in some cases.
    For ex: when we have non-enumerable properties when we have elements on
    the receiver. This cl removes this try_fast path from the builtin. This
    could impact performance. The long term fix for this would be to fix
    KeyAccumulator::GetKeys to use fast path for more cases.
    
    
    Bug: chromium:977870
    Change-Id: Iecde730739c2c452ffa0d893d0d1b3612a45d1b2
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1679499Reviewed-by: 's avatarJakob Gruber <jgruber@chromium.org>
    Reviewed-by: 's avatarIgor Sheludko <ishell@chromium.org>
    Commit-Queue: Mythri Alle <mythria@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#62649}
    b048429e
Name
Last commit
Last update
..
api Loading commit data...
asmjs Loading commit data...
ast Loading commit data...
base Loading commit data...
builtins Loading commit data...
codegen Loading commit data...
common Loading commit data...
compiler Loading commit data...
compiler-dispatcher Loading commit data...
d8 Loading commit data...
date Loading commit data...
debug Loading commit data...
deoptimizer Loading commit data...
diagnostics Loading commit data...
execution Loading commit data...
extensions Loading commit data...
flags Loading commit data...
handles Loading commit data...
heap Loading commit data...
ic Loading commit data...
init Loading commit data...
inspector Loading commit data...
interpreter Loading commit data...
json Loading commit data...
libplatform Loading commit data...
libsampler Loading commit data...
logging Loading commit data...
numbers Loading commit data...
objects Loading commit data...
parsing Loading commit data...
profiler Loading commit data...
protobuf Loading commit data...
regexp Loading commit data...
roots Loading commit data...
runtime Loading commit data...
sanitizer Loading commit data...
snapshot Loading commit data...
strings Loading commit data...
tasks Loading commit data...
third_party Loading commit data...
torque Loading commit data...
tracing Loading commit data...
trap-handler Loading commit data...
utils Loading commit data...
wasm Loading commit data...
zone Loading commit data...
DEPS Loading commit data...
OWNERS Loading commit data...