• Camillo Bruni's avatar
    [runtime] Clean up runtime function Arguments accesses · cead6573
    Camillo Bruni authored
    Replace all CONVERT_XXX_ARG_XXX() macros from runtime-util.h with direct
    calls to Arguments or the fully expanded equivalent.
    
    - This replaces many of the hard CHECKs with DCHECK (as is common
      practice in most V8 code)
    - Instead of relying on verbose comments we now have readable code
    - Rename Arguments.::xxx_at with Arguments::xxx_value_at since these
      methods don't return the Object but rather their double/int value
    
    - Add Oddball::ToBool helper
    - Add and use v8::internal::PropertyAttributesFromInt helper
    - Add stronger DCHECK for PropertyAttributes returned in
      GetPropertyAttributesWithInterceptorInternal
    
    
    
    Bug: v8:11263
    Change-Id: I8d531857e05d19f3198753b05af28d993a391854
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3497768Reviewed-by: 's avatarIgor Sheludko <ishell@chromium.org>
    Reviewed-by: 's avatarJakob Gruber <jgruber@chromium.org>
    Commit-Queue: Camillo Bruni <cbruni@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#79418}
    cead6573
runtime-promise.cc 7.57 KB